{"id":807415,"url":"http://patchwork.ozlabs.org/api/1.2/patches/807415/?format=json","web_url":"http://patchwork.ozlabs.org/project/uboot/patch/1504070142-7951-1-git-send-email-tien.fong.chee@intel.com/","project":{"id":18,"url":"http://patchwork.ozlabs.org/api/1.2/projects/18/?format=json","name":"U-Boot","link_name":"uboot","list_id":"u-boot.lists.denx.de","list_email":"u-boot@lists.denx.de","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<1504070142-7951-1-git-send-email-tien.fong.chee@intel.com>","list_archive_url":null,"date":"2017-08-30T05:15:42","name":"[U-Boot] libfdt: Initialize the stack variable","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"0bc1fdffb12a7b27752898b36a555287e611cd16","submitter":{"id":70549,"url":"http://patchwork.ozlabs.org/api/1.2/people/70549/?format=json","name":"Chee, Tien Fong","email":"tien.fong.chee@intel.com"},"delegate":{"id":3184,"url":"http://patchwork.ozlabs.org/api/1.2/users/3184/?format=json","username":"sjg","first_name":"Simon","last_name":"Glass","email":"sjg@chromium.org"},"mbox":"http://patchwork.ozlabs.org/project/uboot/patch/1504070142-7951-1-git-send-email-tien.fong.chee@intel.com/mbox/","series":[{"id":526,"url":"http://patchwork.ozlabs.org/api/1.2/series/526/?format=json","web_url":"http://patchwork.ozlabs.org/project/uboot/list/?series=526","date":"2017-08-30T05:15:42","name":"[U-Boot] libfdt: Initialize the stack variable","version":1,"mbox":"http://patchwork.ozlabs.org/series/526/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/807415/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/807415/checks/","tags":{},"related":[],"headers":{"Return-Path":"<u-boot-bounces@lists.denx.de>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=<UNKNOWN>)","Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xhtyd1ytVz9s83\n\tfor <incoming@patchwork.ozlabs.org>;\n\tWed, 30 Aug 2017 15:16:23 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid 98C0CC21D72; Wed, 30 Aug 2017 05:16:12 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id B0A55C21DA1;\n\tWed, 30 Aug 2017 05:16:10 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid 633B2C21DA1; Wed, 30 Aug 2017 05:16:09 +0000 (UTC)","from mga05.intel.com (mga05.intel.com [192.55.52.43])\n\tby lists.denx.de (Postfix) with ESMTPS id 98834C21D72\n\tfor <u-boot@lists.denx.de>; Wed, 30 Aug 2017 05:16:08 +0000 (UTC)","from fmsmga001.fm.intel.com ([10.253.24.23])\n\tby fmsmga105.fm.intel.com with ESMTP; 29 Aug 2017 22:16:07 -0700","from tfchee-mobl.gar.corp.intel.com (HELO tienfong.fm.intel.com,\n\t) ([10.226.242.65])\n\tby fmsmga001.fm.intel.com with ESMTP; 29 Aug 2017 22:16:04 -0700"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-2.3 required=5.0 tests=RCVD_IN_DNSWL_MED\n\tautolearn=unavailable autolearn_force=no version=3.4.0","X-ExtLoop1":"1","X-IronPort-AV":"E=Sophos; i=\"5.41,447,1498546800\"; d=\"scan'208\";\n\ta=\"1189661601\"","From":"tien.fong.chee@intel.com","To":"u-boot@lists.denx.de","Date":"Wed, 30 Aug 2017 13:15:42 +0800","Message-Id":"<1504070142-7951-1-git-send-email-tien.fong.chee@intel.com>","X-Mailer":"git-send-email 2.7.4","Cc":"Tom Rini <trini@konsulko.com>, Ching Liang See <chin.liang.see@intel.com>,\n\tTien Fong Chee <tien.fong.chee@intel.com>","Subject":"[U-Boot] [PATCH] libfdt: Initialize the stack variable","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion <u-boot.lists.denx.de>","List-Unsubscribe":"<https://lists.denx.de/options/u-boot>,\n\t<mailto:u-boot-request@lists.denx.de?subject=unsubscribe>","List-Archive":"<http://lists.denx.de/pipermail/u-boot/>","List-Post":"<mailto:u-boot@lists.denx.de>","List-Help":"<mailto:u-boot-request@lists.denx.de?subject=help>","List-Subscribe":"<https://lists.denx.de/listinfo/u-boot>,\n\t<mailto:u-boot-request@lists.denx.de?subject=subscribe>","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" <u-boot-bounces@lists.denx.de>"},"content":"From: Tien Fong Chee <tien.fong.chee@intel.com>\n\nReport Coverity log:\nThe code uses a variable that has not\nbeen initialized, leading to unpredictable\nor unintended results.\n\nReported-by: Coverity (CID: 60519)\nSigned-off-by: Tien Fong Chee <tien.fong.chee@intel.com>\n---\n lib/libfdt/fdt_wip.c |    2 +-\n 1 files changed, 1 insertions(+), 1 deletions(-)","diff":"diff --git a/lib/libfdt/fdt_wip.c b/lib/libfdt/fdt_wip.c\nindex 45fb964..01adad0 100644\n--- a/lib/libfdt/fdt_wip.c\n+++ b/lib/libfdt/fdt_wip.c\n@@ -115,7 +115,7 @@ int fdt_find_regions(const void *fdt, char * const inc[], int inc_count,\n \t\t     struct fdt_region region[], int max_regions,\n \t\t     char *path, int path_len, int add_string_tab)\n {\n-\tint stack[FDT_MAX_DEPTH];\n+\tint stack[FDT_MAX_DEPTH] = { 0 };\n \tchar *end;\n \tint nextoffset = 0;\n \tuint32_t tag;\n","prefixes":["U-Boot"]}