{"id":807382,"url":"http://patchwork.ozlabs.org/api/1.2/patches/807382/?format=json","web_url":"http://patchwork.ozlabs.org/project/openvswitch/patch/1504061938-113805-1-git-send-email-ming.lu@citrix.com/","project":{"id":47,"url":"http://patchwork.ozlabs.org/api/1.2/projects/47/?format=json","name":"Open vSwitch","link_name":"openvswitch","list_id":"ovs-dev.openvswitch.org","list_email":"ovs-dev@openvswitch.org","web_url":"http://openvswitch.org/","scm_url":"git@github.com:openvswitch/ovs.git","webscm_url":"https://github.com/openvswitch/ovs","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<1504061938-113805-1-git-send-email-ming.lu@citrix.com>","list_archive_url":null,"date":"2017-08-30T02:58:58","name":"[ovs-dev] bond: send learning pkg when non active slave failed.","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"661edca4b7731619580440e4351dc348de91f192","submitter":{"id":72253,"url":"http://patchwork.ozlabs.org/api/1.2/people/72253/?format=json","name":"minglumlu","email":"ming.lu@citrix.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/openvswitch/patch/1504061938-113805-1-git-send-email-ming.lu@citrix.com/mbox/","series":[{"id":518,"url":"http://patchwork.ozlabs.org/api/1.2/series/518/?format=json","web_url":"http://patchwork.ozlabs.org/project/openvswitch/list/?series=518","date":"2017-08-30T02:58:58","name":"[ovs-dev] bond: send learning pkg when non active slave failed.","version":1,"mbox":"http://patchwork.ozlabs.org/series/518/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/807382/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/807382/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","dev@openvswitch.org"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","ovs-dev@mail.linuxfoundation.org"],"Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=openvswitch.org\n\t(client-ip=140.211.169.12; helo=mail.linuxfoundation.org;\n\tenvelope-from=ovs-dev-bounces@openvswitch.org;\n\treceiver=)","Received":["from mail.linuxfoundation.org (mail.linuxfoundation.org\n\t[140.211.169.12])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xhr9w72mrz9s06\n\tfor ;\n\tWed, 30 Aug 2017 13:11:00 +1000 (AEST)","from mail.linux-foundation.org (localhost [127.0.0.1])\n\tby mail.linuxfoundation.org (Postfix) with ESMTP id 68DBE927;\n\tWed, 30 Aug 2017 03:10:57 +0000 (UTC)","from smtp1.linuxfoundation.org (smtp1.linux-foundation.org\n\t[172.17.192.35])\n\tby mail.linuxfoundation.org (Postfix) with ESMTPS id 7C1268A5\n\tfor ; Wed, 30 Aug 2017 03:10:56 +0000 (UTC)","from SMTP.CITRIX.COM.AU (smtp.citrix.com.au [103.14.252.240])\n\tby smtp1.linuxfoundation.org (Postfix) with ESMTPS id 4C6891F2\n\tfor ; Wed, 30 Aug 2017 03:10:54 +0000 (UTC)"],"X-Greylist":"delayed 00:10:13 by SQLgrey-1.7.6","X-IronPort-AV":"E=Sophos;i=\"5.41,446,1498521600\"; d=\"scan'208\";a=\"100552941\"","From":"minglumlu ","To":"","Date":"Wed, 30 Aug 2017 03:58:58 +0100","Message-ID":"<1504061938-113805-1-git-send-email-ming.lu@citrix.com>","X-Mailer":"git-send-email 1.8.3.1","MIME-Version":"1.0","X-Spam-Status":"No, score=-2.3 required=5.0 tests=RCVD_IN_DNSWL_MED\n\tautolearn=disabled version=3.3.1","X-Spam-Checker-Version":"SpamAssassin 3.3.1 (2010-03-16) on\n\tsmtp1.linux-foundation.org","Cc":"minglumlu ","Subject":"[ovs-dev] [PATCH] bond: send learning pkg when non active slave\n\tfailed.","X-BeenThere":"ovs-dev@openvswitch.org","X-Mailman-Version":"2.1.12","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"ovs-dev-bounces@openvswitch.org","Errors-To":"ovs-dev-bounces@openvswitch.org"},"content":"In active-active bond, a non-active slave failure doesn't trigger\nthe sending of learning packets. This patch fixes this issue.\n\nSigned-off-by: minglumlu \n---\n ofproto/bond.c | 3 +++\n 1 file changed, 3 insertions(+)","diff":"diff --git a/ofproto/bond.c b/ofproto/bond.c\nindex 365a3ca..4f9f0ea 100644\n--- a/ofproto/bond.c\n+++ b/ofproto/bond.c\n@@ -1679,6 +1679,8 @@ bond_slave_lookup(struct bond *bond, const void *slave_)\n static void\n bond_enable_slave(struct bond_slave *slave, bool enable)\n {\n+ struct bond *bond = slave->bond;\n+\n slave->delay_expires = LLONG_MAX;\n if (enable != slave->enabled) {\n slave->bond->bond_revalidate = true;\n@@ -1688,6 +1690,7 @@ bond_enable_slave(struct bond_slave *slave, bool enable)\n if (enable) {\n ovs_list_insert(&slave->bond->enabled_slaves, &slave->list_node);\n } else {\n+ bond->send_learning_packets = true;\n ovs_list_remove(&slave->list_node);\n }\n ovs_mutex_unlock(&slave->bond->mutex);\n","prefixes":["ovs-dev"]}