{"id":807256,"url":"http://patchwork.ozlabs.org/api/1.2/patches/807256/?format=json","web_url":"http://patchwork.ozlabs.org/project/uboot/patch/20170829195347.15976-1-sjg@chromium.org/","project":{"id":18,"url":"http://patchwork.ozlabs.org/api/1.2/projects/18/?format=json","name":"U-Boot","link_name":"uboot","list_id":"u-boot.lists.denx.de","list_email":"u-boot@lists.denx.de","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20170829195347.15976-1-sjg@chromium.org>","list_archive_url":null,"date":"2017-08-29T19:53:46","name":"[U-Boot] env: Fix operation of 'make environ'","commit_ref":null,"pull_url":null,"state":"deferred","archived":false,"hash":"8f08364f69ea46c0521bff0b6d9daf0b3320e16e","submitter":{"id":6170,"url":"http://patchwork.ozlabs.org/api/1.2/people/6170/?format=json","name":"Simon Glass","email":"sjg@chromium.org"},"delegate":{"id":3184,"url":"http://patchwork.ozlabs.org/api/1.2/users/3184/?format=json","username":"sjg","first_name":"Simon","last_name":"Glass","email":"sjg@chromium.org"},"mbox":"http://patchwork.ozlabs.org/project/uboot/patch/20170829195347.15976-1-sjg@chromium.org/mbox/","series":[{"id":457,"url":"http://patchwork.ozlabs.org/api/1.2/series/457/?format=json","web_url":"http://patchwork.ozlabs.org/project/uboot/list/?series=457","date":"2017-08-29T19:53:46","name":"[U-Boot] env: Fix operation of 'make environ'","version":1,"mbox":"http://patchwork.ozlabs.org/series/457/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/807256/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/807256/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=google.com header.i=@google.com\n\theader.b=\"FZ5TvAV3\"; dkim-atps=neutral"],"Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xhfTp2FPXz9sNc\n\tfor ;\n\tWed, 30 Aug 2017 05:54:06 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid B235EC225CB; Tue, 29 Aug 2017 19:54:00 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id D1684C2251F;\n\tTue, 29 Aug 2017 19:53:57 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid 82BABC2251F; Tue, 29 Aug 2017 19:53:56 +0000 (UTC)","from mail-oi0-f52.google.com (mail-oi0-f52.google.com\n\t[209.85.218.52])\n\tby lists.denx.de (Postfix) with ESMTPS id 06D06C2247A\n\tfor ; Tue, 29 Aug 2017 19:53:55 +0000 (UTC)","by mail-oi0-f52.google.com with SMTP id w10so35999432oie.1\n\tfor ; Tue, 29 Aug 2017 12:53:54 -0700 (PDT)","from kiwi.bld.corp.google.com ([100.101.164.89])\n\tby smtp.gmail.com with ESMTPSA id\n\tz124sm3473666oia.23.2017.08.29.12.53.52\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tTue, 29 Aug 2017 12:53:52 -0700 (PDT)","by kiwi.bld.corp.google.com (Postfix, from userid 121222)\n\tid 0A5CD13F85F; Tue, 29 Aug 2017 13:53:50 -0600 (MDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-0.0 required=5.0 tests=RCVD_IN_DNSWL_NONE,\n\tRCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,\n\tT_DKIM_INVALID autolearn=unavailable\n\tautolearn_force=no version=3.4.0","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n\ts=20161025; \n\th=sender:from:to:cc:subject:date:message-id:mime-version\n\t:content-transfer-encoding;\n\tbh=+9Vpyk5S0ZByoejOhzSVpZvWwXl+dF7mXF794H9SWsQ=;\n\tb=FZ5TvAV3b6m3qdCi4eYSMPPgEpTw7S/I0Y5QE85Vti5cQV4zjOAImyjx4hOf5eP75X\n\ttrxQenCgqroHyrsUx7k0wd9RdjjuUm9BvI/GSrQc83hxfDEX08Nff2X3oea678WIfj1x\n\tDD1IjXx82Ld0LiSIIkfp4uNoIlCCEByGnmgQjRMCBVM8CfhBn0PEb0B5vIB2M3LFUzG2\n\tg2G5WdxwYi+OHBxAPVswQgaz9g/rmLYMVbiAy5JLSn6AvIfkK7CjLeRvngIzUhOEsPwC\n\tflhbAHNn1rWobQIaK9Iwc73dJyZ0grHLM00H93LvhpdnE/a9dzn9BsMiMyQJ2rszW/6Y\n\ty8lw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:sender:from:to:cc:subject:date:message-id\n\t:mime-version:content-transfer-encoding;\n\tbh=+9Vpyk5S0ZByoejOhzSVpZvWwXl+dF7mXF794H9SWsQ=;\n\tb=OOlDA4U0W6OJQ4zn13W4wIC60VRxgh1NPxm28hW/8jwFGp6COcBPtcm1mDJCs8OLav\n\tmYvfyx/WoyIpwoXGokXLo5zjKs9rf6LuOfV9Ebty633JuyRVzzwwCNArgHP3jATpme7B\n\tM4zoXubLGw5ckSHHe1faTx+WYfaPXHElCpartAIxKIgh77Q03xF3R+MtDLJA7A8noV7T\n\trv/gVnbzPikA3KR3iOnp76Zc8OlprBxQV3A/H8SEZL0Bgtdq3f2xSNloEVS9DxxOUOBX\n\txf8Y87l+F5blhsoGGxClhaymT3HYinEQ1Wfovj//zmT2WYbOs2F9lgm83J5TVsqHKFux\n\tGfuw==","X-Gm-Message-State":"AHYfb5gzJBBdr+oHhXWICbTDj7xJvpMngORmtaQAjhNqBPa6hFKxxVhy\n\t2neAVQeboDzruYfO","X-Google-Smtp-Source":"ADKCNb6IPh60bfVFotHGRX1AlSqWTpXQv/YziiDsY+NWXvDhNKwEJsgJ19E7c3UgbS5DMpkOk1cM9Q==","X-Received":"by 10.202.228.10 with SMTP id b10mr1539171oih.39.1504036433236; \n\tTue, 29 Aug 2017 12:53:53 -0700 (PDT)","From":"Simon Glass ","To":"U-Boot Mailing List ","Date":"Tue, 29 Aug 2017 13:53:46 -0600","Message-Id":"<20170829195347.15976-1-sjg@chromium.org>","X-Mailer":"git-send-email 2.14.1.342.g6490525c54-goog","MIME-Version":"1.0","Cc":"Tom Rini , =?utf-8?b?TcOlbnMgUnVsbGfDpXJk?=\n\t, Joe Hershberger ,\n\tAndre Przywara , \"Jr.\"@kiwi.bld.corp.google.com, \n\tCooper@kiwi.bld.corp.google.com, Franklin ","Subject":"[U-Boot] [PATCH] env: Fix operation of 'make environ'","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "},"content":"This was broken by the recent environment refactoring. Specifically:\n\n$ make environ\nscripts/Makefile.build:59: tools/environ/Makefile: No such file or directory\nmake[1]: *** No rule to make target 'tools/environ/Makefile'. Stop.\nmake: *** [Makefile:1469: environ] Error 2\n\nFix this by updating the Makefile and adjusting the #include filesnames in\ntwo C files.\n\nFixes: ec74f5f (Makefile: Rename 'env' target to 'environ')\nReported-by: Måns Rullgård \nSigned-off-by: Simon Glass \n---\n\n Makefile | 2 +-\n tools/env/env_attr.c | 2 +-\n tools/env/env_flags.c | 2 +-\n 3 files changed, 3 insertions(+), 3 deletions(-)","diff":"diff --git a/Makefile b/Makefile\nindex a0f3bfd2a5..dd9d567811 100644\n--- a/Makefile\n+++ b/Makefile\n@@ -1466,7 +1466,7 @@ checkarmreloc: u-boot\n \tfi\n \n environ: scripts_basic\n-\t$(Q)$(MAKE) $(build)=tools/$@\n+\t$(Q)$(MAKE) $(build)=tools/env\n \n tools-only: scripts_basic $(version_h) $(timestamp_h)\n \t$(Q)$(MAKE) $(build)=tools\ndiff --git a/tools/env/env_attr.c b/tools/env/env_attr.c\nindex 502d4c900b..4d8536335c 100644\n--- a/tools/env/env_attr.c\n+++ b/tools/env/env_attr.c\n@@ -1 +1 @@\n-#include \"../../common/env_attr.c\"\n+#include \"../../env/attr.c\"\ndiff --git a/tools/env/env_flags.c b/tools/env/env_flags.c\nindex b261cb8e39..71e13e2021 100644\n--- a/tools/env/env_flags.c\n+++ b/tools/env/env_flags.c\n@@ -1 +1 @@\n-#include \"../../common/env_flags.c\"\n+#include \"../../env/flags.c\"\n","prefixes":["U-Boot"]}