{"id":807097,"url":"http://patchwork.ozlabs.org/api/1.2/patches/807097/?format=json","web_url":"http://patchwork.ozlabs.org/project/rtc-linux/patch/1504014419-16894-1-git-send-email-himanshujha199640@gmail.com/","project":{"id":9,"url":"http://patchwork.ozlabs.org/api/1.2/projects/9/?format=json","name":"Linux RTC development","link_name":"rtc-linux","list_id":"linux-rtc.vger.kernel.org","list_email":"linux-rtc@vger.kernel.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<1504014419-16894-1-git-send-email-himanshujha199640@gmail.com>","list_archive_url":null,"date":"2017-08-29T13:46:59","name":"rtc: Use PTR_ERR_OR_ZERO","commit_ref":null,"pull_url":null,"state":"rejected","archived":false,"hash":"a4a544ca30e01dfff73b4ba1f0753581153a16c6","submitter":{"id":72201,"url":"http://patchwork.ozlabs.org/api/1.2/people/72201/?format=json","name":"Himanshu Jha","email":"himanshujha199640@gmail.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/rtc-linux/patch/1504014419-16894-1-git-send-email-himanshujha199640@gmail.com/mbox/","series":[{"id":374,"url":"http://patchwork.ozlabs.org/api/1.2/series/374/?format=json","web_url":"http://patchwork.ozlabs.org/project/rtc-linux/list/?series=374","date":"2017-08-29T13:46:59","name":"rtc: Use PTR_ERR_OR_ZERO","version":1,"mbox":"http://patchwork.ozlabs.org/series/374/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/807097/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/807097/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=linux-rtc-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"p2C5WZxk\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xhVLZ11LZz9sRV\n\tfor ;\n\tTue, 29 Aug 2017 23:47:17 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1752460AbdH2NrQ (ORCPT );\n\tTue, 29 Aug 2017 09:47:16 -0400","from mail-pf0-f195.google.com ([209.85.192.195]:34509 \"EHLO\n\tmail-pf0-f195.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751336AbdH2NrQ (ORCPT\n\t); Tue, 29 Aug 2017 09:47:16 -0400","by mail-pf0-f195.google.com with SMTP id p69so2376826pfk.1;\n\tTue, 29 Aug 2017 06:47:15 -0700 (PDT)","from localhost.localdomain ([103.254.204.108])\n\tby smtp.gmail.com with ESMTPSA id\n\tt75sm4987354pfk.154.2017.08.29.06.47.10\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128);\n\tTue, 29 Aug 2017 06:47:14 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=gmail.com; s=20161025;\n\th=from:to:cc:subject:date:message-id;\n\tbh=beVQl25dumij1imZZijPDcX7RdnNLMSJWkmOU9nQiHs=;\n\tb=p2C5WZxkxyQW/KXYBcyc2a8j0uQrbeDwdd8P45dQZA6ZfDEINQymrd2BEwTfK6P17Z\n\tr8a6+WG+MIG1+rfPXs7ByxLuXl04F4PJK91QRG3x57h0ixw3RdO65z+Q9FHKMnQ9QdHg\n\t2VYvVYpY34N/YssC72jiFeEd42VyTThPYfii5sToQI2W7Wbgwt+F8xZ7uhTSqFBJ2rej\n\tPkEQgHBIoRupX2TtGBwRV2ArWFfbKAojKP4HAMNM+EOQj1pts3mXYenIeItlEcUNsU+A\n\t6Ho2+Jrdjm/awWmjhd/n16fehNnpzB+ISXw1rty6iCeAV2fdTG9SEGsklvMTQW2VRkA0\n\tep/A==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id;\n\tbh=beVQl25dumij1imZZijPDcX7RdnNLMSJWkmOU9nQiHs=;\n\tb=Ov6yaYt/QXsk76GDTBmEh8PAdLgarlm470JEJBZA+c0z2M1tPVyWWwPEe1Vl+2p/H+\n\t5ep1BFL3B/HTpHxGtuiR6n8CxwPhVPGiJvh72QoiIzKQDt+Abz8KAr3B9bre3rG7obWV\n\tHwZp2yq1IpTnKZZXX0dcKSQEbFt79KdAYxIU+QLkKz5sxBJb9JjQrM3kzh8uUoo7YnXz\n\tDlsyP4sxZyECMDw6uGndrRpnH4OmOgc9BYgnfBVrQpAtyD/Xqshv0cyWX42+/MB7IJFz\n\tS+9MZ/FBJXMuH1iSm9YfEfYgIuPDHrP5lmmaZ5E5WCfNHjA0TyCqPwvq1srxrTrYrKhY\n\txtPA==","X-Gm-Message-State":"AHYfb5iFvyAoSI9wxLfZE0ekymzUFpNjjgyNfx+S9zZ8AlhlCD+T+iVH\n\t6oPsjJ1XOxRDlQ==","X-Google-Smtp-Source":"ADKCNb4FyOcHNOq1EkTVt4BmJbtwIh0j8GUQ/qkDfv94fQUnebZfdS/+FtKIZn09p1e0BdtARQwKEQ==","X-Received":"by 10.99.160.80 with SMTP id u16mr394457pgn.62.1504014435481;\n\tTue, 29 Aug 2017 06:47:15 -0700 (PDT)","From":"Himanshu Jha ","To":"a.zummo@towertech.it","Cc":"alexandre.belloni@free-electrons.com, baruch@tkos.co.il,\n\tlinux-rtc@vger.kernel.org, linux-arm-kernel@lists.infradead.org,\n\tlinux-kernel@vger.kernel.org, Himanshu Jha ","Subject":"[PATCH] rtc: Use PTR_ERR_OR_ZERO","Date":"Tue, 29 Aug 2017 19:16:59 +0530","Message-Id":"<1504014419-16894-1-git-send-email-himanshujha199640@gmail.com>","X-Mailer":"git-send-email 2.7.4","Sender":"linux-rtc-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"linux-rtc@vger.kernel.org"},"content":"Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR\n\nSigned-off-by: Himanshu Jha \n---\n drivers/rtc/rtc-digicolor.c | 5 +----\n drivers/rtc/rtc-ds1347.c | 5 +----\n 2 files changed, 2 insertions(+), 8 deletions(-)","diff":"diff --git a/drivers/rtc/rtc-digicolor.c b/drivers/rtc/rtc-digicolor.c\nindex b253bf1..1e200a0 100644\n--- a/drivers/rtc/rtc-digicolor.c\n+++ b/drivers/rtc/rtc-digicolor.c\n@@ -202,10 +202,7 @@ static int __init dc_rtc_probe(struct platform_device *pdev)\n \tplatform_set_drvdata(pdev, rtc);\n \trtc->rtc_dev = devm_rtc_device_register(&pdev->dev, pdev->name,\n \t\t\t\t\t\t&dc_rtc_ops, THIS_MODULE);\n-\tif (IS_ERR(rtc->rtc_dev))\n-\t\treturn PTR_ERR(rtc->rtc_dev);\n-\n-\treturn 0;\n+\treturn PTR_ERR_OR_ZERO(rtc->rtc_dev);\n }\n \n static const struct of_device_id dc_dt_ids[] = {\ndiff --git a/drivers/rtc/rtc-ds1347.c b/drivers/rtc/rtc-ds1347.c\nindex ccfc9d4..9a02ca7 100644\n--- a/drivers/rtc/rtc-ds1347.c\n+++ b/drivers/rtc/rtc-ds1347.c\n@@ -155,10 +155,7 @@ static int ds1347_probe(struct spi_device *spi)\n \trtc = devm_rtc_device_register(&spi->dev, \"ds1347\",\n \t\t\t\t&ds1347_rtc_ops, THIS_MODULE);\n \n-\tif (IS_ERR(rtc))\n-\t\treturn PTR_ERR(rtc);\n-\n-\treturn 0;\n+\treturn PTR_ERR_OR_ZERO(rtc);\n }\n \n static struct spi_driver ds1347_driver = {\n","prefixes":[]}