{"id":807065,"url":"http://patchwork.ozlabs.org/api/1.2/patches/807065/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20170829120836.16091-1-berto@igalia.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.2/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20170829120836.16091-1-berto@igalia.com>","list_archive_url":null,"date":"2017-08-29T12:08:36","name":"misc: Remove unused Error variables","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"a70ef752dd73a15617fa392831765a748a217111","submitter":{"id":65704,"url":"http://patchwork.ozlabs.org/api/1.2/people/65704/?format=json","name":"Alberto Garcia","email":"berto@igalia.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20170829120836.16091-1-berto@igalia.com/mbox/","series":[{"id":356,"url":"http://patchwork.ozlabs.org/api/1.2/series/356/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=356","date":"2017-08-29T12:08:36","name":"misc: Remove unused Error variables","version":1,"mbox":"http://patchwork.ozlabs.org/series/356/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/807065/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/807065/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=igalia.com header.i=@igalia.com\n\theader.b=\"qAswsg/L\"; dkim-atps=neutral"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xhS9x0KpYz9t1t\n\tfor ;\n\tTue, 29 Aug 2017 22:09:41 +1000 (AEST)","from localhost ([::1]:44632 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dmfKs-000863-V0\n\tfor incoming@patchwork.ozlabs.org; Tue, 29 Aug 2017 08:09:38 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:38526)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dmfKa-00085n-6t\n\tfor qemu-devel@nongnu.org; Tue, 29 Aug 2017 08:09:21 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dmfKU-0001sN-AG\n\tfor qemu-devel@nongnu.org; Tue, 29 Aug 2017 08:09:20 -0400","from fanzine.igalia.com ([91.117.99.155]:49623)\n\tby eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)\n\t(Exim 4.71) (envelope-from )\n\tid 1dmfKT-0001qd-TN; Tue, 29 Aug 2017 08:09:14 -0400","from [194.100.51.2] (helo=perseus.local)\n\tby fanzine.igalia.com with esmtpsa \n\t(Cipher TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim)\n\tid 1dmfKR-0003qS-5L; Tue, 29 Aug 2017 14:09:11 +0200","from berto by perseus.local with local (Exim 4.89)\n\t(envelope-from )\n\tid 1dmfK9-0004CH-LN; Tue, 29 Aug 2017 15:08:53 +0300"],"DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com;\n\ts=20170329; h=Message-Id:Date:Subject:Cc:To:From;\n\tbh=VGj5ndmh8/b7UT9bF4crQ8bs77yQjpMo3uHteM9CRH8=; \n\tb=qAswsg/L1W9wG0FT5++zID+82YczjutkePgZTf5pjcz4EG4nYhj9wnxuaQGpt5L4xvBRN5DPDlnecXgwDarGzgUVm4tWMHU7Uy59yt2l2v8AbWe5brcZkgKiWbaYkEK+3Mc8ecVQJRoBpTuYf+r2HZ6aglgMmaKVQurl7NmN4fzt+VSvuxuacIUJVfQhnsGrKPBBn8cwqpmE2gUPUYLrdH0jBW1eZPLKPqNS3dVCPh4c4o1jp3Xf93e1zjgiLA8DLhaUmA3/8bP3OVhO3vj2HLlj9xbtkRSXGpIra81IyQA6P9Oua4RUnF4LKgDMtxkOoEWCb2MYFc/AdEFxh1kcMw==;","From":"Alberto Garcia ","To":"qemu-devel@nongnu.org","Date":"Tue, 29 Aug 2017 15:08:36 +0300","Message-Id":"<20170829120836.16091-1-berto@igalia.com>","X-Mailer":"git-send-email 2.11.0","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x (no\n\ttimestamps) [generic] [fuzzy]","X-Received-From":"91.117.99.155","Subject":"[Qemu-devel] [PATCH] misc: Remove unused Error variables","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Kevin Wolf , Alberto Garcia ,\n\tqemu-block@nongnu.org, Max Reitz ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"},"content":"There's a few cases which we're passing an Error pointer to a function\nonly to discard it immediately afterwards without checking it. In\nthese cases we can simply remove the variable and pass NULL instead.\n\nSigned-off-by: Alberto Garcia \n---\n block/qcow.c | 12 +++---------\n block/qcow2.c | 8 ++------\n dump.c | 4 +---\n 3 files changed, 6 insertions(+), 18 deletions(-)","diff":"diff --git a/block/qcow.c b/block/qcow.c\nindex c08cdc4a7b..63904a26ee 100644\n--- a/block/qcow.c\n+++ b/block/qcow.c\n@@ -454,13 +454,11 @@ static uint64_t get_cluster_offset(BlockDriverState *bs,\n start_sect = (offset & ~(s->cluster_size - 1)) >> 9;\n for(i = 0; i < s->cluster_sectors; i++) {\n if (i < n_start || i >= n_end) {\n- Error *err = NULL;\n memset(s->cluster_data, 0x00, 512);\n if (qcrypto_block_encrypt(s->crypto, start_sect + i,\n s->cluster_data,\n BDRV_SECTOR_SIZE,\n- &err) < 0) {\n- error_free(err);\n+ NULL) < 0) {\n errno = EIO;\n return -1;\n }\n@@ -572,7 +570,6 @@ static coroutine_fn int qcow_co_readv(BlockDriverState *bs, int64_t sector_num,\n QEMUIOVector hd_qiov;\n uint8_t *buf;\n void *orig_buf;\n- Error *err = NULL;\n \n if (qiov->niov > 1) {\n buf = orig_buf = qemu_try_blockalign(bs, qiov->size);\n@@ -637,7 +634,7 @@ static coroutine_fn int qcow_co_readv(BlockDriverState *bs, int64_t sector_num,\n if (bs->encrypted) {\n assert(s->crypto);\n if (qcrypto_block_decrypt(s->crypto, sector_num, buf,\n- n * BDRV_SECTOR_SIZE, &err) < 0) {\n+ n * BDRV_SECTOR_SIZE, NULL) < 0) {\n goto fail;\n }\n }\n@@ -660,7 +657,6 @@ done:\n return ret;\n \n fail:\n- error_free(err);\n ret = -EIO;\n goto done;\n }\n@@ -709,11 +705,9 @@ static coroutine_fn int qcow_co_writev(BlockDriverState *bs, int64_t sector_num,\n break;\n }\n if (bs->encrypted) {\n- Error *err = NULL;\n assert(s->crypto);\n if (qcrypto_block_encrypt(s->crypto, sector_num, buf,\n- n * BDRV_SECTOR_SIZE, &err) < 0) {\n- error_free(err);\n+ n * BDRV_SECTOR_SIZE, NULL) < 0) {\n ret = -EIO;\n break;\n }\ndiff --git a/block/qcow2.c b/block/qcow2.c\nindex 40ba26c111..fbfffadc76 100644\n--- a/block/qcow2.c\n+++ b/block/qcow2.c\n@@ -1820,15 +1820,13 @@ static coroutine_fn int qcow2_co_preadv(BlockDriverState *bs, uint64_t offset,\n assert(s->crypto);\n assert((offset & (BDRV_SECTOR_SIZE - 1)) == 0);\n assert((cur_bytes & (BDRV_SECTOR_SIZE - 1)) == 0);\n- Error *err = NULL;\n if (qcrypto_block_decrypt(s->crypto,\n (s->crypt_physical_offset ?\n cluster_offset + offset_in_cluster :\n offset) >> BDRV_SECTOR_BITS,\n cluster_data,\n cur_bytes,\n- &err) < 0) {\n- error_free(err);\n+ NULL) < 0) {\n ret = -EIO;\n goto fail;\n }\n@@ -1942,7 +1940,6 @@ static coroutine_fn int qcow2_co_pwritev(BlockDriverState *bs, uint64_t offset,\n qemu_iovec_concat(&hd_qiov, qiov, bytes_done, cur_bytes);\n \n if (bs->encrypted) {\n- Error *err = NULL;\n assert(s->crypto);\n if (!cluster_data) {\n cluster_data = qemu_try_blockalign(bs->file->bs,\n@@ -1963,8 +1960,7 @@ static coroutine_fn int qcow2_co_pwritev(BlockDriverState *bs, uint64_t offset,\n cluster_offset + offset_in_cluster :\n offset) >> BDRV_SECTOR_BITS,\n cluster_data,\n- cur_bytes, &err) < 0) {\n- error_free(err);\n+ cur_bytes, NULL) < 0) {\n ret = -EIO;\n goto fail;\n }\ndiff --git a/dump.c b/dump.c\nindex d9090a24cc..a79773d0f7 100644\n--- a/dump.c\n+++ b/dump.c\n@@ -1695,10 +1695,8 @@ static void dump_process(DumpState *s, Error **errp)\n \n static void *dump_thread(void *data)\n {\n- Error *err = NULL;\n DumpState *s = (DumpState *)data;\n- dump_process(s, &err);\n- error_free(err);\n+ dump_process(s, NULL);\n return NULL;\n }\n \n","prefixes":[]}