{"id":807005,"url":"http://patchwork.ozlabs.org/api/1.2/patches/807005/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20170829090622.30843-1-kchamart@redhat.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.2/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20170829090622.30843-1-kchamart@redhat.com>","list_archive_url":null,"date":"2017-08-29T09:06:22","name":"[v2] qemu-iotests: Extend non-shared storage migration test (194)","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"e27691e55e1b64d8dd8c6b6df7001a23eec2d2b6","submitter":{"id":65934,"url":"http://patchwork.ozlabs.org/api/1.2/people/65934/?format=json","name":"Kashyap Chamarthy","email":"kchamart@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20170829090622.30843-1-kchamart@redhat.com/mbox/","series":[{"id":329,"url":"http://patchwork.ozlabs.org/api/1.2/series/329/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=329","date":"2017-08-29T09:06:22","name":"[v2] qemu-iotests: Extend non-shared storage migration test (194)","version":2,"mbox":"http://patchwork.ozlabs.org/series/329/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/807005/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/807005/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=nongnu.org\n\t(client-ip=2001:4830:134:3::11; helo=lists.gnu.org;\n\tenvelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n\treceiver=)","ext-mx09.extmail.prod.ext.phx2.redhat.com;\n\tdmarc=none (p=none dis=none) header.from=redhat.com","ext-mx09.extmail.prod.ext.phx2.redhat.com;\n\tspf=fail smtp.mailfrom=kchamart@redhat.com"],"Received":["from lists.gnu.org (lists.gnu.org [IPv6:2001:4830:134:3::11])\n\t(using TLSv1 with cipher AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xhN7G5GwTz9t2Q\n\tfor ;\n\tTue, 29 Aug 2017 19:07:06 +1000 (AEST)","from localhost ([::1]:43524 helo=lists.gnu.org)\n\tby lists.gnu.org with esmtp (Exim 4.71) (envelope-from\n\t)\n\tid 1dmcUC-0002A9-Ls\n\tfor incoming@patchwork.ozlabs.org; Tue, 29 Aug 2017 05:07:04 -0400","from eggs.gnu.org ([2001:4830:134:3::10]:48226)\n\tby lists.gnu.org with esmtp (Exim 4.71)\n\t(envelope-from ) id 1dmcTq-00027v-CY\n\tfor qemu-devel@nongnu.org; Tue, 29 Aug 2017 05:06:43 -0400","from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)\n\t(envelope-from ) id 1dmcTo-0005qI-Vf\n\tfor qemu-devel@nongnu.org; Tue, 29 Aug 2017 05:06:42 -0400","from mx1.redhat.com ([209.132.183.28]:37998)\n\tby eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32)\n\t(Exim 4.71) (envelope-from )\n\tid 1dmcTi-0005mT-KT; Tue, 29 Aug 2017 05:06:34 -0400","from smtp.corp.redhat.com\n\t(int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id 93C2D4A6EE;\n\tTue, 29 Aug 2017 09:06:33 +0000 (UTC)","from eukaryote.localdomain (ovpn-117-86.ams2.redhat.com\n\t[10.36.117.86])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id F41126BC1E;\n\tTue, 29 Aug 2017 09:06:26 +0000 (UTC)"],"DMARC-Filter":"OpenDMARC Filter v1.3.2 mx1.redhat.com 93C2D4A6EE","From":"Kashyap Chamarthy ","To":"qemu-devel@nongnu.org","Date":"Tue, 29 Aug 2017 11:06:22 +0200","Message-Id":"<20170829090622.30843-1-kchamart@redhat.com>","X-Scanned-By":"MIMEDefang 2.79 on 10.5.11.11","X-Greylist":"Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.38]);\n\tTue, 29 Aug 2017 09:06:33 +0000 (UTC)","X-detected-operating-system":"by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic]\n\t[fuzzy]","X-Received-From":"209.132.183.28","Subject":"[Qemu-devel] [PATCH v2] qemu-iotests: Extend non-shared storage\n\tmigration test (194)","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"kwolf@redhat.com, famz@redhat.com, qemu-block@nongnu.org,\n\tKashyap Chamarthy , dgilbert@redhat.com,\n\tstefanha@redhat.com","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"\"Qemu-devel\"\n\t"},"content":"This is the follow-up patch that was discussed[*] as part of feedback to\nqemu-iotest 194.\n\nChanges in this patch:\n\n - Supply 'job-id' parameter to `drive-mirror` invocation.\n\n - Issue QMP `block-job-cancel` command on the source QEMU to\n gracefully complete `drive-mirror` operation.\n\n - Stop the NBD server on the destination QEMU.\n\n - Finally, check for both the events: MIGRATION and\n BLOCK_JOB_COMPLETED\n\nWith the above, the test will also be (almost) in sync with the\nprocedure outlined in the document 'live-block-operations.rst'[+]\n(section: \"QMP invocation for live storage migration with\n``drive-mirror`` + NBD\").\n\n[*] https://lists.nongnu.org/archive/html/qemu-devel/2017-08/msg04820.html\n -- qemu-iotests: add 194 non-shared storage migration test\n[+] https://git.qemu.org/gitweb.cgi?p=qemu.git;a=blob;f=docs/interop/live-block-operations.rst\n\nSigned-off-by: Kashyap Chamarthy \n---\nChanges in v2:\n - Check for both the events: MIGRATION and BLOCK_JOB_COMPLETED (Eric)\n---\n tests/qemu-iotests/194 | 25 +++++++++++++++++++------\n tests/qemu-iotests/194.out | 11 ++++++++---\n 2 files changed, 27 insertions(+), 9 deletions(-)","diff":"diff --git a/tests/qemu-iotests/194 b/tests/qemu-iotests/194\nindex 8028111e21bed5cf4a2e8e32dc04aa5a9ea9caca..9d81189fe3e790d060da5a0fd41836f4b57f95c7 100755\n--- a/tests/qemu-iotests/194\n+++ b/tests/qemu-iotests/194\n@@ -46,16 +46,17 @@ iotests.log('Launching NBD server on destination...')\n iotests.log(dest_vm.qmp('nbd-server-start', addr={'type': 'unix', 'data': {'path': nbd_sock_path}}))\n iotests.log(dest_vm.qmp('nbd-server-add', device='drive0', writable=True))\n \n-iotests.log('Starting drive-mirror on source...')\n+iotests.log('Starting `drive-mirror` on source...')\n iotests.log(source_vm.qmp(\n 'drive-mirror',\n device='drive0',\n target='nbd+unix:///drive0?socket={0}'.format(nbd_sock_path),\n sync='full',\n format='raw', # always raw, the server handles the format\n- mode='existing'))\n+ mode='existing',\n+ job_id='mirror-job0'))\n \n-iotests.log('Waiting for drive-mirror to complete...')\n+iotests.log('Waiting for `drive-mirror` to complete...')\n iotests.log(source_vm.event_wait('BLOCK_JOB_READY'),\n filters=[iotests.filter_qmp_event])\n \n@@ -66,8 +67,20 @@ dest_vm.qmp('migrate-set-capabilities',\n capabilities=[{'capability': 'events', 'state': True}])\n iotests.log(source_vm.qmp('migrate', uri='unix:{0}'.format(migration_sock_path)))\n \n+iotests.log('Gracefully ending the `drive-mirror` job on source...')\n+iotests.log(source_vm.qmp('block-job-cancel', device='mirror-job0'))\n+\n+iotests.log('Stopping the NBD server on destination...')\n+iotests.log(dest_vm.qmp('nbd-server-stop'))\n+\n while True:\n- event = source_vm.event_wait('MIGRATION')\n- iotests.log(event, filters=[iotests.filter_qmp_event])\n- if event['data']['status'] in ('completed', 'failed'):\n+ event1 = source_vm.event_wait('MIGRATION')\n+ iotests.log(event1, filters=[iotests.filter_qmp_event])\n+ if event1['data']['status'] in ('completed', 'failed'):\n+ break\n+\n+while True:\n+ event2 = source_vm.event_wait('BLOCK_JOB_COMPLETED')\n+ iotests.log(event2, filters=[iotests.filter_qmp_event])\n+ if event2['event'] == 'BLOCK_JOB_COMPLETED':\n break\ndiff --git a/tests/qemu-iotests/194.out b/tests/qemu-iotests/194.out\nindex ae501fecacb706b1851cb9063ce9c9d5a28bb7ea..a461d7e21abb2dee54d72d93d644100f9fbcb17d 100644\n--- a/tests/qemu-iotests/194.out\n+++ b/tests/qemu-iotests/194.out\n@@ -2,12 +2,17 @@ Launching VMs...\n Launching NBD server on destination...\n {u'return': {}}\n {u'return': {}}\n-Starting drive-mirror on source...\n+Starting `drive-mirror` on source...\n {u'return': {}}\n-Waiting for drive-mirror to complete...\n-{u'timestamp': {u'seconds': 'SECS', u'microseconds': 'USECS'}, u'data': {u'device': u'drive0', u'type': u'mirror', u'speed': 0, u'len': 1073741824, u'offset': 1073741824}, u'event': u'BLOCK_JOB_READY'}\n+Waiting for `drive-mirror` to complete...\n+{u'timestamp': {u'seconds': 'SECS', u'microseconds': 'USECS'}, u'data': {u'device': u'mirror-job0', u'type': u'mirror', u'speed': 0, u'len': 1073741824, u'offset': 1073741824}, u'event': u'BLOCK_JOB_READY'}\n Starting migration...\n {u'return': {}}\n+Gracefully ending the `drive-mirror` job on source...\n+{u'return': {}}\n+Stopping the NBD server on destination...\n+{u'return': {}}\n {u'timestamp': {u'seconds': 'SECS', u'microseconds': 'USECS'}, u'data': {u'status': u'setup'}, u'event': u'MIGRATION'}\n {u'timestamp': {u'seconds': 'SECS', u'microseconds': 'USECS'}, u'data': {u'status': u'active'}, u'event': u'MIGRATION'}\n {u'timestamp': {u'seconds': 'SECS', u'microseconds': 'USECS'}, u'data': {u'status': u'completed'}, u'event': u'MIGRATION'}\n+{u'timestamp': {u'seconds': 'SECS', u'microseconds': 'USECS'}, u'data': {u'device': u'mirror-job0', u'type': u'mirror', u'speed': 0, u'len': 1073741824, u'offset': 1073741824}, u'event': u'BLOCK_JOB_COMPLETED'}\n","prefixes":["v2"]}