{"id":806936,"url":"http://patchwork.ozlabs.org/api/1.2/patches/806936/?format=json","web_url":"http://patchwork.ozlabs.org/project/openvswitch/patch/1503980997-3519-1-git-send-email-roid@mellanox.com/","project":{"id":47,"url":"http://patchwork.ozlabs.org/api/1.2/projects/47/?format=json","name":"Open vSwitch","link_name":"openvswitch","list_id":"ovs-dev.openvswitch.org","list_email":"ovs-dev@openvswitch.org","web_url":"http://openvswitch.org/","scm_url":"git@github.com:openvswitch/ovs.git","webscm_url":"https://github.com/openvswitch/ovs","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<1503980997-3519-1-git-send-email-roid@mellanox.com>","list_archive_url":null,"date":"2017-08-29T04:29:57","name":"[ovs-dev] netdev-tc-offloads: Fix offloading when tunnel id is 0","commit_ref":null,"pull_url":null,"state":"changes-requested","archived":false,"hash":"6d8b34656faf1dda14cc9bc636df9676ceaaa29a","submitter":{"id":70307,"url":"http://patchwork.ozlabs.org/api/1.2/people/70307/?format=json","name":"Roi Dayan","email":"roid@mellanox.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/openvswitch/patch/1503980997-3519-1-git-send-email-roid@mellanox.com/mbox/","series":[{"id":299,"url":"http://patchwork.ozlabs.org/api/1.2/series/299/?format=json","web_url":"http://patchwork.ozlabs.org/project/openvswitch/list/?series=299","date":"2017-08-29T04:29:57","name":"[ovs-dev] netdev-tc-offloads: Fix offloading when tunnel id is 0","version":1,"mbox":"http://patchwork.ozlabs.org/series/299/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/806936/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/806936/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","dev@openvswitch.org"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","ovs-dev@mail.linuxfoundation.org"],"Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=openvswitch.org\n\t(client-ip=140.211.169.12; helo=mail.linuxfoundation.org;\n\tenvelope-from=ovs-dev-bounces@openvswitch.org;\n\treceiver=)","Received":["from mail.linuxfoundation.org (mail.linuxfoundation.org\n\t[140.211.169.12])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xhFzf71dKz9s7c\n\tfor ;\n\tTue, 29 Aug 2017 14:30:06 +1000 (AEST)","from mail.linux-foundation.org (localhost [127.0.0.1])\n\tby mail.linuxfoundation.org (Postfix) with ESMTP id 1E8648E2;\n\tTue, 29 Aug 2017 04:30:03 +0000 (UTC)","from smtp1.linuxfoundation.org (smtp1.linux-foundation.org\n\t[172.17.192.35])\n\tby mail.linuxfoundation.org (Postfix) with ESMTPS id 4E2E788A\n\tfor ; Tue, 29 Aug 2017 04:30:02 +0000 (UTC)","from mellanox.co.il (mail-il-dmz.mellanox.com [193.47.165.129])\n\tby smtp1.linuxfoundation.org (Postfix) with ESMTP id 64CEF87\n\tfor ; Tue, 29 Aug 2017 04:30:01 +0000 (UTC)","from Internal Mail-Server by MTLPINE1 (envelope-from\n\troid@mellanox.com)\n\twith ESMTPS (AES256-SHA encrypted); 29 Aug 2017 07:29:59 +0300","from dev-r-vrt-189.mtr.labs.mlnx (dev-r-vrt-189.mtr.labs.mlnx\n\t[10.212.189.1])\n\tby labmailer.mlnx (8.13.8/8.13.8) with ESMTP id v7T4TxCW026316;\n\tTue, 29 Aug 2017 07:29:59 +0300"],"X-Greylist":"domain auto-whitelisted by SQLgrey-1.7.6","From":"Roi Dayan ","To":"dev@openvswitch.org","Date":"Tue, 29 Aug 2017 07:29:57 +0300","Message-Id":"<1503980997-3519-1-git-send-email-roid@mellanox.com>","X-Mailer":"git-send-email 2.7.5","X-Spam-Status":"No, score=0.0 required=5.0 tests=RP_MATCHES_RCVD,\n\tUNPARSEABLE_RELAY autolearn=disabled version=3.3.1","X-Spam-Checker-Version":"SpamAssassin 3.3.1 (2010-03-16) on\n\tsmtp1.linux-foundation.org","Cc":"Simon Horman ","Subject":"[ovs-dev] [PATCH] netdev-tc-offloads: Fix offloading when tunnel id\n\tis 0","X-BeenThere":"ovs-dev@openvswitch.org","X-Mailman-Version":"2.1.12","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"ovs-dev-bounces@openvswitch.org","Errors-To":"ovs-dev-bounces@openvswitch.org"},"content":"From: Paul Blakey \n\nCurrently we test the tunnel id value and not the mask so matching on\ntunnel id 0 is skipped and we fail to offload the rule with an\nunknown attribute error.\n\nFix this by testing the mask of tunnel id instead.\n\nFixes: 8f283af89298 (\"netdev-tc-offloads: Implement netdev flow put using tc interface\")\nSigned-off-by: Paul Blakey \nReviewed-by: Roi Dayan \n---\n lib/netdev-tc-offloads.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)","diff":"diff --git a/lib/netdev-tc-offloads.c b/lib/netdev-tc-offloads.c\nindex 099c021..ba7a873 100644\n--- a/lib/netdev-tc-offloads.c\n+++ b/lib/netdev-tc-offloads.c\n@@ -678,7 +678,7 @@ netdev_tc_flow_put(struct netdev *netdev, struct match *match,\n \n memset(&flower, 0, sizeof flower);\n \n- if (tnl->tun_id) {\n+ if (mask->tunnel.tun_id) {\n VLOG_DBG_RL(&rl,\n \"tunnel: id %#\" PRIx64 \" src \" IP_FMT\n \" dst \" IP_FMT \" tp_src %d tp_dst %d\",\n","prefixes":["ovs-dev"]}