{"id":806198,"url":"http://patchwork.ozlabs.org/api/1.2/patches/806198/?format=json","web_url":"http://patchwork.ozlabs.org/project/uboot/patch/1503800579-19321-2-git-send-email-bmeng.cn@gmail.com/","project":{"id":18,"url":"http://patchwork.ozlabs.org/api/1.2/projects/18/?format=json","name":"U-Boot","link_name":"uboot","list_id":"u-boot.lists.denx.de","list_email":"u-boot@lists.denx.de","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<1503800579-19321-2-git-send-email-bmeng.cn@gmail.com>","list_archive_url":null,"date":"2017-08-27T02:22:59","name":"[U-Boot,2/2] x86: ich-spi: Clear atomic preop only when SPI settings are not locked","commit_ref":"d2ca80c3d7e314c2dd2ac1bf63e5630ae7131a57","pull_url":null,"state":"accepted","archived":false,"hash":"a7747903e53641ef8982b3e7d52e66fd56fd4111","submitter":{"id":64981,"url":"http://patchwork.ozlabs.org/api/1.2/people/64981/?format=json","name":"Bin Meng","email":"bmeng.cn@gmail.com"},"delegate":{"id":56520,"url":"http://patchwork.ozlabs.org/api/1.2/users/56520/?format=json","username":"bmeng","first_name":"Bin","last_name":"Meng","email":"bmeng.cn@gmail.com"},"mbox":"http://patchwork.ozlabs.org/project/uboot/patch/1503800579-19321-2-git-send-email-bmeng.cn@gmail.com/mbox/","series":[],"comments":"http://patchwork.ozlabs.org/api/patches/806198/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/806198/checks/","tags":{},"related":[],"headers":{"Return-Path":"<u-boot-bounces@lists.denx.de>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=<UNKNOWN>)","ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"u847KTom\"; dkim-atps=neutral"],"Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xfz9Y1jqhz9sRm\n\tfor <incoming@patchwork.ozlabs.org>;\n\tSun, 27 Aug 2017 12:19:13 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid C3E18C221F0; Sun, 27 Aug 2017 02:18:57 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id 8A28AC2223C;\n\tSun, 27 Aug 2017 02:18:40 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid 40E63C221AB; Sun, 27 Aug 2017 02:18:38 +0000 (UTC)","from mail-io0-f193.google.com (mail-io0-f193.google.com\n\t[209.85.223.193])\n\tby lists.denx.de (Postfix) with ESMTPS id B2000C22194\n\tfor <u-boot@lists.denx.de>; Sun, 27 Aug 2017 02:18:37 +0000 (UTC)","by mail-io0-f193.google.com with SMTP id m40so1547860ioi.5\n\tfor <u-boot@lists.denx.de>; Sat, 26 Aug 2017 19:18:37 -0700 (PDT)","from ala-d2121-lx1.wrs.com (unknown-156-139.windriver.com.\n\t[147.11.156.139]) by smtp.gmail.com with ESMTPSA id\n\tw135sm2385424itc.42.2017.08.26.19.18.35\n\t(version=TLS1_1 cipher=ECDHE-RSA-AES128-SHA bits=128/128);\n\tSat, 26 Aug 2017 19:18:35 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=0.0 required=5.0 tests=FREEMAIL_FROM,\n\tRCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2,\n\tT_DKIM_INVALID autolearn=unavailable\n\tautolearn_force=no version=3.4.0","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=from:to:subject:date:message-id:in-reply-to:references;\n\tbh=aT790oOA46UoW1YSTKpUnT4o9QMLf9WSO9THgIPTKFc=;\n\tb=u847KTomLC72bAkoPrwcRePp9GNzo80vOu/NWoIXqsL5wrKuCzccXPc93BPvRL139z\n\tESXdcoqqr5UX8sN+nATTNLNGd/hvhEg+NfXUtDfAgZHvRlmeYKdiYWUqVdfRJCrqhXSn\n\tr63WmmeF8Wu+bHHshVDHnZURHQso/fmJ9BctfMI9Hs3DNSceRuTfZWoB3UfhtBGRdcik\n\tvV8/I8ingolanjDCgCCHfqBCTd5dFJXc4L26Wvpy/lFdxv1FnR+MYrOqfaYcUwUbjc2B\n\thSFbW2Msp9oK8+oos10SET9nPASWguHFI+fXLtG8Vk6vLog32RGq3zKlusfsukNq4vPW\n\th+Lg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=aT790oOA46UoW1YSTKpUnT4o9QMLf9WSO9THgIPTKFc=;\n\tb=uVrFEsP633PfxdG8XiUUjutWK/22PbqHcYUAZzzmYGutYPkj5Zl40Vm62g8emIMFSn\n\t1FuDgnJ8xAO9DuH8ZdLTe+AoQ/JqwSBUV/Lk48xbuGPzd5cij9mZxy/50w9z+DjH6ug4\n\tzHkPjk0avlYOkBCh70nWWWBSUnrUfLftqleq1B04yUp3sjw0spELKE++Rbc9oFLqtQLV\n\t9gbFjpCl6Z9PmImRboOxzvLKwmsNCxwh1PdcWL86nT/zj0nJPfnHlYwdlmFVvXtNRivW\n\t2cn0zB8i0/wbr+X02RukEUruTf/USkot+ijbbJ/wMaHpdRUaUgBI/e2pVR34Wts7nERZ\n\taP6g==","X-Gm-Message-State":"AHYfb5iSWsnQUPRbRNbYlfpbtafl5dM66zVq02lE6oYIJGxfWWR8vMcf\n\ttVyg4/U7HUe+RA==","X-Received":"by 10.107.15.135 with SMTP id 7mr2563933iop.57.1503800316705;\n\tSat, 26 Aug 2017 19:18:36 -0700 (PDT)","From":"Bin Meng <bmeng.cn@gmail.com>","To":"Simon Glass <sjg@chromium.org>, Stefan Roese <sr@denx.de>,\n\tU-Boot Mailing List <u-boot@lists.denx.de>","Date":"Sat, 26 Aug 2017 19:22:59 -0700","Message-Id":"<1503800579-19321-2-git-send-email-bmeng.cn@gmail.com>","X-Mailer":"git-send-email 1.7.9.5","In-Reply-To":"<1503800579-19321-1-git-send-email-bmeng.cn@gmail.com>","References":"<1503800579-19321-1-git-send-email-bmeng.cn@gmail.com>","Subject":"[U-Boot] [PATCH 2/2] x86: ich-spi: Clear atomic preop only when SPI\n\tsettings are not locked","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion <u-boot.lists.denx.de>","List-Unsubscribe":"<https://lists.denx.de/options/u-boot>,\n\t<mailto:u-boot-request@lists.denx.de?subject=unsubscribe>","List-Archive":"<http://lists.denx.de/pipermail/u-boot/>","List-Post":"<mailto:u-boot@lists.denx.de>","List-Help":"<mailto:u-boot-request@lists.denx.de?subject=help>","List-Subscribe":"<https://lists.denx.de/listinfo/u-boot>,\n\t<mailto:u-boot-request@lists.denx.de?subject=subscribe>","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" <u-boot-bounces@lists.denx.de>"},"content":"The atomic preop register can only be written when SPI settings are\nnot locked, otherwise it's read-only.\n\nSigned-off-by: Bin Meng <bmeng.cn@gmail.com>\n---\n\n drivers/spi/ich.c | 3 ++-\n 1 file changed, 2 insertions(+), 1 deletion(-)","diff":"diff --git a/drivers/spi/ich.c b/drivers/spi/ich.c\nindex 5a3d690..22fc83d 100644\n--- a/drivers/spi/ich.c\n+++ b/drivers/spi/ich.c\n@@ -563,7 +563,8 @@ static int ich_spi_xfer(struct udevice *dev, unsigned int bitlen,\n \t}\n \n \t/* Clear atomic preop now that xfer is done */\n-\tich_writew(ctlr, 0, ctlr->preop);\n+\tif (!lock)\n+\t\tich_writew(ctlr, 0, ctlr->preop);\n \n \treturn 0;\n }\n","prefixes":["U-Boot","2/2"]}