{"id":806148,"url":"http://patchwork.ozlabs.org/api/1.2/patches/806148/?format=json","web_url":"http://patchwork.ozlabs.org/project/netdev/patch/1503778667-4416-1-git-send-email-himanshujha199640@gmail.com/","project":{"id":7,"url":"http://patchwork.ozlabs.org/api/1.2/projects/7/?format=json","name":"Linux network development","link_name":"netdev","list_id":"netdev.vger.kernel.org","list_email":"netdev@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<1503778667-4416-1-git-send-email-himanshujha199640@gmail.com>","list_archive_url":null,"date":"2017-08-26T20:17:47","name":"net: ethernet: broadcom: Remove null check before kfree","commit_ref":null,"pull_url":null,"state":"accepted","archived":true,"hash":"d0e7b3505d93dbe3e3fe56130f56539efc612ffb","submitter":{"id":72201,"url":"http://patchwork.ozlabs.org/api/1.2/people/72201/?format=json","name":"Himanshu Jha","email":"himanshujha199640@gmail.com"},"delegate":{"id":34,"url":"http://patchwork.ozlabs.org/api/1.2/users/34/?format=json","username":"davem","first_name":"David","last_name":"Miller","email":"davem@davemloft.net"},"mbox":"http://patchwork.ozlabs.org/project/netdev/patch/1503778667-4416-1-git-send-email-himanshujha199640@gmail.com/mbox/","series":[],"comments":"http://patchwork.ozlabs.org/api/patches/806148/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/806148/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"NPxWrSRM\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xfq9m6M7Fz9sNc\n\tfor ;\n\tSun, 27 Aug 2017 06:18:52 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751121AbdHZUS3 (ORCPT );\n\tSat, 26 Aug 2017 16:18:29 -0400","from mail-pg0-f66.google.com ([74.125.83.66]:34810 \"EHLO\n\tmail-pg0-f66.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751083AbdHZUS1 (ORCPT\n\t); Sat, 26 Aug 2017 16:18:27 -0400","by mail-pg0-f66.google.com with SMTP id 63so3319053pgc.1;\n\tSat, 26 Aug 2017 13:18:27 -0700 (PDT)","from localhost.localdomain ([103.46.192.10])\n\tby smtp.gmail.com with ESMTPSA id\n\tx4sm16062829pfb.79.2017.08.26.13.18.23\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128);\n\tSat, 26 Aug 2017 13:18:25 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=gmail.com; s=20161025;\n\th=from:to:cc:subject:date:message-id;\n\tbh=K4NtbYBnhCCkq09926Wo6b56wrySvDdn3WpqaOt7dDo=;\n\tb=NPxWrSRMD6F2xLttObe8BY2fW6kjiacZXWLjAph47MYDhJ5iatgVNVV/46WB6qUY+E\n\trlALPk00M/O1ngQKBKdzxV+y3hCC3D9IT9SFodKASdR5fMjsXdPhTIiaUwqaWYaZzqk1\n\tLgyQszFtL2MZg+7TDqUPPu1Ay/DAqtRb9pRcmTqMjtDDbcAvLAOHidyVde/No5+S9Mih\n\t/XwpctvBGf7SqDXxEWbGf86tBA+IKu8RDwh8A12OCn1F/xwl/znYl+GrOMSAoMrqHn96\n\tdUGh9jLUMvaj2/uhGP6GLfor3n/FpbSFXG4RH655JTIW6RK6QOopAUUopLpwTLSJSWsp\n\tzy4g==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id;\n\tbh=K4NtbYBnhCCkq09926Wo6b56wrySvDdn3WpqaOt7dDo=;\n\tb=t3tgyQmytpnOUgE8nb3jo7GEtzdHu7syAm2Z1Mvo5dWfG19GEoJqVo+vNnBlX8gXTo\n\tBNq719Z1Krag2wVx7l+G8bcv5n2MAv13++tpg91DoyicTr+410ReEkyWs3Ge8hVWXc8C\n\tM2LqdzkRCEyRhpUGmCa+1x16eJtXzV8oQ+j+ANLC6LSIGyV3e5m+vBjdNouoDro11DvR\n\t8XNi0xWmj+1BJqWzqRJ5zmvw9qY0VEbcYadW3nUO684LTL+ywr8SNiJ5+yfoqF319iXM\n\tUZaI469k8z2QvahlmXw21EkQkcK7gYKQTaL2GXyMyLkftwWVcV/7uuJA8fl2e7yyRHOK\n\tvymQ==","X-Gm-Message-State":"AHYfb5h9uibVGJp03tgk/quMv2Itb/MUlx5/ID85o8i9CyevLGQ8Wcuv\n\tw8axcXCsc6hxmw==","X-Received":"by 10.99.38.195 with SMTP id m186mr2669818pgm.323.1503778707085; \n\tSat, 26 Aug 2017 13:18:27 -0700 (PDT)","From":"Himanshu Jha ","To":"davem@davemloft.net","Cc":"jarod@redhat.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org,\n\tHimanshu Jha ","Subject":"[PATCH] net: ethernet: broadcom: Remove null check before kfree","Date":"Sun, 27 Aug 2017 01:47:47 +0530","Message-Id":"<1503778667-4416-1-git-send-email-himanshujha199640@gmail.com>","X-Mailer":"git-send-email 2.7.4","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"},"content":"Kfree on NULL pointer is a no-op and therefore checking is redundant.\n\nSigned-off-by: Himanshu Jha \n---\n drivers/net/ethernet/broadcom/sb1250-mac.c | 12 ++++--------\n 1 file changed, 4 insertions(+), 8 deletions(-)","diff":"diff --git a/drivers/net/ethernet/broadcom/sb1250-mac.c b/drivers/net/ethernet/broadcom/sb1250-mac.c\nindex 16a0f19..ecdef42 100644\n--- a/drivers/net/ethernet/broadcom/sb1250-mac.c\n+++ b/drivers/net/ethernet/broadcom/sb1250-mac.c\n@@ -1367,15 +1367,11 @@ static int sbmac_initctx(struct sbmac_softc *s)\n \n static void sbdma_uninitctx(struct sbmacdma *d)\n {\n-\tif (d->sbdma_dscrtable_unaligned) {\n-\t\tkfree(d->sbdma_dscrtable_unaligned);\n-\t\td->sbdma_dscrtable_unaligned = d->sbdma_dscrtable = NULL;\n-\t}\n+\tkfree(d->sbdma_dscrtable_unaligned);\n+\td->sbdma_dscrtable_unaligned = d->sbdma_dscrtable = NULL;\n \n-\tif (d->sbdma_ctxtable) {\n-\t\tkfree(d->sbdma_ctxtable);\n-\t\td->sbdma_ctxtable = NULL;\n-\t}\n+\tkfree(d->sbdma_ctxtable);\n+\td->sbdma_ctxtable = NULL;\n }\n \n \n","prefixes":[]}