{"id":806137,"url":"http://patchwork.ozlabs.org/api/1.2/patches/806137/?format=json","web_url":"http://patchwork.ozlabs.org/project/rtc-linux/patch/3b43da73-ff4e-4519-d1c7-266b17cc5d05@gmail.com/","project":{"id":9,"url":"http://patchwork.ozlabs.org/api/1.2/projects/9/?format=json","name":"Linux RTC development","link_name":"rtc-linux","list_id":"linux-rtc.vger.kernel.org","list_email":"linux-rtc@vger.kernel.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<3b43da73-ff4e-4519-d1c7-266b17cc5d05@gmail.com>","list_archive_url":null,"date":"2017-08-26T19:16:34","name":"rtc: core: let rtc_set_time properly populate element wday","commit_ref":null,"pull_url":null,"state":"rejected","archived":false,"hash":"2ce15c75f0212da6a316d5d30ad667fedb2ec4ec","submitter":{"id":65365,"url":"http://patchwork.ozlabs.org/api/1.2/people/65365/?format=json","name":"Heiner Kallweit","email":"hkallweit1@gmail.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/rtc-linux/patch/3b43da73-ff4e-4519-d1c7-266b17cc5d05@gmail.com/mbox/","series":[],"comments":"http://patchwork.ozlabs.org/api/patches/806137/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/806137/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=linux-rtc-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"kvp1NhgO\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xfnp65HlNz9rvt\n\tfor ;\n\tSun, 27 Aug 2017 05:16:46 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751137AbdHZTQp (ORCPT );\n\tSat, 26 Aug 2017 15:16:45 -0400","from mail-wr0-f196.google.com ([209.85.128.196]:38544 \"EHLO\n\tmail-wr0-f196.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751056AbdHZTQp (ORCPT\n\t); Sat, 26 Aug 2017 15:16:45 -0400","by mail-wr0-f196.google.com with SMTP id o76so1750676wrb.5\n\tfor ; Sat, 26 Aug 2017 12:16:44 -0700 (PDT)","from ?IPv6:2003:ea:8bc7:5e00:a47e:1aef:83c8:d614?\n\t(p200300EA8BC75E00A47E1AEF83C8D614.dip0.t-ipconnect.de.\n\t[2003:ea:8bc7:5e00:a47e:1aef:83c8:d614])\n\tby smtp.googlemail.com with ESMTPSA id\n\to82sm2785471wmo.5.2017.08.26.12.16.42\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tSat, 26 Aug 2017 12:16:43 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=gmail.com; s=20161025;\n\th=from:subject:to:cc:message-id:date:user-agent:mime-version\n\t:content-transfer-encoding;\n\tbh=noVLl1KRqcc3QhtLZg1M9MYNFQ8lAJtRTqUUdtkwwjw=;\n\tb=kvp1NhgOxruyUytplhaE2UZgTJLqrlek2geTf6XRV7sQNJ3W1RAyF6WAbDecVDHzaU\n\t8UcQJYD4JMCFRKytBEZ7fJ/gpGJVzrgIykoLuKBghMZns34n9uC8sczYeu8zdM1DgBIN\n\tbCfU2HDpmnduK3tenRTl+s8tsmR1/m4loqqh0FShDmOHJcO7TugqseG/G0wne+RpcCJG\n\tWnMKK2dQ30CDvELEDdfriI7C60PvrtFI7H0u59vWGRFeEA3hzrHbgZye2TKin1XT5QZE\n\tSQlVowGnhP+rgV5wkLF0Aj9sHxJW20XqCt5lJZmskT2ixYQH2B1qcFprP8LhgwBATFED\n\tHzQw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:subject:to:cc:message-id:date:user-agent\n\t:mime-version:content-transfer-encoding;\n\tbh=noVLl1KRqcc3QhtLZg1M9MYNFQ8lAJtRTqUUdtkwwjw=;\n\tb=H6ZRiHAA9UNJAKOo3BrfezgvFhw9lcwOm8pAKrjoALoFw7jStla7VA8ffwEs//BrbW\n\tWefvSAPqmDv7Qjomf3luZqWj5phlc8OV0HWy9tldnaViwIT46WGF+9efPpveCBZZEUrH\n\tpykb+mzsWzB1EH+cy+lScnVcJpKkbPre5y/NsjlRZ7dzdfiqCvnuPk857S8urkov1Tpv\n\tGKCD8YKtP8IOAVBfTloVzljBimzhP7NxK+MCOGyqrKvdymBSOp+uPHdkLK9cIA6C9kQr\n\tcOMojMd5jL9TvGZ5BglUW3+RN5uQG2a9UK8iQ9aLAFRu+ayQXWeQIQn8Q3mUDkkryNeo\n\tIH3w==","X-Gm-Message-State":"AHYfb5jbf99ww8trtG3fqEe/5Puv7NMBscyC4/l8tC4BZCmXkrztrBD3\n\t+Uvccc/4QHidpV98","X-Received":"by 10.223.134.107 with SMTP id 40mr1316914wrw.223.1503775003910; \n\tSat, 26 Aug 2017 12:16:43 -0700 (PDT)","From":"Heiner Kallweit ","Subject":"[PATCH] rtc: core: let rtc_set_time properly populate element wday","To":"Alexandre Belloni ","Cc":"linux-rtc@vger.kernel.org","Message-ID":"<3b43da73-ff4e-4519-d1c7-266b17cc5d05@gmail.com>","Date":"Sat, 26 Aug 2017 21:16:34 +0200","User-Agent":"Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101\n\tThunderbird/52.3.0","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Transfer-Encoding":"7bit","Sender":"linux-rtc-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"linux-rtc@vger.kernel.org"},"content":"Some drivers use element wday of the struct rtc_time which is passed to\ncallback set_time. However element wday may incorrectly or not be\npopulated if struct rtc_time is coming from userspace via rtc_dev_ioctl.\nrtc_valid_tm() doesn't check element wday.\n\nTherefore convert struct rtc_time to time64_t and then use\nrtc_time64_to_tm to generate a struct rtc_time with all elements properly\npopulated.\n\nSigned-off-by: Heiner Kallweit \n---\n drivers/rtc/interface.c | 24 ++++++++++++++++--------\n 1 file changed, 16 insertions(+), 8 deletions(-)","diff":"diff --git a/drivers/rtc/interface.c b/drivers/rtc/interface.c\nindex 8cec9a02..5a53c590 100644\n--- a/drivers/rtc/interface.c\n+++ b/drivers/rtc/interface.c\n@@ -59,28 +59,36 @@ EXPORT_SYMBOL_GPL(rtc_read_time);\n \n int rtc_set_time(struct rtc_device *rtc, struct rtc_time *tm)\n {\n+\ttime64_t secs64;\n \tint err;\n \n \terr = rtc_valid_tm(tm);\n \tif (err != 0)\n \t\treturn err;\n \n+\tsecs64 = rtc_tm_to_time64(tm);\n+\n \terr = mutex_lock_interruptible(&rtc->ops_lock);\n \tif (err)\n \t\treturn err;\n \n \tif (!rtc->ops)\n \t\terr = -ENODEV;\n-\telse if (rtc->ops->set_time)\n-\t\terr = rtc->ops->set_time(rtc->dev.parent, tm);\n-\telse if (rtc->ops->set_mmss64) {\n-\t\ttime64_t secs64 = rtc_tm_to_time64(tm);\n-\n+\telse if (rtc->ops->set_time) {\n+\t\tstruct rtc_time tmp;\n+\n+\t\t/*\n+\t\t * element wday of tm may not be set, therefore use\n+\t\t * rtc_time64_to_tm to generate a struct rtc_time\n+\t\t * with all elements being properly populated\n+\t\t */\n+\t\trtc_time64_to_tm(secs64, &tmp);\n+\t\terr = rtc->ops->set_time(rtc->dev.parent, &tmp);\n+\t} else if (rtc->ops->set_mmss64)\n \t\terr = rtc->ops->set_mmss64(rtc->dev.parent, secs64);\n-\t} else if (rtc->ops->set_mmss) {\n-\t\ttime64_t secs64 = rtc_tm_to_time64(tm);\n+\telse if (rtc->ops->set_mmss)\n \t\terr = rtc->ops->set_mmss(rtc->dev.parent, secs64);\n-\t} else\n+\telse\n \t\terr = -EINVAL;\n \n \tpm_stay_awake(rtc->dev.parent);\n","prefixes":[]}