{"id":806126,"url":"http://patchwork.ozlabs.org/api/1.2/patches/806126/?format=json","web_url":"http://patchwork.ozlabs.org/project/netdev/patch/1503760140-9095-2-git-send-email-minipli@googlemail.com/","project":{"id":7,"url":"http://patchwork.ozlabs.org/api/1.2/projects/7/?format=json","name":"Linux network development","link_name":"netdev","list_id":"netdev.vger.kernel.org","list_email":"netdev@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<1503760140-9095-2-git-send-email-minipli@googlemail.com>","list_archive_url":null,"date":"2017-08-26T15:08:57","name":"[net,1/4] xfrm_user: fix info leak in copy_user_offload()","commit_ref":null,"pull_url":null,"state":"awaiting-upstream","archived":true,"hash":"8728d1e3acc53fd07fdb74798add4438341b11e0","submitter":{"id":6743,"url":"http://patchwork.ozlabs.org/api/1.2/people/6743/?format=json","name":"Mathias Krause","email":"minipli@googlemail.com"},"delegate":{"id":34,"url":"http://patchwork.ozlabs.org/api/1.2/users/34/?format=json","username":"davem","first_name":"David","last_name":"Miller","email":"davem@davemloft.net"},"mbox":"http://patchwork.ozlabs.org/project/netdev/patch/1503760140-9095-2-git-send-email-minipli@googlemail.com/mbox/","series":[],"comments":"http://patchwork.ozlabs.org/api/patches/806126/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/806126/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"patchwork-incoming@ozlabs.org","Delivered-To":"patchwork-incoming@ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netdev-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=googlemail.com header.i=@googlemail.com\n\theader.b=\"b3ZMYCyk\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xfhJy23Pwz9t5X\n\tfor ;\n\tSun, 27 Aug 2017 01:09:38 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1751130AbdHZPJa (ORCPT );\n\tSat, 26 Aug 2017 11:09:30 -0400","from mail-wm0-f68.google.com ([74.125.82.68]:38803 \"EHLO\n\tmail-wm0-f68.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1751063AbdHZPJ2 (ORCPT\n\t); Sat, 26 Aug 2017 11:09:28 -0400","by mail-wm0-f68.google.com with SMTP id z132so2558393wmg.5\n\tfor ; Sat, 26 Aug 2017 08:09:27 -0700 (PDT)","from jig.fritz.box (ip-90-186-2-57.web.vodafone.de. [90.186.2.57])\n\tby smtp.gmail.com with ESMTPSA id\n\tj15sm7126308wmg.14.2017.08.26.08.09.25\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tSat, 26 Aug 2017 08:09:26 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=googlemail.com; s=20161025;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=dpWRYUkHkZ2rJkH0GXOfq7zX10y0yxCO6qStUYpW/1A=;\n\tb=b3ZMYCykKoUH/bVpLxGSnqo/tAjvNepZfvK47zq3dDC4t8aNksTrlZ4kHU0HKhseK5\n\t+PcdWYjqIq/J9NF0ZfXVG5dFAxu95goVVa1gkCxmrv9H/sU7AoI1Hon/fWSWQNFkOThr\n\tw/Q2gFROXVxfP/UvPn3dMcRxR4m3FbLWTy7cNH5cYR7LIqcZxripLlkZmYr4ZmuRBoRw\n\tCpMQMPewBqUrMm/fpd2UchKuyit84XS5oclt7gS8w6OsA2kevP5JMSC2eQXu+oAtn5lX\n\twOyLAWKRaV7xOlL17mhs7rYEeBSBNUSEUR6P9S1r+3+67UI6SYiDwKPBIy17XB1liGzx\n\tLWbQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=dpWRYUkHkZ2rJkH0GXOfq7zX10y0yxCO6qStUYpW/1A=;\n\tb=Mz6nanLI6iYELgGOvSgcscnS8nboFVlBD28lNxY9UpFZYvqeY909Zbv+oRS2By1rKs\n\tJOcReTmtIDY1itGbEV/Qr77dR/O2Um+WnIJIW6I+xnmAkq3n17yemPqgxf1gr3+/62Rz\n\tzHhDELZqu4JHOaFGTnHuHC/3rFPDd5JP/HH2KF4QNnpsVjfldTQiD6QVdf3gnLhV9GFT\n\twzLVRuVKYboewnF9jT5qH2Mrgl2ibF1/xWzIfwODU/9Vh8LJ0Hy8vlSbEJHyJuhM4K4O\n\teL8URcppzNX6beeSSHQgmvN8vJz8wtbPm2BAeU4zFQIXqyNAEs4q648yOIyIySIf2EvQ\n\tj/bw==","X-Gm-Message-State":"AHYfb5j+llFBA0YPBgd7GQptgql31FNDz5+3VN2u9WQUFKRFYHh0iC4/\n\txyY6tO85mGPRhg==","X-Received":"by 10.28.24.83 with SMTP id 80mr864048wmy.86.1503760166951;\n\tSat, 26 Aug 2017 08:09:26 -0700 (PDT)","From":"Mathias Krause ","To":"Steffen Klassert ,\n\t\"David S. Miller\" ,\n\tHerbert Xu ","Cc":"netdev@vger.kernel.org, Mathias Krause ","Subject":"[PATCH net 1/4] xfrm_user: fix info leak in copy_user_offload()","Date":"Sat, 26 Aug 2017 17:08:57 +0200","Message-Id":"<1503760140-9095-2-git-send-email-minipli@googlemail.com>","X-Mailer":"git-send-email 1.7.10.4","In-Reply-To":"<1503760140-9095-1-git-send-email-minipli@googlemail.com>","References":"<1503760140-9095-1-git-send-email-minipli@googlemail.com>","Sender":"netdev-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netdev@vger.kernel.org"},"content":"The memory reserved to dump the xfrm offload state includes padding\nbytes of struct xfrm_user_offload added by the compiler for alignment.\nAdd an explicit memset(0) before filling the buffer to avoid the heap\ninfo leak.\n\nCc: Steffen Klassert \nFixes: d77e38e612a0 (\"xfrm: Add an IPsec hardware offloading API\")\nSigned-off-by: Mathias Krause \n---\n net/xfrm/xfrm_user.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)","diff":"diff --git a/net/xfrm/xfrm_user.c b/net/xfrm/xfrm_user.c\nindex 2be4c6af008a..3259555ae7d7 100644\n--- a/net/xfrm/xfrm_user.c\n+++ b/net/xfrm/xfrm_user.c\n@@ -796,7 +796,7 @@ static int copy_user_offload(struct xfrm_state_offload *xso, struct sk_buff *skb\n \t\treturn -EMSGSIZE;\n \n \txuo = nla_data(attr);\n-\n+\tmemset(xuo, 0, sizeof(*xuo));\n \txuo->ifindex = xso->dev->ifindex;\n \txuo->flags = xso->flags;\n \n","prefixes":["net","1/4"]}