{"id":806120,"url":"http://patchwork.ozlabs.org/api/1.2/patches/806120/?format=json","web_url":"http://patchwork.ozlabs.org/project/lede/patch/20170826131420.2107-1-mr.zoltan.gyarmati@gmail.com/","project":{"id":54,"url":"http://patchwork.ozlabs.org/api/1.2/projects/54/?format=json","name":"LEDE development","link_name":"lede","list_id":"lede-dev.lists.infradead.org","list_email":"lede-dev@lists.infradead.org","web_url":"http://lede-project.org/","scm_url":"","webscm_url":"http://git.lede-project.org/","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20170826131420.2107-1-mr.zoltan.gyarmati@gmail.com>","list_archive_url":null,"date":"2017-08-26T13:14:20","name":"[LEDE-DEV] scripts/dowload.pl: use glob to expand target dir","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"423b07a141d65ce72b2f7382f7b226d3d7c929b4","submitter":{"id":18211,"url":"http://patchwork.ozlabs.org/api/1.2/people/18211/?format=json","name":"Zoltán Gyarmati","email":"mr.zoltan.gyarmati@gmail.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/lede/patch/20170826131420.2107-1-mr.zoltan.gyarmati@gmail.com/mbox/","series":[],"comments":"http://patchwork.ozlabs.org/api/patches/806120/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/806120/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org; spf=none (mailfrom)\n\tsmtp.mailfrom=lists.infradead.org (client-ip=65.50.211.133;\n\thelo=bombadil.infradead.org;\n\tenvelope-from=lede-dev-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=lists.infradead.org\n\theader.i=@lists.infradead.org header.b=\"DcunimOY\"; \n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"EE4kWVHM\"; dkim-atps=neutral"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n\t[65.50.211.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xfdn51bRpz9sRY\n\tfor ;\n\tSat, 26 Aug 2017 23:15:21 +1000 (AEST)","from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dlavd-000495-38; Sat, 26 Aug 2017 13:15:09 +0000","from mail-wr0-x243.google.com ([2a00:1450:400c:c0c::243])\n\tby bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dlavY-0002uZ-OV\n\tfor lede-dev@lists.infradead.org; Sat, 26 Aug 2017 13:15:07 +0000","by mail-wr0-x243.google.com with SMTP id a47so1391419wra.2\n\tfor ;\n\tSat, 26 Aug 2017 06:14:43 -0700 (PDT)","from zgyarmati-w530.localdomain (x4e35e813.dyn.telefonica.de.\n\t[78.53.232.19]) by smtp.gmail.com with ESMTPSA id\n\tb96sm20033091wrd.94.2017.08.26.06.14.40\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tSat, 26 Aug 2017 06:14:41 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20170209; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe:\n\tList-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Subject:Message-Id:\n\tDate:To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:\n\tResent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:\n\tList-Owner; bh=ISVg68hOrek4erXEgcQ7nfNqlQiAo6oNwqfn/AmYhL0=;\n\tb=DcunimOYZ5pwbf\n\tQWUY2Et7bJUqZts5Rb9rgVO8w++KqK6eP2BrfRNlOI+ceEGe3jvEocH93lEBW/yC93/VqzxWB97OR\n\tfiZxsXwh4awwPdh6B2TgsISxPyboV3W//S7rC3/1Qe/6baY4hYsCR2lshJEhtGs9XdY33uuvnIHHq\n\txBfTs9BzLdi9/I2UY2O7OkcRfufpAVii6EFGyYpyNfPKf0Vco0Ukxx7FXhMoW275opKwEgwlRs5bJ\n\tkD9xUqOppCGmvXZZqbQPsaSx4LxZFHnvDi051zK4oRoFJornWuz8qAfyeQAI9YTlLw/psKs3A8ioz\n\tJFWcBjxEVS90WEKAHC6g==;","v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=from:to:cc:subject:date:message-id;\n\tbh=sSUzFCJv4/4gfe0tGRR7+zBogOE4ruYAo8hM5XJgGV0=;\n\tb=EE4kWVHMR4h6iQuYYrg5BnpvHTG3Aj9O2XqVQ1bDUcCWgQaQ93XyTQK8t1x7u4fEbp\n\tbon505rHQH7pRZOAz28PYKCmZ2+tXwJ6rlNpvYexNktHwO7vpSsV8QyHBH3G6v42Nc+t\n\tPeaNDErvc8rDSnsIz5TSLGJpzR94n87LIzfYn6DHgfE5eiHsVmPioTE83Ii8+7itxX9T\n\tpPaW08oQmHihGcqKbfGt0Q6tXxs6UBmt86rV9jk0xhVaLrgUXXHLeiOkqy3xerSnI1Y5\n\tihvhLMymK38E0oSNxvFUgfK9DBVoWbMH0bNco77UIItL59JW2TljtYvGGuX6VAvd+Zsu\n\teVvA=="],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id;\n\tbh=sSUzFCJv4/4gfe0tGRR7+zBogOE4ruYAo8hM5XJgGV0=;\n\tb=qg2ASHGj10rPeI/BThRjoC7EiPyOuogks5ub0bUvtrof7DbDrl9EymgaODSHtFuIDt\n\tzpTSfJM0u5WB8o+XcmZvx601+1zYL6UEH1wADSNH47eRBgwlocb0by71QcftG3ET8kZw\n\t539sSmGNaAKdyAoFYHvBgwUfSWLiNmfbsHIE2xI3+ItVmmW2+vhBuhHOa+uEMJAWYhz0\n\t6beu2Ta2AcxG5gmAdwQtkXw1cxVbNpDfEtofFUfYnUWfcowq3wP6uREefrR5t0QFWkcb\n\tDJK4IUF418S7LyIr6m+UXx2W5DCx3RIM5MnPun2rPaOjiq7Yh5pCJPt9yIUzpqbCWXFV\n\tbN2g==","X-Gm-Message-State":"AHYfb5g8pXgN9EgwOjUekotDbEzf/iQo1sn8d9l34pocGliBfFLia28s\n\tTo1veBCpT2HEObaBN4Y=","X-Received":"by 10.223.175.21 with SMTP id z21mr1320289wrc.145.1503753282319; \n\tSat, 26 Aug 2017 06:14:42 -0700 (PDT)","From":"Zoltan Gyarmati ","To":"lede-dev@lists.infradead.org","Date":"Sat, 26 Aug 2017 15:14:20 +0200","Message-Id":"<20170826131420.2107-1-mr.zoltan.gyarmati@gmail.com>","X-Mailer":"git-send-email 2.14.1","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20170826_061504_987265_EF13C3CB ","X-CRM114-Status":"UNSURE ( 8.09 )","X-CRM114-Notice":"Please train this message.","X-Spam-Score":"-2.0 (--)","X-Spam-Report":"SpamAssassin version 3.4.1 on bombadil.infradead.org summary:\n\tContent analysis details: (-2.0 points)\n\tpts rule name description\n\t---- ----------------------\n\t--------------------------------------------------\n\t-0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/,\n\tno\n\ttrust [2a00:1450:400c:c0c:0:0:0:243 listed in] [list.dnswl.org]\n\t-0.0 SPF_PASS SPF: sender matches SPF record\n\t0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail\n\tprovider (mr.zoltan.gyarmati[at]gmail.com)\n\t-1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%\n\t[score: 0.0000]\n\t-0.1 DKIM_VALID Message has at least one valid DKIM or DK signature\n\t0.1 DKIM_SIGNED Message has a DKIM or DK signature,\n\tnot necessarily valid\n\t-0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from\n\tauthor's domain","Subject":"[LEDE-DEV] [PATCH] scripts/dowload.pl: use glob to expand target dir","X-BeenThere":"lede-dev@lists.infradead.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Zoltan Gyarmati ","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"\"Lede-dev\" ","Errors-To":"lede-dev-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org"},"content":"If CONFIG_DOWNLOAD_FOLDER is set to for example \"~/dl\", the download\nscript fails to create the .hash and .dl files with the following\nerrors:\n Cannot create file ~/dl/dropbear-2017.75.tar.bz2.dl: No such file or directory\n sh: 1: cannot create ~/dl/dropbear-2017.75.tar.bz2.hash: Directory nonexistent\n\nIf the tarball already exists in the ~/dl dir, it's properly found and\nused, so this issue only affects the download.pl script.\n This patch calls glob() on the target dir parameter, which will expand `~`.\n---\n scripts/download.pl | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)","diff":"diff --git a/scripts/download.pl b/scripts/download.pl\nindex 645ac8546c..bf9fe8c761 100755\n--- a/scripts/download.pl\n+++ b/scripts/download.pl\n@@ -16,7 +16,7 @@ use Text::ParseWords;\n @ARGV > 2 or die \"Syntax: $0 [ ...]\\n\";\n \n my $url_filename;\n-my $target = shift @ARGV;\n+my $target = glob(shift @ARGV);\n my $filename = shift @ARGV;\n my $file_hash = shift @ARGV;\n $url_filename = shift @ARGV unless $ARGV[0] =~ /:\\/\\//;\n","prefixes":["LEDE-DEV"]}