{"id":805797,"url":"http://patchwork.ozlabs.org/api/1.2/patches/805797/?format=json","web_url":"http://patchwork.ozlabs.org/project/openvswitch/patch/1503647589-32847-1-git-send-email-wangzhike@jd.com/","project":{"id":47,"url":"http://patchwork.ozlabs.org/api/1.2/projects/47/?format=json","name":"Open vSwitch","link_name":"openvswitch","list_id":"ovs-dev.openvswitch.org","list_email":"ovs-dev@openvswitch.org","web_url":"http://openvswitch.org/","scm_url":"git@github.com:openvswitch/ovs.git","webscm_url":"https://github.com/openvswitch/ovs","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<1503647589-32847-1-git-send-email-wangzhike@jd.com>","list_archive_url":null,"date":"2017-08-25T07:53:09","name":"[ovs-dev,v2] netdev-dpdk: update vhost user client port status.","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"3115a93e6333bc7ae9d6ee2c1d2530976224bfa7","submitter":{"id":71845,"url":"http://patchwork.ozlabs.org/api/1.2/people/71845/?format=json","name":"Zhike Wang","email":"wangzhike@jd.com"},"delegate":{"id":67810,"url":"http://patchwork.ozlabs.org/api/1.2/users/67810/?format=json","username":"darball1","first_name":"Darrell","last_name":"Ball","email":"dlu998@gmail.com"},"mbox":"http://patchwork.ozlabs.org/project/openvswitch/patch/1503647589-32847-1-git-send-email-wangzhike@jd.com/mbox/","series":[],"comments":"http://patchwork.ozlabs.org/api/patches/805797/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/805797/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","dev@openvswitch.org"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","ovs-dev@mail.linuxfoundation.org"],"Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=openvswitch.org\n\t(client-ip=140.211.169.12; helo=mail.linuxfoundation.org;\n\tenvelope-from=ovs-dev-bounces@openvswitch.org;\n\treceiver=)","Received":["from mail.linuxfoundation.org (mail.linuxfoundation.org\n\t[140.211.169.12])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xdtjC4FCWz9sRm\n\tfor ;\n\tFri, 25 Aug 2017 17:54:22 +1000 (AEST)","from mail.linux-foundation.org (localhost [127.0.0.1])\n\tby mail.linuxfoundation.org (Postfix) with ESMTP id 39A2EAEF;\n\tFri, 25 Aug 2017 07:54:17 +0000 (UTC)","from smtp1.linuxfoundation.org (smtp1.linux-foundation.org\n\t[172.17.192.35])\n\tby mail.linuxfoundation.org (Postfix) with ESMTPS id E205B516\n\tfor ; Fri, 25 Aug 2017 07:54:14 +0000 (UTC)","from smtp.jd.com (smtp.jd.com [58.83.206.59])\n\tby smtp1.linuxfoundation.org (Postfix) with ESMTPS id 9400887\n\tfor ; Fri, 25 Aug 2017 07:53:47 +0000 (UTC)","from USHUB02.360buyAD.local (172.26.2.76) by HUB03.360buyAD.local\n\t(172.17.27.17) with Microsoft SMTP Server (TLS) id 14.3.123.3;\n\tFri, 25 Aug 2017 15:53:41 +0800","from localhost.localdomain (39.109.125.70) by\n\tUSHUB02.360buyAD.local\n\t(138.229.76.5) with Microsoft SMTP Server id 14.3.123.3;\n\tFri, 25 Aug 2017 15:53:17 +0800"],"X-Greylist":"from auto-whitelisted by SQLgrey-1.7.6","From":"wangzhike ","To":"","Date":"Fri, 25 Aug 2017 00:53:09 -0700","Message-ID":"<1503647589-32847-1-git-send-email-wangzhike@jd.com>","X-Mailer":"git-send-email 1.8.3.1","MIME-Version":"1.0","X-Originating-IP":"[39.109.125.70]","X-Spam-Status":"No, score=-1.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_NONE,\n\tRP_MATCHES_RCVD autolearn=unavailable version=3.3.1","X-Spam-Checker-Version":"SpamAssassin 3.3.1 (2010-03-16) on\n\tsmtp1.linux-foundation.org","Cc":"wangzhike ","Subject":"[ovs-dev] [PATCH v2] netdev-dpdk: update vhost user client port\n\tstatus.","X-BeenThere":"ovs-dev@openvswitch.org","X-Mailman-Version":"2.1.12","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"ovs-dev-bounces@openvswitch.org","Errors-To":"ovs-dev-bounces@openvswitch.org"},"content":"After ovs-vswitchd reboots, vhost user client port status is displayed as\nLINK DOWN though the traffic is OK.\n\nThe problem is that the port may be udpated while the vhost_reconfigured\nis false. Then the vhost_reconfigured is updated to true. As a result,\nthe vhost port status is kept as LINK-DOWN.\n\nSigned-off-by: wangzhike \n---\n lib/netdev-dpdk.c | 6 +++++-\n 1 file changed, 5 insertions(+), 1 deletion(-)","diff":"diff --git a/lib/netdev-dpdk.c b/lib/netdev-dpdk.c\nindex 1aaf6f7..80415ef 100644\n--- a/lib/netdev-dpdk.c\n+++ b/lib/netdev-dpdk.c\n@@ -3227,7 +3227,11 @@ dpdk_vhost_reconfigure_helper(struct netdev_dpdk *dev)\n }\n \n if (netdev_dpdk_get_vid(dev) >= 0) {\n- dev->vhost_reconfigured = true;\n+ if (dev->vhost_reconfigured == false) {\n+ dev->vhost_reconfigured = true;\n+ /* Carrier status may need updating. */\n+ netdev_change_seq_changed(&dev->up);\n+ }\n }\n \n return 0;\n","prefixes":["ovs-dev","v2"]}