{"id":805710,"url":"http://patchwork.ozlabs.org/api/1.2/patches/805710/?format=json","web_url":"http://patchwork.ozlabs.org/project/lede/patch/20170824235124.4834-2-rosenp@gmail.com/","project":{"id":54,"url":"http://patchwork.ozlabs.org/api/1.2/projects/54/?format=json","name":"LEDE development","link_name":"lede","list_id":"lede-dev.lists.infradead.org","list_email":"lede-dev@lists.infradead.org","web_url":"http://lede-project.org/","scm_url":"","webscm_url":"http://git.lede-project.org/","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20170824235124.4834-2-rosenp@gmail.com>","list_archive_url":null,"date":"2017-08-24T23:51:24","name":"[LEDE-DEV,2/2] samba36: Don't resolve interfaces.","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"b94b203e3e9d11ecebbbd923f38c3e6074a6005a","submitter":{"id":70304,"url":"http://patchwork.ozlabs.org/api/1.2/people/70304/?format=json","name":"Rosen Penev","email":"rosenp@gmail.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/lede/patch/20170824235124.4834-2-rosenp@gmail.com/mbox/","series":[],"comments":"http://patchwork.ozlabs.org/api/patches/805710/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/805710/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org; spf=none (mailfrom)\n\tsmtp.mailfrom=lists.infradead.org (client-ip=65.50.211.133;\n\thelo=bombadil.infradead.org;\n\tenvelope-from=lede-dev-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=lists.infradead.org\n\theader.i=@lists.infradead.org header.b=\"M18IZ0Lx\"; \n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"YpgGgx3n\"; dkim-atps=neutral"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n\t[65.50.211.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xdh0y6Tx1z9t3f\n\tfor ;\n\tFri, 25 Aug 2017 09:52:18 +1000 (AEST)","from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dl1ux-0006Hu-Bo; Thu, 24 Aug 2017 23:52:07 +0000","from mail-pg0-x244.google.com ([2607:f8b0:400e:c05::244])\n\tby bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dl1up-00067j-Km\n\tfor lede-dev@lists.infradead.org; Thu, 24 Aug 2017 23:52:05 +0000","by mail-pg0-x244.google.com with SMTP id 83so1345061pgb.3\n\tfor ;\n\tThu, 24 Aug 2017 16:51:39 -0700 (PDT)","from mangix.lan (astound-69-42-27-48.ca.astound.net. [69.42.27.48])\n\tby smtp.gmail.com with ESMTPSA id\n\tu123sm2317659pfb.9.2017.08.24.16.51.38\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tThu, 24 Aug 2017 16:51:38 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20170209; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe:\n\tList-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Subject:References:\n\tIn-Reply-To:Message-Id:Date:To:From:Reply-To:Content-ID:Content-Description:\n\tResent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:\n\tList-Owner; bh=sm/i3TPD/5mbxnQXgDQctTSE2+3Z6ol4BulIq1gKrIQ=;\n\tb=M18IZ0LxT67tSw\n\tS4TjQcetr+VL0A49VlSgIA4+VAsMvse7KDwzyoSnyPlZnsapL4sl7PAln+tqaKG76w1mz7F0t8Mtj\n\taSRfMTOr/2jeSqZ1/A8ctlhxqVfQ3fLZqpLMCX492lDSOfs8q36x1JV9CtTOIK8jaJg6hDd/AtCQu\n\t5dW/rkn1BnINgbP9HMbFlmFnx0Wikv1qCZCjLAO+M7+gdqrfTPgiXSHvAf66HXjf/mOPJuTIf6rcy\n\tUpORFhlLcw6DrY6qRXVrMIalsSjqPk3MpY94yaH9bTU641gcbCRISxlfeUbIBXpVpM2Cb0bZz4qpC\n\tqdR6/wZQyQ8vJYD0nS5A==;","v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=Ber2TJADtTvPCTYGbvaVYEUml8ikiIaMhf+6we0e/kA=;\n\tb=YpgGgx3nGye9G2xYOeyWazG1zpRYCPeeTmeiXZ6LmNxgqQxvK6Z8ydkD7MJJ6p9lSO\n\trLP2p5M//XiqaVtk9Jr7Zmu9MuisBxZ1jvLFseu7iIbW4sNeQl40YaGhNUJ63UAHaT5R\n\txWGvy+61hb0P4I5QeSv4g24+SK0HGMNG6cNkGVNL0Qqd/gDAuyE+fX955xl+UUHpWDAn\n\tzV/3UuPvhIBNTCuLPuspx1rxH9/6/JGt6VsCRZM3Aca0PNyaev5NJJ7F5IVRc+lhdUrB\n\tsBhfVecC8jrLEs/8VLMl5sKGxtwTs2ShHJikIHtG1FL+8YUFTswI5AQfEm2o8rth30C/\n\tCBGQ=="],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=Ber2TJADtTvPCTYGbvaVYEUml8ikiIaMhf+6we0e/kA=;\n\tb=m5WRlWHov3Em+JCFVI26bmTR9C5gNRwdJoAk3BN2BRuXnDqt82Ry7f80Ub4jYCZX8w\n\tmcJYU/fmYCnucwuTIXOdC+WxVE+9oN/UNIp+FKijtk9DWV2fcMjjOufKLKbxKC5DdpB3\n\tFwzAH/1ZLZ10G2N8/oTWbW+SMwLhikcxZuhR8KqW3OcyEkx/MrqQjQwcdlbg7eFcomnH\n\tBLacGbJykwvolTCGU81NZ15OnIzooNMJse+HmxTF+cFlXwL680D0pT/Cs12t36X+haf6\n\tMSAa5xoc+e0oJdqBL1he7mS1+cwU+aWoPF6SB5NJ8SVgv36uMWdFZhI5POI/bXzr4pgJ\n\tJgoA==","X-Gm-Message-State":"AHYfb5hrdWXMvhEF5IastpGTVEQIh/ZRuhYDek6x6TYiXBK5O0fRcNHI\n\tLsrHC5jwz3IJ5M7aPKw=","X-Received":"by 10.84.128.162 with SMTP id a31mr6071342pla.136.1503618698973; \n\tThu, 24 Aug 2017 16:51:38 -0700 (PDT)","From":"Rosen Penev ","To":"lede-dev@lists.infradead.org","Date":"Thu, 24 Aug 2017 16:51:24 -0700","Message-Id":"<20170824235124.4834-2-rosenp@gmail.com>","X-Mailer":"git-send-email 2.13.5","In-Reply-To":"<20170824235124.4834-1-rosenp@gmail.com>","References":"<20170824235124.4834-1-rosenp@gmail.com>","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20170824_165200_475142_4E71EFE8 ","X-CRM114-Status":"UNSURE ( 6.56 )","X-CRM114-Notice":"Please train this message.","X-Spam-Score":"-2.0 (--)","X-Spam-Report":"SpamAssassin version 3.4.1 on bombadil.infradead.org summary:\n\tContent analysis details: (-2.0 points)\n\tpts rule name description\n\t---- ----------------------\n\t--------------------------------------------------\n\t-0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/,\n\tno\n\ttrust [2607:f8b0:400e:c05:0:0:0:244 listed in] [list.dnswl.org]\n\t-0.0 SPF_PASS SPF: sender matches SPF record\n\t0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail\n\tprovider (rosenp[at]gmail.com)\n\t-1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%\n\t[score: 0.0000]\n\t-0.1 DKIM_VALID Message has at least one valid DKIM or DK signature\n\t0.1 DKIM_SIGNED Message has a DKIM or DK signature,\n\tnot necessarily valid\n\t-0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from\n\tauthor's domain","Subject":"[LEDE-DEV] [PATCH 2/2] samba36: Don't resolve interfaces.","X-BeenThere":"lede-dev@lists.infradead.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Rosen Penev ","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"\"Lede-dev\" ","Errors-To":"lede-dev-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org"},"content":"It's redundant and also buggy. IPv6 link local addresses and ::1 are not resolved for example. Doesn't matter since lo and br-lan for example, resolve to them.\n\nSigned-off-by: Rosen Penev \n---\n package/network/services/samba36/Makefile | 2 +-\n package/network/services/samba36/files/samba.init | 7 +------\n 2 files changed, 2 insertions(+), 7 deletions(-)","diff":"diff --git a/package/network/services/samba36/Makefile b/package/network/services/samba36/Makefile\nindex 0762dd9307..81bad871aa 100644\n--- a/package/network/services/samba36/Makefile\n+++ b/package/network/services/samba36/Makefile\n@@ -9,7 +9,7 @@ include $(TOPDIR)/rules.mk\n \n PKG_NAME:=samba\n PKG_VERSION:=3.6.25\n-PKG_RELEASE:=7\n+PKG_RELEASE:=8\n \n PKG_SOURCE_URL:=https://download.samba.org/pub/samba \\\n \t\thttps://download.samba.org/pub/samba/stable\ndiff --git a/package/network/services/samba36/files/samba.init b/package/network/services/samba36/files/samba.init\nindex c8413243ba..28b0064df9 100755\n--- a/package/network/services/samba36/files/samba.init\n+++ b/package/network/services/samba36/files/samba.init\n@@ -15,12 +15,7 @@ smb_header() {\n \t\tfor net in $samba_iface; do\n \t\t\tlocal device\n \t\t\tnetwork_is_up $net || continue\n-\t\t\tnetwork_get_device device \"$net\" && {\n-\t\t\t\tlocal subnet\n-\t\t\t\tnetwork_get_subnet subnet \"$net\" && echo -n \"$subnet \"\n-\t\t\t\tnetwork_get_subnet6 subnet \"$net\" && echo -n \"$subnet \"\n-\t\t\t}\n-\n+\t\t\tnetwork_get_device device \"$net\"\n \t\t\techo -n \"${device:-$net} \"\n \t\tdone\n \t)\n","prefixes":["LEDE-DEV","2/2"]}