{"id":805709,"url":"http://patchwork.ozlabs.org/api/1.2/patches/805709/?format=json","web_url":"http://patchwork.ozlabs.org/project/lede/patch/20170824235124.4834-1-rosenp@gmail.com/","project":{"id":54,"url":"http://patchwork.ozlabs.org/api/1.2/projects/54/?format=json","name":"LEDE development","link_name":"lede","list_id":"lede-dev.lists.infradead.org","list_email":"lede-dev@lists.infradead.org","web_url":"http://lede-project.org/","scm_url":"","webscm_url":"http://git.lede-project.org/","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20170824235124.4834-1-rosenp@gmail.com>","list_archive_url":null,"date":"2017-08-24T23:51:23","name":"[LEDE-DEV,1/2] samba36: Remove guest ok since LuCI configures it.","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"e8d0361cf79b10697d4559fe6ddd67b775600cdc","submitter":{"id":70304,"url":"http://patchwork.ozlabs.org/api/1.2/people/70304/?format=json","name":"Rosen Penev","email":"rosenp@gmail.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/lede/patch/20170824235124.4834-1-rosenp@gmail.com/mbox/","series":[],"comments":"http://patchwork.ozlabs.org/api/patches/805709/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/805709/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org; spf=none (mailfrom)\n\tsmtp.mailfrom=lists.infradead.org (client-ip=65.50.211.133;\n\thelo=bombadil.infradead.org;\n\tenvelope-from=lede-dev-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=lists.infradead.org\n\theader.i=@lists.infradead.org header.b=\"R2Qg8/al\"; \n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"GATNlHDv\"; dkim-atps=neutral"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n\t[65.50.211.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xdh0w5Tlhz9t3f\n\tfor ;\n\tFri, 25 Aug 2017 09:52:16 +1000 (AEST)","from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dl1um-00068q-16; Thu, 24 Aug 2017 23:51:56 +0000","from mail-pg0-x242.google.com ([2607:f8b0:400e:c05::242])\n\tby bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dl1uj-00067i-Sm\n\tfor lede-dev@lists.infradead.org; Thu, 24 Aug 2017 23:51:55 +0000","by mail-pg0-x242.google.com with SMTP id r133so1355017pgr.2\n\tfor ;\n\tThu, 24 Aug 2017 16:51:33 -0700 (PDT)","from mangix.lan (astound-69-42-27-48.ca.astound.net. [69.42.27.48])\n\tby smtp.gmail.com with ESMTPSA id\n\tu123sm2317659pfb.9.2017.08.24.16.51.31\n\t(version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);\n\tThu, 24 Aug 2017 16:51:32 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20170209; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe:\n\tList-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Subject:Message-Id:\n\tDate:To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:\n\tResent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:\n\tList-Owner; bh=pS4WsmwagRdBWu+1kewJCdwcRC7WoytCoWZbkshDh2I=;\n\tb=R2Qg8/alkrpOJn\n\t3shwOmJxb9R3R7R6N/Bnk/LNGXoaBBXmVlHNGGA548hqSskNQpUDOLduNxFLXdmUeUgQ5G+m4u9CC\n\t1aAB9cwsor/X/a/gedzk5HhvsD+B3rSB8LFwUilVAIrQ2utWG+O+WuadE31/oWNk9/dwAb03OazwW\n\tjS0UZVwjTbB8TPeCgLcBA6E0ePryMaEFCCOU+UloESZ2QhZ5kyxFbu8pAZ+zIvvsKk1IIWE8DJ3BM\n\tydKDoMk7z5zyy6d9X9k8JnhJWUCzxQLjYH+blSstDVpNPUlq8T53RzL6vkNyQkxrLBj4gIXStbqkm\n\t709Rc4CDk/7zx7YbT/rA==;","v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=from:to:cc:subject:date:message-id;\n\tbh=31H3jgJhlU57UvkJGAI19eG+mzzXVuqLxf3KYRivi+U=;\n\tb=GATNlHDvOdsmbZAxnZngXMz2xHZ+vobF1p90KSb4DCQ2EjfQ2ZUB1QnnUxgANKff90\n\tpy93OfSIh7227Np/DNEmkj/+WAeLSSS8NcZRFr0TqUlVQhKM0Qm3mHUDhwPuOwefhw7e\n\t0Fx3FME6NlWOv2o6L+MikX8wupVeY8R0zJiaeAYh8CxFAEvrYPgXqosExDvEywPknOd1\n\t3j3oAlfaWDPy9DIJhtyZOB2hsP66dM7n1VXmMyod4UpIa/NpDdBYp25ovJYbSq31WGtF\n\tVif+RA27385vAEyOClOvLxzayrlrdEGO6EssanVXRa9F7lFN1QNj9gmSo4w1nDutLwMV\n\tsR5Q=="],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id;\n\tbh=31H3jgJhlU57UvkJGAI19eG+mzzXVuqLxf3KYRivi+U=;\n\tb=NGlO14kD2iHYgT/U3GEHRQtfXIGvd15hy4XQFTog0B3OJG8rSMJYn7kGQWuIQcrTAE\n\tkby+9pLRbpCdLsdI1WagYgHcKU+yk8/YSxGscfXTniyGYskYYE1XPGHjBKRt6mRPLDCT\n\t81XhoYwBWdDke0EO4rkBiup6HFKeiugl/R1Jay4Dn8L97VvHJMhElhfwNm16DbIEaaN+\n\tVJh8QyFTwsbiah3VYJfudBzlQ9wIZV8JHTI8yaumCs6YU1p1irQbLPf1mIXWEyhu7HNk\n\ts3d+t+GLjXyT9Q6K0iOAgyyz2taEUeItLGmhA3QKe6puzqSGrsJHdrFrVrJg00qCfx1H\n\t8hzA==","X-Gm-Message-State":"AHYfb5h4ZcoYp0xJIULYzULioJz2rK5E5d2rUiM9I6W3ZE6JtcZZrH9Y\n\tZUI8L/tz1XcokpmKy2g=","X-Received":"by 10.84.232.199 with SMTP id x7mr8623861plm.408.1503618692983; \n\tThu, 24 Aug 2017 16:51:32 -0700 (PDT)","From":"Rosen Penev ","To":"lede-dev@lists.infradead.org","Date":"Thu, 24 Aug 2017 16:51:23 -0700","Message-Id":"<20170824235124.4834-1-rosenp@gmail.com>","X-Mailer":"git-send-email 2.13.5","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20170824_165153_982113_B155D394 ","X-CRM114-Status":"UNSURE ( 6.82 )","X-CRM114-Notice":"Please train this message.","X-Spam-Score":"-2.0 (--)","X-Spam-Report":"SpamAssassin version 3.4.1 on bombadil.infradead.org summary:\n\tContent analysis details: (-2.0 points)\n\tpts rule name description\n\t---- ----------------------\n\t--------------------------------------------------\n\t-0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at http://www.dnswl.org/,\n\tno\n\ttrust [2607:f8b0:400e:c05:0:0:0:242 listed in] [list.dnswl.org]\n\t-0.0 SPF_PASS SPF: sender matches SPF record\n\t0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail\n\tprovider (rosenp[at]gmail.com)\n\t-1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%\n\t[score: 0.0000]\n\t-0.1 DKIM_VALID Message has at least one valid DKIM or DK signature\n\t0.1 DKIM_SIGNED Message has a DKIM or DK signature,\n\tnot necessarily valid\n\t-0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from\n\tauthor's domain","Subject":"[LEDE-DEV] [PATCH 1/2] samba36: Remove guest ok since LuCI\n\tconfigures it.","X-BeenThere":"lede-dev@lists.infradead.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Rosen Penev ","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"\"Lede-dev\" ","Errors-To":"lede-dev-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org"},"content":"guest ok is set per share and as such, don't override it. also, fix an error introduced in the last commit.\n\nSigned-off-by: Rosen Penev \n---\n package/network/services/samba36/files/smb.conf.template | 3 +--\n 1 file changed, 1 insertion(+), 2 deletions(-)","diff":"diff --git a/package/network/services/samba36/files/smb.conf.template b/package/network/services/samba36/files/smb.conf.template\nindex c35d7792bd..47ec11699d 100644\n--- a/package/network/services/samba36/files/smb.conf.template\n+++ b/package/network/services/samba36/files/smb.conf.template\n@@ -8,10 +8,9 @@\n \tbind interfaces only = yes\n \tdeadtime = 30\n \tenable core files = no\n-\tguest ok = yes\n \tinvalid users = root\n \tload printers = no\n-\tlocal master = yes\n+\tlocal master = no\n \tmap to guest = Bad User\n \tmax protocol = SMB2\n \tmin receivefile size = 16384\n","prefixes":["LEDE-DEV","1/2"]}