{"id":804039,"url":"http://patchwork.ozlabs.org/api/1.2/patches/804039/?format=json","web_url":"http://patchwork.ozlabs.org/project/netfilter-devel/patch/20170821141926.18670-1-fw@strlen.de/","project":{"id":26,"url":"http://patchwork.ozlabs.org/api/1.2/projects/26/?format=json","name":"Netfilter Development","link_name":"netfilter-devel","list_id":"netfilter-devel.vger.kernel.org","list_email":"netfilter-devel@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20170821141926.18670-1-fw@strlen.de>","list_archive_url":null,"date":"2017-08-21T14:19:26","name":"[nf-next] netfilter: fix a few (harmless) sparse warnings","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"4e05af83ff7bf46ceda274528ba839095fd101bc","submitter":{"id":1025,"url":"http://patchwork.ozlabs.org/api/1.2/people/1025/?format=json","name":"Florian Westphal","email":"fw@strlen.de"},"delegate":{"id":6139,"url":"http://patchwork.ozlabs.org/api/1.2/users/6139/?format=json","username":"pablo","first_name":"Pablo","last_name":"Neira","email":"pablo@netfilter.org"},"mbox":"http://patchwork.ozlabs.org/project/netfilter-devel/patch/20170821141926.18670-1-fw@strlen.de/mbox/","series":[],"comments":"http://patchwork.ozlabs.org/api/patches/804039/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/804039/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=netfilter-devel-owner@vger.kernel.org;\n\treceiver=)","Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xbbR21QYCz9s76\n\tfor ;\n\tTue, 22 Aug 2017 00:19:10 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1753502AbdHUOTJ (ORCPT );\n\tMon, 21 Aug 2017 10:19:09 -0400","from Chamillionaire.breakpoint.cc ([146.0.238.67]:45080 \"EHLO\n\tChamillionaire.breakpoint.cc\" rhost-flags-OK-OK-OK-OK)\n\tby vger.kernel.org with ESMTP id S1753222AbdHUOTI (ORCPT\n\t);\n\tMon, 21 Aug 2017 10:19:08 -0400","from fw by Chamillionaire.breakpoint.cc with local (Exim 4.84_2)\n\t(envelope-from )\n\tid 1djnVO-0006Jo-PA; Mon, 21 Aug 2017 16:16:38 +0200"],"From":"Florian Westphal ","To":"","Cc":"Florian Westphal ","Subject":"[PATCH nf-next] netfilter: fix a few (harmless) sparse warnings","Date":"Mon, 21 Aug 2017 16:19:26 +0200","Message-Id":"<20170821141926.18670-1-fw@strlen.de>","X-Mailer":"git-send-email 2.13.0","Sender":"netfilter-devel-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"netfilter-devel@vger.kernel.org"},"content":"net/netfilter/nft_payload.c:187:18: warning: incorrect type in return expression (expected bool got restricted __sum16 [usertype] check)\nnet/netfilter/nft_exthdr.c:222:14: warning: cast to restricted __be32\nnet/netfilter/nft_rt.c:49:23: warning: incorrect type in assignment (different base types expected unsigned int got restricted __be32)\nnet/netfilter/nft_rt.c:70:25: warning: symbol 'nft_rt_policy' was not declared. Should it be static?\n\nSigned-off-by: Florian Westphal \n---\n net/netfilter/nft_exthdr.c | 2 +-\n net/netfilter/nft_payload.c | 2 +-\n net/netfilter/nft_rt.c | 6 +++---\n 3 files changed, 5 insertions(+), 5 deletions(-)","diff":"diff --git a/net/netfilter/nft_exthdr.c b/net/netfilter/nft_exthdr.c\nindex f5a0bf5e3bdd..a0a93d987a3b 100644\n--- a/net/netfilter/nft_exthdr.c\n+++ b/net/netfilter/nft_exthdr.c\n@@ -388,7 +388,7 @@ nft_exthdr_select_ops(const struct nft_ctx *ctx,\n \tif (tb[NFTA_EXTHDR_SREG] && tb[NFTA_EXTHDR_DREG])\n \t\treturn ERR_PTR(-EOPNOTSUPP);\n \n-\top = ntohl(nla_get_u32(tb[NFTA_EXTHDR_OP]));\n+\top = ntohl(nla_get_be32(tb[NFTA_EXTHDR_OP]));\n \tswitch (op) {\n \tcase NFT_EXTHDR_OP_TCPOPT:\n \t\tif (tb[NFTA_EXTHDR_SREG])\ndiff --git a/net/netfilter/nft_payload.c b/net/netfilter/nft_payload.c\nindex 7d699bbd45b0..e110b0ebbf58 100644\n--- a/net/netfilter/nft_payload.c\n+++ b/net/netfilter/nft_payload.c\n@@ -184,7 +184,7 @@ static bool nft_payload_udp_checksum(struct sk_buff *skb, unsigned int thoff)\n \tif (!uh)\n \t\treturn false;\n \n-\treturn uh->check;\n+\treturn (__force bool)uh->check;\n }\n \n static int nft_payload_l4csum_offset(const struct nft_pktinfo *pkt,\ndiff --git a/net/netfilter/nft_rt.c b/net/netfilter/nft_rt.c\nindex e142e65d3176..61fd3acaa3c9 100644\n--- a/net/netfilter/nft_rt.c\n+++ b/net/netfilter/nft_rt.c\n@@ -82,8 +82,8 @@ static void nft_rt_get_eval(const struct nft_expr *expr,\n \t\tif (nft_pf(pkt) != NFPROTO_IPV4)\n \t\t\tgoto err;\n \n-\t\t*dest = rt_nexthop((const struct rtable *)dst,\n-\t\t\t\t ip_hdr(skb)->daddr);\n+\t\t*dest = (__force u32)rt_nexthop((const struct rtable *)dst,\n+\t\t\t\t\t\tip_hdr(skb)->daddr);\n \t\tbreak;\n \tcase NFT_RT_NEXTHOP6:\n \t\tif (nft_pf(pkt) != NFPROTO_IPV6)\n@@ -106,7 +106,7 @@ static void nft_rt_get_eval(const struct nft_expr *expr,\n \tregs->verdict.code = NFT_BREAK;\n }\n \n-const struct nla_policy nft_rt_policy[NFTA_RT_MAX + 1] = {\n+static const struct nla_policy nft_rt_policy[NFTA_RT_MAX + 1] = {\n \t[NFTA_RT_DREG]\t\t= { .type = NLA_U32 },\n \t[NFTA_RT_KEY]\t\t= { .type = NLA_U32 },\n };\n","prefixes":["nf-next"]}