{"id":803832,"url":"http://patchwork.ozlabs.org/api/1.2/patches/803832/?format=json","web_url":"http://patchwork.ozlabs.org/project/uboot/patch/1503283202-11909-2-git-send-email-trini@konsulko.com/","project":{"id":18,"url":"http://patchwork.ozlabs.org/api/1.2/projects/18/?format=json","name":"U-Boot","link_name":"uboot","list_id":"u-boot.lists.denx.de","list_email":"u-boot@lists.denx.de","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<1503283202-11909-2-git-send-email-trini@konsulko.com>","list_archive_url":null,"date":"2017-08-21T02:40:02","name":"[U-Boot,2/2] net: nfs: Correct type of rpc_t->u.reply->data","commit_ref":null,"pull_url":null,"state":"rejected","archived":false,"hash":"aece6352d27284bc31de2deecdbabdb78484f549","submitter":{"id":65875,"url":"http://patchwork.ozlabs.org/api/1.2/people/65875/?format=json","name":"Tom Rini","email":"trini@konsulko.com"},"delegate":{"id":6337,"url":"http://patchwork.ozlabs.org/api/1.2/users/6337/?format=json","username":"jhersh","first_name":"Joe","last_name":"Hershberger","email":"joe.hershberger@gmail.com"},"mbox":"http://patchwork.ozlabs.org/project/uboot/patch/1503283202-11909-2-git-send-email-trini@konsulko.com/mbox/","series":[],"comments":"http://patchwork.ozlabs.org/api/patches/803832/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/803832/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":"ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=lists.denx.de\n\t(client-ip=81.169.180.215; helo=lists.denx.de;\n\tenvelope-from=u-boot-bounces@lists.denx.de;\n\treceiver=)","Received":["from lists.denx.de (dione.denx.de [81.169.180.215])\n\tby ozlabs.org (Postfix) with ESMTP id 3xbHx85hrJz9s7v\n\tfor ;\n\tMon, 21 Aug 2017 12:40:44 +1000 (AEST)","by lists.denx.de (Postfix, from userid 105)\n\tid 91A99C220CD; Mon, 21 Aug 2017 02:40:18 +0000 (UTC)","from lists.denx.de (localhost [IPv6:::1])\n\tby lists.denx.de (Postfix) with ESMTP id 50841C21FD6;\n\tMon, 21 Aug 2017 02:40:01 +0000 (UTC)","by lists.denx.de (Postfix, from userid 105)\n\tid 5DC05C21C27; Mon, 21 Aug 2017 02:39:59 +0000 (UTC)","from mail-yw0-f196.google.com (mail-yw0-f196.google.com\n\t[209.85.161.196])\n\tby lists.denx.de (Postfix) with ESMTPS id CC5C5C21C4F\n\tfor ; Mon, 21 Aug 2017 02:39:58 +0000 (UTC)","by mail-yw0-f196.google.com with SMTP id y64so1098734ywf.1\n\tfor ; Sun, 20 Aug 2017 19:39:58 -0700 (PDT)","from localhost.localdomain (cpe-174-106-0-58.ec.res.rr.com.\n\t[174.106.0.58]) by smtp.gmail.com with ESMTPSA id\n\tb79sm4247699ywh.65.2017.08.20.19.39.56\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128);\n\tSun, 20 Aug 2017 19:39:57 -0700 (PDT)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-0.0 required=5.0 tests=RCVD_IN_DNSWL_NONE,\n\tRCVD_IN_MSPIKE_H3,\n\tRCVD_IN_MSPIKE_WL autolearn=unavailable autolearn_force=no\n\tversion=3.4.0","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=oh/YEoxHJf66v/rHkc0Do2Ozb3QgtxvZUmd96J8LKfQ=;\n\tb=l0mk2gACnwx+IKkgLBmNzVtIFq5g81bMRgIHTOZ1cRN76YPqd2vHIuxr3QQj2BDUpq\n\ty697ZgZP7leuaCBDAnUFn2Zzq70AksvCCwSXre9j3hLrF1Ioj+ZcD1rYNxgMJLUSvdBv\n\tAq8X2iMNngBU6xLK1+pe0APze2KKO/ZlCJx43sZUEtVUvfw3IqHLtGzYCwNoXo7aFtdQ\n\tTzdjpaIpFyaSrKN9yaqXu86eqqX8Jb89vzd2ThAhE0fJNmRPJAlatrF50qd6iogm3yX5\n\t5iCq/kEm7gzjXPgq7M5PsjAq6McHr7Kqlc+jqf5vl04XUVhfd+ceCG/kxsW1EceIF+1M\n\tr1NA==","X-Gm-Message-State":"AHYfb5j6SHj/X9MRa0GT+pfX8Nkzz0OwhBYYbrkLCbG2xMqdebXloxPP\n\twOD34uTzRlF8+RxG","X-Received":"by 10.129.94.196 with SMTP id s187mr3697605ywb.457.1503283197583;\n\tSun, 20 Aug 2017 19:39:57 -0700 (PDT)","From":"Tom Rini ","To":"u-boot@lists.denx.de","Date":"Sun, 20 Aug 2017 22:40:02 -0400","Message-Id":"<1503283202-11909-2-git-send-email-trini@konsulko.com>","X-Mailer":"git-send-email 1.9.1","In-Reply-To":"<1503283202-11909-1-git-send-email-trini@konsulko.com>","References":"<1503283202-11909-1-git-send-email-trini@konsulko.com>","Cc":"Joe Hershberger ","Subject":"[U-Boot] [PATCH 2/2] net: nfs: Correct type of rpc_t->u.reply->data","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.18","Precedence":"list","List-Id":"U-Boot discussion ","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" "},"content":"In rpc_t we declare data to be a uint8_t of size 2048, for a final size\nof 2048. We also however declare the reply part of the union to have a\nuint32_t data field of NFS_READ_SIZE (1024) for a final size of\n4096+24=4120 and an overrun. Expand the comment above the struct to\nnote that if NFS_READ_SIZE is increased then the data buf must also be\nincreased and correct the declaration to be uint8_t.\n\nReported-by: Coverity (CID: 152888)\nCc: Joe Hershberger \nSigned-off-by: Tom Rini \n---\n net/nfs.h | 7 ++++---\n 1 file changed, 4 insertions(+), 3 deletions(-)","diff":"diff --git a/net/nfs.h b/net/nfs.h\nindex 1aa06e8fb90f..b23b4088d825 100644\n--- a/net/nfs.h\n+++ b/net/nfs.h\n@@ -39,8 +39,9 @@\n /*\n * Block size used for NFS read accesses. A RPC reply packet (including all\n * headers) must fit within a single Ethernet frame to avoid fragmentation.\n- * However, if CONFIG_IP_DEFRAG is set, a bigger value could be used. In any\n- * case, most NFS servers are optimized for a power of 2.\n+ * However, if CONFIG_IP_DEFRAG is set, a bigger value could be used, so long\n+ * as rpc_t->u->data is incrased to match. In any case, most NFS servers are\n+ * optimized for a power of 2.\n */\n #define NFS_READ_SIZE\t1024\t/* biggest power of two that fits Ether frame */\n \n@@ -73,7 +74,7 @@ struct rpc_t {\n \t\t\tuint32_t verifier;\n \t\t\tuint32_t v2;\n \t\t\tuint32_t astatus;\n-\t\t\tuint32_t data[NFS_READ_SIZE];\n+\t\t\tuint8_t data[NFS_READ_SIZE];\n \t\t} reply;\n \t} u;\n } __attribute__((packed));\n","prefixes":["U-Boot","2/2"]}