{"id":803362,"url":"http://patchwork.ozlabs.org/api/1.2/patches/803362/?format=json","web_url":"http://patchwork.ozlabs.org/project/hostap/patch/1503078260-22306-1-git-send-email-michael-dev@fami-braun.de/","project":{"id":22,"url":"http://patchwork.ozlabs.org/api/1.2/projects/22/?format=json","name":"HostAP Development","link_name":"hostap","list_id":"hostap.lists.infradead.org","list_email":"hostap@lists.infradead.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<1503078260-22306-1-git-send-email-michael-dev@fami-braun.de>","list_archive_url":null,"date":"2017-08-18T17:44:20","name":"[1/1] macsec_linux: exit early when missing macsec kernel module","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"f5e696b12afd53fe534c39a88a6249deb563b3e6","submitter":{"id":3892,"url":"http://patchwork.ozlabs.org/api/1.2/people/3892/?format=json","name":"michael-dev","email":"michael-dev@fami-braun.de"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/hostap/patch/1503078260-22306-1-git-send-email-michael-dev@fami-braun.de/mbox/","series":[],"comments":"http://patchwork.ozlabs.org/api/patches/803362/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/803362/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org; spf=none (mailfrom)\n\tsmtp.mailfrom=lists.infradead.org (client-ip=65.50.211.133;\n\thelo=bombadil.infradead.org;\n\tenvelope-from=hostap-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=lists.infradead.org\n\theader.i=@lists.infradead.org header.b=\"feU/zTFQ\"; \n\tdkim-atps=neutral"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n\t[65.50.211.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xYrBX6jX7z9t42\n\tfor ;\n\tSat, 19 Aug 2017 03:47:16 +1000 (AEST)","from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dilMG-0008WF-JA; Fri, 18 Aug 2017 17:46:56 +0000","from mail.fem.tu-ilmenau.de ([141.24.220.54])\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dilLs-0008U0-Fg\n\tfor hostap@lists.infradead.org; Fri, 18 Aug 2017 17:46:34 +0000","from localhost (localhost [127.0.0.1])\n\tby mail.fem.tu-ilmenau.de (Postfix) with ESMTP id A401164AE;\n\tFri, 18 Aug 2017 19:46:11 +0200 (CEST)","from mail.fem.tu-ilmenau.de ([127.0.0.1])\n\tby localhost (mail.fem.tu-ilmenau.de [127.0.0.1]) (amavisd-new,\n\tport 10024)\n\twith ESMTP id T+vaBZsXV6ce; Fri, 18 Aug 2017 19:46:11 +0200 (CEST)","from a234.fem.tu-ilmenau.de (ray-controller.net.fem.tu-ilmenau.de\n\t[10.42.51.234]) by mail.fem.tu-ilmenau.de (Postfix) with ESMTP;\n\tFri, 18 Aug 2017 19:46:10 +0200 (CEST)","by a234.fem.tu-ilmenau.de (Postfix, from userid 1000)\n\tid 473E43085499; Fri, 18 Aug 2017 19:44:21 +0200 (CEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20170209; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe:\n\tList-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date:\n\tSubject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date:\n\tResent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:\n\tReferences:List-Owner; bh=UDEiqgvJPZqQv927APKUOHJlFne8So6ND/9d/PvJeX8=;\n\tb=feU\n\t/zTFQnGKJlQ6CTQzqLga4hs7psFdyAJpX8iv1IQ7KX7HMF99flHPbOM9YkeOgt3QJwFSk0t3zRisq\n\taUD8eIM/cKz5WAjy9UJBWx673wxM9LAA5oE0sJk9qEBRGy3rNoyoihrIDv6WalmMP6cKOYQDcywuk\n\tVOleJK5MoxkkfwnvoAPdRZuRZf4j+rgHLCrN4AyWELpgyZCdr4S0gXa76vdtCfEgRnNH3n/FdUqD0\n\tKJR6rFqyoGl4EHJ0vuhGIz2jhIdOK8Oz9LNWzVHNBpbJvzqo5vpUvVt4r8fGZ+dr9s6M4q9W+69Yo\n\tJOzd2D1rixQ4ZNLYGfTa09tGJonIXFQ==;","X-Virus-Scanned":"amavisd-new at fem.tu-ilmenau.de","From":"Michael Braun ","To":"hostap@lists.infradead.org","Subject":"[PATCH 1/1] macsec_linux: exit early when missing macsec kernel\n\tmodule","Date":"Fri, 18 Aug 2017 19:44:20 +0200","Message-Id":"<1503078260-22306-1-git-send-email-michael-dev@fami-braun.de>","X-Mailer":"git-send-email 2.1.4","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20170818_104632_687670_F249D49B ","X-CRM114-Status":"UNSURE ( 7.61 )","X-CRM114-Notice":"Please train this message.","X-Spam-Score":"-4.2 (----)","X-Spam-Report":"SpamAssassin version 3.4.1 on bombadil.infradead.org summary:\n\tContent analysis details: (-4.2 points)\n\tpts rule name description\n\t---- ----------------------\n\t--------------------------------------------------\n\t-2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at http://www.dnswl.org/,\n\tmedium trust [141.24.220.54 listed in list.dnswl.org]\n\t-1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%\n\t[score: 0.0000]","X-BeenThere":"hostap@lists.infradead.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"projekt-wlan@fem.tu-ilmenau.de, Michael Braun ","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"\"Hostap\" ","Errors-To":"hostap-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org"},"content":"Using driver macsec_linux makes no sense without macsec kernel module loaded.\n\nSigned-off-by: Michael Braun \n---\n src/drivers/driver_macsec_linux.c | 35 +++++++++++++++++++++++++++++++++++\n 1 file changed, 35 insertions(+)","diff":"diff --git a/src/drivers/driver_macsec_linux.c b/src/drivers/driver_macsec_linux.c\nindex 0694e60..df2197b 100644\n--- a/src/drivers/driver_macsec_linux.c\n+++ b/src/drivers/driver_macsec_linux.c\n@@ -234,10 +234,45 @@ static void macsec_drv_wpa_deinit(void *priv)\n }\n \n \n+static int macsec_check_macsec()\n+{\n+\tstruct nl_sock *sk;\n+\tint err = -1;\n+\n+\tsk = nl_socket_alloc();\n+\tif (!sk) {\n+\t\twpa_printf(MSG_ERROR, DRV_PREFIX \"failed to alloc genl socket\");\n+\t\treturn -1;\n+\t}\n+\n+\tif (genl_connect(sk) < 0) {\n+\t\twpa_printf(MSG_ERROR,\n+\t\t\t DRV_PREFIX \"connection to genl socket failed\");\n+\t\tgoto out_free;\n+\t}\n+\n+\tint macsec_genl_id = genl_ctrl_resolve(sk, \"macsec\");\n+\tif (macsec_genl_id < 0) {\n+\t\twpa_printf(MSG_ERROR, DRV_PREFIX \"genl resolve failed\");\n+\t\tgoto out_free;\n+\t}\n+\n+\terr = 0;\n+\n+out_free:\n+\tnl_socket_free(sk);\n+\treturn err;\n+}\n+\n static void * macsec_drv_wpa_init(void *ctx, const char *ifname)\n {\n \tstruct macsec_drv_data *drv;\n \n+\tif (macsec_check_macsec() < 0) {\n+\t\twpa_printf(MSG_ERROR, DRV_PREFIX \"macsec kernel module missing\");\n+\t\treturn NULL;\n+\t}\n+\n \tdrv = os_zalloc(sizeof(*drv));\n \tif (!drv)\n \t\treturn NULL;\n","prefixes":["1/1"]}