{"id":803358,"url":"http://patchwork.ozlabs.org/api/1.2/patches/803358/?format=json","web_url":"http://patchwork.ozlabs.org/project/hostap/patch/1503077440-3182-1-git-send-email-michael-dev@fami-braun.de/","project":{"id":22,"url":"http://patchwork.ozlabs.org/api/1.2/projects/22/?format=json","name":"HostAP Development","link_name":"hostap","list_id":"hostap.lists.infradead.org","list_email":"hostap@lists.infradead.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<1503077440-3182-1-git-send-email-michael-dev@fami-braun.de>","list_archive_url":null,"date":"2017-08-18T17:30:40","name":"[1/1] macsec: handle missing macsec kernel module","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"79687f7811fcaf6d6eb24ed3e23f25b4670c3b43","submitter":{"id":3892,"url":"http://patchwork.ozlabs.org/api/1.2/people/3892/?format=json","name":"michael-dev","email":"michael-dev@fami-braun.de"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/hostap/patch/1503077440-3182-1-git-send-email-michael-dev@fami-braun.de/mbox/","series":[],"comments":"http://patchwork.ozlabs.org/api/patches/803358/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/803358/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org; spf=none (mailfrom)\n\tsmtp.mailfrom=lists.infradead.org (client-ip=65.50.211.133;\n\thelo=bombadil.infradead.org;\n\tenvelope-from=hostap-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=lists.infradead.org\n\theader.i=@lists.infradead.org header.b=\"TvZV/YEY\"; \n\tdkim-atps=neutral"],"Received":["from bombadil.infradead.org (bombadil.infradead.org\n\t[65.50.211.133])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xYqtz4Hzbz9t3C\n\tfor ;\n\tSat, 19 Aug 2017 03:33:47 +1000 (AEST)","from localhost ([127.0.0.1] helo=bombadil.infradead.org)\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dil94-0007od-MX; Fri, 18 Aug 2017 17:33:18 +0000","from mail.fem.tu-ilmenau.de ([141.24.220.54])\n\tby bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux))\n\tid 1dil8f-0007iD-OA\n\tfor hostap@lists.infradead.org; Fri, 18 Aug 2017 17:32:55 +0000","from localhost (localhost [127.0.0.1])\n\tby mail.fem.tu-ilmenau.de (Postfix) with ESMTP id B128B6653;\n\tFri, 18 Aug 2017 19:32:32 +0200 (CEST)","from mail.fem.tu-ilmenau.de ([127.0.0.1])\n\tby localhost (mail.fem.tu-ilmenau.de [127.0.0.1]) (amavisd-new,\n\tport 10024)\n\twith ESMTP id ZzMXuOaV5DOZ; Fri, 18 Aug 2017 19:32:32 +0200 (CEST)","from mail-backup.fem.tu-ilmenau.de\n\t(mail-backup.net.fem.tu-ilmenau.de [10.42.40.22])\n\t(using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mail.fem.tu-ilmenau.de (Postfix) with ESMTPS;\n\tFri, 18 Aug 2017 19:32:31 +0200 (CEST)","from a234.fem.tu-ilmenau.de (ray-controller.net.fem.tu-ilmenau.de\n\t[10.42.51.234])\n\tby mail-backup.fem.tu-ilmenau.de (Postfix) with ESMTP id B2DC556054; \n\tFri, 18 Aug 2017 19:32:31 +0200 (CEST)","by a234.fem.tu-ilmenau.de (Postfix, from userid 1000)\n\tid 070333085499; Fri, 18 Aug 2017 19:30:41 +0200 (CEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;\n\td=lists.infradead.org; s=bombadil.20170209; h=Sender:\n\tContent-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe:\n\tList-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date:\n\tSubject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date:\n\tResent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:\n\tReferences:List-Owner; bh=nemkZuCuOnN4jh3D5UH/naZ0WRvwRwy2+DyDL8+EMsA=;\n\tb=TvZ\n\tV/YEYuiM245HczyPuaO4RSoilpGMVCe4tzMk5iOIYU9fBipka+CUoKvnB109czPXNVOjrSKmGn/WF\n\ti8/z5rkDcOE1G/l9rLr6JFPJn2xVcWrTLzjid39ECFGOaOHEtjypInuJEdCw/UAj9aMRY/NAfLEBU\n\t1N+FfRcO6fXaa0Fqg84xJExs9Th02aOzA75kFBIyhpgSr0Beokkn1nVZZT3zp4MAw/K3EjX852d1n\n\tC+YWFY4PME9z+PUxN31elHaMuMFmGwr4rR7emyZQPCSGMk8QhyDJyPxOZ6sUnLs71qZW+lh3ARtAs\n\tqdL1DMgLRiQ9HEnh0deUN3bp1gzCtdA==;","X-Virus-Scanned":"amavisd-new at fem.tu-ilmenau.de","From":"Michael Braun ","To":"hostap@lists.infradead.org","Subject":"[PATCH 1/1] macsec: handle missing macsec kernel module","Date":"Fri, 18 Aug 2017 19:30:40 +0200","Message-Id":"<1503077440-3182-1-git-send-email-michael-dev@fami-braun.de>","X-Mailer":"git-send-email 2.1.4","X-CRM114-Version":"20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 ","X-CRM114-CacheID":"sfid-20170818_103254_185236_5D753AB6 ","X-CRM114-Status":"UNSURE ( 8.06 )","X-CRM114-Notice":"Please train this message.","X-Spam-Score":"-4.2 (----)","X-Spam-Report":"SpamAssassin version 3.4.1 on bombadil.infradead.org summary:\n\tContent analysis details: (-4.2 points)\n\tpts rule name description\n\t---- ----------------------\n\t--------------------------------------------------\n\t-2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at http://www.dnswl.org/,\n\tmedium trust [141.24.220.54 listed in list.dnswl.org]\n\t-1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1%\n\t[score: 0.0000]","X-BeenThere":"hostap@lists.infradead.org","X-Mailman-Version":"2.1.21","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"projekt-wlan@fem.tu-ilmenau.de, Michael Braun ","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Sender":"\"Hostap\" ","Errors-To":"hostap-bounces+incoming=patchwork.ozlabs.org@lists.infradead.org"},"content":"This fixes the following crash:\n\n0. do not modprobe macsec\n1. create veth pair\n2. run two wpa_supplicant linux_macsec instances on both ends\n3. see one instance crash\n\nSuccessfully initialized wpa_supplicant\nmacsec_linux: genl resolve failed\nmacsec_linux: genl resolve failed\nmacsec_linux: NULL rtnl socket\nveth1: Associated with 01:80:c2:00:00:03\nveth1: CTRL-EVENT-CONNECTED - Connection to 01:80:c2:00:00:03 completed [id=0 id_str=]\nWMM AC: Missing IEs\nveth1: CTRL-EVENT-SUBNET-STATUS-UPDATE status=0\nASAN:SIGSEGV","diff":"=================================================================\n==9601==ERROR: AddressSanitizer: SEGV on unknown address 0x000000000004 (pc 0x7f25f6959ec0 sp 0x7ffe0abe9808 bp 0x000000000000 T0)\n #0 0x7f25f6959ebf (/opt/libnl/lib/.libs/libnl-3.so.200+0x12ebf)\n #1 0x7f25f695814f in nl_complete_msg /opt/libnl/lib/nl.c:487\n #2 0x7f25f6958180 in nl_send_auto /opt/libnl/lib/nl.c:518\n #3 0x585930 in nl_send_recv ../src/drivers/driver_macsec_linux.c:558\n #4 0x58a4a2 in macsec_drv_create_receive_sc ../src/drivers/driver_macsec_linux.c:733\n #5 0x4a2038 in wpa_drv_create_receive_sc /home/mbr/hostap/wpa_supplicant/driver_i.h:797\n #6 0x4a2038 in wpas_create_receive_sc /home/mbr/hostap/wpa_supplicant/wpas_kay.c:113\n #7 0x4c26eb in secy_create_receive_sc ../src/pae/ieee802_1x_secy_ops.c:235\n #8 0x4b1703 in ieee802_1x_kay_move_live_peer ../src/pae/ieee802_1x_kay.c:655\n #9 0x4b1703 in ieee802_1x_kay_decode_mkpdu ../src/pae/ieee802_1x_kay.c:2983\n #10 0x4b24e7 in kay_l2_receive ../src/pae/ieee802_1x_kay.c:3089\n #11 0x5e3fec in l2_packet_receive ../src/l2_packet/l2_packet_linux.c:191\n #12 0x44572b in eloop_sock_table_dispatch ../src/utils/eloop.c:595\n #13 0x4485cd in eloop_run ../src/utils/eloop.c:1218\n #14 0x544c88 in wpa_supplicant_run /home/mbr/hostap/wpa_supplicant/wpa_supplicant.c:5905\n #15 0x583a88 in main /home/mbr/hostap/wpa_supplicant/main.c:392\n #16 0x7f25f4c1cb44 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x21b44)\n #17 0x409448 (/home/mbr/hostap/wpa_supplicant/wpa_supplicant+0x409448)\n\nSigned-off-by: Michael Braun \n---\n src/pae/ieee802_1x_kay.c | 6 +++++-\n 1 file changed, 5 insertions(+), 1 deletion(-)\n\ndiff --git a/src/pae/ieee802_1x_kay.c b/src/pae/ieee802_1x_kay.c\nindex a919dfe..1ab48d6 100644\n--- a/src/pae/ieee802_1x_kay.c\n+++ b/src/pae/ieee802_1x_kay.c\n@@ -3166,7 +3166,11 @@ ieee802_1x_kay_init(struct ieee802_1x_kay_ctx *ctx, enum macsec_policy policy,\n \twpa_printf(MSG_DEBUG, \"KaY: state machine created\");\n \n \t/* Initialize the SecY must be prio to CP, as CP will control SecY */\n-\tsecy_init_macsec(kay);\n+\tif (secy_init_macsec(kay) < 0) {\n+\t\twpa_printf(MSG_ERROR, \"KaY: secy init macsec failed\");\n+\t\tos_free(kay);\n+\t\treturn NULL;\n+\t}\n \n \twpa_printf(MSG_DEBUG, \"KaY: secy init macsec done\");\n \n","prefixes":["1/1"]}