{"id":802651,"url":"http://patchwork.ozlabs.org/api/1.2/patches/802651/?format=json","web_url":"http://patchwork.ozlabs.org/project/swupdate/patch/20170817132614.17160-1-christian.storm@siemens.com/","project":{"id":58,"url":"http://patchwork.ozlabs.org/api/1.2/projects/58/?format=json","name":"swupdate development","link_name":"swupdate","list_id":"swupdate.googlegroups.com","list_email":"swupdate@googlegroups.com","web_url":"https://github.com/sbabic/swupdate","scm_url":"git://github.com/sbabic/swupdate","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20170817132614.17160-1-christian.storm@siemens.com>","list_archive_url":null,"date":"2017-08-17T13:26:14","name":"[resent] IPC: don't zero ipc_postupdate()'s msg parameter","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"12c79f5568e876f235ce8e449cd9ceb695b19c2c","submitter":{"id":72180,"url":"http://patchwork.ozlabs.org/api/1.2/people/72180/?format=json","name":"Storm, Christian","email":"christian.storm@siemens.com"},"delegate":{"id":1693,"url":"http://patchwork.ozlabs.org/api/1.2/users/1693/?format=json","username":"sbabic","first_name":"Stefano","last_name":"Babic","email":"sbabic@denx.de"},"mbox":"http://patchwork.ozlabs.org/project/swupdate/patch/20170817132614.17160-1-christian.storm@siemens.com/mbox/","series":[],"comments":"http://patchwork.ozlabs.org/api/patches/802651/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/802651/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=googlegroups.com\n\t(client-ip=2a00:1450:4010:c07::23f;\n\thelo=mail-lf0-x23f.google.com;\n\tenvelope-from=swupdate+bncbdd6bwv65qpbb4ft23gakgqesc7gi3q@googlegroups.com;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=googlegroups.com header.i=@googlegroups.com\n\theader.b=\"LGJiUcsq\"; dkim-atps=neutral"],"Received":["from mail-lf0-x23f.google.com (mail-lf0-x23f.google.com\n\t[IPv6:2a00:1450:4010:c07::23f])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xY6VD56Kzz9t4V\n\tfor ;\n\tThu, 17 Aug 2017 23:28:19 +1000 (AEST)","by mail-lf0-x23f.google.com with SMTP id 71sf832436lfs.1\n\tfor ;\n\tThu, 17 Aug 2017 06:28:19 -0700 (PDT)","by 10.25.23.94 with SMTP id n91ls227937lfi.9.gmail;\n\tThu, 17 Aug 2017 06:28:16 -0700 (PDT)","from thoth.sbs.de (thoth.sbs.de. [192.35.17.2])\n\tby gmr-mx.google.com with ESMTPS id\n\to62si1568541wmo.2.2017.08.17.06.28.16\n\tfor \n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tThu, 17 Aug 2017 06:28:16 -0700 (PDT)","from mail1.siemens.de (mail1.siemens.de [139.23.33.14])\n\tby thoth.sbs.de (8.15.2/8.15.2) with ESMTPS id v7HDSGiN004033\n\t(version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK)\n\tfor ; Thu, 17 Aug 2017 15:28:16 +0200","from MD1KR9XC.ww002.siemens.net ([139.25.68.253])\n\tby mail1.siemens.de (8.15.2/8.15.2) with ESMTP id v7HDSG0L009095;\n\tThu, 17 Aug 2017 15:28:16 +0200"],"ARC-Seal":["i=2; a=rsa-sha256; t=1502976497; cv=pass;\n\td=google.com; s=arc-20160816;\n\tb=VKFSaTEdEr695/C+4QYd752c+XKDKAeKa0/EnababQpMjgr0FWZ1knMZRujbwMENE8\n\toQpYKNbtHiqK2IBgIbFaNTwrZSBtMzkN/kXZABk00C9UWhR68TDjqjcZINKsySpA1CSy\n\tYD3Wbkh+lWY9bGy2Rw0ObiBhirEhG/+tUhQkXSyYYvn7pUxLhZCTRRC+Z13/efb6c7BV\n\ttDjsE+3DWrtxUXKH0pbBYAvaIIDZG8JhiYgWktNxJA7ZH26LtsLs8Nmc+nEhyjO1vH0W\n\tVZCYQoD6AyWfKHV/KYMzTkTP6xieglbUJi8CZWLLSnE7hM/EFCv/tZm+M7Ib2Rxe/TQB\n\tXSMQ==","i=1; a=rsa-sha256; t=1502976496; cv=none;\n\td=google.com; s=arc-20160816;\n\tb=Q//5yl3avP+5YHkPHoyveSlVKXxk2MrVIvfZw9Fo5qUOX72NvGyDyg0ZnJbQqsI8l6\n\tv5Xyy8a1AFEmW/e2fOk1msFVKtlnB+KwfYQ9Jh1ZCW+pxVBNdsvJVeJGHibk2k2y8YeC\n\tgch4GigUVMN31rY47zKf2Mk+afcp8ayqfu45P6GQduL0zYZS3YRIPicVZxB4Jfo5U/az\n\tnkiZiKhSwJMhhMHODIhe+oOcdoMER/XiJvxPjXbuMrUhIE4x6gd/xnGKurL39Ef8ZBpQ\n\t66yvxBV1wESWAAHw+lTMGOkT/mNC5afUf4OAqA2bGE5wwBpKNgHUaFLWXw4A2CtWpPsW\n\tOb7A=="],"ARC-Message-Signature":["i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n\ts=arc-20160816; \n\th=list-unsubscribe:list-subscribe:list-archive:list-help:list-post\n\t:list-id:mailing-list:precedence:message-id:date:subject:cc:to:from\n\t:arc-authentication-results:arc-message-signature:mime-version\n\t:sender:dkim-signature:arc-authentication-results;\n\tbh=hP3hWtz/Z1/kFwuJyPEO32/o/5Bjm9JSbFHQlDDY+wE=;\n\tb=oD54GnzjhLnnx05CVM2X3guoVtqmMSUfnWti2NREAJ73S1PJC+crlMNZsE84cPm8eD\n\t9vQyuiytEkmfjmBLRu6PDWdiPOaE808NIqgKJ78Y1paFLNxpuRQLGhSWmWoW0AozEHXh\n\twIzTqNRzPMNvT+ljiE9sP/EFxZ9JyVp4Ht2Hr4mWHi4X15LwIjUgRogcCZPLEvSNFhkS\n\t0MvL+PqV5qNxoPQmv3DLkb0SnwFx7o7kXpURjN7tuljVCiB1jUlqEL1bQBzGsVlt971v\n\tOYAsVXnhAteZOoSe+NI5kHvygXWIXuBjn66AnI3boDdVhz5N+MHMgyi2/HGoOqcULitd\n\tqeFw==","i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n\ts=arc-20160816; \n\th=message-id:date:subject:cc:to:from:arc-authentication-results;\n\tbh=6EK/KhW39qhodFiYtc+Wjo9ZWBYwE6VipUmRZt3emhE=;\n\tb=RBT2DuxJhC7HsUwq2QaWhlpSH6UVBNrFiZoLMq74YZs/G4hMXUfpGWoDRBq9P+Si2l\n\t/1M3ujDiNcYTCMrW6f5Qb1TG+BzW1qyrJLtf5wg6hdSKsdT8EQT+fWiBsv8kTphvL9Ls\n\tnWRllbESoyfftpnMzkEdwbcEZzM5Gb7zYA/BN1rOemdSjQSX1CnZhrlbhuMCVTkTOahU\n\txsXjnytOaJKMVd2mnhAigIJAsoI9YUio73JXk2myuxkMyqBut81OnprS5lU1aajEFcB1\n\tQSdtQUJ1rRYIKX8LuR6wisdnn3mG/px2PyNYLeaoo9xzE90uWT7tavLggQWa6AKSdh7Y\n\tU9Hg=="],"ARC-Authentication-Results":["i=2; gmr-mx.google.com;\n\tspf=neutral (google.com: 192.35.17.2 is neither permitted nor denied\n\tby best guess record for domain of\n\tchristian.storm@siemens.com)\n\tsmtp.mailfrom=christian.storm@siemens.com","i=1; gmr-mx.google.com;\n\tspf=neutral (google.com: 192.35.17.2 is neither permitted nor denied\n\tby best guess record for domain of\n\tchristian.storm@siemens.com)\n\tsmtp.mailfrom=christian.storm@siemens.com"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=googlegroups.com; s=20161025;\n\th=sender:mime-version:from:to:cc:subject:date:message-id\n\t:x-original-sender:x-original-authentication-results:precedence\n\t:mailing-list:list-id:list-post:list-help:list-archive\n\t:list-subscribe:list-unsubscribe;\n\tbh=hP3hWtz/Z1/kFwuJyPEO32/o/5Bjm9JSbFHQlDDY+wE=;\n\tb=LGJiUcsqNovEdhxS1m7yLqUWUK3ADLcjhP+xOQIZNaPBe73wWnv/fB+IkW/NH+tTco\n\t0t4HNEv81Ox2/4d+oyNVnMMKXcDOsOjYwU4VgHmlud1xeE0Sw7aJBkiXPZy/MOcEFrSx\n\tuJvQZ5vDJqHi0uKZKuvHxT9dHBZFPSk8xNhHSLZsHQbYYj3swiBEGBHSh9T1hY7SoUWX\n\tJVfsKOaABIx4YN945Nmz4LfCeQDE3barD032zcBpnG1rcen/lqlwl7xihTpm7/IcKnLc\n\twpNvugNsoL5Bw7o/7eWO0FJTeNhncjvDbT2bvkCXW6gj125A1lsCu/gC4r7WhYN2l2+2\n\tTBLA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=sender:x-gm-message-state:mime-version:from:to:cc:subject:date\n\t:message-id:x-original-sender:x-original-authentication-results\n\t:precedence:mailing-list:list-id:x-spam-checked-in-group:list-post\n\t:list-help:list-archive:list-subscribe:list-unsubscribe;\n\tbh=hP3hWtz/Z1/kFwuJyPEO32/o/5Bjm9JSbFHQlDDY+wE=;\n\tb=Hu3lezL7Rek/7hOVX+95EdseRmYHyx33tz86MmXqIj8YkV0BJMeEjUMMrvC+2W6S7k\n\tNjJgcRefkt5rk4adQc+O+FfHtQAatcK0aL1Iv6izgTDNTFwEIj05KyeslY3f1HBMoZK0\n\tlBexdu3mI87OBvxYdDgbWETm8UZf7OfTqn4jQvPcEifgySieySPWse5mSTLXQgGiS5uY\n\tWiNVsfriiL80tjbF9NNe6//awYxQ/9YhYJet1SFWBMZo25rDReDe6PpknMAxWoAnW15a\n\tQpof06zLVXxlPfMO4Q6JXg1bBa2ORfqq1zs8gRMN+rtLB6sK+TdRntO+mkiFHuvwQN0P\n\tPJnQ==","Sender":"swupdate@googlegroups.com","X-Gm-Message-State":"AHYfb5iX1RBWPjyBXFCpWMyVtw0y0OvnkuEspvvPFB/t/orDEnqOzErZ\n\tMk3gobSvWRXbiA==","X-Received":["by 10.46.32.135 with SMTP id g7mr10224lji.18.1502976497143;\n\tThu, 17 Aug 2017 06:28:17 -0700 (PDT)","by 10.25.233.88 with SMTP id g85mr24236lfh.38.1502976496492;\n\tThu, 17 Aug 2017 06:28:16 -0700 (PDT)"],"MIME-Version":"1.0","X-BeenThere":"swupdate@googlegroups.com","Received-SPF":"neutral (google.com: 192.35.17.2 is neither permitted nor\n\tdenied by best guess record for domain of\n\tchristian.storm@siemens.com) client-ip=192.35.17.2; ","From":"Christian Storm ","To":"swupdate@googlegroups.com","Cc":"Christian Storm ","Subject":"[swupdate] [PATCH resent] IPC: don't zero ipc_postupdate()'s msg\n\tparameter","Date":"Thu, 17 Aug 2017 15:26:14 +0200","Message-Id":"<20170817132614.17160-1-christian.storm@siemens.com>","X-Mailer":"git-send-email 2.14.1","X-Original-Sender":"christian.storm@siemens.com","X-Original-Authentication-Results":"gmr-mx.google.com; spf=neutral\n\t(google.com: 192.35.17.2 is neither permitted nor denied by best\n\tguess record\n\tfor domain of christian.storm@siemens.com)\n\tsmtp.mailfrom=christian.storm@siemens.com","Content-Type":"text/plain; charset=\"UTF-8\"","Precedence":"list","Mailing-list":"list swupdate@googlegroups.com;\n\tcontact swupdate+owners@googlegroups.com","List-ID":"","X-Spam-Checked-In-Group":"swupdate@googlegroups.com","X-Google-Group-Id":"605343134186","List-Post":",\n\t","List-Help":",\n\t","List-Archive":",\n\t","List-Unsubscribe":",\n\t"},"content":"When signaling the due execution of postupdate() via\nipc_postupdate(), zero out msg preserving msg.data.instmsg.buf\nso that an optional message can be forwarded to postupdate().\n\nSigned-off-by: Christian Storm \n---\n ipc/network_ipc.c | 14 ++++++++++++++\n 1 file changed, 14 insertions(+)","diff":"diff --git a/ipc/network_ipc.c b/ipc/network_ipc.c\nindex 0f346ba..6629461 100644\n--- a/ipc/network_ipc.c\n+++ b/ipc/network_ipc.c\n@@ -78,7 +78,21 @@ int ipc_postupdate(ipc_message *msg) {\n \t}\n \n \tssize_t ret;\n+\tchar* tmpbuf = NULL;\n+\tif (msg->data.instmsg.len > 0) {\n+\t\tif ((tmpbuf = strndupa(msg->data.instmsg.buf,\n+\t\t\t\tmsg->data.instmsg.len > sizeof(msg->data.instmsg.buf)\n+\t\t\t\t ? sizeof(msg->data.instmsg.buf)\n+\t\t\t\t : msg->data.instmsg.len)) == NULL) {\n+\t\t\tclose(connfd);\n+\t\t\treturn -1;\n+\t\t}\n+\t}\n \tmemset(msg, 0, sizeof(*msg));\n+\tif (tmpbuf != NULL) {\n+\t\tstrncpy(msg->data.instmsg.buf, tmpbuf, sizeof(msg->data.instmsg.buf));\n+\t\tmsg->data.instmsg.len = strnlen(tmpbuf, sizeof(msg->data.instmsg.buf));\n+\t}\n \tmsg->magic = IPC_MAGIC;\n \tmsg->type = POST_UPDATE;\n \tret = write(connfd, msg, sizeof(*msg));\n","prefixes":["resent"]}