{"id":802621,"url":"http://patchwork.ozlabs.org/api/1.2/patches/802621/?format=json","web_url":"http://patchwork.ozlabs.org/project/swupdate/patch/1502975227-3112-1-git-send-email-sbabic@denx.de/","project":{"id":58,"url":"http://patchwork.ozlabs.org/api/1.2/projects/58/?format=json","name":"swupdate development","link_name":"swupdate","list_id":"swupdate.googlegroups.com","list_email":"swupdate@googlegroups.com","web_url":"https://github.com/sbabic/swupdate","scm_url":"git://github.com/sbabic/swupdate","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<1502975227-3112-1-git-send-email-sbabic@denx.de>","list_archive_url":null,"date":"2017-08-17T13:07:07","name":"hawkbit: artifact not installed if SWU is not the first","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"349e1cdbf74e542f83d53046d5a49f2317b76dc9","submitter":{"id":5771,"url":"http://patchwork.ozlabs.org/api/1.2/people/5771/?format=json","name":"Stefano Babic","email":"sbabic@denx.de"},"delegate":{"id":1693,"url":"http://patchwork.ozlabs.org/api/1.2/users/1693/?format=json","username":"sbabic","first_name":"Stefano","last_name":"Babic","email":"sbabic@denx.de"},"mbox":"http://patchwork.ozlabs.org/project/swupdate/patch/1502975227-3112-1-git-send-email-sbabic@denx.de/mbox/","series":[],"comments":"http://patchwork.ozlabs.org/api/patches/802621/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/802621/checks/","tags":{},"related":[],"headers":{"Return-Path":"<swupdate+bncBAABBCVK23GAKGQEX3IIQZY@googlegroups.com>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=googlegroups.com\n\t(client-ip=2a00:1450:4010:c07::23e;\n\thelo=mail-lf0-x23e.google.com;\n\tenvelope-from=swupdate+bncbaabbcvk23gakgqex3iiqzy@googlegroups.com;\n\treceiver=<UNKNOWN>)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=googlegroups.com header.i=@googlegroups.com\n\theader.b=\"sJeWI2qr\"; dkim-atps=neutral"],"Received":["from mail-lf0-x23e.google.com (mail-lf0-x23e.google.com\n\t[IPv6:2a00:1450:4010:c07::23e])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128\n\tbits)) (No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xY6255Brbz9t4V\n\tfor <incoming@patchwork.ozlabs.org>;\n\tThu, 17 Aug 2017 23:07:25 +1000 (AEST)","by mail-lf0-x23e.google.com with SMTP id 71sf813820lfs.1\n\tfor <incoming@patchwork.ozlabs.org>;\n\tThu, 17 Aug 2017 06:07:25 -0700 (PDT)","by 10.28.55.130 with SMTP id e124ls758842wma.24.gmail; Thu, 17 Aug\n\t2017 06:07:22 -0700 (PDT)","from mail-out.m-online.net (mail-out.m-online.net.\n\t[2001:a60:0:28:0:1:25:1]) by gmr-mx.google.com with ESMTPS id\n\to62si1554421wmo.2.2017.08.17.06.07.22\n\tfor <swupdate@googlegroups.com>\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tThu, 17 Aug 2017 06:07:22 -0700 (PDT)","from frontend01.mail.m-online.net (unknown [192.168.8.182])\n\tby mail-out.m-online.net (Postfix) with ESMTP id 3xY6216kmQz1qryn;\n\tThu, 17 Aug 2017 15:07:21 +0200 (CEST)","from localhost (dynscan1.mnet-online.de [192.168.6.70])\n\tby mail.m-online.net (Postfix) with ESMTP id 3xY6212wcWz3jR9q;\n\tThu, 17 Aug 2017 15:07:21 +0200 (CEST)","from mail.mnet-online.de ([192.168.8.182])\n\tby localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new,\n\tport 10024)\n\twith ESMTP id PeCn4I1sETqs; Thu, 17 Aug 2017 15:07:15 +0200 (CEST)","from babic.homelinux.org\n\t(host-88-217-136-221.customer.m-online.net [88.217.136.221])\n\t(using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mail.mnet-online.de (Postfix) with ESMTPS;\n\tThu, 17 Aug 2017 15:07:15 +0200 (CEST)","from localhost (mail.babic.homelinux.org [127.0.0.1])\n\tby babic.homelinux.org (Postfix) with ESMTP id 41E6A45405ED;\n\tThu, 17 Aug 2017 15:07:15 +0200 (CEST)","from babic.homelinux.org ([127.0.0.1])\n\tby localhost (mail.babic.homelinux.org [127.0.0.1]) (amavisd-new,\n\tport 10024)\n\twith ESMTP id t4eVjOB43ViZ; Thu, 17 Aug 2017 15:07:09 +0200 (CEST)","from papero.fritz.box (papero.fritz.box [192.168.178.132])\n\tby babic.homelinux.org (Postfix) with ESMTP id 4294845403C3;\n\tThu, 17 Aug 2017 15:07:09 +0200 (CEST)"],"ARC-Seal":["i=2; a=rsa-sha256; t=1502975242; cv=pass;\n\td=google.com; s=arc-20160816;\n\tb=eSmQhOcLUKHhZG46tgSZ2d3EW2uAgtUjF/nYQM08BkN+DXGNfdJdOzG0RddYv8MHWa\n\tsmYFzlFx76b0eJSPMEiDCWkCUA3/obzSfhwpGZQ96JtDrbJyKlI+JXSkFrbFRKfbeu6O\n\tAgaBYpAm0Q9zBs19LKtB3IluqVQ2SjDTh2rdQVa6aTdq2IkOdr4rfLYcvM0mMQo74GaV\n\tG0kmSxIPYvyOkoFLBuQbbqOMJKGSx7mfQ2kC0YG6OVSlQJsooqunA4QJk7T6HxnQc6Fb\n\t9Zeg9rPkLT4n0+lrgAL5BGYosS8V2kbH+dlFiNcgfFJEMgcVnPxccAO1XGRnXWdnD9xE\n\tlFCQ==","i=1; a=rsa-sha256; t=1502975242; cv=none;\n\td=google.com; s=arc-20160816;\n\tb=p9yay5iub9OJfqPZ+C0zXZV7KNYa8Q5wGU7zpsI+hh1ZnQTXyJZOTeVgnHxtN5xuaj\n\tPX3+j95LqXEsdyE3VVXrFBpI8AxyPwUKYF+JvOE0/AMHTYwaLqXBO3cIQVaIejAQsKcy\n\tLYj3F0qkWXv92U62KIO0kC88AVYs1x9Ek1nMyGvhdfuIXZN/xMf6WAnfbncKy5WmyL82\n\thwYdflHSKeikKV+h/wtDgGzwRS926aplLhYuw1VQX2DCsBA3xGvaEab1P4cbKTKcyo1T\n\thMWG61xjwaBLnhchp4YFIc5BnS2W4FDUXlbmLrYM/xzqeyDesKSlg9FZt/4u3l2ufkMS\n\tyC2g=="],"ARC-Message-Signature":["i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n\ts=arc-20160816; \n\th=list-unsubscribe:list-subscribe:list-archive:list-help:list-post\n\t:list-id:mailing-list:precedence:message-id:date:subject:cc:to:from\n\t:arc-authentication-results:arc-message-signature:mime-version\n\t:sender:dkim-signature:arc-authentication-results;\n\tbh=Wl+5kk6tBoUQEspr23zeWJ6KJ6/TF4x4eHFcYW6jPQc=;\n\tb=LpnjaS4SwjQ8Y56C2V8Bzil6OIqv/KjzpAiKcM+shG5tdMufnPM/UrfDMs6zauBErY\n\tZxV4u4GJhHhoxDSEEJjXwTzVGPZi/fXsAvdCth66aBlBxku74NzNtw/hqSEHCLdvahRR\n\tibj/ojGU00NMzijHRwP30WSHOXCaaNGrVp85K+YRpKdgiZySGrgeAYPn4tSuDDuV/gCS\n\th1OLCRTTgUc6/W/b1X7HKbLY0aL0TH0ZYVH2/j9pm2g1xGGhdeAXsw50A5k+hrX0R7rt\n\tMhF0ymAmB1AvToM3GIDDuFZo1KzaLe55rq3aKLAi/WLdAHZ/WLlyGcwq+SEBCIik/K9N\n\tO6Hg==","i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;\n\ts=arc-20160816; \n\th=message-id:date:subject:cc:to:from:arc-authentication-results;\n\tbh=AqeRdpbYeFt/RU0JA5Yvp0quWAFvTT1POzae8BkXHIo=;\n\tb=rIwRhbR/iMXnviS62yXUjwvPw7IXi1GDC+4xITT7rrX8pUPvVYg785p1c6maeopYOo\n\tqFOIX0V11uTzMrR7mAMVSHtHIsE92vI8oiWdlbJBckKIo7PhKc7IVGmPyGWVakjt67/p\n\tM7fpqpkm8sxmcecs53qjKM1R/oaamnM3xezwP4l1iP7/tBw4WPHEfQq5URo/5R/R7DUc\n\tnV/hYKsctVa/TiITZjNHIVBfWlCdnFgEL3lH87GrIoXMszSuCMeScOj1oQfJNQMjgDbo\n\tE7x6FZZlVff5Mz85OJzrLVxSaNtcKj/m0Q5Sbn2bXG5wdYonZKX/kWJrfyHesJgR1kkS\n\tYPTQ=="],"ARC-Authentication-Results":["i=2; gmr-mx.google.com;\n\tspf=neutral (google.com: 2001:a60:0:28:0:1:25:1 is neither permitted\n\tnor denied by best guess record for domain of sbabic@denx.de)\n\tsmtp.mailfrom=sbabic@denx.de","i=1; gmr-mx.google.com;\n\tspf=neutral (google.com: 2001:a60:0:28:0:1:25:1 is neither permitted\n\tnor denied by best guess record for domain of sbabic@denx.de)\n\tsmtp.mailfrom=sbabic@denx.de"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=googlegroups.com; s=20161025;\n\th=sender:mime-version:from:to:cc:subject:date:message-id\n\t:x-original-sender:x-original-authentication-results:precedence\n\t:mailing-list:list-id:list-post:list-help:list-archive\n\t:list-subscribe:list-unsubscribe;\n\tbh=Wl+5kk6tBoUQEspr23zeWJ6KJ6/TF4x4eHFcYW6jPQc=;\n\tb=sJeWI2qrYcbNZEVWDuGAFPFQLTQIHX7KVelQveeelfBcol+ZccV8+r1ThMiJPdQTTY\n\tsJDgOP7qapTjXfNlwwNh/TmsemJeNyzlTnwn7j86onju3ZIIydvWF0NOpBHNMA2fO/Qb\n\tZZt3uqOKxgCk75fBr54Ui8OZn/jUOPN8ehJCdhOpOS4iS0Cq4X6y7wR7hKcskbSjY1Pa\n\ter5ZuCU9Yr1i0bzjnkzc1oMXgsO6gU7DSJ4I4IEBiMK8BmquKYpSxpkHtcH1u3YAZmNo\n\t4jCKC3ahaSE47lPjot5dzWpSU5CdsTLgPLrZX/2KVlVa+P7gRyOSecV8/cMb5bRuK7f4\n\tJ/PA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=sender:x-gm-message-state:mime-version:from:to:cc:subject:date\n\t:message-id:x-original-sender:x-original-authentication-results\n\t:precedence:mailing-list:list-id:x-spam-checked-in-group:list-post\n\t:list-help:list-archive:list-subscribe:list-unsubscribe;\n\tbh=Wl+5kk6tBoUQEspr23zeWJ6KJ6/TF4x4eHFcYW6jPQc=;\n\tb=TWBGOSNqya3UhTC/gOKkKIvOoAkK/zvKLhGBkxiPCfQPDz+/A2Krf+uFGBA6Ik4yeo\n\tieTSEyTI+pb/reZxGVz2wPQcVxRp9STenDriZoN7C1Q1w9pyM/DAY6cfEfweJJ41P5je\n\tX0J4wZrDsbmQOnLx+tNcNw5iWHBQmlACr6050nkN+ahXSn/svQu1S7dlHxFhArz3xuI0\n\tKVO0le4ZrLeC5IWI9DOc4pqZzxWMeOZtoIrm3KeE0vnxOJB0BwWTzwso35RVIZnJUEV/\n\tZOPQaD1x1MGuZdUoCtKIBbGQ5uo6mIqfhoStimSj+srCaApCYT8/VlVOxHzpvyE3mng0\n\tAAYw==","Sender":"swupdate@googlegroups.com","X-Gm-Message-State":"AHYfb5h3NLqidnKcl9/FL0pqUL+xJG0/+biAksO1ZprzlFpaBbD3MdUv\n\tpnNLATvL0GAY5g==","X-Received":["by 10.28.66.205 with SMTP id k74mr2280wmi.10.1502975242557;\n\tThu, 17 Aug 2017 06:07:22 -0700 (PDT)","by 10.28.51.131 with SMTP id z125mr283295wmz.16.1502975242169;\n\tThu, 17 Aug 2017 06:07:22 -0700 (PDT)"],"MIME-Version":"1.0","X-BeenThere":"swupdate@googlegroups.com","Received-SPF":"neutral (google.com: 2001:a60:0:28:0:1:25:1 is neither\n\tpermitted nor denied by best guess record for domain of\n\tsbabic@denx.de) client-ip=2001:a60:0:28:0:1:25:1; ","X-Virus-Scanned":["amavisd-new at mnet-online.de","Debian amavisd-new at babic.homelinux.org"],"From":"Stefano Babic <sbabic@denx.de>","To":"swupdate@googlegroups.com","Cc":"Stefano Babic <sbabic@denx.de>","Subject":"[swupdate] [PATCH] hawkbit: artifact not installed if SWU is not\n\tthe first","Date":"Thu, 17 Aug 2017 15:07:07 +0200","Message-Id":"<1502975227-3112-1-git-send-email-sbabic@denx.de>","X-Mailer":"git-send-email 2.7.4","X-Original-Sender":"sbabic@denx.de","X-Original-Authentication-Results":"gmr-mx.google.com;       spf=neutral\n\t(google.com: 2001:a60:0:28:0:1:25:1 is neither permitted nor denied\n\tby best\n\tguess record for domain of sbabic@denx.de)\n\tsmtp.mailfrom=sbabic@denx.de","Content-Type":"text/plain; charset=\"UTF-8\"","Precedence":"list","Mailing-list":"list swupdate@googlegroups.com;\n\tcontact swupdate+owners@googlegroups.com","List-ID":"<swupdate.googlegroups.com>","X-Spam-Checked-In-Group":"swupdate@googlegroups.com","X-Google-Group-Id":"605343134186","List-Post":"<https://groups.google.com/group/swupdate/post>,\n\t<mailto:swupdate@googlegroups.com>","List-Help":"<https://groups.google.com/support/>,\n\t<mailto:swupdate+help@googlegroups.com>","List-Archive":"<https://groups.google.com/group/swupdate","List-Subscribe":"<https://groups.google.com/group/swupdate/subscribe>,\n\t<mailto:swupdate+subscribe@googlegroups.com>","List-Unsubscribe":"<mailto:googlegroups-manage+605343134186+unsubscribe@googlegroups.com>,\n\t<https://groups.google.com/group/swupdate/subscribe>"},"content":"If the Hawkbit server delivers artifacts not in SWU format, SWUpdate\nstops. The behaviour is changed and SWUpdate will simply skip all\nartifacts that are not SWU images. This avoids that Software is not\ninstalled at all if SWU is not the first artifact in the list provided\nby the server.\n\nSigned-off-by: Stefano Babic <sbabic@denx.de>\n---\n suricatta/server_hawkbit.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)","diff":"diff --git a/suricatta/server_hawkbit.c b/suricatta/server_hawkbit.c\nindex 605733f..4603803 100644\n--- a/suricatta/server_hawkbit.c\n+++ b/suricatta/server_hawkbit.c\n@@ -1076,7 +1076,7 @@ server_op_res_t server_process_update_artifact(int action_id,\n \t\tif (endfilename <= 0 ||\n \t\t    strncmp(&s[endfilename], \".swu\", 4)) {\n \t\t\tDEBUG(\"File '%s' is not a SWU image, skipping\", s);\n-\t\t\tgoto cleanup;\n+\t\t\tcontinue;\n \t\t}\n \n \t\tDEBUG(\"Processing '%s' from '%s'\\n\",\n","prefixes":[]}