{"id":796555,"url":"http://patchwork.ozlabs.org/api/1.2/patches/796555/?format=json","web_url":"http://patchwork.ozlabs.org/project/rtc-linux/patch/1501662902-16048-1-git-send-email-bhumirks@gmail.com/","project":{"id":9,"url":"http://patchwork.ozlabs.org/api/1.2/projects/9/?format=json","name":"Linux RTC development","link_name":"rtc-linux","list_id":"linux-rtc.vger.kernel.org","list_email":"linux-rtc@vger.kernel.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<1501662902-16048-1-git-send-email-bhumirks@gmail.com>","list_archive_url":null,"date":"2017-08-02T08:35:02","name":"rtc: add const to bin_attribute structures","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"f41b119fcf1d0af4657af7acc9a270b995dc7429","submitter":{"id":69882,"url":"http://patchwork.ozlabs.org/api/1.2/people/69882/?format=json","name":"Bhumika Goyal","email":"bhumirks@gmail.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/rtc-linux/patch/1501662902-16048-1-git-send-email-bhumirks@gmail.com/mbox/","series":[],"comments":"http://patchwork.ozlabs.org/api/patches/796555/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/796555/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@bilbo.ozlabs.org","Authentication-Results":["ozlabs.org;\n\tspf=none (mailfrom) smtp.mailfrom=vger.kernel.org\n\t(client-ip=209.132.180.67; helo=vger.kernel.org;\n\tenvelope-from=linux-rtc-owner@vger.kernel.org;\n\treceiver=)","ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"ZnjxSiA3\"; dkim-atps=neutral"],"Received":["from vger.kernel.org (vger.kernel.org [209.132.180.67])\n\tby ozlabs.org (Postfix) with ESMTP id 3xMmjD6Mg5z9s65\n\tfor ;\n\tWed, 2 Aug 2017 18:35:28 +1000 (AEST)","(majordomo@vger.kernel.org) by vger.kernel.org via listexpand\n\tid S1752519AbdHBIfP (ORCPT );\n\tWed, 2 Aug 2017 04:35:15 -0400","from mail-pf0-f193.google.com ([209.85.192.193]:32953 \"EHLO\n\tmail-pf0-f193.google.com\" rhost-flags-OK-OK-OK-OK) by vger.kernel.org\n\twith ESMTP id S1752294AbdHBIfM (ORCPT\n\t); Wed, 2 Aug 2017 04:35:12 -0400","by mail-pf0-f193.google.com with SMTP id c65so5172796pfl.0;\n\tWed, 02 Aug 2017 01:35:12 -0700 (PDT)","from gmail.com ([117.196.126.40]) by smtp.gmail.com with ESMTPSA id\n\ts11sm58928916pgr.53.2017.08.02.01.35.08\n\t(version=TLS1 cipher=AES128-SHA bits=128/128);\n\tWed, 02 Aug 2017 01:35:11 -0700 (PDT)","by gmail.com (sSMTP sendmail emulation);\n\tWed, 02 Aug 2017 14:05:05 +0530"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=gmail.com; s=20161025;\n\th=from:to:cc:subject:date:message-id;\n\tbh=lq58rns3fhormD6zeTRXZwVCQkN3lcwhw6LYy7JtETs=;\n\tb=ZnjxSiA3DZG6s/4JP8wV4avWZfcy5x5uXaDAEIWPf4EAa2L2WnW50a73JYT1wbFlhk\n\tOODuP/VOQdPtkwHEaD1LTtwiS9IJ7Av2gZBFIrpMSjlzmK8fWf4NVqk6CceKjO0N5wXF\n\tSbVdC+zlJr9taQEaE58GeccuSuHysy39eW3eZbSvPn29K8bE2hOCun2aq+4zlYZo6epX\n\tienAbblzmQtWmIR2dTL7PquC+Ke3Pkz5EUT/V7mX0Pg4OlmACIK6HZTbvIoZ++BwYoJR\n\t/YyPHvgkgGiVP0Q2w2V4sIc7ZalRwmF6lS3V/6/cjHJTBcvRGYMwFyy0xDK91IexiUzn\n\tOCqQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id;\n\tbh=lq58rns3fhormD6zeTRXZwVCQkN3lcwhw6LYy7JtETs=;\n\tb=kLf7t2vBLhIrhPMgP7phOJzq7HkI4trdxOcqbWNBNWSvxz9gdKCIumHJTL0V8oKxO1\n\tV+fGe1cb4JfyaGq3qDybVzCyyI+eA5EIwGkvHRtmMweWguUVESO+z4UQ2NBqp2aB3TyF\n\t3PuQ8b1BZwxBqT5+T6E03c5rH8IuBedGfWFT0oiVXDQS8b7361bweF4Foe1QYwA/+ocF\n\t/5HFkko42FTJ1i1TkhFJuFPxR+r95YEZYU/u3TnCUxZoze8e2HHK6NR5PhjH/raEm4bG\n\trt7hkUrEMhtGxBeQ5BDLmOoXxpHLRne6Bjmt7rFPXStOVzfOBYtZHz0PQq55DVOU72NA\n\t6Fwg==","X-Gm-Message-State":"AIVw111oIj3qYCvKqv6809sgTV/evlj5cJma0tjoxYCz4vkSJYZW9Nlj\n\tuA8dRxxR+3cYHA==","X-Received":"by 10.99.114.84 with SMTP id c20mr21616822pgn.13.1501662911981; \n\tWed, 02 Aug 2017 01:35:11 -0700 (PDT)","From":"Bhumika Goyal ","To":"julia.lawall@lip6.fr, a.zummo@towertech.it,\n\talexandre.belloni@free-electrons.com, linux-rtc@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org","Cc":"Bhumika Goyal ","Subject":"[PATCH] rtc: add const to bin_attribute structures","Date":"Wed, 2 Aug 2017 14:05:02 +0530","Message-Id":"<1501662902-16048-1-git-send-email-bhumirks@gmail.com>","X-Mailer":"git-send-email 1.9.1","Sender":"linux-rtc-owner@vger.kernel.org","Precedence":"bulk","List-ID":"","X-Mailing-List":"linux-rtc@vger.kernel.org"},"content":"Add const to bin_attribute structures as they are only passed to the\nfunctions sysfs_{remove/create}_bin_file or\ndevice_{remove/create}_bin_file. The arguments passed are of\ntype const, so declare the structures to be const.\n\nDone using Coccinelle:\n\n@m disable optional_qualifier@\nidentifier s;\nposition p;\n@@\nstatic struct bin_attribute s@p={...};\n\n@okay1@\nposition p;\nidentifier m.s;\n@@\n(\nsysfs_create_bin_file(...,&s@p,...)\n|\nsysfs_remove_bin_file(...,&s@p,...)\n)\n\n@bad@\nposition p!={m.p,okay1.p};\nidentifier m.s;\n@@\ns@p\n\n@change depends on !bad disable optional_qualifier@\nidentifier m.s;\n@@\nstatic\n+const\nstruct bin_attribute s={...};\n\nSame script was modified for device_{create/remove}_bin_file functions.\nCross compiled drivers/rtc/rtc-tx4939.o file for mips architecture.\n\nSigned-off-by: Bhumika Goyal \n---\n drivers/rtc/rtc-ds1305.c | 2 +-\n drivers/rtc/rtc-ds1343.c | 2 +-\n drivers/rtc/rtc-stk17ta8.c | 2 +-\n drivers/rtc/rtc-tx4939.c | 2 +-\n 4 files changed, 4 insertions(+), 4 deletions(-)","diff":"diff --git a/drivers/rtc/rtc-ds1305.c b/drivers/rtc/rtc-ds1305.c\nindex 72b2293..148e746 100644\n--- a/drivers/rtc/rtc-ds1305.c\n+++ b/drivers/rtc/rtc-ds1305.c\n@@ -558,7 +558,7 @@ static void msg_init(struct spi_message *m, struct spi_transfer *x,\n \treturn (status < 0) ? status : count;\n }\n \n-static struct bin_attribute nvram = {\n+static const struct bin_attribute nvram = {\n \t.attr.name\t= \"nvram\",\n \t.attr.mode\t= S_IRUGO | S_IWUSR,\n \t.read\t\t= ds1305_nvram_read,\ndiff --git a/drivers/rtc/rtc-ds1343.c b/drivers/rtc/rtc-ds1343.c\nindex 895fbee..61d4254 100644\n--- a/drivers/rtc/rtc-ds1343.c\n+++ b/drivers/rtc/rtc-ds1343.c\n@@ -191,7 +191,7 @@ static ssize_t ds1343_nvram_read(struct file *filp, struct kobject *kobj,\n }\n \n \n-static struct bin_attribute nvram_attr = {\n+static const struct bin_attribute nvram_attr = {\n \t.attr.name\t= \"nvram\",\n \t.attr.mode\t= S_IRUGO | S_IWUSR,\n \t.read\t\t= ds1343_nvram_read,\ndiff --git a/drivers/rtc/rtc-stk17ta8.c b/drivers/rtc/rtc-stk17ta8.c\nindex a456cb6..b84c83a 100644\n--- a/drivers/rtc/rtc-stk17ta8.c\n+++ b/drivers/rtc/rtc-stk17ta8.c\n@@ -272,7 +272,7 @@ static ssize_t stk17ta8_nvram_write(struct file *filp, struct kobject *kobj,\n \treturn count;\n }\n \n-static struct bin_attribute stk17ta8_nvram_attr = {\n+static const struct bin_attribute stk17ta8_nvram_attr = {\n \t.attr = {\n \t\t.name = \"nvram\",\n \t\t.mode = S_IRUGO | S_IWUSR,\ndiff --git a/drivers/rtc/rtc-tx4939.c b/drivers/rtc/rtc-tx4939.c\nindex 560d9a5..83fbfa5a 100644\n--- a/drivers/rtc/rtc-tx4939.c\n+++ b/drivers/rtc/rtc-tx4939.c\n@@ -225,7 +225,7 @@ static ssize_t tx4939_rtc_nvram_write(struct file *filp, struct kobject *kobj,\n \treturn count;\n }\n \n-static struct bin_attribute tx4939_rtc_nvram_attr = {\n+static const struct bin_attribute tx4939_rtc_nvram_attr = {\n \t.attr = {\n \t\t.name = \"nvram\",\n \t\t.mode = S_IRUGO | S_IWUSR,\n","prefixes":[]}