{"id":792258,"url":"http://patchwork.ozlabs.org/api/1.2/patches/792258/?format=json","web_url":"http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20170721183627.13373-3-bpoirier@suse.com/","project":{"id":46,"url":"http://patchwork.ozlabs.org/api/1.2/projects/46/?format=json","name":"Intel Wired Ethernet development","link_name":"intel-wired-lan","list_id":"intel-wired-lan.osuosl.org","list_email":"intel-wired-lan@osuosl.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20170721183627.13373-3-bpoirier@suse.com>","list_archive_url":null,"date":"2017-07-21T18:36:25","name":"[3/5] e1000e: Fix return value test","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"e723ac999c45496dfefc41bc647233cbb3459b07","submitter":{"id":67008,"url":"http://patchwork.ozlabs.org/api/1.2/people/67008/?format=json","name":"Benjamin Poirier","email":"bpoirier@suse.com"},"delegate":{"id":68,"url":"http://patchwork.ozlabs.org/api/1.2/users/68/?format=json","username":"jtkirshe","first_name":"Jeff","last_name":"Kirsher","email":"jeffrey.t.kirsher@intel.com"},"mbox":"http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20170721183627.13373-3-bpoirier@suse.com/mbox/","series":[],"comments":"http://patchwork.ozlabs.org/api/patches/792258/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/792258/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.136; helo=silver.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=)","Received":["from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xDfcv5F1Lz9s3T\n\tfor ;\n\tSat, 22 Jul 2017 04:37:03 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id D0D982F6E6;\n\tFri, 21 Jul 2017 18:37:01 +0000 (UTC)","from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id ClRG0zJ8xuhu; Fri, 21 Jul 2017 18:36:59 +0000 (UTC)","from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby silver.osuosl.org (Postfix) with ESMTP id C17BD2F6A1;\n\tFri, 21 Jul 2017 18:36:59 +0000 (UTC)","from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\tby ash.osuosl.org (Postfix) with ESMTP id 1DDFC1C0964\n\tfor ;\n\tFri, 21 Jul 2017 18:36:57 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 162978A16E\n\tfor ;\n\tFri, 21 Jul 2017 18:36:57 +0000 (UTC)","from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id 785ro0GlZlOX for ;\n\tFri, 21 Jul 2017 18:36:56 +0000 (UTC)","from mx1.suse.de (mx2.suse.de [195.135.220.15])\n\tby hemlock.osuosl.org (Postfix) with ESMTPS id 39FE38A1FA\n\tfor ;\n\tFri, 21 Jul 2017 18:36:56 +0000 (UTC)","from relay1.suse.de (charybdis-ext.suse.de [195.135.220.254])\n\tby mx1.suse.de (Postfix) with ESMTP id 9E34FABC3;\n\tFri, 21 Jul 2017 18:36:54 +0000 (UTC)"],"X-Virus-Scanned":["amavisd-new at osuosl.org","amavisd-new at osuosl.org","by amavisd-new at test-mx.suse.de"],"X-Greylist":"domain auto-whitelisted by SQLgrey-1.7.6","From":"Benjamin Poirier ","To":"Jeff Kirsher ","Date":"Fri, 21 Jul 2017 11:36:25 -0700","Message-Id":"<20170721183627.13373-3-bpoirier@suse.com>","X-Mailer":"git-send-email 2.13.2","In-Reply-To":"<20170721183627.13373-1-bpoirier@suse.com>","References":"<20170721160937.GA22632@csclub.uwaterloo.ca>\n\t<20170721183627.13373-1-bpoirier@suse.com>","Cc":"netdev@vger.kernel.org, intel-wired-lan@lists.osuosl.org,\n\tlinux-kernel@vger.kernel.org,\n\tLennart Sorensen ","Subject":"[Intel-wired-lan] [PATCH 3/5] e1000e: Fix return value test","X-BeenThere":"intel-wired-lan@osuosl.org","X-Mailman-Version":"2.1.18-1","Precedence":"list","List-Id":"Intel Wired Ethernet Linux Kernel Driver Development\n\t","List-Unsubscribe":", \n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":", \n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"intel-wired-lan-bounces@osuosl.org","Sender":"\"Intel-wired-lan\" "},"content":"All the helpers return -E1000_ERR_PHY.\n\nSigned-off-by: Benjamin Poirier \n---\n drivers/net/ethernet/intel/e1000e/netdev.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)","diff":"diff --git a/drivers/net/ethernet/intel/e1000e/netdev.c b/drivers/net/ethernet/intel/e1000e/netdev.c\nindex 58a87134d2e5..fc6a1d9999b2 100644\n--- a/drivers/net/ethernet/intel/e1000e/netdev.c\n+++ b/drivers/net/ethernet/intel/e1000e/netdev.c\n@@ -5099,7 +5099,7 @@ static bool e1000e_has_link(struct e1000_adapter *adapter)\n \t\tbreak;\n \t}\n \n-\tif ((ret_val == E1000_ERR_PHY) && (hw->phy.type == e1000_phy_igp_3) &&\n+\tif ((ret_val == -E1000_ERR_PHY) && (hw->phy.type == e1000_phy_igp_3) &&\n \t (er32(CTRL) & E1000_PHY_CTRL_GBE_DISABLE)) {\n \t\t/* See e1000_kmrn_lock_loss_workaround_ich8lan() */\n \t\te_info(\"Gigabit has been disabled, downgrading speed\\n\");\n","prefixes":["3/5"]}