{"id":792257,"url":"http://patchwork.ozlabs.org/api/1.2/patches/792257/?format=json","web_url":"http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20170721183627.13373-2-bpoirier@suse.com/","project":{"id":46,"url":"http://patchwork.ozlabs.org/api/1.2/projects/46/?format=json","name":"Intel Wired Ethernet development","link_name":"intel-wired-lan","list_id":"intel-wired-lan.osuosl.org","list_email":"intel-wired-lan@osuosl.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20170721183627.13373-2-bpoirier@suse.com>","list_archive_url":null,"date":"2017-07-21T18:36:24","name":"[2/5] e1000e: Fix wrong comment related to link detection","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"cd083f44bda0c8e393c9a6e30d80c6c46673df9b","submitter":{"id":67008,"url":"http://patchwork.ozlabs.org/api/1.2/people/67008/?format=json","name":"Benjamin Poirier","email":"bpoirier@suse.com"},"delegate":{"id":68,"url":"http://patchwork.ozlabs.org/api/1.2/users/68/?format=json","username":"jtkirshe","first_name":"Jeff","last_name":"Kirsher","email":"jeffrey.t.kirsher@intel.com"},"mbox":"http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20170721183627.13373-2-bpoirier@suse.com/mbox/","series":[],"comments":"http://patchwork.ozlabs.org/api/patches/792257/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/792257/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Authentication-Results":"ozlabs.org;\n\tspf=pass (mailfrom) smtp.mailfrom=osuosl.org\n\t(client-ip=140.211.166.137; helo=fraxinus.osuosl.org;\n\tenvelope-from=intel-wired-lan-bounces@osuosl.org;\n\treceiver=)","Received":["from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3xDfcq6gqFz9s3T\n\tfor ;\n\tSat, 22 Jul 2017 04:36:59 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id D61D387EC9;\n\tFri, 21 Jul 2017 18:36:57 +0000 (UTC)","from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id aYqBWvf7L0m5; Fri, 21 Jul 2017 18:36:57 +0000 (UTC)","from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id 3373887B2B;\n\tFri, 21 Jul 2017 18:36:57 +0000 (UTC)","from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\tby ash.osuosl.org (Postfix) with ESMTP id AE0691C0964\n\tfor ;\n\tFri, 21 Jul 2017 18:36:55 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n\tby fraxinus.osuosl.org (Postfix) with ESMTP id A6E6687B4A\n\tfor ;\n\tFri, 21 Jul 2017 18:36:55 +0000 (UTC)","from fraxinus.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id Ibxhuv38Psz5 for ;\n\tFri, 21 Jul 2017 18:36:54 +0000 (UTC)","from mx1.suse.de (mx2.suse.de [195.135.220.15])\n\tby fraxinus.osuosl.org (Postfix) with ESMTPS id 5D41187B2B\n\tfor ;\n\tFri, 21 Jul 2017 18:36:54 +0000 (UTC)","from relay1.suse.de (charybdis-ext.suse.de [195.135.220.254])\n\tby mx1.suse.de (Postfix) with ESMTP id D55A5AC03;\n\tFri, 21 Jul 2017 18:36:52 +0000 (UTC)"],"X-Virus-Scanned":["amavisd-new at osuosl.org","amavisd-new at osuosl.org","by amavisd-new at test-mx.suse.de"],"X-Greylist":"domain auto-whitelisted by SQLgrey-1.7.6","From":"Benjamin Poirier ","To":"Jeff Kirsher ","Date":"Fri, 21 Jul 2017 11:36:24 -0700","Message-Id":"<20170721183627.13373-2-bpoirier@suse.com>","X-Mailer":"git-send-email 2.13.2","In-Reply-To":"<20170721183627.13373-1-bpoirier@suse.com>","References":"<20170721160937.GA22632@csclub.uwaterloo.ca>\n\t<20170721183627.13373-1-bpoirier@suse.com>","Cc":"netdev@vger.kernel.org, intel-wired-lan@lists.osuosl.org,\n\tlinux-kernel@vger.kernel.org,\n\tLennart Sorensen ","Subject":"[Intel-wired-lan] [PATCH 2/5] e1000e: Fix wrong comment related to\n\tlink detection","X-BeenThere":"intel-wired-lan@osuosl.org","X-Mailman-Version":"2.1.18-1","Precedence":"list","List-Id":"Intel Wired Ethernet Linux Kernel Driver Development\n\t","List-Unsubscribe":", \n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":", \n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"intel-wired-lan-bounces@osuosl.org","Sender":"\"Intel-wired-lan\" "},"content":"Reading e1000e_check_for_copper_link() shows that get_link_status is set to\nfalse after link has been detected. Therefore, it stays TRUE until then.\n\nSigned-off-by: Benjamin Poirier \n---\n drivers/net/ethernet/intel/e1000e/netdev.c | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)","diff":"diff --git a/drivers/net/ethernet/intel/e1000e/netdev.c b/drivers/net/ethernet/intel/e1000e/netdev.c\nindex 2dcb5463d9b8..58a87134d2e5 100644\n--- a/drivers/net/ethernet/intel/e1000e/netdev.c\n+++ b/drivers/net/ethernet/intel/e1000e/netdev.c\n@@ -5074,7 +5074,7 @@ static bool e1000e_has_link(struct e1000_adapter *adapter)\n \n \t/* get_link_status is set on LSC (link status) interrupt or\n \t * Rx sequence error interrupt. get_link_status will stay\n-\t * false until the check_for_link establishes link\n+\t * true until the check_for_link establishes link\n \t * for copper adapters ONLY\n \t */\n \tswitch (hw->phy.media_type) {\n@@ -5092,7 +5092,7 @@ static bool e1000e_has_link(struct e1000_adapter *adapter)\n \t\tbreak;\n \tcase e1000_media_type_internal_serdes:\n \t\tret_val = hw->mac.ops.check_for_link(hw);\n-\t\tlink_active = adapter->hw.mac.serdes_has_link;\n+\t\tlink_active = hw->mac.serdes_has_link;\n \t\tbreak;\n \tdefault:\n \tcase e1000_media_type_unknown:\n","prefixes":["2/5"]}