{"id":787391,"url":"http://patchwork.ozlabs.org/api/1.2/patches/787391/?format=json","web_url":"http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20170712094614.76501-11-alice.michael@intel.com/","project":{"id":46,"url":"http://patchwork.ozlabs.org/api/1.2/projects/46/?format=json","name":"Intel Wired Ethernet development","link_name":"intel-wired-lan","list_id":"intel-wired-lan.osuosl.org","list_email":"intel-wired-lan@osuosl.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20170712094614.76501-11-alice.michael@intel.com>","list_archive_url":null,"date":"2017-07-12T09:46:14","name":"[next,S75-V3,11/11] i40e: 25G FEC status improvements","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"43123dffd5c8f3c9aff160572965e1fd08482ca6","submitter":{"id":71123,"url":"http://patchwork.ozlabs.org/api/1.2/people/71123/?format=json","name":"Michael, Alice","email":"alice.michael@intel.com"},"delegate":{"id":68,"url":"http://patchwork.ozlabs.org/api/1.2/users/68/?format=json","username":"jtkirshe","first_name":"Jeff","last_name":"Kirsher","email":"jeffrey.t.kirsher@intel.com"},"mbox":"http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20170712094614.76501-11-alice.michael@intel.com/mbox/","series":[],"comments":"http://patchwork.ozlabs.org/api/patches/787391/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/787391/checks/","tags":{},"related":[],"headers":{"Return-Path":"<intel-wired-lan-bounces@osuosl.org>","X-Original-To":["incoming@patchwork.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Delivered-To":["patchwork-incoming@bilbo.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Received":["from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3x761m6NlHz9s71\n\tfor <incoming@patchwork.ozlabs.org>;\n\tThu, 13 Jul 2017 03:50:52 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby silver.osuosl.org (Postfix) with ESMTP id 4A7E030914;\n\tWed, 12 Jul 2017 17:50:51 +0000 (UTC)","from silver.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id 6f5XOhm15kkR; Wed, 12 Jul 2017 17:50:48 +0000 (UTC)","from ash.osuosl.org (ash.osuosl.org [140.211.166.34])\n\tby silver.osuosl.org (Postfix) with ESMTP id 3B61530919;\n\tWed, 12 Jul 2017 17:50:47 +0000 (UTC)","from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n\tby ash.osuosl.org (Postfix) with ESMTP id 94E6D1C42AB\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 12 Jul 2017 17:50:43 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n\tby hemlock.osuosl.org (Postfix) with ESMTP id 8AF3189FE8\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 12 Jul 2017 17:50:43 +0000 (UTC)","from hemlock.osuosl.org ([127.0.0.1])\n\tby localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)\n\twith ESMTP id H1kt1DtiGVm8 for <intel-wired-lan@lists.osuosl.org>;\n\tWed, 12 Jul 2017 17:50:43 +0000 (UTC)","from mga06.intel.com (mga06.intel.com [134.134.136.31])\n\tby hemlock.osuosl.org (Postfix) with ESMTPS id D9A2F89FFC\n\tfor <intel-wired-lan@lists.osuosl.org>;\n\tWed, 12 Jul 2017 17:50:42 +0000 (UTC)","from fmsmga003.fm.intel.com ([10.253.24.29])\n\tby orsmga104.jf.intel.com with ESMTP; 12 Jul 2017 10:50:42 -0700","from unknown (HELO localhost.jf.intel.com) ([10.166.16.121])\n\tby FMSMGA003.fm.intel.com with ESMTP; 12 Jul 2017 10:50:42 -0700"],"X-Virus-Scanned":["amavisd-new at osuosl.org","amavisd-new at osuosl.org"],"X-Greylist":"domain auto-whitelisted by SQLgrey-1.7.6","X-ExtLoop1":"1","X-IronPort-AV":"E=Sophos;i=\"5.40,350,1496127600\"; d=\"scan'208\";a=\"878118692\"","From":"Alice Michael <alice.michael@intel.com>","To":"alice.michael@intel.com,\n\tintel-wired-lan@lists.osuosl.org","Date":"Wed, 12 Jul 2017 05:46:14 -0400","Message-Id":"<20170712094614.76501-11-alice.michael@intel.com>","X-Mailer":"git-send-email 2.9.3","In-Reply-To":"<20170712094614.76501-1-alice.michael@intel.com>","References":"<20170712094614.76501-1-alice.michael@intel.com>","Cc":"Mariusz Stachura <mariusz.stachura@intel.com>","Subject":"[Intel-wired-lan] [next PATCH S75-V3 11/11] i40e: 25G FEC status\n\timprovements","X-BeenThere":"intel-wired-lan@osuosl.org","X-Mailman-Version":"2.1.18-1","Precedence":"list","List-Id":"Intel Wired Ethernet Linux Kernel Driver Development\n\t<intel-wired-lan.osuosl.org>","List-Unsubscribe":"<https://lists.osuosl.org/mailman/options/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=unsubscribe>","List-Archive":"<http://lists.osuosl.org/pipermail/intel-wired-lan/>","List-Post":"<mailto:intel-wired-lan@osuosl.org>","List-Help":"<mailto:intel-wired-lan-request@osuosl.org?subject=help>","List-Subscribe":"<https://lists.osuosl.org/mailman/listinfo/intel-wired-lan>, \n\t<mailto:intel-wired-lan-request@osuosl.org?subject=subscribe>","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"intel-wired-lan-bounces@osuosl.org","Sender":"\"Intel-wired-lan\" <intel-wired-lan-bounces@osuosl.org>"},"content":"From: Mariusz Stachura <mariusz.stachura@intel.com>\n\nThis patch improves the system log message. The log message will\nbe expanded to include the FEC mode the FW requested before link\nwas established.\n\nSigned-off-by: Mariusz Stachura <mariusz.stachura@intel.com>\n---\n drivers/net/ethernet/intel/i40e/i40e_main.c | 18 ++++++++++++++++--\n 1 file changed, 16 insertions(+), 2 deletions(-)","diff":"diff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c b/drivers/net/ethernet/intel/i40e/i40e_main.c\nindex 0c8c07d..fa93c63 100644\n--- a/drivers/net/ethernet/intel/i40e/i40e_main.c\n+++ b/drivers/net/ethernet/intel/i40e/i40e_main.c\n@@ -5355,6 +5355,7 @@ void i40e_print_link_message(struct i40e_vsi *vsi, bool isup)\n \tchar *speed = \"Unknown\";\n \tchar *fc = \"Unknown\";\n \tchar *fec = \"\";\n+\tchar *req_fec = \"\";\n \tchar *an = \"\";\n \n \tnew_speed = vsi->back->hw.phy.link_info.link_speed;\n@@ -5416,6 +5417,7 @@ void i40e_print_link_message(struct i40e_vsi *vsi, bool isup)\n \t}\n \n \tif (vsi->back->hw.phy.link_info.link_speed == I40E_LINK_SPEED_25GB) {\n+\t\treq_fec = \", Requested FEC: None\";\n \t\tfec = \", FEC: None\";\n \t\tan = \", Autoneg: False\";\n \n@@ -5428,10 +5430,22 @@ void i40e_print_link_message(struct i40e_vsi *vsi, bool isup)\n \t\telse if (vsi->back->hw.phy.link_info.fec_info &\n \t\t\t I40E_AQ_CONFIG_FEC_RS_ENA)\n \t\t\tfec = \", FEC: CL108 RS-FEC\";\n+\n+\t\t/* 'CL108 RS-FEC' should be displayed when RS is requested, or\n+\t\t * both RS and FC are requested\n+\t\t */\n+\t\tif (vsi->back->hw.phy.link_info.req_fec_info &\n+\t\t    (I40E_AQ_REQUEST_FEC_KR | I40E_AQ_REQUEST_FEC_RS)) {\n+\t\t\tif (vsi->back->hw.phy.link_info.req_fec_info &\n+\t\t\t    I40E_AQ_REQUEST_FEC_RS)\n+\t\t\t\treq_fec = \", Requested FEC: CL108 RS-FEC\";\n+\t\t\telse\n+\t\t\t\treq_fec = \", Requested FEC: CL74 FC-FEC/BASE-R\";\n+\t\t}\n \t}\n \n-\tnetdev_info(vsi->netdev, \"NIC Link is Up, %sbps Full Duplex%s%s, Flow Control: %s\\n\",\n-\t\t    speed, fec, an, fc);\n+\tnetdev_info(vsi->netdev, \"NIC Link is Up, %sbps Full Duplex%s%s%s, Flow Control: %s\\n\",\n+\t\t    speed, req_fec, fec, an, fc);\n }\n \n /**\n","prefixes":["next","S75-V3","11/11"]}