{"id":783285,"url":"http://patchwork.ozlabs.org/api/1.2/patches/783285/?format=json","web_url":"http://patchwork.ozlabs.org/project/linuxppc-dev/patch/20170703040152.5144-1-joel@jms.id.au/","project":{"id":2,"url":"http://patchwork.ozlabs.org/api/1.2/projects/2/?format=json","name":"Linux PPC development","link_name":"linuxppc-dev","list_id":"linuxppc-dev.lists.ozlabs.org","list_email":"linuxppc-dev@lists.ozlabs.org","web_url":"https://github.com/linuxppc/wiki/wiki","scm_url":"https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git","webscm_url":"https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/","list_archive_url":"https://lore.kernel.org/linuxppc-dev/","list_archive_url_format":"https://lore.kernel.org/linuxppc-dev/{}/","commit_url_format":"https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/commit/?id={}"},"msgid":"<20170703040152.5144-1-joel@jms.id.au>","list_archive_url":"https://lore.kernel.org/linuxppc-dev/20170703040152.5144-1-joel@jms.id.au/","date":"2017-07-03T04:01:52","name":"powerpc/powernv/idle: Put pnv_cpu_offline behind HOTPLUG_CPU","commit_ref":null,"pull_url":null,"state":"superseded","archived":true,"hash":"cf0f70106ae3c18a5d1d871474835eea0935b9c7","submitter":{"id":48628,"url":"http://patchwork.ozlabs.org/api/1.2/people/48628/?format=json","name":"Joel Stanley","email":"joel@jms.id.au"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linuxppc-dev/patch/20170703040152.5144-1-joel@jms.id.au/mbox/","series":[],"comments":"http://patchwork.ozlabs.org/api/patches/783285/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/783285/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":["patchwork-incoming@ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Received":["from lists.ozlabs.org (lists.ozlabs.org [103.22.144.68])\n\t(using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby ozlabs.org (Postfix) with ESMTPS id 3x1D582kXnz9sPN\n\tfor ;\n\tMon, 3 Jul 2017 14:03:24 +1000 (AEST)","from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 3x1D581h69zDr4g\n\tfor ;\n\tMon, 3 Jul 2017 14:03:24 +1000 (AEST)","from mail-pf0-x242.google.com (mail-pf0-x242.google.com\n\t[IPv6:2607:f8b0:400e:c00::242])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128\n\tbits)) (No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 3x1D3c1TlTzDr14\n\tfor ;\n\tMon, 3 Jul 2017 14:02:04 +1000 (AEST)","by mail-pf0-x242.google.com with SMTP id c24so9696681pfe.1\n\tfor ;\n\tSun, 02 Jul 2017 21:02:04 -0700 (PDT)","from aurora.jms.id.au ([45.124.203.19])\n\tby smtp.gmail.com with ESMTPSA id\n\tx25sm34033796pfi.58.2017.07.02.21.01.58\n\t(version=TLS1 cipher=AES128-SHA bits=128/128);\n\tSun, 02 Jul 2017 21:02:01 -0700 (PDT)","by aurora.jms.id.au (sSMTP sendmail emulation);\n\tMon, 03 Jul 2017 13:31:54 +0930"],"Authentication-Results":["ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"mUpcZH/0\"; dkim-atps=neutral","lists.ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"mUpcZH/0\"; dkim-atps=neutral","lists.ozlabs.org; dkim=pass (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"mUpcZH/0\"; dkim-atps=neutral"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=sender:from:to:cc:subject:date:message-id:mime-version\n\t:content-transfer-encoding;\n\tbh=cuHs9/ErTVcmBek7VxlxFau4tusiaCbsC9nLUjO/azY=;\n\tb=mUpcZH/0ndsYkAPTgAegCKI92cIahWCHWQTOCIqqYHSssSAMX13leAD5ySIPMlUaJo\n\tsTqBV4rUHOxOf5u8lzzQ2Ld/3aRWOmUiRXln9CQgDo/3Nyd7gw2w55cij9iw+tBQ+im9\n\tzfyu8nY6GqozieUfrTiBLZIscNwiz9kV2FnQQLeM0SPHkhVzOMNcTKeRYvxCBs1co54q\n\t8zbS14toGqEZzGUTOHxYrLjsTjM+S+h5vsuGUanyob5J+l21plwy0eQ23KahWFYjkjbb\n\t6fS5PAC/cQmMebd4bWc2sQvNyqvdvMhIp7eHgJPHUgK+SZJP/PF92L/o7QC4ptFZOX+V\n\tKqjA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:sender:from:to:cc:subject:date:message-id\n\t:mime-version:content-transfer-encoding;\n\tbh=cuHs9/ErTVcmBek7VxlxFau4tusiaCbsC9nLUjO/azY=;\n\tb=GNp5h1y3EaY1MccbGG66SLvqgBYEicvHNvRjF2fgth8szk3Ng+IUTw2XWEeZDD7dzc\n\tQJbvU9BEhrPBp+AjwMBuYKqkvI03QmvebT1PSHKZmXmZIShSk8Ir7Vnye8Lu2ZjgAbfM\n\tZEplii+pPP1nQgbAUl840queQ5X3PcdI2q4HEyUzk0DJsGHTmFXKefNoARMP8WnpnWP1\n\tIQzWD4cQ7PrBLcMW4RnFCjx9twvTBs4cOrL93UD7khS94H0mJguT+LnTx1ChYUG3T2SO\n\t5CpuBfrFToHCdm/h3jdzTXGz7egv5/Hcf4ORuZNJ66H/JPO8uzr5Ed2WoAhpYHB7g+aT\n\twMYA==","X-Gm-Message-State":"AIVw111sC1qGRLy2NNHCGeL5tG5G/HdqDMHnhO/NppBrxtJFch9KQvzZ\n\t5VS4hQ/AWq7UOw==","X-Received":"by 10.84.216.13 with SMTP id m13mr8373509pli.201.1499054522266; \n\tSun, 02 Jul 2017 21:02:02 -0700 (PDT)","From":"Joel Stanley ","To":"Michael Ellerman ,\n\t\"Gautham R . Shenoy\" ","Subject":"[PATCH] powerpc/powernv/idle: Put pnv_cpu_offline behind HOTPLUG_CPU","Date":"Mon, 3 Jul 2017 13:31:52 +0930","Message-Id":"<20170703040152.5144-1-joel@jms.id.au>","X-Mailer":"git-send-email 2.13.2","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","X-BeenThere":"linuxppc-dev@lists.ozlabs.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"Linux on PowerPC Developers Mail List\n\t","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org,\n\tstable@vger.kernel.org","Errors-To":"linuxppc-dev-bounces+patchwork-incoming=ozlabs.org@lists.ozlabs.org","Sender":"\"Linuxppc-dev\"\n\t"},"content":"In commit 900612315788 (\"powerpc/powernv/smp: Add busy-wait loop as fall back\nfor CPU-Hotplug\") the idle code uses generic_check_cpu_restart(), but that\nfunction is not available when CONFIG_HOTPLUG_CPU is disabled.\n\narch/powerpc/platforms/powernv/idle.c: In function ‘pnv_cpu_offline’:\narch/powerpc/platforms/powernv/idle.c:286:11: error: implicit declaration of\nfunction ‘generic_check_cpu_restart’ [-Werror=implicit-function-declaration]\n while (!generic_check_cpu_restart(cpu)) {\n ^~~~~~~~~~~~~~~~~~~~~~~~~\n\nThe callers of pnv_cpu_offline are behind CONFIG_HOTPLUG_CPU, so fix the build\nerror by putting this code behind the same gard.\n\nFixes: 900612315788 (\"powerpc/powernv/smp: Add busy-wait loop as fall back for CPU-Hotplug\").\nCc: # 4.12\nSigned-off-by: Joel Stanley \n---\n arch/powerpc/platforms/powernv/idle.c | 4 ++++\n 1 file changed, 4 insertions(+)","diff":"diff --git a/arch/powerpc/platforms/powernv/idle.c b/arch/powerpc/platforms/powernv/idle.c\nindex 445f30a2c5ef..b15d108db216 100644\n--- a/arch/powerpc/platforms/powernv/idle.c\n+++ b/arch/powerpc/platforms/powernv/idle.c\n@@ -261,6 +261,8 @@ static u64 pnv_deepest_stop_psscr_val;\n static u64 pnv_deepest_stop_psscr_mask;\n static bool deepest_stop_found;\n \n+#ifdef CONFIG_HOTPLUG_CPU\n+\n /*\n * pnv_cpu_offline: A function that puts the CPU into the deepest\n * available platform idle state on a CPU-Offline.\n@@ -294,6 +296,8 @@ unsigned long pnv_cpu_offline(unsigned int cpu)\n \treturn srr1;\n }\n \n+#endif /* CONFIG_HOTPLUG_CPU */\n+\n /*\n * Power ISA 3.0 idle initialization.\n *\n","prefixes":[]}