{"id":2235273,"url":"http://patchwork.ozlabs.org/api/1.2/patches/2235273/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260509005453.3984184-7-pierrick.bouvier@oss.qualcomm.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.2/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260509005453.3984184-7-pierrick.bouvier@oss.qualcomm.com>","list_archive_url":null,"date":"2026-05-09T00:54:53","name":"[v5,6/6] target-info-qom: use a single class_init for target-info-* classes","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"ed9d61b548d891a1a30f88ab7d4ad180f848a57b","submitter":{"id":93152,"url":"http://patchwork.ozlabs.org/api/1.2/people/93152/?format=json","name":"Pierrick Bouvier","email":"pierrick.bouvier@oss.qualcomm.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260509005453.3984184-7-pierrick.bouvier@oss.qualcomm.com/mbox/","series":[{"id":503469,"url":"http://patchwork.ozlabs.org/api/1.2/series/503469/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=503469","date":"2026-05-09T00:54:47","name":"single-binary: deduplicate target_info()","version":5,"mbox":"http://patchwork.ozlabs.org/series/503469/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2235273/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2235273/checks/","tags":{},"related":[],"headers":{"Return-Path":"<qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=qualcomm.com header.i=@qualcomm.com header.a=rsa-sha256\n header.s=qcppdkim1 header.b=NQzRrFKP;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com\n header.a=rsa-sha256 header.s=google header.b=Zp0ZzPVx;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4gC6xN3Sypz1yCg\n\tfor <incoming@patchwork.ozlabs.org>; Sat, 09 May 2026 10:56:08 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from <qemu-devel-bounces@nongnu.org>)\n\tid 1wLVyw-0000gV-42; Fri, 08 May 2026 20:55:50 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <pierrick.bouvier@oss.qualcomm.com>)\n id 1wLVyQ-0000Tm-8b\n for qemu-devel@nongnu.org; Fri, 08 May 2026 20:55:20 -0400","from mx0b-0031df01.pphosted.com ([205.220.180.131])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from <pierrick.bouvier@oss.qualcomm.com>)\n id 1wLVyO-0005yt-Mh\n for qemu-devel@nongnu.org; Fri, 08 May 2026 20:55:18 -0400","from pps.filterd (m0279871.ppops.net [127.0.0.1])\n by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id\n 648N7wHQ257853\n for <qemu-devel@nongnu.org>; Sat, 9 May 2026 00:55:15 GMT","from mail-dy1-f198.google.com (mail-dy1-f198.google.com\n [74.125.82.198])\n by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4e1auekkjh-1\n (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT)\n for <qemu-devel@nongnu.org>; Sat, 09 May 2026 00:55:15 +0000 (GMT)","by mail-dy1-f198.google.com with SMTP id\n 5a478bee46e88-2f485961555so7056605eec.1\n for <qemu-devel@nongnu.org>; Fri, 08 May 2026 17:55:15 -0700 (PDT)","from hu-pbouvier-lv.qualcomm.com (Global_NAT1.qualcomm.com.\n [129.46.96.20]) by smtp.gmail.com with ESMTPSA id\n 5a478bee46e88-2f888c3b301sm5352610eec.23.2026.05.08.17.55.12\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Fri, 08 May 2026 17:55:12 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h=\n cc:content-transfer-encoding:date:from:in-reply-to:message-id\n :mime-version:references:subject:to; s=qcppdkim1; bh=EqWj9/dq2Uc\n CMjZDn8X5RDV+nwKrGwJ6F1azjrIAg+o=; b=NQzRrFKPwGwrPo5MUbx8jjSoYQJ\n 32aOiruPL6CaoH6n/nEhHh63kA2/kdchAkpmEXTNvWF5mpJ5/OpjkChEYDeUcGAz\n ardwXSaM59Zj513LJaI8hCaCpHtO2QviQvtpUskVhQgq0GLYBuyJl76d1GYFvcYu\n awkmrAEYIzFGwOCrU3oKWRnnF5n/OSn6KkCfIQdldWR8XWEuwBSWOyxKzFCw8adK\n 8PUFeiqtTMenRotYdDdy+nZ7MXXfHzbqmXJbtZjLixhqTFjDKbTQk6pMKVHzoTSa\n 2dJtPr7bTHI5k6HX8DbY5+CaAaM+T3NOPVZall93ABITXMB5M7SBL0sa9Ww==","v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=oss.qualcomm.com; s=google; t=1778288114; x=1778892914; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=EqWj9/dq2UcCMjZDn8X5RDV+nwKrGwJ6F1azjrIAg+o=;\n b=Zp0ZzPVx9IzgCLZhkfe9Xveo1N9HIsPdoF0Pa2e9Zuo2840/y/iB1akMbuuRg5yc7L\n ti3t3gs+NNmvXH9Q4x9MRYiOLgtdSrXdN0uKMqUUcfnIVWfxDK+D0Jh+kaKUwLjlDh7J\n SuG/n/YuFxV5kqYzXgLokJbp1EWTSi5NlBhOliIbzYNOogyOQLUJ/LP1q26jrWxiAO8K\n G/c2o7KebTUJP6ctNUzqUxeSR0YAC71rBK06TVD53pbjiZxto/tnfGFxYVOWxopQ0ThE\n lNTTEQCR5F582NTtJRA2AV4uSm+fIQV7KlhoDFlkgOzlb/ZhTTYgA1ZK6dabbtv8Fw5V\n xT6w=="],"X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1778288114; x=1778892914;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=EqWj9/dq2UcCMjZDn8X5RDV+nwKrGwJ6F1azjrIAg+o=;\n b=oNY/h2YFsHG4DgQMNHmKYilj6wOSdKln2Lqxyks3JjGuE+1L8Hq3k1kViN/3pMiXKU\n edyMMtz0scmxSCttguMWz3rkx+zFTF/eGTxXGf6Onxkv0B3DOUSEhU8sUsnJiAU/EvUm\n lDdfBkGm2qJi6ITtux22BtWSIcVZMinOoYiOLvASuA1PaHa+yxqrdRxs/BUSXMioL4kB\n 5rTXZhBUZfDdd4akgNR7CcKsIOaH1HIVYRZdnP/3y+pOBvDOQd/8+zuYWiuH1DGM9h7c\n q5vtWza9FCN2rmxK8Us5HSSMbnyCiJbWEB21Yi1996ox5BZ+W1RLgFkzxDq/uoa4EZo8\n DhXg==","X-Gm-Message-State":"AOJu0YxLKqAwkuHjntcyTb4JK8orkfPD4rm4b+Uch7C1Aq4l+gVydddN\n 2kUQREYjyPHQda7ovaJRudgb5bsBx+3k5TNa9bC/8plAW1RktYS/Bhzaq/27i0eWgLnvNnDepH5\n 5wQb0QmAX73puTVjuv2SJndsMjCeHFMY2GBlsvQTnGEuMplDMucSvs+EoIrWLqcEtmsEU","X-Gm-Gg":"Acq92OFETJUmBk1SMj/5oZf/Gme6UxMZhERewD3OWhKgegeRF9850qk2hUayS5I7BtJ\n l+7Ip6He8rH81us5HXOkn5YnwNZGIQHeyI3gokHHtJKxvSmVWc5+QDokeMGdnsvq99hMFWcylYM\n J55tWHYFCt0VGwN1XmfnnG2UM3ATV8TdhFwBTSag2OaWytJDdHbWhQoL0feryTN1Dxu3kVbXUwR\n Y02B6iemIDS5BXEC98kwwuvzv7xBQkQlXsddUR2uy8oJlYPDdE+7pKN6ZOgggNiijbtoCVtSSyf\n RuqRJrHsbLC3KG3I0ZwS+JnOYo8Ir4HNJUfXtbl8k8fdFCOQagjcdNh/AoB5cNC24XsTAhUsnhM\n rWgltY9kxQvhQKRbqqmTNCQ/04Qg1vXTaQHux+DMjPX8rz21AS0bCBQnHeKCwzLz2zAsCrCNFFr\n 3z0GyVzg==","X-Received":["by 2002:a05:7301:1687:b0:2ed:7e1:975 with SMTP id\n 5a478bee46e88-2fb3dbf9718mr215135eec.1.1778288114101;\n Fri, 08 May 2026 17:55:14 -0700 (PDT)","by 2002:a05:7301:1687:b0:2ed:7e1:975 with SMTP id\n 5a478bee46e88-2fb3dbf9718mr215118eec.1.1778288113561;\n Fri, 08 May 2026 17:55:13 -0700 (PDT)"],"From":"Pierrick Bouvier <pierrick.bouvier@oss.qualcomm.com>","To":"qemu-devel@nongnu.org","Cc":"Richard Henderson <richard.henderson@linaro.org>, =?utf-8?q?Daniel_P=2E_?=\n\t=?utf-8?q?Berrang=C3=A9?= <berrange@redhat.com>, =?utf-8?q?Marc-Andr=C3=A9_?=\n\t=?utf-8?q?Lureau?= <marcandre.lureau@redhat.com>,\n Markus Armbruster <armbru@redhat.com>, Max Filippov <jcmvbkbc@gmail.com>,\n Paolo Bonzini <pbonzini@redhat.com>,\n =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= <philmd@linaro.org>,\n Pierrick Bouvier <pierrick.bouvier@oss.qualcomm.com>,\n Anton Johansson <anjo@rev.ng>","Subject":"[PATCH v5 6/6] target-info-qom: use a single class_init for\n target-info-* classes","Date":"Fri,  8 May 2026 17:54:53 -0700","Message-ID":"<20260509005453.3984184-7-pierrick.bouvier@oss.qualcomm.com>","X-Mailer":"git-send-email 2.43.0","In-Reply-To":"<20260509005453.3984184-1-pierrick.bouvier@oss.qualcomm.com>","References":"<20260509005453.3984184-1-pierrick.bouvier@oss.qualcomm.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-Proofpoint-Spam-Details-Enc":"AW1haW4tMjYwNTA5MDAwNiBTYWx0ZWRfXym5VHBwU6LNE\n Husk8KCpVdekKrio21C3C/f7yGbkHWIVAlMhT4xO+Tu4vz2HD3y2rRuVraAA66207d4K24AhVn8\n jL2qduOAzc7sjJIo9EA9vjt86lOLWOfBD2H5SZzfo3dXvf9obe4NzcbcukMZlDzl+yYuOImCjkk\n 4v6JTpzBEfvgd5m7kBqd2A0+cuyctlJmTncOohGhXqbJi9p2a0wxWv9JfYAaPsNkpIKJ25zxAsc\n Uslx4mBYgSimvTfCSxJ6KqC1Kx5yx9gla9CeHaeg1Tn6Q7Jy74IUgY86uYRfMB+k0WXqSBmLM/p\n T4kWeeRCXv286UcF3XJiMu4ypulVJI0gp8sF9qfzJdx7AfKKQtUxudfJdMg5zARpr9RFbF9tRXX\n MSi0pQJO2HU97f1jHtjhqTVsA/BWNKzTcEDrenq3MUzDhcqfyHAlrRep3w+43+vZhhuTWfwFOEq\n Jce0gQBxzqsmHw2lHfw==","X-Proofpoint-GUID":"IMgB8tJgEpCiZstKI3c_DWORWmLmPKFJ","X-Proofpoint-ORIG-GUID":"IMgB8tJgEpCiZstKI3c_DWORWmLmPKFJ","X-Authority-Analysis":"v=2.4 cv=fcydDUQF c=1 sm=1 tr=0 ts=69fe85f3 cx=c_pps\n a=wEP8DlPgTf/vqF+yE6f9lg==:117 a=ouPCqIW2jiPt+lZRy3xVPw==:17\n a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22\n a=u7WPNUs3qKkmUXheDGA7:22 a=3WHJM1ZQz_JShphwDgj5:22 a=KKAkSRfTAAAA:8\n a=EUspDBNiAAAA:8 a=ilk2Vr1kweFqPRpfcZEA:9 a=bBxd6f-gb0O0v-kibOvt:22\n a=cvBusfyB2V15izCimMoJ:22","X-Proofpoint-Virus-Version":"vendor=baseguard\n engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49\n definitions=2026-05-09_01,2026-05-08_02,2025-10-01_01","X-Proofpoint-Spam-Details":"rule=outbound_notspam policy=outbound score=0\n malwarescore=0 spamscore=0 bulkscore=0 lowpriorityscore=0 phishscore=0\n priorityscore=1501 impostorscore=0 adultscore=0 clxscore=1015 suspectscore=0\n classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0\n reason=mlx scancount=1 engine=8.22.0-2604200000 definitions=main-2605090006","Received-SPF":"pass client-ip=205.220.180.131;\n envelope-from=pierrick.bouvier@oss.qualcomm.com;\n helo=mx0b-0031df01.pphosted.com","X-Spam_score_int":"-27","X-Spam_score":"-2.8","X-Spam_bar":"--","X-Spam_report":"(-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development <qemu-devel.nongnu.org>","List-Unsubscribe":"<https://lists.nongnu.org/mailman/options/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>","List-Archive":"<https://lists.nongnu.org/archive/html/qemu-devel>","List-Post":"<mailto:qemu-devel@nongnu.org>","List-Help":"<mailto:qemu-devel-request@nongnu.org?subject=help>","List-Subscribe":"<https://lists.nongnu.org/mailman/listinfo/qemu-devel>,\n <mailto:qemu-devel-request@nongnu.org?subject=subscribe>","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"Instead of defining a class_init per class, just use a common\nconstructor and set class_data to corresponding TargetInfo structure.\n\nSuggested-by: Richard Henderson <richard.henderson@linaro.org>\nSigned-off-by: Pierrick Bouvier <pierrick.bouvier@oss.qualcomm.com>\n---\n include/qemu/target-info-init.h | 14 ++------------\n include/qemu/target-info-qom.h  |  1 +\n target-info-qom.c               |  6 ++++++\n 3 files changed, 9 insertions(+), 12 deletions(-)","diff":"diff --git a/include/qemu/target-info-init.h b/include/qemu/target-info-init.h\nindex 176fd975a16..3945f2998e0 100644\n--- a/include/qemu/target-info-init.h\n+++ b/include/qemu/target-info-init.h\n@@ -37,8 +37,6 @@ const TargetInfo *target_info(void)     \\\n #include \"qemu/target-info-qom.h\"\n #include \"qom/object.h\"\n \n-#define TYPE_TARGET_INFO_TARGET TYPE_TARGET_INFO\"-\"TARGET_NAME\n-\n typedef struct TargetInfoQomTarget {\n     TargetInfoQom parent;\n } TargetInfoQomTarget;\n@@ -47,24 +45,16 @@ typedef struct TargetInfoQomTargetClass {\n     TargetInfoQomClass parent_class;\n } TargetInfoQomTargetClass;\n \n-OBJECT_DECLARE_TYPE(TargetInfoQomTarget, TargetInfoQomTargetClass, TARGET_INFO_TARGET)\n-\n #define target_info_init(ti_var)                                            \\\n-static void target_info_qom_class_init(ObjectClass *oc, const void * data)  \\\n-{                                                                           \\\n-    TargetInfoQomTargetClass *klass = TARGET_INFO_TARGET_CLASS(oc);         \\\n-    klass->parent_class.target_info = &ti_var;                              \\\n-}                                                                           \\\n-                                                                            \\\n static const TypeInfo target_info_qom_target_type_info = {                  \\\n-    .name = TYPE_TARGET_INFO_TARGET,                                        \\\n+    .name =  TYPE_TARGET_INFO\"-\"TARGET_NAME,                                \\\n     .parent = TYPE_TARGET_INFO,                                             \\\n     .instance_size = sizeof(TargetInfoQomTarget),                           \\\n     .class_size = sizeof(TargetInfoQomTargetClass),                         \\\n     .class_init = target_info_qom_class_init,                               \\\n+    .class_data = &ti_var,                                                  \\\n     .abstract = false,                                                      \\\n };                                                                          \\\n-                                                                            \\\n DEFINE_TARGET_INFO_TYPE(target_info_qom_target_type_info)\n \n #endif /* CONFIG_USER_ONLY */\ndiff --git a/include/qemu/target-info-qom.h b/include/qemu/target-info-qom.h\nindex 91be415ed33..a37c3e101e0 100644\n--- a/include/qemu/target-info-qom.h\n+++ b/include/qemu/target-info-qom.h\n@@ -25,6 +25,7 @@ typedef struct TargetInfoQomClass {\n \n OBJECT_DECLARE_TYPE(TargetInfoQom, TargetInfoQomClass, TARGET_INFO)\n \n+void target_info_qom_class_init(ObjectClass *oc, const void * data);\n void target_info_qom_set_target(void);\n \n #endif /* QEMU_TARGET_INFO_QOM_H */\ndiff --git a/target-info-qom.c b/target-info-qom.c\nindex cc470b3b4d6..5b0498ca654 100644\n--- a/target-info-qom.c\n+++ b/target-info-qom.c\n@@ -37,6 +37,12 @@ static const TypeInfo target_info_parent_type = {\n \n DEFINE_TARGET_INFO_TYPE(target_info_parent_type)\n \n+void target_info_qom_class_init(ObjectClass *oc, const void * data)\n+{\n+    TargetInfoQomClass *klass = TARGET_INFO_CLASS(oc);\n+    klass->target_info = data;\n+}\n+\n static const TargetInfo *target_info_ptr;\n \n const TargetInfo *target_info(void)\n","prefixes":["v5","6/6"]}