{"id":2235148,"url":"http://patchwork.ozlabs.org/api/1.2/patches/2235148/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260508162013.2751001-2-peter.maydell@linaro.org/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.2/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260508162013.2751001-2-peter.maydell@linaro.org>","list_archive_url":null,"date":"2026-05-08T16:20:10","name":"[1/4] hw/misc/bcm2835_control.c: Don't assert on local timer zero reload value","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"2756bc9289a77715758724cac629e56f4a958dd7","submitter":{"id":5111,"url":"http://patchwork.ozlabs.org/api/1.2/people/5111/?format=json","name":"Peter Maydell","email":"peter.maydell@linaro.org"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260508162013.2751001-2-peter.maydell@linaro.org/mbox/","series":[{"id":503418,"url":"http://patchwork.ozlabs.org/api/1.2/series/503418/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=503418","date":"2026-05-08T16:20:09","name":"hw: Fix some minor arm buglets","version":1,"mbox":"http://patchwork.ozlabs.org/series/503418/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2235148/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2235148/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256\n header.s=google header.b=NYw2bYXc;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4gBvWq19XCz1yCg\n\tfor ; Sat, 09 May 2026 02:21:43 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wLNw6-0001LK-9I; Fri, 08 May 2026 12:20:22 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wLNw4-0001Kh-Dj\n for qemu-devel@nongnu.org; Fri, 08 May 2026 12:20:20 -0400","from mail-wr1-x433.google.com ([2a00:1450:4864:20::433])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from )\n id 1wLNw2-0000wr-JT\n for qemu-devel@nongnu.org; Fri, 08 May 2026 12:20:20 -0400","by mail-wr1-x433.google.com with SMTP id\n ffacd0b85a97d-44b330c5cc6so1583975f8f.1\n for ; Fri, 08 May 2026 09:20:18 -0700 (PDT)","from lanath.. (wildly.archaic.org.uk. [81.2.115.145])\n by smtp.gmail.com with ESMTPSA id\n ffacd0b85a97d-4548ec6aea4sm6226998f8f.10.2026.05.08.09.20.15\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Fri, 08 May 2026 09:20:15 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=linaro.org; s=google; t=1778257217; x=1778862017; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=tHeQ0RvfaPoCSBPza9VvcReWRUsEKtq1mtgPNpsP4iY=;\n b=NYw2bYXcgJY91FHw2170YC3WXihz6tI/AhHejIGCchsojN2K1KhOYoLKpdKSONmlc6\n rDRmOS8WhMgln8o2hU/GjWULUzEqiUk7xolA9qJhDT+hyyS0cMfEEYcImQDz/x5/AEkO\n b8EaNbX7AmsKEl4KSVE3DeeVYj2+a1yS2ffnAqvoaAuHc18HVKHw49+pxmeczSNTzv/x\n mT93zScdqYZ2P5fwbznN08mY+FVYou41RjXSvsaPfULufY7Ll4+zqtBkjiSZvf55ID5O\n 4c0KrSHCf/LG3Xfhr8dS3M6vHw52zqZyPLnzPUGG5gT69cC/ELEOmRLfRulTDaihoSI7\n 9Orw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1778257217; x=1778862017;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=tHeQ0RvfaPoCSBPza9VvcReWRUsEKtq1mtgPNpsP4iY=;\n b=MiLpE7EwmtaAoYgOiTqBPE09ikiEk4XRyC6kuKm9p6E27V1YMFPbNTj7qhX6wQIn/W\n jkXk4XeKHolIPtC+P0iyqKhBdMTpcZ7FyNMWbomuUaO1v1CpVDZN2zqgnpHaecqgwsx5\n HSQPUNqdSNHC70hV50PvAQfeA8U5clFtHfHPtLfVIlp1qXWG/MBAiUx4ySxdSCwuX+7t\n bEOXme+zbVCyodAR+E1NQ6FAkEwo84/lclf555T66ujbTwvGsujmJOp6bYmnRshOTr6A\n 9I1eYxGv+9DIaiwhJqsZasYX9ncD5uOVjzcpEDjMxVIKynEroPmk4thLvp4Bp76gGiTt\n a2qg==","X-Forwarded-Encrypted":"i=1;\n AFNElJ/Na/eSf//Ztz3o0jQjmz4G/pz0xQ5hufnk7y2eu9CrdOqC2X/MxyQ1OC7K6qRiP3YcEMMA7IrwloQp@nongnu.org","X-Gm-Message-State":"AOJu0Ywvq8EVH1jXhy7xG26W1e9/0XXmqanOTOAhX/4uYatUCdGPVLsq\n wCXUwkYOu7QSpIbBXEGvk9xANL+jKqjhoLOE0Bob8mVMNbeUaY8CDI9LBWrWx72h3Rs=","X-Gm-Gg":"Acq92OHVVsnf3+THeh+t5ciAYe9n6sZ4gAhAVDLRlrre8p3ISEX5DUh/6eyWHjaNHpL\n jDn3KIPher5txlNRXvTm02cj8f3Hp4dyXUQ0mE/wJnbdFOJK9W5QLEpC1d1Uf2+2hzO4X3yQ7F6\n MAZYKOFApI49wyZLQCwF0LenStROwb6VGBYyWihBl9e2iyvi8uKiIaKUiibWu0z64UT8+e2X5X3\n QE+uln4utocxv+5qa1rTbJLqSqfGTUGze2xcvJlRMye5XgfPIYWKJviY4Jwi4NpUtHaeKehHIGY\n UqD7a8viYCr1T9pziMEN16J0bkMnMdpd5P7BGuIYvn37eW1RxKpr4oheJJmDGvQFZs/vTGJyxCY\n BSMreXb+OvrVg2zjIIYDexgo+oY4HrtHFJr14JhaVnBbR1g8mwP4suiIfvJ+P6ZRgmi/4JeH1J3\n ISgGQjcGS1lmBHKMIXNU5hnBeXLzKuDi16VI9V0nKZtyDot9Qa/MzDzgjmRAv2Q+aPUX5iWXu3j\n JBhyPDoAMWIS32GJ5cNqcq49hYodJI=","X-Received":"by 2002:a5d:5d03:0:b0:441:1c95:17e7 with SMTP id\n ffacd0b85a97d-4515b5243efmr20254181f8f.15.1778257216862;\n Fri, 08 May 2026 09:20:16 -0700 (PDT)","From":"Peter Maydell ","To":"qemu-arm@nongnu.org,\n\tqemu-devel@nongnu.org","Cc":"=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ","Subject":"[PATCH 1/4] hw/misc/bcm2835_control.c: Don't assert on local timer\n zero reload value","Date":"Fri, 8 May 2026 17:20:10 +0100","Message-ID":"<20260508162013.2751001-2-peter.maydell@linaro.org>","X-Mailer":"git-send-email 2.43.0","In-Reply-To":"<20260508162013.2751001-1-peter.maydell@linaro.org>","References":"<20260508162013.2751001-1-peter.maydell@linaro.org>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=2a00:1450:4864:20::433;\n envelope-from=peter.maydell@linaro.org; helo=mail-wr1-x433.google.com","X-Spam_score_int":"-20","X-Spam_score":"-2.1","X-Spam_bar":"--","X-Spam_report":"(-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"The bcm2836 local timer has a basic \"counts down, fires at zero,\nand reloads to programmed value to count down again\" functionality,\nas documented in\nhttps://www.raspberrypi.org/documentation/hardware/raspberrypi/bcm2836/QA7_rev3.4.pdf\n\nThe documentation is very sparse and doesn't say what actually\nhappens if the guest programs the reload value to zero. Currently we\ntrip an assert in this case.\n\nInstead, log this as a guest error and disable the timer (which seems\na reasonable guess -- effectively the timer will stop counting).\n\nResolves: https://gitlab.com/qemu-project/qemu/-/work_items/3395\nSigned-off-by: Peter Maydell \n---\n hw/intc/bcm2836_control.c | 15 ++++++++++++---\n 1 file changed, 12 insertions(+), 3 deletions(-)","diff":"diff --git a/hw/intc/bcm2836_control.c b/hw/intc/bcm2836_control.c\nindex f1deafaf7a..d6c6057cd2 100644\n--- a/hw/intc/bcm2836_control.c\n+++ b/hw/intc/bcm2836_control.c\n@@ -197,12 +197,21 @@ static void bcm2836_control_local_timer_set_next(void *opaque)\n {\n BCM2836ControlState *s = opaque;\n uint64_t next_event;\n+ uint64_t reload_value = LOCALTIMER_VALUE(s->local_timer_control);\n \n- assert(LOCALTIMER_VALUE(s->local_timer_control) > 0);\n+ if (reload_value == 0) {\n+ /*\n+ * Spec doesn't say what happens in this case; treat as a\n+ * guest error and stop the timer running.\n+ */\n+ qemu_log_mask(LOG_GUEST_ERROR, \"%s: local timer reload value is 0\\n\",\n+ __func__);\n+ timer_del(&s->timer);\n+ return;\n+ }\n \n next_event = qemu_clock_get_ns(QEMU_CLOCK_VIRTUAL) +\n- muldiv64(LOCALTIMER_VALUE(s->local_timer_control),\n- NANOSECONDS_PER_SECOND, LOCALTIMER_FREQ);\n+ muldiv64(reload_value, NANOSECONDS_PER_SECOND, LOCALTIMER_FREQ);\n timer_mod(&s->timer, next_event);\n }\n \n","prefixes":["1/4"]}