{"id":2235098,"url":"http://patchwork.ozlabs.org/api/1.2/patches/2235098/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260508-mips-octeon-missing-insns-v2-v3-7-bcbec96357d9@gmail.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.2/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260508-mips-octeon-missing-insns-v2-v3-7-bcbec96357d9@gmail.com>","list_archive_url":null,"date":"2026-05-08T15:12:07","name":"[v3,07/32] target/mips: add Octeon multiplier state","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"93825538f90150de4480a266d46e3d90633a68f4","submitter":{"id":66301,"url":"http://patchwork.ozlabs.org/api/1.2/people/66301/?format=json","name":"James Hilliard","email":"james.hilliard1@gmail.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260508-mips-octeon-missing-insns-v2-v3-7-bcbec96357d9@gmail.com/mbox/","series":[{"id":503407,"url":"http://patchwork.ozlabs.org/api/1.2/series/503407/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=503407","date":"2026-05-08T15:12:00","name":"target/mips: add missing Octeon user-mode support","version":3,"mbox":"http://patchwork.ozlabs.org/series/503407/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2235098/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2235098/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=l+e2XteY;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4gBt2v1wHZz1yKd\n\tfor ; Sat, 09 May 2026 01:15:03 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wLMtY-0002oQ-Qt; Fri, 08 May 2026 11:13:40 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wLMt2-0002c6-Bm\n for qemu-devel@nongnu.org; Fri, 08 May 2026 11:13:08 -0400","from mail-oo1-xc33.google.com ([2607:f8b0:4864:20::c33])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from )\n id 1wLMt0-0001dQ-L3\n for qemu-devel@nongnu.org; Fri, 08 May 2026 11:13:08 -0400","by mail-oo1-xc33.google.com with SMTP id\n 006d021491bc7-66ee7b9af94so929110eaf.0\n for ; Fri, 08 May 2026 08:13:06 -0700 (PDT)","from\n 1.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.ip6.arpa\n (71-218-113-237.hlrn.qwest.net. [71.218.113.237])\n by smtp.gmail.com with ESMTPSA id\n 586e51a60fabf-43557109b7dsm1897904fac.5.2026.05.08.08.13.04\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Fri, 08 May 2026 08:13:04 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20251104; t=1778253185; x=1778857985; darn=nongnu.org;\n h=cc:to:in-reply-to:references:message-id:content-transfer-encoding\n :mime-version:subject:date:from:from:to:cc:subject:date:message-id\n :reply-to; bh=sHgtjD14wO1k4IMIvHt33UoGD2X3GvWB8k5KsdzFV88=;\n b=l+e2XteYDP6dSpBNd02SLDyC7CCW0BMbJUCeoMrb3TYr4oDK6oHFuZqV5D2L96YMTr\n /1jP7RrIGHlDt1Iam4OEMIpjZpUfnfCpjYP7TkZxePsnYVDTJC4TtMog8CRr9Vhlv71k\n U+IPzxrZdBcJGNklvMoyymUyQ4iGz04xE3XMPwiy5U9gEnVPt1SwrNdfgHIE9+4+qAdN\n jKrXroNDccEGpWWDlIbnmn0xAy+2pymBJADR4rzs42A01L9Rq8O7XJ/byGREcDMESXX8\n FEmcAs1VReWyaC39hdI6+mktihhp5S6ORdpqWsdmG+xkNNzdCj0EizDdG5UClmbzSB2e\n p2Rg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1778253185; x=1778857985;\n h=cc:to:in-reply-to:references:message-id:content-transfer-encoding\n :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to\n :cc:subject:date:message-id:reply-to;\n bh=sHgtjD14wO1k4IMIvHt33UoGD2X3GvWB8k5KsdzFV88=;\n b=oqAFVNaSuESkLVglzkTbLVrjlGDCZ4eqmviiAwgoGWk8pQ0vHlxT3RJQl+YwA0Trgu\n BzbLf0xAt+nxxQNdmdphRLNqlki1jClpcthHSZAxhXcSm91FnfuwXKPhBkmgRGGYbZ9O\n Bme6imHrzJqHK5k8djukf+kPs9ulEdg/ZIFTmU4qeW6TtvG54rTK4AfHXbqrsh009mRY\n +LMGDAZfp2WGcYx+DOPxm3TMhYXtXvdC3T3M6BJERKAc9IPXqDEDDn5En+Xi0wRGpPhH\n tK3743Cm3cHS/F1vDPm2rr6ugU7UAb10Hn010pfM9YISil2Iw5Pu+JbEqowuTMkN/0jI\n x23g==","X-Gm-Message-State":"AOJu0YwojCuW73trs7RzVNDm++TAZC9xcJfz+I+9Tr5VBpmFdHL8XBoS\n 7ZAHpaon0iijXOSp1sf2YR3Qf+zCxI9RFTHAkSKMjfxKJFsBmn1vqSyrcQ2Kpw==","X-Gm-Gg":"AeBDiev9x7xhY9u7Vr8/rMMddzXO0XxO2kyPwCvgaaBZyMmTkIhPmwXWxCgLI6fd126\n 1rBqNwZ3FqUus10s0h218ZlUV8j2NZdXjJsml6XIHfJawlgjNvNMP/4P8a/pGUXY0cO23TOeRd0\n C4e8OdomYgbeTiouOALotHF4XM1J+k1p5/ZdhzehqLQhoRHdHLUr9SUWgXgwRVKkDo5adofhKMG\n XTu9uQH7rkka4Z06phgVm+vsADWH8/c2IkZInlh5Xh2Jf2U6O7X0z+5VPV7zmddmTUYhh4T+0bF\n mTqc92Qex+GmfAGci+yM18mQGhe/CRmErQttPQtqZ3X3RrOzFryqFLG+JsGn73PKgYDvddAZM5k\n pV6xIrGbcL3CDSfD2/4+5Ej1wlIJeEjAKYDNimbGBSwBtyUhrsqoIlTioOP6Ga+mupjF0/S+uJf\n xHNbs1zz7VvminOMvg6OKGQXuqIqnkD8daiJxQC1FVTTp3uF0su3zPLTnu2/aZskaO+GDSa2R7s\n FA9BGqaNvmT0lask1lAQChpCKzXBEsljp9GKJhOtBXJpBqHGaz/k86P3RQT4EJWuOF5pZFDm77Y\n P2cBGYSYtGL2t2SyP7a8Wzmc0FbaQE4hEDHa2ZpbnWxPgiD8kXgG2uXlGtqg6X27kJWI32oCbxl\n 6SWG7lw==","X-Received":"by 2002:a05:6820:1529:b0:686:48b7:d822 with SMTP id\n 006d021491bc7-69998d2e673mr7034841eaf.39.1778253185173;\n Fri, 08 May 2026 08:13:05 -0700 (PDT)","From":"James Hilliard ","Date":"Fri, 08 May 2026 09:12:07 -0600","Subject":"[PATCH v3 07/32] target/mips: add Octeon multiplier state","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"7bit","Message-Id":"\n <20260508-mips-octeon-missing-insns-v2-v3-7-bcbec96357d9@gmail.com>","References":"\n <20260508-mips-octeon-missing-insns-v2-v3-0-bcbec96357d9@gmail.com>","In-Reply-To":"\n <20260508-mips-octeon-missing-insns-v2-v3-0-bcbec96357d9@gmail.com>","To":"qemu-devel@nongnu.org","Cc":"Laurent Vivier , =?utf-8?q?Philippe_Mathieu-Daud?=\n\t=?utf-8?q?=C3=A9?= ,\n Aurelien Jarno ,\n Jiaxun Yang ,\n Aleksandar Rikalo , Huacai Chen ,\n James Hilliard , Helge Deller ,\n Pierrick Bouvier ,\n Pierrick Bouvier ","X-Mailer":"b4 0.15.2","Received-SPF":"pass client-ip=2607:f8b0:4864:20::c33;\n envelope-from=james.hilliard1@gmail.com; helo=mail-oo1-xc33.google.com","X-Spam_score_int":"-17","X-Spam_score":"-1.8","X-Spam_bar":"-","X-Spam_report":"(-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"Add per-thread Octeon multiplier state for the MPL and P limb banks used\nby the VMULU/VMM0/V3MULU instruction family.\n\nKeep the storage in uint64_t arrays and migrate it as an Octeon-only\nsubsection, so later instruction patches can update the architectural\nmultiplier state without mixing state layout changes with decode support.\n\nSigned-off-by: James Hilliard \n---\nChanges v2 -> v3:\n - Split the multiplier state out of the combined Octeon arithmetic and\n memory instruction patch. (requested by Richard Henderson)\n---\n target/mips/cpu.h | 4 ++++\n target/mips/system/machine.c | 33 +++++++++++++++++++++++++++++++++\n 2 files changed, 37 insertions(+)","diff":"diff --git a/target/mips/cpu.h b/target/mips/cpu.h\nindex 84d12b77f9..c6d75c67ab 100644\n--- a/target/mips/cpu.h\n+++ b/target/mips/cpu.h\n@@ -497,6 +497,10 @@ struct TCState {\n target_ulong CP0_TCScheFBack;\n int32_t CP0_Debug_tcstatus;\n target_ulong CP0_UserLocal;\n+ struct {\n+ uint64_t MPL[2 * 3];\n+ uint64_t P[2 * 3];\n+ } octeon;\n \n int32_t msacsr;\n \ndiff --git a/target/mips/system/machine.c b/target/mips/system/machine.c\nindex 5880b401b0..d6d6c23ad2 100644\n--- a/target/mips/system/machine.c\n+++ b/target/mips/system/machine.c\n@@ -120,6 +120,17 @@ static const VMStateDescription vmstate_inactive_tc = {\n .fields = vmstate_tc_fields\n };\n \n+static const VMStateDescription vmstate_octeon_multiplier_tc = {\n+ .name = \"cpu/tc/octeon_multiplier\",\n+ .version_id = 1,\n+ .minimum_version_id = 1,\n+ .fields = (const VMStateField[]) {\n+ VMSTATE_UINT64_ARRAY(octeon.MPL, TCState, 2 * 3),\n+ VMSTATE_UINT64_ARRAY(octeon.P, TCState, 2 * 3),\n+ VMSTATE_END_OF_LIST()\n+ }\n+};\n+\n /* MVP state */\n \n static const VMStateDescription vmstate_mvp = {\n@@ -247,6 +258,27 @@ static const VMStateDescription mips_vmstate_timer = {\n }\n };\n \n+static bool mips_octeon_needed(void *opaque)\n+{\n+ MIPSCPU *cpu = opaque;\n+\n+ return cpu->env.insn_flags & INSN_OCTEON;\n+}\n+\n+static const VMStateDescription mips_vmstate_octeon_multiplier = {\n+ .name = \"cpu/octeon_multiplier\",\n+ .version_id = 1,\n+ .minimum_version_id = 1,\n+ .needed = mips_octeon_needed,\n+ .fields = (const VMStateField[]) {\n+ VMSTATE_STRUCT(env.active_tc, MIPSCPU, 1,\n+ vmstate_octeon_multiplier_tc, TCState),\n+ VMSTATE_STRUCT_ARRAY(env.tcs, MIPSCPU, MIPS_SHADOW_SET_MAX, 1,\n+ vmstate_octeon_multiplier_tc, TCState),\n+ VMSTATE_END_OF_LIST()\n+ }\n+};\n+\n const VMStateDescription vmstate_mips_cpu = {\n .name = \"cpu\",\n .version_id = 21,\n@@ -363,6 +395,7 @@ const VMStateDescription vmstate_mips_cpu = {\n },\n .subsections = (const VMStateDescription * const []) {\n &mips_vmstate_timer,\n+ &mips_vmstate_octeon_multiplier,\n NULL\n }\n };\n","prefixes":["v3","07/32"]}