{"id":2235085,"url":"http://patchwork.ozlabs.org/api/1.2/patches/2235085/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260508-mips-octeon-missing-insns-v2-v3-12-bcbec96357d9@gmail.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.2/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260508-mips-octeon-missing-insns-v2-v3-12-bcbec96357d9@gmail.com>","list_archive_url":null,"date":"2026-05-08T15:12:12","name":"[v3,12/32] target/mips: add Octeon SAAD instruction","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"8d9a1ac8304918fd8af5a5a2d6d672e7f636569e","submitter":{"id":66301,"url":"http://patchwork.ozlabs.org/api/1.2/people/66301/?format=json","name":"James Hilliard","email":"james.hilliard1@gmail.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260508-mips-octeon-missing-insns-v2-v3-12-bcbec96357d9@gmail.com/mbox/","series":[{"id":503407,"url":"http://patchwork.ozlabs.org/api/1.2/series/503407/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=503407","date":"2026-05-08T15:12:00","name":"target/mips: add missing Octeon user-mode support","version":3,"mbox":"http://patchwork.ozlabs.org/series/503407/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2235085/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2235085/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=TkmMDqJY;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4gBt1k52vkz1yKd\n\tfor ; Sat, 09 May 2026 01:14:02 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wLMtb-0002ps-77; Fri, 08 May 2026 11:13:43 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wLMt7-0002en-Ko\n for qemu-devel@nongnu.org; Fri, 08 May 2026 11:13:14 -0400","from mail-oi1-x236.google.com ([2607:f8b0:4864:20::236])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)\n (Exim 4.90_1) (envelope-from )\n id 1wLMt5-0001gv-NO\n for qemu-devel@nongnu.org; Fri, 08 May 2026 11:13:13 -0400","by mail-oi1-x236.google.com with SMTP id\n 5614622812f47-479aa2dbea2so903201b6e.0\n for ; Fri, 08 May 2026 08:13:11 -0700 (PDT)","from\n 1.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.ip6.arpa\n (71-218-113-237.hlrn.qwest.net. [71.218.113.237])\n by smtp.gmail.com with ESMTPSA id\n 586e51a60fabf-43557109b7dsm1897904fac.5.2026.05.08.08.13.09\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Fri, 08 May 2026 08:13:09 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20251104; t=1778253190; x=1778857990; darn=nongnu.org;\n h=cc:to:in-reply-to:references:message-id:content-transfer-encoding\n :mime-version:subject:date:from:from:to:cc:subject:date:message-id\n :reply-to; bh=HOILVDpaMznFWxynFwOxhUhVu0sGJ0ISaYpQernUqr8=;\n b=TkmMDqJYW9PBO5igHSJ5KMicY314QvgItCuE9Qw8c+QdgeFhFpSNPvRTaMQLcCrKDV\n K0ujn93ZX7TIZMheG22lJUJqQUNfXGCiyL9c9hYuTOuZ19veT23jPqMxmH3ZHZ5rUVsm\n zLKY7xiNrWQRN7ANZpivHemomuKsCD4ALN8GV/ioUvQp+PILlkPsNPSTcl8d4eQGtRZY\n u9qCygWzcypwGF0j3bk8PQw01vFiSzMNDFBBNCUYYs/rgYuMKDtN/0fBmwt7NbjRNvBi\n BuGjaR7yAtEQC2q/hc+nmy2xiQ/KsoWz45y9ShARiGVBFDej0Ufhn/mWYJSHtn/NrH+5\n pheQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1778253190; x=1778857990;\n h=cc:to:in-reply-to:references:message-id:content-transfer-encoding\n :mime-version:subject:date:from:x-gm-gg:x-gm-message-state:from:to\n :cc:subject:date:message-id:reply-to;\n bh=HOILVDpaMznFWxynFwOxhUhVu0sGJ0ISaYpQernUqr8=;\n b=oVeAKXqL6JNBQ1hqfOqu7Fog/ipzaX1Aq32AaRvSOjbapJSVLyHQxD/0xz1E3iZn6v\n e+jbCNdP68HE/Ke1u1vke/VIXU6Am/B7nHtP+H/lKZGTtmCxYRa2phOmYaEvZ6Ae98G2\n rBbs2pitvlszEDnsRa6UjtHr4+BlhZXlcKhOdMJdGDJmOAI05CAUGQ5ZyxroAg/P3Q64\n rnjcmwr5fug3LLbooED0q5sQp4J9YpslwSxIrU20pyC+5fUKMxapQ6gBJDDYIRBO4NbG\n 929yd3vtH6jhskfmhDpBWacjHgi9emVHu7SwsCmP4QxPssLpMJMbx/XgbiLcamDGXt1E\n VzGQ==","X-Gm-Message-State":"AOJu0YySo6h6VACmR3x0TeLCRd79jDAkiwH0i272M4AT5SoNKXa5bay8\n KXLA/FUrbwOaUhKrixBLiN5kA5sAriqjqQeusYw+gzQVrruAt0P7ONWgc5zANg==","X-Gm-Gg":"AeBDieueruD4p8gBFzmQOo2YZCx14ouVHN6gnP2cziC+3/jHwX1+SAoiTt8lssOHtWS\n Ts+WJjUnn8XZbQToHFqo97z01A6I35acGqxgPtx0Hw6nuCnuWNBQQ+GsiRboxg6vEt9aunSc/B/\n CaCSdGizz9W7pvyHCOiuhMG3+mesGha0jFJ5jBOXYIWND8mvZ26jfuXpGzzDmJ+/JsjmDrkS6PM\n M8F0uvQXFYngh5vRKeGyZKC9tN6kasyyPkaOlUIKTjNwRAngBwukF+OCE+RdSr1l7cNy5XjZaDK\n 79Bhirnkt0FnzjGk8ylIVV6YeyWT2Vb/jV7RCncYxyC2qMhEhALwp9Mjf1CvdUdfgzf5kGI/6yD\n 7/jZH+HVW3cafJBKMbDKkSYLbaCO1ihnRIZJ/tzDe7j93+RH2/JtW30ceHb3FR/5HhJjcIYIss6\n kocJPQ/gWuMVSKDSC9SrdCl5VPUyKndWXXw+3ARQmbGY/ufUFi7UF/LPDmTvc7a6nCJZLs46nH8\n SZljpB8TfmJjfh429IekLKyGUancxfHFQ9q0VGb/7kdopn6ywUxV/fb2ba/lEB34MsanUlZporT\n bwZtUSqHkpsojzGyLOOz2lozneDYgyKnb1/05L8co30IX4s5O21fCAKLCw0uhXno2haMqxu8DAx\n 31YjTNw==","X-Received":"by 2002:a05:6820:f026:b0:694:a285:1273 with SMTP id\n 006d021491bc7-69998cc6306mr7159586eaf.19.1778253190021;\n Fri, 08 May 2026 08:13:10 -0700 (PDT)","From":"James Hilliard ","Date":"Fri, 08 May 2026 09:12:12 -0600","Subject":"[PATCH v3 12/32] target/mips: add Octeon SAAD instruction","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"7bit","Message-Id":"\n <20260508-mips-octeon-missing-insns-v2-v3-12-bcbec96357d9@gmail.com>","References":"\n <20260508-mips-octeon-missing-insns-v2-v3-0-bcbec96357d9@gmail.com>","In-Reply-To":"\n <20260508-mips-octeon-missing-insns-v2-v3-0-bcbec96357d9@gmail.com>","To":"qemu-devel@nongnu.org","Cc":"Laurent Vivier , =?utf-8?q?Philippe_Mathieu-Daud?=\n\t=?utf-8?q?=C3=A9?= ,\n Aurelien Jarno ,\n Jiaxun Yang ,\n Aleksandar Rikalo , Huacai Chen ,\n James Hilliard , Helge Deller ,\n Pierrick Bouvier ,\n Pierrick Bouvier ","X-Mailer":"b4 0.15.2","Received-SPF":"pass client-ip=2607:f8b0:4864:20::236;\n envelope-from=james.hilliard1@gmail.com; helo=mail-oi1-x236.google.com","X-Spam_score_int":"-17","X-Spam_score":"-1.8","X-Spam_bar":"-","X-Spam_report":"(-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,\n DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001,\n RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,\n SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"SAAD is the doubleword form of SAA: it atomically adds rt to the\nnaturally aligned 64-bit doubleword at base and discards the old memory\nvalue.\n\nImplement it with TCG atomic_fetch_add_i64 and the same aligned\ntransaction semantics as SAA.\n\nSigned-off-by: James Hilliard \n---\nChanges v2 -> v3:\n - Split SAAD out of the combined Octeon arithmetic and memory\n instruction patch. (requested by Richard Henderson)\n---\n target/mips/tcg/octeon.decode | 1 +\n target/mips/tcg/octeon_translate.c | 1 +\n 2 files changed, 2 insertions(+)","diff":"diff --git a/target/mips/tcg/octeon.decode b/target/mips/tcg/octeon.decode\nindex d6b241de42..d77717cd50 100644\n--- a/target/mips/tcg/octeon.decode\n+++ b/target/mips/tcg/octeon.decode\n@@ -47,6 +47,7 @@ SNEI 011100 rs:5 rt:5 imm:s10 101111 &cmpi\n &saa base rt\n @saa ...... base:5 rt:5 ................ &saa\n SAA 011100 ..... ..... 00000 00000 011000 @saa\n+SAAD 011100 ..... ..... 00000 00000 011001 @saa\n \n &lx base index rd\n @lx ...... base:5 index:5 rd:5 ...... ..... &lx\ndiff --git a/target/mips/tcg/octeon_translate.c b/target/mips/tcg/octeon_translate.c\nindex 19535768d2..104822a64a 100644\n--- a/target/mips/tcg/octeon_translate.c\n+++ b/target/mips/tcg/octeon_translate.c\n@@ -188,6 +188,7 @@ static bool trans_saa(DisasContext *ctx, arg_saa *a, MemOp mop)\n }\n \n TRANS(SAA, trans_saa, MO_UL);\n+TRANS(SAAD, trans_saa, MO_UQ);\n TRANS(LBX, trans_lx, MO_SB);\n TRANS(LBUX, trans_lx, MO_UB);\n TRANS(LHX, trans_lx, MO_SW);\n","prefixes":["v3","12/32"]}