{"id":2235059,"url":"http://patchwork.ozlabs.org/api/1.2/patches/2235059/?format=json","web_url":"http://patchwork.ozlabs.org/project/openvswitch/patch/20260508134308.2857449-3-houminxi@gmail.com/","project":{"id":47,"url":"http://patchwork.ozlabs.org/api/1.2/projects/47/?format=json","name":"Open vSwitch","link_name":"openvswitch","list_id":"ovs-dev.openvswitch.org","list_email":"ovs-dev@openvswitch.org","web_url":"http://openvswitch.org/","scm_url":"git@github.com:openvswitch/ovs.git","webscm_url":"https://github.com/openvswitch/ovs","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260508134308.2857449-3-houminxi@gmail.com>","list_archive_url":null,"date":"2026-05-08T13:43:08","name":"[ovs-dev,net-next,v8,2/2] selftests: openvswitch: add pop_vlan test","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"94ee2fcef7d49b7afec11321d155ff8e29963266","submitter":{"id":93141,"url":"http://patchwork.ozlabs.org/api/1.2/people/93141/?format=json","name":"Minxi Hou","email":"houminxi@gmail.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/openvswitch/patch/20260508134308.2857449-3-houminxi@gmail.com/mbox/","series":[{"id":503392,"url":"http://patchwork.ozlabs.org/api/1.2/series/503392/?format=json","web_url":"http://patchwork.ozlabs.org/project/openvswitch/list/?series=503392","date":"2026-05-08T13:43:06","name":"selftests: openvswitch: add pop_vlan test","version":8,"mbox":"http://patchwork.ozlabs.org/series/503392/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2235059/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2235059/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","dev@openvswitch.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","ovs-dev@lists.linuxfoundation.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=QPDxm8hQ;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=openvswitch.org\n (client-ip=140.211.166.137; helo=smtp4.osuosl.org;\n envelope-from=ovs-dev-bounces@openvswitch.org; receiver=patchwork.ozlabs.org)","smtp4.osuosl.org;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key)\n header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20251104\n header.b=QPDxm8hQ","smtp1.osuosl.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com","smtp1.osuosl.org;\n dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com\n header.a=rsa-sha256 header.s=20251104 header.b=QPDxm8hQ"],"Received":["from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4gBr1v1g5pz1yKd\n\tfor ; Fri, 08 May 2026 23:44:03 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby smtp4.osuosl.org (Postfix) with ESMTP id 417754102A;\n\tFri, 8 May 2026 13:44:01 +0000 (UTC)","from smtp4.osuosl.org ([127.0.0.1])\n by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id L1AmX8NwOOzs; Fri, 8 May 2026 13:44:00 +0000 (UTC)","from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56])\n\tby smtp4.osuosl.org (Postfix) with ESMTPS id 4D0084064C;\n\tFri, 8 May 2026 13:44:00 +0000 (UTC)","from lf-lists.osuosl.org (localhost [127.0.0.1])\n\tby lists.linuxfoundation.org (Postfix) with ESMTP id 22876C04ED;\n\tFri, 8 May 2026 13:44:00 +0000 (UTC)","from smtp1.osuosl.org (smtp1.osuosl.org [IPv6:2605:bc80:3010::138])\n by lists.linuxfoundation.org (Postfix) with ESMTP id 6DF8CC04E7\n for ; Fri, 8 May 2026 13:43:59 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n by smtp1.osuosl.org (Postfix) with ESMTP id 3EA4C842C3\n for ; Fri, 8 May 2026 13:43:40 +0000 (UTC)","from smtp1.osuosl.org ([127.0.0.1])\n by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id BaG9bclND--N for ;\n Fri, 8 May 2026 13:43:39 +0000 (UTC)","from mail-oa1-x2a.google.com (mail-oa1-x2a.google.com\n [IPv6:2001:4860:4864:20::2a])\n by smtp1.osuosl.org (Postfix) with ESMTPS id 6B5D3842D3\n for ; Fri, 8 May 2026 13:43:39 +0000 (UTC)","by mail-oa1-x2a.google.com with SMTP id\n 586e51a60fabf-4243bf9be36so992250fac.3\n for ; Fri, 08 May 2026 06:43:39 -0700 (PDT)","from houminxi ([72.244.37.221]) by smtp.gmail.com with ESMTPSA id\n 006d021491bc7-69b25c76cc4sm1119108eaf.6.2026.05.08.06.43.33\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Fri, 08 May 2026 06:43:37 -0700 (PDT)"],"X-Virus-Scanned":["amavis at osuosl.org","amavis at osuosl.org"],"X-Comment":"SPF check N/A for local connections - client-ip=140.211.9.56;\n helo=lists.linuxfoundation.org;\n envelope-from=ovs-dev-bounces@openvswitch.org; receiver= ","DKIM-Filter":["OpenDKIM Filter v2.11.0 smtp4.osuosl.org 4D0084064C","OpenDKIM Filter v2.11.0 smtp1.osuosl.org 6B5D3842D3"],"Received-SPF":"Pass (mailfrom) identity=mailfrom;\n client-ip=2001:4860:4864:20::2a; helo=mail-oa1-x2a.google.com;\n envelope-from=houminxi@gmail.com; receiver=","DMARC-Filter":"OpenDMARC Filter v1.4.2 smtp1.osuosl.org 6B5D3842D3","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20251104; t=1778247818; x=1778852618; darn=openvswitch.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=G++PmIEZH/3IDDChHFNdq5UZKsic2mGL2G/u53vWWPc=;\n b=QPDxm8hQAEmlEfDAvKF6OBI26Wyd/UU5NAqRb8z/aqP+iCEfFOUWLat1nqHkTQUPwk\n gtRMguDpoV6Way2LxfhDWbYWP/qNG5Qq3UvgdV710okGs0t0rn1kGi6ViAnkpEZr93Gb\n 1Y9N0gsQgD7vrlmHaWRnh2GcauNxJkTvwA1+ndAZ+tu36i/fwag3t1oUcXkKC1rDub4+\n /00xLu3zifWjtAGEZF4k1AneTPDBYytUR9rcfilmjAMeKTXboIXlRMnU28y7ER4DuB3G\n g+zjeOHPbUUyXMI26O96dZHE1wQyZqyfDalvW/zje4l/pcDV+YAAQ8CiBcwFZyaolEkB\n oKWQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1778247818; x=1778852618;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=G++PmIEZH/3IDDChHFNdq5UZKsic2mGL2G/u53vWWPc=;\n b=jUtzkfUI0QtrudBXpUlJLIGDhVKqNATssPHNsBjuubySwoUyPA5Cw3pCoby077thRu\n hNY410iyWOqqvOPANj3G0mAyq+L/QEFfcC8iMQ9lhk8Q/OvgkClNW7ccvSw2nHKUDCOh\n y7M+e739L75hyeqZd27qvvSQXocPilQyPTRdnzDS0Z3bw7b7L2CkvUG8MyJQTkEZhNHU\n EfoSqFTVaGhdi5c+A7p6jfC44Nr25jLUiMMIsN0t+L7sMz4dluOFSH8LWmSo0eQFeJtq\n BJWxwbjRt4ngHiCG1Wo17BTiTDYUchsW9/HUx58A1TRGr8L+GnEvBb9Xu0Ig3Ns9S8g0\n vDKg==","X-Forwarded-Encrypted":"i=1;\n AFNElJ9SL2/s1JhLE0TExBe2cJZq+M1lGUTdcvZJaU9WuG9hmfCUA/Rp476nAtcr5CJScStYHLU=@openvswitch.org","X-Gm-Message-State":"AOJu0YyAhPrNMZgmVXtngF07lVxGb3aAWBbn9RTvADffNq4T0FH0yrzC\n Vrc7lsoldETMWw9Dz0uQ/z81GZDTMRr0nr5qB1f7WhDkOlisFBE5U73a","X-Gm-Gg":"AeBDiesOf/iOnaAlajb8OHn4nXpc4pmvLJJs4aRPDTz4dyMAn77HeJwqjTfK+kA/yp+\n MZUYQvt07wih2yEBvAVN2JSLIkPFqzzKQ6IysRgvUt//t2PjKjwiEhTjGMA33Y6+v307OipM39a\n rTt0V2L7nH+zFioaqqkmos1nQjzkEUblMaaHAorbU+irGIIZMvmR/chWhZk2ExRyGrQSEbZPNVk\n exNKNZq2xLNOkRCTkG6Vp1fdT0zjcepHPJazovzm5ZV7NR4DnBsl1MzVZNNTjORTy2ApCV6uIrs\n eDfFuYzY09JFnGQTvAFsWRlqfgFGCQc9rinKufpebOtSdqG3F7m4FgwnsyjK5DUWGnLpkW018tq\n muH5z/tAYaUeGYG1HM6m8m27jVBinGlRX9ldjYLUNyO+51O0+kj/JaxW0T5TZnPBOiirntGsP8P\n 0wWMG+2iADRyjzlME=","X-Received":"by 2002:a05:6820:61e:b0:67b:bd89:90ed with SMTP id\n 006d021491bc7-69998d30169mr7387370eaf.41.1778247818205;\n Fri, 08 May 2026 06:43:38 -0700 (PDT)","From":"Minxi Hou ","To":"netdev@vger.kernel.org","Date":"Fri, 8 May 2026 21:43:08 +0800","Message-ID":"<20260508134308.2857449-3-houminxi@gmail.com>","X-Mailer":"git-send-email 2.53.0","In-Reply-To":"<20260508134308.2857449-1-houminxi@gmail.com>","References":"<20260508134308.2857449-1-houminxi@gmail.com>","MIME-Version":"1.0","Subject":"[ovs-dev] [PATCH net-next v8 2/2] selftests: openvswitch: add\n pop_vlan test","X-BeenThere":"ovs-dev@openvswitch.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Cc":"dev@openvswitch.org, linux-kselftest@vger.kernel.org,\n Minxi Hou , linux-kernel@vger.kernel.org,\n i.maximets@ovn.org, edumazet@google.com, horms@kernel.org, kuba@kernel.org,\n pabeni@redhat.com, shuah@kernel.org, davem@davemloft.net","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"ovs-dev-bounces@openvswitch.org","Sender":"\"dev\" "},"content":"Add test_pop_vlan() to verify OVS kernel datapath pop_vlan action\ncorrectly strips 802.1Q VLAN tags from frames.\n\nTest structure:\n- Baseline: untagged forwarding validates basic connectivity.\n- Negative: forward without pop_vlan, tagged frame is invisible\n to ns2 (no VLAN sub-interface), ping fails.\n- Positive: pop_vlan strips tag on forward path, push_vlan\n restores tag on return path, ping succeeds.\n\nUse static ARP entries to avoid VLAN-tagged ARP complexity.\nRely on ping success/failure for verification -- no tcpdump or\npcap files needed.\n\nSigned-off-by: Minxi Hou \n---\n .../selftests/net/openvswitch/openvswitch.sh | 77 +++++++++++++++++++\n 1 file changed, 77 insertions(+)","diff":"diff --git a/tools/testing/selftests/net/openvswitch/openvswitch.sh b/tools/testing/selftests/net/openvswitch/openvswitch.sh\nindex b327d3061ed5..a0e8e6cbd301 100755\n--- a/tools/testing/selftests/net/openvswitch/openvswitch.sh\n+++ b/tools/testing/selftests/net/openvswitch/openvswitch.sh\n@@ -27,6 +27,7 @@ tests=\"\n \tupcall_interfaces\t\t\tovs: test the upcall interfaces\n \ttunnel_metadata\t\t\t\tovs: test extraction of tunnel metadata\n \tdrop_reason\t\t\t\tdrop: test drop reasons are emitted\n+\tpop_vlan\t\t\t\tvlan: POP_VLAN action strips tag\n \tpsample\t\t\t\t\tpsample: Sampling packets with psample\"\n \n info() {\n@@ -830,6 +831,82 @@ test_tunnel_metadata() {\n \treturn 0\n }\n \n+test_pop_vlan() {\n+\tlocal sbx=\"test_pop_vlan\"\n+\tsbx_add \"$sbx\" || return $?\n+\tovs_add_dp \"$sbx\" vlandp || return 1\n+\n+\tovs_add_netns_and_veths \"$sbx\" vlandp \\\n+\t\tns1 veth1 ns1veth 192.0.2.1/24 || return 1\n+\tovs_add_netns_and_veths \"$sbx\" vlandp \\\n+\t\tns2 veth2 ns2veth 192.0.2.2/24 || return 1\n+\n+\t# Baseline: untagged bidirectional forwarding\n+\tovs_add_flow \"$sbx\" vlandp \\\n+\t\t'in_port(1),eth(),eth_type(0x0806),arp()' '2' || return 1\n+\tovs_add_flow \"$sbx\" vlandp \\\n+\t\t'in_port(2),eth(),eth_type(0x0806),arp()' '1' || return 1\n+\tovs_add_flow \"$sbx\" vlandp \\\n+\t\t'in_port(1),eth(),eth_type(0x0800),ipv4()' '2' || return 1\n+\tovs_add_flow \"$sbx\" vlandp \\\n+\t\t'in_port(2),eth(),eth_type(0x0800),ipv4()' '1' || return 1\n+\tovs_sbx \"$sbx\" ip netns exec ns1 ping -c 3 -W 2 \\\n+\t\t192.0.2.2 || return 1\n+\n+\t# VLAN topology: ns1 uses VLAN sub-interface, ns2 is plain\n+\tip -n ns1 link add link ns1veth name ns1veth.10 \\\n+\t\ttype vlan id 10 || return 1\n+\ton_exit \"ip -n ns1 link del ns1veth.10 2>/dev/null\"\n+\tip -n ns1 addr add 198.51.100.1/24 dev ns1veth.10 || return 1\n+\tip -n ns1 link set ns1veth.10 up || return 1\n+\tip -n ns2 addr add 198.51.100.2/24 dev ns2veth || return 1\n+\n+\tovs_del_flows \"$sbx\" vlandp\n+\n+\t# Static ARP: avoids VLAN-tagged ARP complexity\n+\tlocal ns1veth10mac ns2mac\n+\tns1veth10mac=$(ip -n ns1 link show ns1veth.10 \\\n+\t\t| awk '/link\\/ether/ {print $2}')\n+\t[ -z \"$ns1veth10mac\" ] && \\\n+\t\t{ info \"failed to get ns1veth10mac\"; return 1; }\n+\tns2mac=$(ip -n ns2 link show ns2veth \\\n+\t\t| awk '/link\\/ether/ {print $2}')\n+\t[ -z \"$ns2mac\" ] && \\\n+\t\t{ info \"failed to get ns2mac\"; return 1; }\n+\tip -n ns1 neigh replace 198.51.100.2 lladdr \"$ns2mac\" \\\n+\t\tdev ns1veth.10 nud permanent || return 1\n+\tip -n ns2 neigh replace 198.51.100.1 \\\n+\t\tlladdr \"$ns1veth10mac\" \\\n+\t\tdev ns2veth nud permanent || return 1\n+\n+\tlocal vlan_match='in_port(1),eth(),eth_type(0x8100),'\n+\tvlan_match+='vlan(vid=10),'\n+\tvlan_match+='encap(eth_type(0x0800),'\n+\tvlan_match+='ipv4(src=198.51.100.1,proto=1),icmp())'\n+\n+\t# Negative: forward without pop_vlan -- tagged frame\n+\t# is invisible to ns2 (no VLAN sub-interface), ping fails\n+\tovs_add_flow \"$sbx\" vlandp \"$vlan_match\" '2' || return 1\n+\tovs_sbx \"$sbx\" ip netns exec ns1 ping -I ns1veth.10 \\\n+\t\t-c 3 -W 1 198.51.100.2 >/dev/null 2>&1 \\\n+\t\t&& { info \"FAIL: ping should fail without pop_vlan\"\n+\t\t return 1; }\n+\n+\tovs_del_flows \"$sbx\" vlandp\n+\n+\t# Positive: pop_vlan strips tag on forward path,\n+\t# push_vlan restores tag on return path -- ping succeeds\n+\tovs_add_flow \"$sbx\" vlandp \\\n+\t\t\"$vlan_match\" 'pop_vlan,2' || return 1\n+\tovs_add_flow \"$sbx\" vlandp \\\n+\t\t'in_port(2),eth(),eth_type(0x0800),ipv4()' \\\n+\t\t'push_vlan(vid=10,pcp=0,tpid=0x8100),1' || return 1\n+\tovs_sbx \"$sbx\" ip netns exec ns1 ping -I ns1veth.10 \\\n+\t\t-c 3 -W 2 198.51.100.2 || return 1\n+\n+\treturn 0\n+}\n+\n run_test() {\n \t(\n \ttname=\"$1\"\n","prefixes":["ovs-dev","net-next","v8","2/2"]}