{"id":2235022,"url":"http://patchwork.ozlabs.org/api/1.2/patches/2235022/?format=json","web_url":"http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20260508124208.11622-4-przemyslaw.kitszel@intel.com/","project":{"id":46,"url":"http://patchwork.ozlabs.org/api/1.2/projects/46/?format=json","name":"Intel Wired Ethernet development","link_name":"intel-wired-lan","list_id":"intel-wired-lan.osuosl.org","list_email":"intel-wired-lan@osuosl.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260508124208.11622-4-przemyslaw.kitszel@intel.com>","list_archive_url":null,"date":"2026-05-08T12:41:56","name":"[iwl-next,v1,03/15] ice: simplify ice_vc_dis_qs_msg() a little","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"b497571c4ce4809e8045a66614debe4a4aa78fe5","submitter":{"id":85252,"url":"http://patchwork.ozlabs.org/api/1.2/people/85252/?format=json","name":"Przemek Kitszel","email":"przemyslaw.kitszel@intel.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20260508124208.11622-4-przemyslaw.kitszel@intel.com/mbox/","series":[{"id":503388,"url":"http://patchwork.ozlabs.org/api/1.2/series/503388/?format=json","web_url":"http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=503388","date":"2026-05-08T12:41:53","name":"devlink, mlx5, iavf, ice: XLVF for iavf","version":1,"mbox":"http://patchwork.ozlabs.org/series/503388/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2235022/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2235022/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=osuosl.org header.i=@osuosl.org header.a=rsa-sha256\n header.s=default header.b=AO5EOsRh;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org\n (client-ip=140.211.166.138; helo=smtp1.osuosl.org;\n envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4gBq2v3yfPz1yCg\n\tfor ; Fri, 08 May 2026 22:59:51 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby smtp1.osuosl.org (Postfix) with ESMTP id 95E828232E;\n\tFri, 8 May 2026 12:59:49 +0000 (UTC)","from smtp1.osuosl.org ([127.0.0.1])\n by localhost (smtp1.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id mSteqmrfWBZZ; Fri, 8 May 2026 12:59:49 +0000 (UTC)","from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142])\n\tby smtp1.osuosl.org (Postfix) with ESMTP id 1AF738237C;\n\tFri, 8 May 2026 12:59:49 +0000 (UTC)","from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n by lists1.osuosl.org (Postfix) with ESMTP id A233E358\n for ; Fri, 8 May 2026 12:59:46 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n by smtp4.osuosl.org (Postfix) with ESMTP id 93E0E40E37\n for ; Fri, 8 May 2026 12:59:46 +0000 (UTC)","from smtp4.osuosl.org ([127.0.0.1])\n by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id bjBZ-aROT5lb for ;\n Fri, 8 May 2026 12:59:46 +0000 (UTC)","from mgamail.intel.com (mgamail.intel.com [198.175.65.17])\n by smtp4.osuosl.org (Postfix) with ESMTPS id DA69040E67\n for ; Fri, 8 May 2026 12:59:45 +0000 (UTC)","from fmviesa005.fm.intel.com ([10.60.135.145])\n by orvoesa109.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 08 May 2026 05:59:46 -0700","from irvmail002.ir.intel.com ([10.43.11.120])\n by fmviesa005.fm.intel.com with ESMTP; 08 May 2026 05:59:41 -0700","from vecna.igk.intel.com (vecna.igk.intel.com [10.123.220.17])\n by irvmail002.ir.intel.com (Postfix) with ESMTP id 56A4B2879A;\n Fri, 8 May 2026 13:59:39 +0100 (IST)"],"X-Virus-Scanned":["amavis at osuosl.org","amavis at osuosl.org"],"X-Comment":"SPF check N/A for local connections - client-ip=140.211.166.142;\n helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver= ","DKIM-Filter":["OpenDKIM Filter v2.11.0 smtp1.osuosl.org 1AF738237C","OpenDKIM Filter v2.11.0 smtp4.osuosl.org DA69040E67"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org;\n\ts=default; t=1778245189;\n\tbh=UzP2saOEUL+cxF8zpAdYfyrDJUr1o57OQOyCCFbd3e8=;\n\th=From:To:Cc:Date:In-Reply-To:References:Subject:List-Id:\n\t List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe:\n\t From;\n\tb=AO5EOsRhz9YxPt+Eu9Ywe/xvfEzneYAGBRYfpMRTB8ETSG9H+ph6f6Bns+ChEUu5r\n\t RO2FkDo9oJgvXZJ2Exbi2IWY0fmkMsClWnLbGfvK63NbGjVpAGrNdCxORsGucAxlZM\n\t Zt0Azfe7LyyAAjlb/fao9mKkGpePJrSGaF7D3C3gu/zpQWQp0CKu+dmxhK1PI+V9T+\n\t JMIJhhHj1zRQde4xVK6u1TW0p4FHgemw3bqMgCjbwZwe7QZMqiCQiXXiYYbb78sMqy\n\t 0FfYARsJpAlUs0ganBuKsFK0H6uQl000dsVhVLke3fIQwEbOMfZcYTzwsvvOuoWLFl\n\t H1qvPbSUCiUNQ==","Received-SPF":"Pass (mailfrom) identity=mailfrom; client-ip=198.175.65.17;\n helo=mgamail.intel.com; envelope-from=przemyslaw.kitszel@intel.com;\n receiver=","DMARC-Filter":"OpenDMARC Filter v1.4.2 smtp4.osuosl.org DA69040E67","X-CSE-ConnectionGUID":["ynv89umpQRGo0XWD6ZSxlg==","GMTYscFKSFW/eeqijkQXYA=="],"X-CSE-MsgGUID":["tSw9K54CRfe+9p3GmhuOaQ==","YZKUQNZPQ46TNr2j45qvUw=="],"X-IronPort-AV":["E=McAfee;i=\"6800,10657,11779\"; a=\"79199880\"","E=Sophos;i=\"6.23,223,1770624000\"; d=\"scan'208\";a=\"79199880\"","E=Sophos;i=\"6.23,223,1770624000\"; d=\"scan'208\";a=\"241730099\""],"X-ExtLoop1":"1","From":"Przemek Kitszel ","To":"intel-wired-lan@lists.osuosl.org, Michal Schmidt ,\n Jakub Kicinski , Jiri Pirko ","Cc":"netdev@vger.kernel.org, Simon Horman ,\n Tony Nguyen ,\n Michal Swiatkowski ,\n bruce.richardson@intel.com,\n Vladimir Medvedkin ,\n padraig.j.connolly@intel.com, ananth.s@intel.com,\n timothy.miskell@intel.com, Jacob Keller ,\n Lukasz Czapnik ,\n Aleksandr Loktionov ,\n Andrew Lunn ,\n \"David S. Miller\" ,\n Eric Dumazet , Paolo Abeni ,\n Saeed Mahameed , Leon Romanovsky ,\n Tariq Toukan , Mark Bloch ,\n Przemek Kitszel ","Date":"Fri, 8 May 2026 14:41:56 +0200","Message-Id":"<20260508124208.11622-4-przemyslaw.kitszel@intel.com>","X-Mailer":"git-send-email 2.39.3","In-Reply-To":"<20260508124208.11622-1-przemyslaw.kitszel@intel.com>","References":"<20260508124208.11622-1-przemyslaw.kitszel@intel.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-Mailman-Original-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1778245186; x=1809781186;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=xp8id5hWkxewY8R4U5e0ecSa2Lz1SpyuPfR7qie2fB0=;\n b=SaJeICSpux8GuqK4A48Xd6kD9f1hTwWD7XvWIalH/EaFoql5ZeoLREdD\n gMkcGTpwtzzWC2hMC4912HU1Ps0zXSE6+gvgCj8A8kTY2weeS4BkVQ2fJ\n phH43I/tXw7Z82bV00TpzA4Wn729eZvBuEDBGX6TzR63x8/3oVZag75b3\n 6XnE7aZyeD0yGBPQts4E1axbA3xhUBuPrnoVC7v7kAezIkxW8b/kmAxLq\n xDhBauQQn3zBsPAv8bun3obGiayRCSKXkqjHg4uBWR11twFXcoXMtLyLG\n wAZcWsge8vw6Zf8KfflQmzR6aAnaH636CG8KXQeygOtVG1VKRZ8zaaZXy\n w==;","X-Mailman-Original-Authentication-Results":["smtp4.osuosl.org;\n dmarc=pass (p=none dis=none)\n header.from=intel.com","smtp4.osuosl.org;\n dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com\n header.a=rsa-sha256 header.s=Intel header.b=SaJeICSp"],"Subject":"[Intel-wired-lan] [PATCH iwl-next v1 03/15] ice: simplify\n ice_vc_dis_qs_msg() a little","X-BeenThere":"intel-wired-lan@osuosl.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"Intel Wired Ethernet Linux Kernel Driver Development\n ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"intel-wired-lan-bounces@osuosl.org","Sender":"\"Intel-wired-lan\" "},"content":"Remove special case logic for disabling all queues in ice_vc_dis_qs_msg().\nThere were no actual speedup from it, the only difference was in saved\nbitmap checks, but the HW operations take the majority of time anyway.\nice_vsi_stop_all_rx_rings() used (in the removed code) loops over rings\nanyway.\n\nWith a message added just before removed code, in the \"remove VF\" scenario\nthere were no noticeable difference with the \"speedup\" and without, and it\ntakes ~0.06s on my machine from this point to the whole iavf removed, so\nreally no big deal anyway.\n\nNext commit would otherwise need to complicate the \"speedup possible\"\ncheck, so it's another reason to simplify here.\n\nSigned-off-by: Przemek Kitszel \n---\n drivers/net/ethernet/intel/ice/virt/queues.c | 15 +++------------\n 1 file changed, 3 insertions(+), 12 deletions(-)","diff":"diff --git a/drivers/net/ethernet/intel/ice/virt/queues.c b/drivers/net/ethernet/intel/ice/virt/queues.c\nindex 31be2f76181c..6e4ec681fd07 100644\n--- a/drivers/net/ethernet/intel/ice/virt/queues.c\n+++ b/drivers/net/ethernet/intel/ice/virt/queues.c\n@@ -357,6 +357,8 @@ int ice_vf_vsi_dis_single_txq(struct ice_vf *vf, struct ice_vsi *vsi, u16 q_id)\n * @msg: pointer to the msg buffer\n *\n * called from the VF to disable all or specific queue(s)\n+ *\n+ * Return: exit code of sending the virtchnl response.\n */\n int ice_vc_dis_qs_msg(struct ice_vf *vf, u8 *msg)\n {\n@@ -406,18 +408,7 @@ int ice_vc_dis_qs_msg(struct ice_vf *vf, u8 *msg)\n \t}\n \n \tq_map = vqs->rx_queues;\n-\t/* speed up Rx queue disable by batching them if possible */\n-\tif (q_map &&\n-\t bitmap_equal(&q_map, vf->rxq_ena, ICE_MAX_RSS_QS_PER_VF)) {\n-\t\tif (ice_vsi_stop_all_rx_rings(vsi)) {\n-\t\t\tdev_err(ice_pf_to_dev(vsi->back), \"Failed to stop all Rx rings on VSI %d\\n\",\n-\t\t\t\tvsi->vsi_num);\n-\t\t\tv_ret = VIRTCHNL_STATUS_ERR_PARAM;\n-\t\t\tgoto error_param;\n-\t\t}\n-\n-\t\tbitmap_zero(vf->rxq_ena, ICE_MAX_RSS_QS_PER_VF);\n-\t} else if (q_map) {\n+\tif (q_map) {\n \t\tfor_each_set_bit(vf_q_id, &q_map, ICE_MAX_RSS_QS_PER_VF) {\n \t\t\tif (!ice_vc_isvalid_q_id(vsi, vf_q_id)) {\n \t\t\t\tv_ret = VIRTCHNL_STATUS_ERR_PARAM;\n","prefixes":["iwl-next","v1","03/15"]}