{"id":2234862,"url":"http://patchwork.ozlabs.org/api/1.2/patches/2234862/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-i2c/patch/20260508-k1-i2c-ilcr-v7-2-8c2dde5c3ed5@linux.spacemit.com/","project":{"id":35,"url":"http://patchwork.ozlabs.org/api/1.2/projects/35/?format=json","name":"Linux I2C development","link_name":"linux-i2c","list_id":"linux-i2c.vger.kernel.org","list_email":"linux-i2c@vger.kernel.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260508-k1-i2c-ilcr-v7-2-8c2dde5c3ed5@linux.spacemit.com>","list_archive_url":null,"date":"2026-05-08T07:25:25","name":"[v7,2/2] i2c: spacemit: drop warning when clock-frequency property is absent","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"00ff63cef9f953a79f8d00870ff72096051662d9","submitter":{"id":91240,"url":"http://patchwork.ozlabs.org/api/1.2/people/91240/?format=json","name":"Troy Mitchell","email":"troy.mitchell@linux.spacemit.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linux-i2c/patch/20260508-k1-i2c-ilcr-v7-2-8c2dde5c3ed5@linux.spacemit.com/mbox/","series":[{"id":503337,"url":"http://patchwork.ozlabs.org/api/1.2/series/503337/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-i2c/list/?series=503337","date":"2026-05-08T07:25:24","name":"i2c: spacemit: improve clock handling and cleanups","version":7,"mbox":"http://patchwork.ozlabs.org/series/503337/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2234862/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2234862/checks/","tags":{},"related":[],"headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-i2c@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=linux.spacemit.com header.i=@linux.spacemit.com\n header.a=rsa-sha256 header.s=mxsw2412 header.b=A+ZHduP7;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=172.105.105.114; helo=tor.lore.kernel.org;\n envelope-from=linux-i2c+bounces-17313-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (1024-bit key) header.d=linux.spacemit.com\n header.i=@linux.spacemit.com header.b=\"A+ZHduP7\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=54.207.22.56","smtp.subspace.kernel.org;\n dmarc=none (p=none dis=none) header.from=linux.spacemit.com","smtp.subspace.kernel.org;\n spf=none smtp.mailfrom=linux.spacemit.com"],"Received":["from tor.lore.kernel.org (tor.lore.kernel.org [172.105.105.114])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4gBggb2zHFz1yCg\n\tfor ; Fri, 08 May 2026 17:27:39 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby tor.lore.kernel.org (Postfix) with ESMTP id 224EB3036E7F\n\tfor ; Fri, 8 May 2026 07:27:14 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 96630372EC2;\n\tFri, 8 May 2026 07:26:52 +0000 (UTC)","from smtpbgbr2.qq.com (smtpbgbr2.qq.com [54.207.22.56])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 020D733DEE5;\n\tFri, 8 May 2026 07:26:44 +0000 (UTC)","from = ( [120.237.158.181])\n\tby bizesmtp.qq.com (ESMTP) with\n\tid ; Fri, 08 May 2026 15:25:33 +0800 (CST)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1778225210; cv=none;\n b=iuOBmkAV/yTkftorof+/+s0Uo153NGHqVnQ+L1pIN0J0MmRo5WXasYy5o7niN71IBUkh3aQdT3b9lx1pnJ5Myqahux3Gg5Isxbu/9vtjAjIwcSQpz5+pfBpBtgGhC8zGpUCmH315XW2531fIxQFjiOybClYIRO2PSoVb/Lfi0O4=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1778225210; c=relaxed/simple;\n\tbh=M4lbjoUhPJoCny3IpmEjnduHHjV318FmUyFmpW3E6zo=;\n\th=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References:\n\t In-Reply-To:To:Cc;\n b=YLQXTxQq/mG1afHsXX5M1WByrCqXk0NY8h25xa0QG05765RflOzSJWAZNB+ZUL9t8heobCziu8LJTe36YTL6xzi+px/z1MiwW5CsT558TLGT3Zh4pxLZyG4T61D2BUf6y73tmf6OhHNkcUQNModHLxKTLcV1kemmj7V1Z6yoCnU=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dmarc=none (p=none dis=none) header.from=linux.spacemit.com;\n spf=none smtp.mailfrom=linux.spacemit.com;\n dkim=pass (1024-bit key) header.d=linux.spacemit.com\n header.i=@linux.spacemit.com header.b=A+ZHduP7;\n arc=none smtp.client-ip=54.207.22.56","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.spacemit.com;\n\ts=mxsw2412; t=1778225141;\n\tbh=rbweoWs65LxK6V/Lcm00CesALe08dny3oLDJ8d/9Clk=;\n\th=From:Date:Subject:MIME-Version:Message-Id:To;\n\tb=A+ZHduP79W5W0f4M72QoQUgJw8fJux5FRGDRnNsWWZ/Jcs02jpvm1ZMVqldTauqf4\n\t rHxAI1DSB5dogdLJY5BMMbDEh6IkHEp0ARBhbzNg+gMYwy8DaXkwaHVgnYS3mIh/EM\n\t XQkMTJkzQ2YHf0W/S6Rh7UzePjwVRosLYybRhN08=","X-QQ-mid":"esmtpgz16t1778225135t2ec53698","X-QQ-Originating-IP":"GvWsHhv6gPUuVDAnAl6L7AnrUg0HjU2QvetGSF/n2Sg=","X-QQ-SSF":"0000000000000000000000000000000","X-QQ-GoodBg":"0","X-BIZMAIL-ID":"14195893166969710674","EX-QQ-RecipientCnt":"8","From":"Troy Mitchell ","Date":"Fri, 08 May 2026 15:25:25 +0800","Subject":"[PATCH v7 2/2] i2c: spacemit: drop warning when clock-frequency\n property is absent","Precedence":"bulk","X-Mailing-List":"linux-i2c@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"7bit","Message-Id":"<20260508-k1-i2c-ilcr-v7-2-8c2dde5c3ed5@linux.spacemit.com>","References":"<20260508-k1-i2c-ilcr-v7-0-8c2dde5c3ed5@linux.spacemit.com>","In-Reply-To":"<20260508-k1-i2c-ilcr-v7-0-8c2dde5c3ed5@linux.spacemit.com>","To":"Andi Shyti , Alex Elder ,\n Yixun Lan , Yixun Lan ","Cc":"linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org,\n linux-riscv@lists.infradead.org, spacemit@lists.linux.dev,\n Troy Mitchell ","X-Mailer":"b4 0.15.2","X-Developer-Signature":"v=1; a=ed25519-sha256; t=1778225126; l=1956;\n i=troy.mitchell@linux.spacemit.com; s=20250710; h=from:subject:message-id;\n bh=M4lbjoUhPJoCny3IpmEjnduHHjV318FmUyFmpW3E6zo=;\n b=L1QVCc9kPq+VZX1eNxdP9Uhfxn4G0ma/iZS8P0qUY/XLiZd0Std0gRCjyRoUdDg2gOXNGwYsv\n lkUlaG1kSaiDz5AAWxS2Aq6oSj4NkyEk7NqbRBv+NAZ8jWVI7JMsX7k","X-Developer-Key":"i=troy.mitchell@linux.spacemit.com; a=ed25519;\n pk=lQa7BzLrq8DfZnChqmwJ5qQk8fP2USmY/4xZ2/MSsXc=","X-QQ-SENDSIZE":"520","Feedback-ID":"esmtpgz:linux.spacemit.com:qybglogicsvrgz:qybglogicsvrgz3a-0","X-QQ-XMAILINFO":"N8RLcQ8dzVhj2mrFTixT9so0omh7/fjfhx5jYyMcWJTa53ERrehX134L\n\t8GbMuAYZ6XMji2v8k4d91KQQHLIKgFIBn+qGlI0FuSoNnwa3Im6CK7Nf7tkopOEI/2pjhPG\n\tshu1zgs3YGsSSJI2T/TP8IJaOQu1/1dU80DVeOOoGGDfAFntXLwScXshTVK39bA6V+kTJZT\n\tXYHV4xwXNksmVu67T8UoJ4YNsi+sShu4PT0pggKuux9zsfO1XSyn+KLSrw2yC4TSBEQltSR\n\tUXfdkHwnRzKUVXs+CPLFL92hmkdHsODtkU3gPADu2B7WMssxpFsrKV/JnC5fyPiRjS/EkLn\n\twuT4OLPkbw0lL7Gbj4RnLv7yiN7VMc3F46ZFMPi5aAeojVCuhA4JZXCgyxs3DS6MlDSLiuT\n\t5KDYVT8MNZ67D+peSEb+qwsbofE92WKyztm1nJqC/GOpDj3TcjVV0d289w2vogv66012J3P\n\tWwvyIkklf5clDjNYpszC5AX0TY+NU7k3oBKrr5dd9xhvROViPZQv1M9YPC46yobXNg472L7\n\txBhVYp51XPTM7C6AtJCPg50L8jtUOjm4UJ9KeBvdBQ/eqfYBfi3U1iC52LJOVKzeIOlqwl+\n\tAM+3CgKQIAItohLyglovrJ5XVELJvAR7HMac1SkkX5mK3Iu/m+qSUUxS1ZXt1cma8DB4leA\n\t9YhgLG6pblKRQoVkQDyp4o8zgX3FF7+Q5dGf9Z++LlGfge3jXVxVELSJDKs/gbpmEh2DtXB\n\tVlmXRGvmEltpKsYctG7byD7UBlPLwrZbCDCxUMpqsxDyVkKlGmiCQaFiXDc7wDl1DO1/C9d\n\tN5JjOJMA1Ua9tuZZhjJPnFTnNW/OtH83B6HdFs2pKQMVrmcTZE7EF3/WpcKbXgNP1LyL+pE\n\tbh3eX5uJR38xOkkn7p3Uk0nH2G4VO2tza7zRIU613J4f483b+kaw3ayn1DcAFWyUt3HiaVr\n\tSjC2rJ0XKTdItWGliiR4tMBN5ImtcmK2i252HzYQ2ewONoGHnk0lMvEF15WnLsHnXBlJQWr\n\tFw9nMJ/lHyHcuyoNkgF4koNoSFAE6v3f0rDrqE8u96cqMxkD1Lz20ayWwSYhxpYLEV4qEVw\n\tVwOEd0uLvUgizdjHy2R+NY6mvBjq74MHB8Tlpmppr6LdVTzhE0vKc81dX21tMyUZabYtP3J\n\tgVpw/vMZDSgsndh+rHrVBKNd2642pfCrkIS8","X-QQ-XMRINFO":"Nq+8W0+stu50tPAe92KXseR0ZZmBTk3gLg==","X-QQ-RECHKSPAM":"0"},"content":"The clock-frequency property is optional according to the DT binding.\nDo not emit a warning when the property is missing and fall back to the\ndefault frequency instead.\n\nReviewed-by: Alex Elder \nSigned-off-by: Troy Mitchell \n---\nChangelog in v7:\n- add Alex's tag\n- Link to v6: https://lore.kernel.org/all/20260429-k1-i2c-ilcr-v6-2-1c7a5a5a8b24@linux.spacemit.com/\n\nChangelog in v6:\n- drop Fixes tag per maintainer feedback (this is not a bug fix)\n- change dev_warn to dev_info when clock-frequency is absent (it is optional)\n- Link to v5: https://lore.kernel.org/r/20251226-k1-i2c-ilcr-v5-0-b5807b7dd0e6@linux.spacemit.com\n---\n drivers/i2c/busses/i2c-k1.c | 6 ++----\n 1 file changed, 2 insertions(+), 4 deletions(-)","diff":"diff --git a/drivers/i2c/busses/i2c-k1.c b/drivers/i2c/busses/i2c-k1.c\nindex c6fe2052e479..7cf5c05a20d2 100644\n--- a/drivers/i2c/busses/i2c-k1.c\n+++ b/drivers/i2c/busses/i2c-k1.c\n@@ -833,9 +833,7 @@ static int spacemit_i2c_probe(struct platform_device *pdev)\n \tif (!i2c)\n \t\treturn -ENOMEM;\n \n-\tret = of_property_read_u32(of_node, \"clock-frequency\", &i2c->clock_freq);\n-\tif (ret && ret != -EINVAL)\n-\t\tdev_warn(dev, \"failed to read clock-frequency property: %d\\n\", ret);\n+\tof_property_read_u32(of_node, \"clock-frequency\", &i2c->clock_freq);\n \n \t/* For now, this driver doesn't support high-speed. */\n \tif (i2c->clock_freq > SPACEMIT_I2C_MAX_STANDARD_MODE_FREQ &&\n@@ -844,7 +842,7 @@ static int spacemit_i2c_probe(struct platform_device *pdev)\n \t} else if (i2c->clock_freq && i2c->clock_freq <= SPACEMIT_I2C_MAX_STANDARD_MODE_FREQ) {\n \t\ti2c->mode = SPACEMIT_MODE_STANDARD;\n \t} else {\n-\t\tdev_warn(i2c->dev, \"invalid clock-frequency, fallback to fast mode\");\n+\t\tdev_info(dev, \"clock-frequency not set or out of range, using fast mode\\n\");\n \t\ti2c->mode = SPACEMIT_MODE_FAST;\n \t\ti2c->clock_freq = SPACEMIT_I2C_MAX_FAST_MODE_FREQ;\n \t}\n","prefixes":["v7","2/2"]}