{"id":2234848,"url":"http://patchwork.ozlabs.org/api/1.2/patches/2234848/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-gpio/patch/20260508061729.9530-6-mscardovi95@gmail.com/","project":{"id":42,"url":"http://patchwork.ozlabs.org/api/1.2/projects/42/?format=json","name":"Linux GPIO development","link_name":"linux-gpio","list_id":"linux-gpio.vger.kernel.org","list_email":"linux-gpio@vger.kernel.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260508061729.9530-6-mscardovi95@gmail.com>","list_archive_url":null,"date":"2026-05-08T06:17:28","name":"[v4,5/6] gpio: acpi: use cleanup.h for automated resource deallocation","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"42c9929b02c2f8ebcbcc4e10e9179d078d478b55","submitter":{"id":93312,"url":"http://patchwork.ozlabs.org/api/1.2/people/93312/?format=json","name":"Marco Scardovi","email":"mscardovi95@gmail.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linux-gpio/patch/20260508061729.9530-6-mscardovi95@gmail.com/mbox/","series":[{"id":503330,"url":"http://patchwork.ozlabs.org/api/1.2/series/503330/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-gpio/list/?series=503330","date":"2026-05-08T06:17:27","name":"gpio: acpi: modernize resource management using cleanup.h","version":4,"mbox":"http://patchwork.ozlabs.org/series/503330/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2234848/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2234848/checks/","tags":{},"related":[],"headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-gpio@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=JTMjZQta;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=172.105.105.114; helo=tor.lore.kernel.org;\n envelope-from=linux-gpio+bounces-36435-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com\n header.b=\"JTMjZQta\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=209.85.221.48","smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=gmail.com"],"Received":["from tor.lore.kernel.org (tor.lore.kernel.org [172.105.105.114])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4gBfC1558sz1yJq\n\tfor ; Fri, 08 May 2026 16:21:17 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby tor.lore.kernel.org (Postfix) with ESMTP id DE305307EF40\n\tfor ; Fri, 8 May 2026 06:18:41 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id A9974349AEA;\n\tFri, 8 May 2026 06:18:18 +0000 (UTC)","from mail-wr1-f48.google.com (mail-wr1-f48.google.com\n [209.85.221.48])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 20E07378824\n\tfor ; Fri, 8 May 2026 06:18:02 +0000 (UTC)","by mail-wr1-f48.google.com with SMTP id\n ffacd0b85a97d-43d73352cf2so1298809f8f.1\n for ;\n Thu, 07 May 2026 23:18:00 -0700 (PDT)","from ROG ([2a01:e11:202b:40:68b1:8d59:e348:c16e])\n by smtp.gmail.com with ESMTPSA id\n 5b1f17b1804b1-48e68f5d48fsm11251175e9.14.2026.05.07.23.17.55\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Thu, 07 May 2026 23:17:55 -0700 (PDT)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1778221094; cv=none;\n b=tMVGp621Ci3axKDvDiSvawA6P5hc33w2v23YgliT7nwBFNxHDw9Oz02gRdIV8Dw6zEcUFHxQfMAJYHklvFhDIy3QImDEZB8HFB1LSvWSra0LqUfTbZxotJc8TrvNAvzIZckjY9Xm2FJiQhUxpO+9yVpaPdMxa0jeC4oXEByTCmQ=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1778221094; c=relaxed/simple;\n\tbh=vXzQCDc9L1TnkgaJ2V/CUD7F8PnBdDZXe97ITMRJsds=;\n\th=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References:\n\t MIME-Version;\n b=mRUUXgAaUusxXfUgUIm+NM8fst4ZOTQhm6wrvDQHPs9kvAgEpJk+nRmmYk0Mc/VacdQg2ST+qPW+b/5zpBfCvKhPh4s/CFKySgrVdqMjUSUdV+8zc+TAAz8X3qY8v8vGcicrgM59t289LoX8AVeEgBUIzyIxPl/BGw4JKab22EI=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com;\n spf=pass smtp.mailfrom=gmail.com;\n dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com\n header.b=JTMjZQta; arc=none smtp.client-ip=209.85.221.48","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20251104; t=1778221076; x=1778825876;\n darn=vger.kernel.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=bw5+LRl2yUPLo+LV3S+sRIQay0YVPQ+KYOpW/ni1u98=;\n b=JTMjZQtaWmRHnFRdBIIPiIGNhMsXF1muMTkOcRVwcGVaN1/8uzU6iGjXvKQ4ZzKHtp\n gZ+ni/WMUaNcQOE6nLe/yHurfpVTjb0m/jgcKz746mgZ9SAwK1Y15W6W8qChrFMaj4ju\n uHgUCQycedRwT9LrFAv83T5Q+sxkLPqIXft7reU3BArExS5T67o+E8mkzVr66SisAcTd\n RksP+4pYAjFS4IxafY/dSQXSxYdVGb7yrwfVrvaec9MSS+1Q5FBNYu8mC64wAOOCYpZ1\n FOft/Rgqz/RyXr4c1JCJqyA8iP3m481ImUO+eQrioLyz2/NVz3Rco3OyCwrdaT/aWHfW\n H4iw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1778221076; x=1778825876;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=bw5+LRl2yUPLo+LV3S+sRIQay0YVPQ+KYOpW/ni1u98=;\n b=eZU4LCLScEbArj9ZFwDtI+atXomBOmFgueqKutRzBudI3QQKUoLNw1BE/yFoGjCSwb\n si1NwifqoNH11eBPuIsHxTq7r4OhLUemDhOarPyQFQi0ozJIreN0GZvONwlVDRUrrX8U\n exTus9S30Ro0IGfWaS0n1jSRwjyw+PhAyyuknxj5jeM2Kx3InkdydzFI/AmVldcWWFjm\n 4i+Br0rJITGOjIdd04qvAzN8d/4WAcG1Waz1Pm5a+pK6nx7cZyIleLNV6e2MGI4OoFgk\n SS4bAE8HUNfPUuRRvS4Ka2+LqruFcj0nNmgqCjIhGetgPWLCF4AIrZ1bUhTMsiw7UA8m\n zwKg==","X-Forwarded-Encrypted":"i=1;\n AFNElJ/KrsV4iXTmUQkwhU8U2k1h4/mtcrRijdjXXi+YPmOhxxjW4pMtBpGiL1oklwvYLH0b0p1cZgRT4eF0@vger.kernel.org","X-Gm-Message-State":"AOJu0YwSCzYupbbQgpuN9slvnLm3huBeo1B0udttquB4m4IJiqrpqQqQ\n\tMj7xKn45D26RGB2Bg20J2qYL37fFUQ9VnBTz+ecxKQxesHnQW7R4EvaM","X-Gm-Gg":"AeBDiesV/Fs2I80+oj87p0Oy0HQmfZ6MP+aeQazNvDJ0hARQ92KDTYRKQh9kW5eQUAM\n\tGIySQHA3QaYNQ7GRYpE5nT8FhVTNuaQqqn6+wHEQLJ0o/d+6S1FdpOhyUpGSy2Wspxenc3jb9kO\n\tnemHuESBkdFxl0GWi613w+9n0Dg0mlECHmC9Nd2O0ERidLPDVFzmGMu8Qe+BGKkLHtlJ4n/PWBb\n\t/7OHSHBMUmk5l34/c39H88p6tcZG93Mtv17q8QZrTrjEj16FO/laQbFiUm46WX20c2d1wlEz3rp\n\tBrrZygKkEeWW6gx2YAt8GgmlXgOTIis55UPup4AkysYKuMuxMFd2UR+q5k7rWUfMgPZ2BSmszMy\n\t+mW70U/z8gsKwhm5+CBk7Apdrg/I7X5gfwzW17HiI/XQMJ89wUlpi+rJDJR466c2OdNPtC/IeI3\n\twdVvMspvpUH+NTm2ilwZGpbDRjMQ==","X-Received":"by 2002:a05:600c:3b17:b0:48a:568f:ae6d with SMTP id\n 5b1f17b1804b1-48e51e15c37mr163854705e9.8.1778221076095;\n Thu, 07 May 2026 23:17:56 -0700 (PDT)","From":"Marco Scardovi ","To":"andriy.shevchenko@intel.com","Cc":"linux-acpi@vger.kernel.org,\n\tlinux-gpio@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org,\n\tmathias.nyman@intel.com,\n\tmika.westerberg@intel.com,\n\tMarco Scardovi ","Subject":"[PATCH v4 5/6] gpio: acpi: use cleanup.h for automated resource\n deallocation","Date":"Fri, 8 May 2026 08:17:28 +0200","Message-ID":"<20260508061729.9530-6-mscardovi95@gmail.com>","X-Mailer":"git-send-email 2.54.0","In-Reply-To":"<20260508061729.9530-1-mscardovi95@gmail.com>","References":"\n <20260508061729.9530-1-mscardovi95@gmail.com>","Precedence":"bulk","X-Mailing-List":"linux-gpio@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit"},"content":"Refactor acpi_gpiochip_alloc_event() and acpi_gpio_adr_space_handler()\nto use the __free() macro for GPIO descriptors and ACPI resources.\nThis simplifies error handling by removing manual cleanup calls and\nreducing the need for goto labels.\n\nSigned-off-by: Marco Scardovi \n---\n drivers/gpio/gpiolib-acpi-core.c | 40 +++++++++++---------------------\n 1 file changed, 14 insertions(+), 26 deletions(-)","diff":"diff --git a/drivers/gpio/gpiolib-acpi-core.c b/drivers/gpio/gpiolib-acpi-core.c\nindex 33d6c3b6cdf0..c9b12e24de14 100644\n--- a/drivers/gpio/gpiolib-acpi-core.c\n+++ b/drivers/gpio/gpiolib-acpi-core.c\n@@ -397,31 +397,27 @@ static acpi_status acpi_gpiochip_alloc_event(struct acpi_resource *ares,\n \n \tdesc = acpi_request_own_gpiod(chip, agpio, 0, \"ACPI:Event\");\n \tif (IS_ERR(desc)) {\n-\t\tdev_err(chip->parent,\n-\t\t\t\"Failed to request GPIO for pin 0x%04X, err %pe\\n\",\n-\t\t\tpin, desc);\n+\t\tdev_err(chip->parent, \"Failed to request GPIO for pin 0x%04X, err %pe\\n\", pin, desc);\n \t\treturn AE_OK;\n \t}\n \n+\tstruct gpio_desc *desc_guard __free(free_gpio_desc) = desc;\n+\n \tret = gpiochip_lock_as_irq(chip, pin);\n \tif (ret) {\n-\t\tdev_err(chip->parent,\n-\t\t\t\"Failed to lock GPIO pin 0x%04X as interrupt, err %d\\n\",\n-\t\t\tpin, ret);\n-\t\tgoto fail_free_desc;\n+\t\tdev_err(chip->parent, \"Failed to lock GPIO pin 0x%04X as interrupt, err %d\\n\", pin, ret);\n+\t\treturn AE_OK;\n \t}\n \n \tirq = gpiod_to_irq(desc);\n \tif (irq < 0) {\n-\t\tdev_err(chip->parent,\n-\t\t\t\"Failed to translate GPIO pin 0x%04X to IRQ, err %d\\n\",\n-\t\t\tpin, irq);\n-\t\tgoto fail_unlock_irq;\n+\t\tdev_err(chip->parent, \"Failed to translate GPIO pin 0x%04X to IRQ, err %d\\n\", pin, irq);\n+\t\tgoto err_unlock;\n \t}\n \n \tevent = kzalloc_obj(*event);\n \tif (!event)\n-\t\tgoto fail_unlock_irq;\n+\t\tgoto err_unlock;\n \n \tevent->irqflags = IRQF_ONESHOT;\n \tif (agpio->triggering == ACPI_LEVEL_SENSITIVE) {\n@@ -449,17 +445,15 @@ static acpi_status acpi_gpiochip_alloc_event(struct acpi_resource *ares,\n \tevent->irq = irq;\n \tevent->irq_is_wake = acpi_gpio_irq_is_wake(chip->parent, agpio);\n \tevent->pin = pin;\n-\tevent->desc = desc;\n+\t/* Transfer ownership to event, prevent auto-free */\n+\tevent->desc = no_free_ptr(desc_guard);\n \n \tlist_add_tail(&event->node, &acpi_gpio->events);\n \n \treturn AE_OK;\n \n-fail_unlock_irq:\n+err_unlock:\n \tgpiochip_unlock_as_irq(chip, pin);\n-fail_free_desc:\n-\tgpiochip_free_own_desc(desc);\n-\n \treturn AE_OK;\n }\n \n@@ -1091,7 +1085,7 @@ acpi_gpio_adr_space_handler(u32 function, acpi_physical_address address,\n \tstruct acpi_gpio_chip *achip = region_context;\n \tstruct gpio_chip *chip = achip->chip;\n \tstruct acpi_resource_gpio *agpio;\n-\tstruct acpi_resource *ares;\n+\tstruct acpi_resource *ares __free(acpi_free) = NULL;\n \tu16 pin_index = address;\n \tacpi_status status;\n \tint length;\n@@ -1102,18 +1096,14 @@ acpi_gpio_adr_space_handler(u32 function, acpi_physical_address address,\n \tif (ACPI_FAILURE(status))\n \t\treturn status;\n \n-\tif (WARN_ON(ares->type != ACPI_RESOURCE_TYPE_GPIO)) {\n-\t\tACPI_FREE(ares);\n+\tif (WARN_ON(ares->type != ACPI_RESOURCE_TYPE_GPIO))\n \t\treturn AE_BAD_PARAMETER;\n-\t}\n \n \tagpio = &ares->data.gpio;\n \n \tif (WARN_ON(agpio->io_restriction == ACPI_IO_RESTRICT_INPUT &&\n-\t function == ACPI_WRITE)) {\n-\t\tACPI_FREE(ares);\n+\t function == ACPI_WRITE))\n \t\treturn AE_BAD_PARAMETER;\n-\t}\n \n \tlength = min(agpio->pin_table_length, pin_index + bits);\n \tfor (i = pin_index; i < length; ++i) {\n@@ -1189,8 +1179,6 @@ acpi_gpio_adr_space_handler(u32 function, acpi_physical_address address,\n \t\t}\n \t}\n \n-out:\n-\tACPI_FREE(ares);\n \treturn status;\n }\n \n","prefixes":["v4","5/6"]}