{"id":2234842,"url":"http://patchwork.ozlabs.org/api/1.2/patches/2234842/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-gpio/patch/20260508061729.9530-5-mscardovi95@gmail.com/","project":{"id":42,"url":"http://patchwork.ozlabs.org/api/1.2/projects/42/?format=json","name":"Linux GPIO development","link_name":"linux-gpio","list_id":"linux-gpio.vger.kernel.org","list_email":"linux-gpio@vger.kernel.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260508061729.9530-5-mscardovi95@gmail.com>","list_archive_url":null,"date":"2026-05-08T06:17:27","name":"[v4,4/6] gpio: acpi: use guard(mutex) for conn_lock","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"a4876249e61e6f76809bf443f7daa138009efa10","submitter":{"id":93312,"url":"http://patchwork.ozlabs.org/api/1.2/people/93312/?format=json","name":"Marco Scardovi","email":"mscardovi95@gmail.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linux-gpio/patch/20260508061729.9530-5-mscardovi95@gmail.com/mbox/","series":[{"id":503330,"url":"http://patchwork.ozlabs.org/api/1.2/series/503330/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-gpio/list/?series=503330","date":"2026-05-08T06:17:27","name":"gpio: acpi: modernize resource management using cleanup.h","version":4,"mbox":"http://patchwork.ozlabs.org/series/503330/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2234842/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2234842/checks/","tags":{},"related":[],"headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-gpio@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256\n header.s=20251104 header.b=bZLlb5Xm;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=2600:3c09:e001:a7::12fc:5321; helo=sto.lore.kernel.org;\n envelope-from=linux-gpio+bounces-36432-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com\n header.b=\"bZLlb5Xm\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=209.85.128.45","smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com","smtp.subspace.kernel.org;\n spf=pass smtp.mailfrom=gmail.com"],"Received":["from sto.lore.kernel.org (sto.lore.kernel.org\n [IPv6:2600:3c09:e001:a7::12fc:5321])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4gBf7l1Ysfz1yK7\n\tfor ; Fri, 08 May 2026 16:18:27 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sto.lore.kernel.org (Postfix) with ESMTP id 81BA6300E00A\n\tfor ; Fri, 8 May 2026 06:18:23 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 54154356A0D;\n\tFri, 8 May 2026 06:18:10 +0000 (UTC)","from mail-wm1-f45.google.com (mail-wm1-f45.google.com\n [209.85.128.45])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id CD2A437104A\n\tfor ; Fri, 8 May 2026 06:18:00 +0000 (UTC)","by mail-wm1-f45.google.com with SMTP id\n 5b1f17b1804b1-488ff90d6c7so14113045e9.2\n for ;\n Thu, 07 May 2026 23:18:00 -0700 (PDT)","from ROG ([2a01:e11:202b:40:68b1:8d59:e348:c16e])\n by smtp.gmail.com with ESMTPSA id\n 5b1f17b1804b1-48e68f5d48fsm11251175e9.14.2026.05.07.23.17.54\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Thu, 07 May 2026 23:17:54 -0700 (PDT)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1778221085; cv=none;\n b=CZp1+mRCaFjaguTNBU7KiFfQOfbHtFVcG7YofiuSRMETyusM9MeGHAg6biObd09QIlsPl3EFxpvX0LZI3EUUS4fOY2Oesfm8tqV7xucG58nBbN8VDbghp96vzzSQyf0IEd8L688ALq8BTbMtEDa57uJCEhFebkqK6O+J8NKppPg=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1778221085; c=relaxed/simple;\n\tbh=iAz3jJlPBsba8da3kwjpUIhKKIX2c5o7oUegAZLaLs8=;\n\th=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References:\n\t MIME-Version;\n b=K7xvV+46Rha6j+ea1R821a60R5WrabAQyfF4kkYoaMiGq3UmF5tNGIrSm/tCtO43gPu6SVJrea9bHdPQu3OqSM8Afl5ZzX7DR77OZW7v09CFZYrz/q5g2VIyrCAvBeS4Dc9dCFctg6JHy2U34pxagwijL4vNoEXEp6sgXgrE9eg=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dmarc=pass (p=none dis=none) header.from=gmail.com;\n spf=pass smtp.mailfrom=gmail.com;\n dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com\n header.b=bZLlb5Xm; arc=none smtp.client-ip=209.85.128.45","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20251104; t=1778221075; x=1778825875;\n darn=vger.kernel.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=7/HBkO+y62XsV45mtLzlDevXxl0xhhsA9eRibM5h14I=;\n b=bZLlb5XmFI5aUFxtUyQJyuZaE3fA3eA3C/SAu+k5kxhItC5EjvAhgAUvCjqJ9kF+NY\n OzmFlXPYXSCe1jtrSxsLYiu0u7goCAbg1pu3FLUI/nFEgrDwRX3T61Tfx+VJoRWG94QV\n z/tRN/WsF3ab6LItv1YThZycu9mDO6lmAJ7xWzveADTpHhKJliDuxq21hs2wSb3z0l/N\n BpQiYVEQpTGvApanGRWRu8NdJd9qDCFrgGGy/rsGD6MxE+hjMjscTPOSvS96PXk5YpB1\n gG+j45kP010HTcQ790KDFnIDOXQhxb3rk8VooSS1gQYlmPmt7NO9In6TK0661I1QydKF\n 3qFg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1778221075; x=1778825875;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=7/HBkO+y62XsV45mtLzlDevXxl0xhhsA9eRibM5h14I=;\n b=Wx4Q7Ep6OD7UsH69Bh8I/xtAhpgW4oY2YXVm+1mz43RKe8u1ECpe6umCiaoq8hxUDY\n 8XTbwxLmddu4cRtZlUoZWlOKppdwkZysyV66wRTQEvVKdCgxm6MX9p73/igHamhN27A3\n /5SXMthm3PJ/BepFTne/u9+vEGjwntRue2pn+vyyFuUxKldmzme60mNfjaSY7rWp7ydi\n rMhXRDRHXEUPPaV4U+kwt2E+FqE110Qdcrvi51FRGizWD9bOPMN7Xgi5CQ9pTQTVvdX3\n JhbttS7PNFibOsFMTELh9vTtE0D+AqxANWAt1xd9aWokViQ4AD3n1AtcQrSdgTazUjnA\n SdOg==","X-Forwarded-Encrypted":"i=1;\n AFNElJ/KwEqRou71ViGoy1jK6Hf0ohEi1JwBa6KbSBye8ubBllVESzQY1XwJklcL0kNc2/gGBJpUm7x5UWsm@vger.kernel.org","X-Gm-Message-State":"AOJu0YxdGiYrs4M3B/EF7cHV6iQTniIZkdMLzHy/toSus8oWIrShUO5Q\n\t2/hsAI5qGVSS1OcjMVXJ3YM0zVB1GMCWXj1BdLa8VROlP0CIj/j157zo","X-Gm-Gg":"AeBDiet35YZWpyhrSvyrKYr5Pcf7hXX7MlicjQwkuzGG4LAg9tsIXhksKipIGEvXYeG\n\t6p1arYwotChgzWlbx/FNvsySuI2kl1vKS4V9HDBQ4XIOANobvGzn5QXY4tIVKv0u4x+WF7yC59o\n\ttrn8YejqYKtUsqTYrDfzN9BfYHDwpCMmZJbeOPcNWvqFKo8TGMMKc21qodRPL8JXqg7PW2yakl6\n\tGDTueh1A/7ryf0LAI7tk5zNYUAZO5BxYa1KkzQb1p9o8RPbdcRlIW4r+GOC9h2qEm8uJymNHqKc\n\tqMXZzqW2Uaa8FJC7GnyGU1XcDXFQqyY9O+8HE3ucuWObONBz1eSDoymBNa4GMVtfibscJpjw3/T\n\t7nZ3PhNsXV07zgItxbFrIlPgYdkFytIqfzIQPcEN8NR324h4yIwZ5C5eXCST50dekYUKfIq4Dzp\n\t6xlNzP2418NeUC7h99YD9cFvCmlw==","X-Received":"by 2002:a05:600c:3f18:b0:487:2671:fb8f with SMTP id\n 5b1f17b1804b1-48e51e19668mr170774595e9.8.1778221074930;\n Thu, 07 May 2026 23:17:54 -0700 (PDT)","From":"Marco Scardovi ","To":"andriy.shevchenko@intel.com","Cc":"linux-acpi@vger.kernel.org,\n\tlinux-gpio@vger.kernel.org,\n\tlinux-kernel@vger.kernel.org,\n\tmathias.nyman@intel.com,\n\tmika.westerberg@intel.com,\n\tMarco Scardovi ","Subject":"[PATCH v4 4/6] gpio: acpi: use guard(mutex) for conn_lock","Date":"Fri, 8 May 2026 08:17:27 +0200","Message-ID":"<20260508061729.9530-5-mscardovi95@gmail.com>","X-Mailer":"git-send-email 2.54.0","In-Reply-To":"<20260508061729.9530-1-mscardovi95@gmail.com>","References":"\n <20260508061729.9530-1-mscardovi95@gmail.com>","Precedence":"bulk","X-Mailing-List":"linux-gpio@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit"},"content":"Replace manual mutex_lock() and mutex_unlock() calls in\nacpi_gpio_adr_space_handler() with the guard(mutex) helper. This\nensures the conn_lock is automatically released when exiting the\nscope, preventing potential deadlocks and simplifying the logic.\n\nSigned-off-by: Marco Scardovi \n---\n drivers/gpio/gpiolib-acpi-core.c | 10 +++-------\n 1 file changed, 3 insertions(+), 7 deletions(-)","diff":"diff --git a/drivers/gpio/gpiolib-acpi-core.c b/drivers/gpio/gpiolib-acpi-core.c\nindex e53d68578024..33d6c3b6cdf0 100644\n--- a/drivers/gpio/gpiolib-acpi-core.c\n+++ b/drivers/gpio/gpiolib-acpi-core.c\n@@ -1123,7 +1123,7 @@ acpi_gpio_adr_space_handler(u32 function, acpi_physical_address address,\n \t\tu16 word, shift;\n \t\tbool found;\n \n-\t\tmutex_lock(&achip->conn_lock);\n+\t\tguard(mutex)(&achip->conn_lock);\n \n \t\tfound = false;\n \t\tlist_for_each_entry(conn, &achip->conns, node) {\n@@ -1155,17 +1155,15 @@ acpi_gpio_adr_space_handler(u32 function, acpi_physical_address address,\n \t\tif (!found) {\n \t\t\tdesc = acpi_request_own_gpiod(chip, agpio, i, \"ACPI:OpRegion\");\n \t\t\tif (IS_ERR(desc)) {\n-\t\t\t\tmutex_unlock(&achip->conn_lock);\n \t\t\t\tstatus = AE_ERROR;\n-\t\t\t\tgoto out;\n+\t\t\t\tbreak;\n \t\t\t}\n \n \t\t\tconn = kzalloc_obj(*conn);\n \t\t\tif (!conn) {\n \t\t\t\tgpiochip_free_own_desc(desc);\n-\t\t\t\tmutex_unlock(&achip->conn_lock);\n \t\t\t\tstatus = AE_NO_MEMORY;\n-\t\t\t\tgoto out;\n+\t\t\t\tbreak;\n \t\t\t}\n \n \t\t\tconn->pin = pin;\n@@ -1173,8 +1171,6 @@ acpi_gpio_adr_space_handler(u32 function, acpi_physical_address address,\n \t\t\tlist_add_tail(&conn->node, &achip->conns);\n \t\t}\n \n-\t\tmutex_unlock(&achip->conn_lock);\n-\n \t\t/*\n \t\t * For the cases when OperationRegion() consists of more than\n \t\t * 64 bits calculate the word and bit shift to use that one to\n","prefixes":["v4","4/6"]}