{"id":2234828,"url":"http://patchwork.ozlabs.org/api/1.2/patches/2234828/?format=json","web_url":"http://patchwork.ozlabs.org/project/linuxppc-dev/patch/20260508043543.217179-25-kwilczynski@kernel.org/","project":{"id":2,"url":"http://patchwork.ozlabs.org/api/1.2/projects/2/?format=json","name":"Linux PPC development","link_name":"linuxppc-dev","list_id":"linuxppc-dev.lists.ozlabs.org","list_email":"linuxppc-dev@lists.ozlabs.org","web_url":"https://github.com/linuxppc/wiki/wiki","scm_url":"https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git","webscm_url":"https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/","list_archive_url":"https://lore.kernel.org/linuxppc-dev/","list_archive_url_format":"https://lore.kernel.org/linuxppc-dev/{}/","commit_url_format":"https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/commit/?id={}"},"msgid":"<20260508043543.217179-25-kwilczynski@kernel.org>","list_archive_url":"https://lore.kernel.org/linuxppc-dev/20260508043543.217179-25-kwilczynski@kernel.org/","date":"2026-05-08T04:35:43","name":"[v7,24/24] PCI/sysfs: Limit BAR resize attribute scope to platforms with PCI mmap","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"a44876b4a377f9b8dc8fa6db66c1d780ef1ca073","submitter":{"id":86709,"url":"http://patchwork.ozlabs.org/api/1.2/people/86709/?format=json","name":"Krzysztof Wilczyński","email":"kwilczynski@kernel.org"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linuxppc-dev/patch/20260508043543.217179-25-kwilczynski@kernel.org/mbox/","series":[{"id":503322,"url":"http://patchwork.ozlabs.org/api/1.2/series/503322/?format=json","web_url":"http://patchwork.ozlabs.org/project/linuxppc-dev/list/?series=503322","date":"2026-05-08T04:35:20","name":"PCI: Convert all dynamic sysfs attributes to static","version":7,"mbox":"http://patchwork.ozlabs.org/series/503322/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2234828/comments/","check":"success","checks":"http://patchwork.ozlabs.org/api/patches/2234828/checks/","tags":{},"related":[],"headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=pDIZz6JT;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.ozlabs.org\n (client-ip=2404:9400:21b9:f100::1; helo=lists.ozlabs.org;\n envelope-from=linuxppc-dev+bounces-20608-incoming=patchwork.ozlabs.org@lists.ozlabs.org;\n receiver=patchwork.ozlabs.org)","lists.ozlabs.org;\n arc=none smtp.remote-ip=172.105.4.254","lists.ozlabs.org;\n dmarc=pass (p=quarantine dis=none) header.from=kernel.org","lists.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=pDIZz6JT;\n\tdkim-atps=neutral","lists.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=kernel.org\n (client-ip=172.105.4.254; helo=tor.source.kernel.org;\n envelope-from=kwilczynski@kernel.org; receiver=lists.ozlabs.org)"],"Received":["from lists.ozlabs.org (lists.ozlabs.org\n [IPv6:2404:9400:21b9:f100::1])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4gBbwz0xMXz1yJq\n\tfor ; Fri, 08 May 2026 14:38:59 +1000 (AEST)","from boromir.ozlabs.org (localhost [127.0.0.1])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 4gBbv330hnz30Vr;\n\tFri, 08 May 2026 14:37:19 +1000 (AEST)","from tor.source.kernel.org (tor.source.kernel.org [172.105.4.254])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 4gBbv23Wthz2xPb\n\tfor ; Fri, 08 May 2026 14:37:18 +1000 (AEST)","from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58])\n\tby tor.source.kernel.org (Postfix) with ESMTP id 71F7B6024D;\n\tFri, 8 May 2026 04:37:16 +0000 (UTC)","by smtp.kernel.org (Postfix) with ESMTPSA id D7B32C2BCB0;\n\tFri, 8 May 2026 04:37:12 +0000 (UTC)"],"ARC-Seal":"i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1778215039;\n\tcv=none;\n b=eTZWIjqVJO6t61foTynxRy4plWcIP7483u9L+ljpSHVq5cHW/hA0xw+ZV4yrUHzACe+81L9FNEkIWS0VWmFuap1OUEaeQtJLJRBDx4Xfx8ZyVHK8GJpCxlgsRH2gSjNw/ej8SI2fT+oWmyzGViPSx4138C2JlfJs+I5ISF3+gwVi6BbTOZr3fkNMMpewYTG4p9UoXKlg/D3Nd7ceKcVDbHWHzWV6r3a1C4cFm7UxE4fgIZpTbI1dYb/d/IVDgGhQfn67bkwdUDjG3BpKOej+yff0BB3cZY/nOsqTBodP9SVhZ1cvOk/zbnKqsaS/AoDUELe4pbV6ducBAJrGZMNx8w==","ARC-Message-Signature":"i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707;\n\tt=1778215039; c=relaxed/relaxed;\n\tbh=5rM02NLXVdR9uWLAGneUkIpOyQErRLVkxCVpCs0cPIk=;\n\th=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References:\n\t MIME-Version:Content-Type;\n b=PNt+vtWCHiKwfWOJUiZVPIj6XyE1Np9lZqykKKklx1NKB55r+D0T9ilDVDZeFZk+Lg9K1oV3w74ZYvv22zpJK7Wbkp6JcyFA1Lup9V4Qyn3aEpif85SN9iPskdTxaUpglAYJM1B6qEg9qtNWHTTno+/bBbDtI2nsV02tR+5TPDbnuFGL/XdoqfQzsrWgEtrPvJqFlKDArgAW9uzE0dNKdDnA6j3ivI6kuM2SCX2sXzuG/9tI9+dmNfdf4cfsYO41r8Kl26b1uI1lEe3aMCCnESlaMwG4RykbtjlURh2kfMC+Z/T7bB7OqxVq0GCoZSsnQS8iacZvOizk+oBpIsoLxQ==","ARC-Authentication-Results":"i=1; lists.ozlabs.org;\n dmarc=pass (p=quarantine dis=none) header.from=kernel.org;\n dkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=pDIZz6JT; dkim-atps=neutral;\n spf=pass (client-ip=172.105.4.254; helo=tor.source.kernel.org;\n envelope-from=kwilczynski@kernel.org;\n receiver=lists.ozlabs.org) smtp.mailfrom=kernel.org","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n\ts=k20201202; t=1778215036;\n\tbh=g1Q0Y9xFxmkBFDILfcdAU3XRw5NhqOHXxvlpf+w+W4s=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=pDIZz6JT+F50/NoXuF7lFmNqg8Xpq6ar8JHkiL1odWO86N+rOe8JidqrT7wtsIW3t\n\t 93FSlxaBsR1QokyyJQgywFCxNoHnJN1NdlhT9+bOWnTetGZ0UGfNr2EJYfRxtSa9+7\n\t QafCJBekO6SkU2yTq/Ljkct+pzdCfy1y6YRu75s/pcMlmDhnqoynyxXB9EWN3hAlq+\n\t ShPRwGhnWD94gNzGH+PKAm0G7/pWojPkWZV7fdHaAbDN0ZvvmcR/LehdvcM5/RxpQY\n\t fy+35MGYw1z1BM427XCnE9GzPrIrGwKKUJDZMlUpUYQFHur1LncvYHjphNqfo8qNUB\n\t zzg9mYwpDD3dw==","From":"=?utf-8?q?Krzysztof_Wilczy=C5=84ski?= ","To":"Bjorn Helgaas ","Cc":"Bjorn Helgaas ,\n Manivannan Sadhasivam ,\n Lorenzo Pieralisi ,\n Alex Williamson , Magnus Lindholm ,\n Matt Turner ,\n Richard Henderson ,\n Christophe Leroy ,\n Madhavan Srinivasan ,\n Michael Ellerman , Nicholas Piggin ,\n Dexuan Cui ,\n =?utf-8?q?Krzysztof_Ha=C5=82asa?= ,\n Lukas Wunner , \"Oliver O'Halloran\" ,\n Saurabh Singh Sengar ,\n Shuan He , Srivatsa Bhat ,\n\t=?utf-8?q?Ilpo_J=C3=A4rvinen?= ,\n linux-pci@vger.kernel.org, linux-alpha@vger.kernel.org,\n linuxppc-dev@lists.ozlabs.org","Subject":"[PATCH v7 24/24] PCI/sysfs: Limit BAR resize attribute scope to\n platforms with PCI mmap","Date":"Fri, 8 May 2026 04:35:43 +0000","Message-ID":"<20260508043543.217179-25-kwilczynski@kernel.org>","X-Mailer":"git-send-email 2.54.0","In-Reply-To":"<20260508043543.217179-1-kwilczynski@kernel.org>","References":"<20260508043543.217179-1-kwilczynski@kernel.org>","X-Mailing-List":"linuxppc-dev@lists.ozlabs.org","List-Id":"","List-Help":"","List-Owner":"","List-Post":"","List-Archive":",\n ","List-Subscribe":",\n ,\n ","List-Unsubscribe":"","Precedence":"list","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","X-Spam-Status":"No, score=-0.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,\n\tDKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS\n\tautolearn=disabled version=4.0.1 OzLabs 8","X-Spam-Checker-Version":"SpamAssassin 4.0.1 (2024-03-25) on lists.ozlabs.org"},"content":"Currently, __resource_resize_store() uses sysfs_remove_groups()\nand sysfs_create_groups() on pci_dev_resource_attr_groups to\ntear down and recreate the resourceN files after a BAR resize,\nso the updated BAR sizes are visible in sysfs.\n\nThe resourceN files only exist on platforms that define\nHAVE_PCI_MMAP or ARCH_GENERIC_PCI_MMAP_RESOURCE. On platforms\nthat define neither, pci_dev_resource_attr_groups is NULL and\nthe sysfs_remove_groups() and sysfs_create_groups() calls in\n__resource_resize_store() become no-ops.\n\nResizable BAR (ReBAR) is a PCI Express extended capability\n(PCI_EXT_CAP_ID_REBAR) that requires PCIe extended config\nspace. Every PCIe-capable architecture defines HAVE_PCI_MMAP\nor ARCH_GENERIC_PCI_MMAP_RESOURCE (via arch headers or the\nasm-generic/pci.h fallback). Architectures without either\nonly support conventional PCI and cannot have any ReBAR-capable\ndevices.\n\nThus, move the resize show and store helpers, the per-BAR attribute\ndefinitions, and the attribute group behind the existing #ifdef\nHAVE_PCI_MMAP || ARCH_GENERIC_PCI_MMAP_RESOURCE guard, and fold the\ngroup reference in pci_dev_groups[] into the existing #if block.\n\nTested-by: Shivaprasad G Bhat \nSigned-off-by: Krzysztof Wilczyński \n---\n drivers/pci/pci-sysfs.c | 4 +++-\n 1 file changed, 3 insertions(+), 1 deletion(-)","diff":"diff --git a/drivers/pci/pci-sysfs.c b/drivers/pci/pci-sysfs.c\nindex f5427bcfb0cc..6099371f67e7 100644\n--- a/drivers/pci/pci-sysfs.c\n+++ b/drivers/pci/pci-sysfs.c\n@@ -1661,6 +1661,7 @@ static const struct attribute_group pci_dev_reset_method_attr_group = {\n \t.is_visible = pci_dev_reset_attr_is_visible,\n };\n \n+#if defined(HAVE_PCI_MMAP) || defined(ARCH_GENERIC_PCI_MMAP_RESOURCE)\n static ssize_t __resource_resize_show(struct device *dev, int n, char *buf)\n {\n \tstruct pci_dev *pdev = to_pci_dev(dev);\n@@ -1775,6 +1776,7 @@ static const struct attribute_group pci_dev_resource_resize_attr_group = {\n \t.attrs = resource_resize_attrs,\n \t.is_visible = resource_resize_attr_is_visible,\n };\n+#endif\n \n static struct attribute *pci_dev_dev_attrs[] = {\n \t&dev_attr_boot_vga.attr,\n@@ -1849,8 +1851,8 @@ const struct attribute_group *pci_dev_groups[] = {\n \t&pci_dev_resource_io_attr_group,\n \t&pci_dev_resource_uc_attr_group,\n \t&pci_dev_resource_wc_attr_group,\n-#endif\n \t&pci_dev_resource_resize_attr_group,\n+#endif\n \t&pci_dev_config_attr_group,\n \t&pci_dev_rom_attr_group,\n \t&pci_dev_reset_attr_group,\n","prefixes":["v7","24/24"]}