{"id":2234819,"url":"http://patchwork.ozlabs.org/api/1.2/patches/2234819/?format=json","web_url":"http://patchwork.ozlabs.org/project/linuxppc-dev/patch/20260508043543.217179-16-kwilczynski@kernel.org/","project":{"id":2,"url":"http://patchwork.ozlabs.org/api/1.2/projects/2/?format=json","name":"Linux PPC development","link_name":"linuxppc-dev","list_id":"linuxppc-dev.lists.ozlabs.org","list_email":"linuxppc-dev@lists.ozlabs.org","web_url":"https://github.com/linuxppc/wiki/wiki","scm_url":"https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git","webscm_url":"https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/","list_archive_url":"https://lore.kernel.org/linuxppc-dev/","list_archive_url_format":"https://lore.kernel.org/linuxppc-dev/{}/","commit_url_format":"https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/commit/?id={}"},"msgid":"<20260508043543.217179-16-kwilczynski@kernel.org>","list_archive_url":"https://lore.kernel.org/linuxppc-dev/20260508043543.217179-16-kwilczynski@kernel.org/","date":"2026-05-08T04:35:34","name":"[v7,15/24] alpha/PCI: Remove WARN from __pci_mmap_fits() and __legacy_mmap_fits()","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"594f657a1e00a74d1e7ed287c9bce30ed5002b25","submitter":{"id":86709,"url":"http://patchwork.ozlabs.org/api/1.2/people/86709/?format=json","name":"Krzysztof Wilczyński","email":"kwilczynski@kernel.org"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linuxppc-dev/patch/20260508043543.217179-16-kwilczynski@kernel.org/mbox/","series":[{"id":503322,"url":"http://patchwork.ozlabs.org/api/1.2/series/503322/?format=json","web_url":"http://patchwork.ozlabs.org/project/linuxppc-dev/list/?series=503322","date":"2026-05-08T04:35:20","name":"PCI: Convert all dynamic sysfs attributes to static","version":7,"mbox":"http://patchwork.ozlabs.org/series/503322/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2234819/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2234819/checks/","tags":{},"related":[],"headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=R6HBL0pi;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.ozlabs.org\n (client-ip=112.213.38.117; helo=lists.ozlabs.org;\n envelope-from=linuxppc-dev+bounces-20599-incoming=patchwork.ozlabs.org@lists.ozlabs.org;\n receiver=patchwork.ozlabs.org)","lists.ozlabs.org;\n arc=none smtp.remote-ip=172.234.252.31","lists.ozlabs.org;\n dmarc=pass (p=quarantine dis=none) header.from=kernel.org","lists.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=R6HBL0pi;\n\tdkim-atps=neutral","lists.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=kernel.org\n (client-ip=172.234.252.31; helo=sea.source.kernel.org;\n envelope-from=kwilczynski@kernel.org; receiver=lists.ozlabs.org)"],"Received":["from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4gBbvf0wfBz1yJq\n\tfor ; Fri, 08 May 2026 14:37:50 +1000 (AEST)","from boromir.ozlabs.org (localhost [127.0.0.1])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 4gBbtP6KGQz3cCx;\n\tFri, 08 May 2026 14:36:45 +1000 (AEST)","from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 4gBbtP08jzz2xPb\n\tfor ; Fri, 08 May 2026 14:36:45 +1000 (AEST)","from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58])\n\tby sea.source.kernel.org (Postfix) with ESMTP id 7DF6343EB4;\n\tFri, 8 May 2026 04:36:43 +0000 (UTC)","by smtp.kernel.org (Postfix) with ESMTPSA id 1BDF0C2BCB4;\n\tFri, 8 May 2026 04:36:39 +0000 (UTC)"],"ARC-Seal":"i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1778215005;\n\tcv=none;\n b=neOYTLSPxrddBgmLsdz/7hWNSVmM7evjX8LqXI/5iz+j0Y8N1+dMppTsNzAIsawH1c5CVDnnirB+I1bJp+5EdAUJD5ok7YX+PY7Q06IGylJZPKLzfBkI++592Hg2wQ72zlXFq+u1pR5v8IVlKAN1L4XDhJWjJd+80DyukelBVJa+eYHhrcRqBZBPWgsO+9dDA8Zg5sv11/aR+Nr3pi1CgCbDVp1uXtOGR6y05I/7XtK0Ot6gswwqYNqww/v6iSs8HFo92WmNV2HzwAVHtwdwZtmnPl9KmeUZRK1I2uaFt67k645Ixucz9wneshbpGDHF7xCRnVXrwX9U2FZN8CVMUA==","ARC-Message-Signature":"i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707;\n\tt=1778215005; c=relaxed/relaxed;\n\tbh=ZCzYyhfxvQAj7TpGJaObGl0Ccl4gbdOuJWkciK3dG9I=;\n\th=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References:\n\t MIME-Version:Content-Type;\n b=FrLtTJ1mwKOGcr2UK7FkOjlf6pmv8Fbr22Zk95TA4+fkG2Fjin+1nPwJXZiJOCmYcvXtO9cSV+av1xAxKo5++0sNnLHRZVrrRkpdrw9A+AZDM/VzeZGEFwoil/+rJyJXfs+cxtSyQcRmTsVQVE0icXzzwG+zO/OpQs3W4pkUdfQBGweUglhcESIXdYAOiLAbimzsFCBvF/D5fOyKKJuRVrotV8gsQMYOTb6AeDTCcgKsOQfyY/JqZtm2vgbukNS564HfM58WR9FbnvmkWraH5URuIX2bU+jd9WlsaSQ9eucWOmJhaBY7Wk+XtDECopdXFb0RZ2tkMEu31WpHwo7tTg==","ARC-Authentication-Results":"i=1; lists.ozlabs.org;\n dmarc=pass (p=quarantine dis=none) header.from=kernel.org;\n dkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=R6HBL0pi; dkim-atps=neutral;\n spf=pass (client-ip=172.234.252.31; helo=sea.source.kernel.org;\n envelope-from=kwilczynski@kernel.org;\n receiver=lists.ozlabs.org) smtp.mailfrom=kernel.org","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n\ts=k20201202; t=1778215003;\n\tbh=RvhmeHPggHFvnpvKsNMm4x+OKY6vAIZNY1FNS7XUoxg=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=R6HBL0pinAWktnoLCLexrXMErdJxfRI3rqc0tRU23vmwpMZG2iZWBFQiawvwdama7\n\t invyEx99A5op8QyhD40MMD/JRw1YfS5fMjapZ3HM3cThGZ00Xf9h4l4VV57lK4Vi78\n\t IS83/FicH4dpT7UBDUCjWXj2F+ANaJ82RldQ1UUqAzJq25dtHOv7RqTfeABdNoZ+cb\n\t 0UFEA5Irs8HN0SSZO3odQp/QJ1wtZZCG0QaqnigEJFbnjrs+AhxM7LLVw2av/xWfJu\n\t YDIflHsAtCCxTMFzyXtuNCKBsL6scKYhv8VYhRgR4rj/2L50xgbv1v8Tn3jBvOuCzr\n\t W4DsRyW/AmuzA==","From":"=?utf-8?q?Krzysztof_Wilczy=C5=84ski?= ","To":"Bjorn Helgaas ","Cc":"Bjorn Helgaas ,\n Manivannan Sadhasivam ,\n Lorenzo Pieralisi ,\n Alex Williamson , Magnus Lindholm ,\n Matt Turner ,\n Richard Henderson ,\n Christophe Leroy ,\n Madhavan Srinivasan ,\n Michael Ellerman , Nicholas Piggin ,\n Dexuan Cui ,\n =?utf-8?q?Krzysztof_Ha=C5=82asa?= ,\n Lukas Wunner , \"Oliver O'Halloran\" ,\n Saurabh Singh Sengar ,\n Shuan He , Srivatsa Bhat ,\n\t=?utf-8?q?Ilpo_J=C3=A4rvinen?= ,\n linux-pci@vger.kernel.org, linux-alpha@vger.kernel.org,\n linuxppc-dev@lists.ozlabs.org","Subject":"[PATCH v7 15/24] alpha/PCI: Remove WARN from __pci_mmap_fits() and\n __legacy_mmap_fits()","Date":"Fri, 8 May 2026 04:35:34 +0000","Message-ID":"<20260508043543.217179-16-kwilczynski@kernel.org>","X-Mailer":"git-send-email 2.54.0","In-Reply-To":"<20260508043543.217179-1-kwilczynski@kernel.org>","References":"<20260508043543.217179-1-kwilczynski@kernel.org>","X-Mailing-List":"linuxppc-dev@lists.ozlabs.org","List-Id":"","List-Help":"","List-Owner":"","List-Post":"","List-Archive":",\n ","List-Subscribe":",\n ,\n ","List-Unsubscribe":"","Precedence":"list","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","X-Spam-Status":"No, score=-0.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,\n\tDKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS\n\tautolearn=disabled version=4.0.1 OzLabs 8","X-Spam-Checker-Version":"SpamAssassin 4.0.1 (2024-03-25) on lists.ozlabs.org"},"content":"Remove the WARN() that fires when userspace attempts to mmap beyond\nthe BAR bounds. The check still returns 0 to reject the mapping,\nbut the warning is excessive for normal operation.\n\nA similar warning was removed from the PCI core in the commit\n3b519e4ea618 (\"PCI: fix size checks for mmap() on /proc/bus/pci files\").\n\nTested-by: Magnus Lindholm \nTested-by: Shivaprasad G Bhat \nReviewed-by: Ilpo Järvinen \nAcked-by: Magnus Lindholm \nSigned-off-by: Krzysztof Wilczyński \n---\n arch/alpha/kernel/pci-sysfs.c | 20 ++++----------------\n 1 file changed, 4 insertions(+), 16 deletions(-)","diff":"diff --git a/arch/alpha/kernel/pci-sysfs.c b/arch/alpha/kernel/pci-sysfs.c\nindex 8802f955256e..a8dade7d084b 100644\n--- a/arch/alpha/kernel/pci-sysfs.c\n+++ b/arch/alpha/kernel/pci-sysfs.c\n@@ -48,13 +48,7 @@ static int __pci_mmap_fits(struct pci_dev *pdev, int num,\n \tstart = vma->vm_pgoff;\n \tsize = ((len - 1) >> (PAGE_SHIFT - shift)) + 1;\n \n-\tif (start < size && size - start >= nr)\n-\t\treturn 1;\n-\tWARN(1, \"process \\\"%s\\\" tried to map%s 0x%08lx-0x%08lx on %s BAR %d \"\n-\t\t\"(size 0x%08lx)\\n\",\n-\t\tcurrent->comm, sparse ? \" sparse\" : \"\", start, start + nr,\n-\t\tpci_name(pdev), num, size);\n-\treturn 0;\n+\treturn start < size && size - start >= nr;\n }\n \n /**\n@@ -259,7 +253,7 @@ int pci_create_resource_files(struct pci_dev *pdev)\n \n static int __legacy_mmap_fits(struct pci_controller *hose,\n \t\t\t struct vm_area_struct *vma,\n-\t\t\t unsigned long res_size, int sparse)\n+\t\t\t unsigned long res_size)\n {\n \tunsigned long nr, start, size;\n \n@@ -267,13 +261,7 @@ static int __legacy_mmap_fits(struct pci_controller *hose,\n \tstart = vma->vm_pgoff;\n \tsize = ((res_size - 1) >> PAGE_SHIFT) + 1;\n \n-\tif (start < size && size - start >= nr)\n-\t\treturn 1;\n-\tWARN(1, \"process \\\"%s\\\" tried to map%s 0x%08lx-0x%08lx on hose %d \"\n-\t\t\"(size 0x%08lx)\\n\",\n-\t\tcurrent->comm, sparse ? \" sparse\" : \"\", start, start + nr,\n-\t\those->index, size);\n-\treturn 0;\n+\treturn start < size && size - start >= nr;\n }\n \n static inline int has_sparse(struct pci_controller *hose,\n@@ -296,7 +284,7 @@ int pci_mmap_legacy_page_range(struct pci_bus *bus, struct vm_area_struct *vma,\n \n \tres_size = (mmap_type == pci_mmap_mem) ? bus->legacy_mem->size :\n \t\t\t\t\t\t bus->legacy_io->size;\n-\tif (!__legacy_mmap_fits(hose, vma, res_size, sparse))\n+\tif (!__legacy_mmap_fits(hose, vma, res_size))\n \t\treturn -EINVAL;\n \n \treturn hose_mmap_page_range(hose, vma, mmap_type, sparse);\n","prefixes":["v7","15/24"]}