{"id":2234817,"url":"http://patchwork.ozlabs.org/api/1.2/patches/2234817/?format=json","web_url":"http://patchwork.ozlabs.org/project/linuxppc-dev/patch/20260508043543.217179-14-kwilczynski@kernel.org/","project":{"id":2,"url":"http://patchwork.ozlabs.org/api/1.2/projects/2/?format=json","name":"Linux PPC development","link_name":"linuxppc-dev","list_id":"linuxppc-dev.lists.ozlabs.org","list_email":"linuxppc-dev@lists.ozlabs.org","web_url":"https://github.com/linuxppc/wiki/wiki","scm_url":"https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git","webscm_url":"https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/","list_archive_url":"https://lore.kernel.org/linuxppc-dev/","list_archive_url_format":"https://lore.kernel.org/linuxppc-dev/{}/","commit_url_format":"https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/commit/?id={}"},"msgid":"<20260508043543.217179-14-kwilczynski@kernel.org>","list_archive_url":"https://lore.kernel.org/linuxppc-dev/20260508043543.217179-14-kwilczynski@kernel.org/","date":"2026-05-08T04:35:32","name":"[v7,13/24] alpha/PCI: Use PCI resource accessor macros","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"7cc0706417dacc6b2532ec94eb1f6973a6a971b4","submitter":{"id":86709,"url":"http://patchwork.ozlabs.org/api/1.2/people/86709/?format=json","name":"Krzysztof Wilczyński","email":"kwilczynski@kernel.org"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linuxppc-dev/patch/20260508043543.217179-14-kwilczynski@kernel.org/mbox/","series":[{"id":503322,"url":"http://patchwork.ozlabs.org/api/1.2/series/503322/?format=json","web_url":"http://patchwork.ozlabs.org/project/linuxppc-dev/list/?series=503322","date":"2026-05-08T04:35:20","name":"PCI: Convert all dynamic sysfs attributes to static","version":7,"mbox":"http://patchwork.ozlabs.org/series/503322/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2234817/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2234817/checks/","tags":{},"related":[],"headers":{"Return-Path":"\n <linuxppc-dev+bounces-20597-incoming=patchwork.ozlabs.org@lists.ozlabs.org>","X-Original-To":["incoming@patchwork.ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=U768Bl7I;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.ozlabs.org\n (client-ip=2404:9400:21b9:f100::1; helo=lists.ozlabs.org;\n envelope-from=linuxppc-dev+bounces-20597-incoming=patchwork.ozlabs.org@lists.ozlabs.org;\n receiver=patchwork.ozlabs.org)","lists.ozlabs.org;\n arc=none smtp.remote-ip=172.234.252.31","lists.ozlabs.org;\n dmarc=pass (p=quarantine dis=none) header.from=kernel.org","lists.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=U768Bl7I;\n\tdkim-atps=neutral","lists.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=kernel.org\n (client-ip=172.234.252.31; helo=sea.source.kernel.org;\n envelope-from=kwilczynski@kernel.org; receiver=lists.ozlabs.org)"],"Received":["from lists.ozlabs.org (lists.ozlabs.org\n [IPv6:2404:9400:21b9:f100::1])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4gBbvM05m8z1yJq\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 08 May 2026 14:37:35 +1000 (AEST)","from boromir.ozlabs.org (localhost [127.0.0.1])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 4gBbtG45TFz3bt7;\n\tFri, 08 May 2026 14:36:38 +1000 (AEST)","from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 4gBbtF5HFfz2xPb\n\tfor <linuxppc-dev@lists.ozlabs.org>; Fri, 08 May 2026 14:36:37 +1000 (AEST)","from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58])\n\tby sea.source.kernel.org (Postfix) with ESMTP id 39A3840DA9;\n\tFri,  8 May 2026 04:36:36 +0000 (UTC)","by smtp.kernel.org (Postfix) with ESMTPSA id CB0AFC2BCB4;\n\tFri,  8 May 2026 04:36:32 +0000 (UTC)"],"ARC-Seal":"i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1778214998;\n\tcv=none;\n b=UjTJn35qQUKmMtwnwIHRhqvu1xTTKBU5ZX0VaERAx7dy+XTBkL4UJnuxgqHn/uWF8o8DUu3xNenS7H+rOHYNwGqIAcyLax4ejR92zMHroqfE2e5uJfZvPFFiTwi/LBwJz4XdC7UFvlW4hH6GaGEEdZX5rWQ/gawqDjsVKrxAFuckvZ5uNbaiGT+qyxQ+tqHTLZX24qxTzqKabF/R27v15AwoHUXaGHddXOzZAUb7Q8Q1h2T18PkFcSQkMjQgzre3KNHEGsG0YlkEp4ZYOKdkBeYcjYrgMcMMCgBvg4q1+qLelnBDqjAsW1yt19vUl3RKJg5G+pa6BgRTC03PXf1axw==","ARC-Message-Signature":"i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707;\n\tt=1778214998; c=relaxed/relaxed;\n\tbh=tdD9Lbn8DnP9ORvNg6BF8yTpuzPfY3PhHqazzEpZ/U4=;\n\th=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References:\n\t MIME-Version:Content-Type;\n b=g54xOgNDo6CYah6fbTfhUK7ARaBQxRss6Wjl6DECGqFoeJkm1QUXFgT+kZjIJesRaxlhvfufvkohWSocWtXxFHzko8F8effX+oRHETLwsBAvR9NB6NW8Ww6iT86Y9mgSJYtNk7m1/cuA/15j7xSnfBDvAPD3Bl6pC6Q0bov+jp5rYNPEnP/0Da8H4F+KAzckqldxsMo/f2QbVuw+FxKao2L0FPaR+gpCH3IksXIhqbNpXCg28SZiryGgklTHHpQgLmnm9D5hT1+y025oGqfNPhKmiv5zQjQ7JvdJOSLd/F1G2VLoA6sFrp2VOc9LLDrswNwlyJUYtdM8wwtY/YZHzg==","ARC-Authentication-Results":"i=1; lists.ozlabs.org;\n dmarc=pass (p=quarantine dis=none) header.from=kernel.org;\n dkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=U768Bl7I; dkim-atps=neutral;\n spf=pass (client-ip=172.234.252.31; helo=sea.source.kernel.org;\n envelope-from=kwilczynski@kernel.org;\n receiver=lists.ozlabs.org) smtp.mailfrom=kernel.org","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n\ts=k20201202; t=1778214996;\n\tbh=SMbLqHpQBSHeWnaUElgUylOvX9Lrle48atcc8IMqjDc=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=U768Bl7InLs0BQxxHT6SKAu4A2lTThU+HuhyYxhB/hO2DbIgmmbEwnjz+UL52xbDx\n\t kEY+AyyeU8S6StsrIGG9perBBAYuCxWTjh7mE+F6hdrrfU+Un25asxz2O2uQH8eVZd\n\t gCH9ZSBYAmkxh03I2H02IJq2BBZOMmZBUftUsNRv4roEBTvAhTSFvLF6JZKontLqbx\n\t +AJIWgAC7IGDxLMw0UCSUB2/n/F7fGHuITcC8kq3xO4spR3uqRH1//g/pCnTarZzYO\n\t 6hTVtm2TM9tbq7HYST6iJJOF5tQwJjAFK9e0EMxncrL2eILHB6QLV52PV60+PN9OWN\n\t BKRqhIfg+2LBg==","From":"=?utf-8?q?Krzysztof_Wilczy=C5=84ski?= <kwilczynski@kernel.org>","To":"Bjorn Helgaas <bhelgaas@google.com>","Cc":"Bjorn Helgaas <helgaas@kernel.org>,\n Manivannan Sadhasivam <mani@kernel.org>,\n Lorenzo Pieralisi <lpieralisi@kernel.org>,\n Alex Williamson <alex@shazbot.org>, Magnus Lindholm <linmag7@gmail.com>,\n Matt Turner <mattst88@gmail.com>,\n Richard Henderson <richard.henderson@linaro.org>,\n Christophe Leroy <chleroy@kernel.org>,\n Madhavan Srinivasan <maddy@linux.ibm.com>,\n Michael Ellerman <mpe@ellerman.id.au>, Nicholas Piggin <npiggin@gmail.com>,\n Dexuan Cui <decui@microsoft.com>,\n =?utf-8?q?Krzysztof_Ha=C5=82asa?= <khalasa@piap.pl>,\n Lukas Wunner <lukas@wunner.de>, \"Oliver O'Halloran\" <oohall@gmail.com>,\n Saurabh Singh Sengar <ssengar@microsoft.com>,\n Shuan He <heshuan@bytedance.com>, Srivatsa Bhat <srivatsabhat@microsoft.com>,\n\t=?utf-8?q?Ilpo_J=C3=A4rvinen?= <ilpo.jarvinen@linux.intel.com>,\n linux-pci@vger.kernel.org, linux-alpha@vger.kernel.org,\n linuxppc-dev@lists.ozlabs.org","Subject":"[PATCH v7 13/24] alpha/PCI: Use PCI resource accessor macros","Date":"Fri,  8 May 2026 04:35:32 +0000","Message-ID":"<20260508043543.217179-14-kwilczynski@kernel.org>","X-Mailer":"git-send-email 2.54.0","In-Reply-To":"<20260508043543.217179-1-kwilczynski@kernel.org>","References":"<20260508043543.217179-1-kwilczynski@kernel.org>","X-Mailing-List":"linuxppc-dev@lists.ozlabs.org","List-Id":"<linuxppc-dev.lists.ozlabs.org>","List-Help":"<mailto:linuxppc-dev+help@lists.ozlabs.org>","List-Owner":"<mailto:linuxppc-dev+owner@lists.ozlabs.org>","List-Post":"<mailto:linuxppc-dev@lists.ozlabs.org>","List-Archive":"<https://lore.kernel.org/linuxppc-dev/>,\n  <https://lists.ozlabs.org/pipermail/linuxppc-dev/>","List-Subscribe":"<mailto:linuxppc-dev+subscribe@lists.ozlabs.org>,\n  <mailto:linuxppc-dev+subscribe-digest@lists.ozlabs.org>,\n  <mailto:linuxppc-dev+subscribe-nomail@lists.ozlabs.org>","List-Unsubscribe":"<mailto:linuxppc-dev+unsubscribe@lists.ozlabs.org>","Precedence":"list","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","X-Spam-Status":"No, score=-0.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,\n\tDKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS\n\tautolearn=disabled version=4.0.1 OzLabs 8","X-Spam-Checker-Version":"SpamAssassin 4.0.1 (2024-03-25) on lists.ozlabs.org"},"content":"Replace direct pdev->resource[] accesses with pci_resource_n(),\nand open-coded res->flags type checks with pci_resource_is_mem()\nand pci_resource_start() helpers.\n\nWhile at it, move the pci_resource_n() call directly into\npcibios_resource_to_bus() and drop the local struct\nresource pointer.\n\nNo functional changes intended.\n\nTested-by: Magnus Lindholm <linmag7@gmail.com>\nTested-by: Shivaprasad G Bhat <sbhat@linux.ibm.com>\nReviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>\nAcked-by: Magnus Lindholm <linmag7@gmail.com>\nSigned-off-by: Krzysztof Wilczyński <kwilczynski@kernel.org>\n---\n arch/alpha/kernel/pci-sysfs.c | 12 ++++++------\n 1 file changed, 6 insertions(+), 6 deletions(-)","diff":"diff --git a/arch/alpha/kernel/pci-sysfs.c b/arch/alpha/kernel/pci-sysfs.c\nindex 2330ab84d59c..5c29f1d2821c 100644\n--- a/arch/alpha/kernel/pci-sysfs.c\n+++ b/arch/alpha/kernel/pci-sysfs.c\n@@ -70,7 +70,6 @@ static int pci_mmap_resource(struct kobject *kobj,\n {\n \tstruct pci_dev *pdev = to_pci_dev(kobj_to_dev(kobj));\n \tint barno = (unsigned long)attr->private;\n-\tstruct resource *res = pci_resource_n(pdev, barno);\n \tenum pci_mmap_state mmap_type;\n \tstruct pci_bus_region bar;\n \tint ret;\n@@ -79,15 +78,16 @@ static int pci_mmap_resource(struct kobject *kobj,\n \tif (ret)\n \t\treturn ret;\n \n-\tif (res->flags & IORESOURCE_MEM && iomem_is_exclusive(res->start))\n+\tif (pci_resource_is_mem(pdev, barno) &&\n+\t    iomem_is_exclusive(pci_resource_start(pdev, barno)))\n \t\treturn -EINVAL;\n \n \tif (!__pci_mmap_fits(pdev, barno, vma, sparse))\n \t\treturn -EINVAL;\n \n-\tpcibios_resource_to_bus(pdev->bus, &bar, res);\n+\tpcibios_resource_to_bus(pdev->bus, &bar, pci_resource_n(pdev, barno));\n \tvma->vm_pgoff += bar.start >> (PAGE_SHIFT - (sparse ? 5 : 0));\n-\tmmap_type = res->flags & IORESOURCE_MEM ? pci_mmap_mem : pci_mmap_io;\n+\tmmap_type = pci_resource_is_mem(pdev, barno) ? pci_mmap_mem : pci_mmap_io;\n \n \treturn hose_mmap_page_range(pdev->sysdata, vma, mmap_type, sparse);\n }\n@@ -141,7 +141,7 @@ static int sparse_mem_mmap_fits(struct pci_dev *pdev, int num)\n \tlong dense_offset;\n \tunsigned long sparse_size;\n \n-\tpcibios_resource_to_bus(pdev->bus, &bar, &pdev->resource[num]);\n+\tpcibios_resource_to_bus(pdev->bus, &bar, pci_resource_n(pdev, num));\n \n \t/* All core logic chips have 4G sparse address space, except\n \t   CIA which has 16G (see xxx_SPARSE_MEM and xxx_DENSE_MEM\n@@ -181,7 +181,7 @@ static int pci_create_attr(struct pci_dev *pdev, int num)\n \tsuffix = \"\";\t/* Assume bwx machine, normal resourceN files. */\n \tnlen1 = 10;\n \n-\tif (pdev->resource[num].flags & IORESOURCE_MEM) {\n+\tif (pci_resource_is_mem(pdev, num)) {\n \t\tsparse_base = hose->sparse_mem_base;\n \t\tdense_base = hose->dense_mem_base;\n \t\tif (sparse_base && !sparse_mem_mmap_fits(pdev, num)) {\n","prefixes":["v7","13/24"]}