{"id":2234815,"url":"http://patchwork.ozlabs.org/api/1.2/patches/2234815/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-pci/patch/20260508043543.217179-25-kwilczynski@kernel.org/","project":{"id":28,"url":"http://patchwork.ozlabs.org/api/1.2/projects/28/?format=json","name":"Linux PCI development","link_name":"linux-pci","list_id":"linux-pci.vger.kernel.org","list_email":"linux-pci@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260508043543.217179-25-kwilczynski@kernel.org>","list_archive_url":null,"date":"2026-05-08T04:35:43","name":"[v7,24/24] PCI/sysfs: Limit BAR resize attribute scope to platforms with PCI mmap","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"a44876b4a377f9b8dc8fa6db66c1d780ef1ca073","submitter":{"id":86709,"url":"http://patchwork.ozlabs.org/api/1.2/people/86709/?format=json","name":"Krzysztof Wilczyński","email":"kwilczynski@kernel.org"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linux-pci/patch/20260508043543.217179-25-kwilczynski@kernel.org/mbox/","series":[{"id":503321,"url":"http://patchwork.ozlabs.org/api/1.2/series/503321/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-pci/list/?series=503321","date":"2026-05-08T04:35:19","name":"PCI: Convert all dynamic sysfs attributes to static","version":7,"mbox":"http://patchwork.ozlabs.org/series/503321/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2234815/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2234815/checks/","tags":{},"related":[],"headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-pci@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=pDIZz6JT;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=172.234.253.10; helo=sea.lore.kernel.org;\n envelope-from=linux-pci+bounces-54217-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=\"pDIZz6JT\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=10.30.226.201"],"Received":["from sea.lore.kernel.org (sea.lore.kernel.org [172.234.253.10])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4gBbv85vY2z1yJq\n\tfor ; Fri, 08 May 2026 14:37:24 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sea.lore.kernel.org (Postfix) with ESMTP id E8B3C302882C\n\tfor ; Fri, 8 May 2026 04:37:16 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 68B221D9663;\n\tFri, 8 May 2026 04:37:16 +0000 (UTC)","from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org\n [10.30.226.201])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 45C6115539A;\n\tFri, 8 May 2026 04:37:16 +0000 (UTC)","by smtp.kernel.org (Postfix) with ESMTPSA id D7B32C2BCB0;\n\tFri, 8 May 2026 04:37:12 +0000 (UTC)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1778215036; cv=none;\n b=JtOvs1GvypVCCDWrHNsXu7Vz+eivuWuV0IFgFnc2ojf0rgjwREQr+VjWG4l+Unt0RaE742X0W0k9TVTkDFk8DgRlh/LGm3u79fBYw0mnC9Tj/5wHUe/kOcCOF/WNJ5tt4kHVNbrIW6c1PvHc7M4JfHbOeKX44QLpoFsno4Um1pM=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1778215036; c=relaxed/simple;\n\tbh=g1Q0Y9xFxmkBFDILfcdAU3XRw5NhqOHXxvlpf+w+W4s=;\n\th=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References:\n\t MIME-Version:Content-Type;\n b=Yflkpni5iTNoZuYAVY1bZvfiQIOugokzHcDgUpU2zYDST6xnPiXCN3iSy7rsi+Kw5nOFylSX27THex8waBSIkaj8gyNoEFemufWWfb81IvSp5+QRjGaKZo6spq73fY0/QfSWWmttki2u74T3yvci55J6+CuH/YYPx05Y2uz8h4A=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=pDIZz6JT; arc=none smtp.client-ip=10.30.226.201","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n\ts=k20201202; t=1778215036;\n\tbh=g1Q0Y9xFxmkBFDILfcdAU3XRw5NhqOHXxvlpf+w+W4s=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=pDIZz6JT+F50/NoXuF7lFmNqg8Xpq6ar8JHkiL1odWO86N+rOe8JidqrT7wtsIW3t\n\t 93FSlxaBsR1QokyyJQgywFCxNoHnJN1NdlhT9+bOWnTetGZ0UGfNr2EJYfRxtSa9+7\n\t QafCJBekO6SkU2yTq/Ljkct+pzdCfy1y6YRu75s/pcMlmDhnqoynyxXB9EWN3hAlq+\n\t ShPRwGhnWD94gNzGH+PKAm0G7/pWojPkWZV7fdHaAbDN0ZvvmcR/LehdvcM5/RxpQY\n\t fy+35MGYw1z1BM427XCnE9GzPrIrGwKKUJDZMlUpUYQFHur1LncvYHjphNqfo8qNUB\n\t zzg9mYwpDD3dw==","From":"=?utf-8?q?Krzysztof_Wilczy=C5=84ski?= ","To":"Bjorn Helgaas ","Cc":"Bjorn Helgaas ,\n Manivannan Sadhasivam ,\n Lorenzo Pieralisi ,\n Alex Williamson , Magnus Lindholm ,\n Matt Turner ,\n Richard Henderson ,\n Christophe Leroy ,\n Madhavan Srinivasan ,\n Michael Ellerman , Nicholas Piggin ,\n Dexuan Cui ,\n =?utf-8?q?Krzysztof_Ha=C5=82asa?= ,\n Lukas Wunner , \"Oliver O'Halloran\" ,\n Saurabh Singh Sengar ,\n Shuan He , Srivatsa Bhat ,\n\t=?utf-8?q?Ilpo_J=C3=A4rvinen?= ,\n linux-pci@vger.kernel.org, linux-alpha@vger.kernel.org,\n linuxppc-dev@lists.ozlabs.org","Subject":"[PATCH v7 24/24] PCI/sysfs: Limit BAR resize attribute scope to\n platforms with PCI mmap","Date":"Fri, 8 May 2026 04:35:43 +0000","Message-ID":"<20260508043543.217179-25-kwilczynski@kernel.org>","X-Mailer":"git-send-email 2.54.0","In-Reply-To":"<20260508043543.217179-1-kwilczynski@kernel.org>","References":"<20260508043543.217179-1-kwilczynski@kernel.org>","Precedence":"bulk","X-Mailing-List":"linux-pci@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit"},"content":"Currently, __resource_resize_store() uses sysfs_remove_groups()\nand sysfs_create_groups() on pci_dev_resource_attr_groups to\ntear down and recreate the resourceN files after a BAR resize,\nso the updated BAR sizes are visible in sysfs.\n\nThe resourceN files only exist on platforms that define\nHAVE_PCI_MMAP or ARCH_GENERIC_PCI_MMAP_RESOURCE. On platforms\nthat define neither, pci_dev_resource_attr_groups is NULL and\nthe sysfs_remove_groups() and sysfs_create_groups() calls in\n__resource_resize_store() become no-ops.\n\nResizable BAR (ReBAR) is a PCI Express extended capability\n(PCI_EXT_CAP_ID_REBAR) that requires PCIe extended config\nspace. Every PCIe-capable architecture defines HAVE_PCI_MMAP\nor ARCH_GENERIC_PCI_MMAP_RESOURCE (via arch headers or the\nasm-generic/pci.h fallback). Architectures without either\nonly support conventional PCI and cannot have any ReBAR-capable\ndevices.\n\nThus, move the resize show and store helpers, the per-BAR attribute\ndefinitions, and the attribute group behind the existing #ifdef\nHAVE_PCI_MMAP || ARCH_GENERIC_PCI_MMAP_RESOURCE guard, and fold the\ngroup reference in pci_dev_groups[] into the existing #if block.\n\nTested-by: Shivaprasad G Bhat \nSigned-off-by: Krzysztof Wilczyński \n---\n drivers/pci/pci-sysfs.c | 4 +++-\n 1 file changed, 3 insertions(+), 1 deletion(-)","diff":"diff --git a/drivers/pci/pci-sysfs.c b/drivers/pci/pci-sysfs.c\nindex f5427bcfb0cc..6099371f67e7 100644\n--- a/drivers/pci/pci-sysfs.c\n+++ b/drivers/pci/pci-sysfs.c\n@@ -1661,6 +1661,7 @@ static const struct attribute_group pci_dev_reset_method_attr_group = {\n \t.is_visible = pci_dev_reset_attr_is_visible,\n };\n \n+#if defined(HAVE_PCI_MMAP) || defined(ARCH_GENERIC_PCI_MMAP_RESOURCE)\n static ssize_t __resource_resize_show(struct device *dev, int n, char *buf)\n {\n \tstruct pci_dev *pdev = to_pci_dev(dev);\n@@ -1775,6 +1776,7 @@ static const struct attribute_group pci_dev_resource_resize_attr_group = {\n \t.attrs = resource_resize_attrs,\n \t.is_visible = resource_resize_attr_is_visible,\n };\n+#endif\n \n static struct attribute *pci_dev_dev_attrs[] = {\n \t&dev_attr_boot_vga.attr,\n@@ -1849,8 +1851,8 @@ const struct attribute_group *pci_dev_groups[] = {\n \t&pci_dev_resource_io_attr_group,\n \t&pci_dev_resource_uc_attr_group,\n \t&pci_dev_resource_wc_attr_group,\n-#endif\n \t&pci_dev_resource_resize_attr_group,\n+#endif\n \t&pci_dev_config_attr_group,\n \t&pci_dev_rom_attr_group,\n \t&pci_dev_reset_attr_group,\n","prefixes":["v7","24/24"]}