{"id":2234812,"url":"http://patchwork.ozlabs.org/api/1.2/patches/2234812/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-pci/patch/20260508043543.217179-22-kwilczynski@kernel.org/","project":{"id":28,"url":"http://patchwork.ozlabs.org/api/1.2/projects/28/?format=json","name":"Linux PCI development","link_name":"linux-pci","list_id":"linux-pci.vger.kernel.org","list_email":"linux-pci@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260508043543.217179-22-kwilczynski@kernel.org>","list_archive_url":null,"date":"2026-05-08T04:35:40","name":"[v7,21/24] PCI/sysfs: Add __weak pci_legacy_has_sparse() helper","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"52a3dc2f5995f083ef026d4e471564dc3553239a","submitter":{"id":86709,"url":"http://patchwork.ozlabs.org/api/1.2/people/86709/?format=json","name":"Krzysztof Wilczyński","email":"kwilczynski@kernel.org"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linux-pci/patch/20260508043543.217179-22-kwilczynski@kernel.org/mbox/","series":[{"id":503321,"url":"http://patchwork.ozlabs.org/api/1.2/series/503321/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-pci/list/?series=503321","date":"2026-05-08T04:35:19","name":"PCI: Convert all dynamic sysfs attributes to static","version":7,"mbox":"http://patchwork.ozlabs.org/series/503321/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2234812/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2234812/checks/","tags":{},"related":[],"headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-pci@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=gojkxWSs;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=172.234.253.10; helo=sea.lore.kernel.org;\n envelope-from=linux-pci+bounces-54214-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=\"gojkxWSs\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=10.30.226.201"],"Received":["from sea.lore.kernel.org (sea.lore.kernel.org [172.234.253.10])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4gBbtx67Klz1yJq\n\tfor ; Fri, 08 May 2026 14:37:13 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sea.lore.kernel.org (Postfix) with ESMTP id 18B8B3026300\n\tfor ; Fri, 8 May 2026 04:37:06 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id 7C29E1EE01A;\n\tFri, 8 May 2026 04:37:05 +0000 (UTC)","from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org\n [10.30.226.201])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id 5921515539A;\n\tFri, 8 May 2026 04:37:05 +0000 (UTC)","by smtp.kernel.org (Postfix) with ESMTPSA id EE601C2BCB0;\n\tFri, 8 May 2026 04:37:01 +0000 (UTC)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1778215025; cv=none;\n b=D0WwHPGWHjSZDSj7S2+sPnPd6xuHXIK7hUWSLx3C/gY8ELaqYqFs/6ZrHqATlgegkej0h0fwgxZrwlnC7GB2N3B939+Iy8MDDyNTRsXl035rS7JuKcU1TRPju8psppw8YRrMoKgpTPlQlY+R4nfMcoB90XuWYuPORDuFysoUlGA=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1778215025; c=relaxed/simple;\n\tbh=dvrWWiezWy8a25eOYZ7kT3ZuDPygnOIs6x7THQzp8XQ=;\n\th=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References:\n\t MIME-Version:Content-Type;\n b=L1MMo31jlpuF3X/IhUii28/UYqSEfvQkB2VSnLX2LXrwWSLSEUmcdFa8zyaO8+Eo2CYj6CpHIdkxSHX8LkxAVQqUxyqcCu+umUXTsNnVboS+oBm4RxQlEh42ljwcxtpwg+/u6e98UhUV1ylBq6Etn9STwmoylWkL5WEX3ItM29o=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=gojkxWSs; arc=none smtp.client-ip=10.30.226.201","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n\ts=k20201202; t=1778215025;\n\tbh=dvrWWiezWy8a25eOYZ7kT3ZuDPygnOIs6x7THQzp8XQ=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=gojkxWSsjs4HHq9Sz1NSR2O576qHSQJY9wjQgo3bfowHdAoHZaa2OE4OAIT5iyLuP\n\t 1VpquJbvclXBjRHzxZVoiaJSQm2KwI5VPFtECPmugIzmuvpF01L1CdZ1Yjr+cEJVC3\n\t Ak226U0ylzCooHHs2Q9NZp3EfiQYOOGqhd63jMVXMSq71IBWsjMVr+Wq9sjwozh97L\n\t QxTwsxqawiRzUVwLTbNnwDEOqzjD2/st35DFOcvcz+br+7wpfW5xaoSw4uBOuLmCxM\n\t BqUa22aGeF+PkSv+tOokpEGR+dM9F5rxgNRml1vbS7Jb+3HweCOElZNafhXQPdmZh+\n\t Iuvqb+63kgpMQ==","From":"=?utf-8?q?Krzysztof_Wilczy=C5=84ski?= ","To":"Bjorn Helgaas ","Cc":"Bjorn Helgaas ,\n Manivannan Sadhasivam ,\n Lorenzo Pieralisi ,\n Alex Williamson , Magnus Lindholm ,\n Matt Turner ,\n Richard Henderson ,\n Christophe Leroy ,\n Madhavan Srinivasan ,\n Michael Ellerman , Nicholas Piggin ,\n Dexuan Cui ,\n =?utf-8?q?Krzysztof_Ha=C5=82asa?= ,\n Lukas Wunner , \"Oliver O'Halloran\" ,\n Saurabh Singh Sengar ,\n Shuan He , Srivatsa Bhat ,\n\t=?utf-8?q?Ilpo_J=C3=A4rvinen?= ,\n linux-pci@vger.kernel.org, linux-alpha@vger.kernel.org,\n linuxppc-dev@lists.ozlabs.org","Subject":"[PATCH v7 21/24] PCI/sysfs: Add __weak pci_legacy_has_sparse() helper","Date":"Fri, 8 May 2026 04:35:40 +0000","Message-ID":"<20260508043543.217179-22-kwilczynski@kernel.org>","X-Mailer":"git-send-email 2.54.0","In-Reply-To":"<20260508043543.217179-1-kwilczynski@kernel.org>","References":"<20260508043543.217179-1-kwilczynski@kernel.org>","Precedence":"bulk","X-Mailing-List":"linux-pci@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit"},"content":"Currently, Alpha's sparse/dense legacy attribute handling is done via\npci_adjust_legacy_attr(), which updates dynamically allocated attributes\nat runtime. The upcoming conversion to static attributes needs a way\nto determine sparse support at visibility check time.\n\nAdd a __weak pci_legacy_has_sparse() that returns false by default.\nAlpha overrides it to check has_sparse() on the bus host controller.\n\nTested-by: Shivaprasad G Bhat \nSigned-off-by: Krzysztof Wilczyński \n---\n arch/alpha/include/asm/pci.h | 2 ++\n arch/alpha/kernel/pci-sysfs.c | 7 +++++++\n drivers/pci/pci-sysfs.c | 6 ++++++\n drivers/pci/pci.h | 4 ++++\n 4 files changed, 19 insertions(+)","diff":"diff --git a/arch/alpha/include/asm/pci.h b/arch/alpha/include/asm/pci.h\nindex ef19295f2e33..95de7ffd59e8 100644\n--- a/arch/alpha/include/asm/pci.h\n+++ b/arch/alpha/include/asm/pci.h\n@@ -86,6 +86,8 @@ extern int pci_mmap_legacy_page_range(struct pci_bus *bus,\n \t\t\t\t enum pci_mmap_state mmap_state);\n extern void pci_adjust_legacy_attr(struct pci_bus *bus,\n \t\t\t\t enum pci_mmap_state mmap_type);\n+extern bool pci_legacy_has_sparse(struct pci_bus *bus,\n+\t\t\t\t enum pci_mmap_state type);\n #define HAVE_PCI_LEGACY\t1\n \n extern const struct attribute_group pci_dev_resource_attr_group;\ndiff --git a/arch/alpha/kernel/pci-sysfs.c b/arch/alpha/kernel/pci-sysfs.c\nindex 89329910b890..2d46502ba09b 100644\n--- a/arch/alpha/kernel/pci-sysfs.c\n+++ b/arch/alpha/kernel/pci-sysfs.c\n@@ -185,6 +185,13 @@ int pci_mmap_legacy_page_range(struct pci_bus *bus, struct vm_area_struct *vma,\n \treturn hose_mmap_page_range(hose, vma, mmap_type, sparse);\n }\n \n+bool pci_legacy_has_sparse(struct pci_bus *bus, enum pci_mmap_state type)\n+{\n+\tstruct pci_controller *hose = bus->sysdata;\n+\n+\treturn has_sparse(hose, type);\n+}\n+\n /**\n * pci_adjust_legacy_attr - adjustment of legacy file attributes\n * @bus: bus to create files under\ndiff --git a/drivers/pci/pci-sysfs.c b/drivers/pci/pci-sysfs.c\nindex 7ba12b2abe48..1e6786463e4e 100644\n--- a/drivers/pci/pci-sysfs.c\n+++ b/drivers/pci/pci-sysfs.c\n@@ -983,6 +983,12 @@ static int pci_mmap_legacy_io(struct file *filp, struct kobject *kobj,\n \treturn pci_mmap_legacy_page_range(bus, vma, pci_mmap_io);\n }\n \n+bool __weak pci_legacy_has_sparse(struct pci_bus *bus,\n+\t\t\t\t enum pci_mmap_state type)\n+{\n+\treturn false;\n+}\n+\n /**\n * pci_adjust_legacy_attr - adjustment of legacy file attributes\n * @b: bus to create files under\ndiff --git a/drivers/pci/pci.h b/drivers/pci/pci.h\nindex 71a1fde1e505..c64c7f5f0bcf 100644\n--- a/drivers/pci/pci.h\n+++ b/drivers/pci/pci.h\n@@ -392,6 +392,10 @@ static inline int pci_no_d1d2(struct pci_dev *dev)\n \n }\n \n+#ifdef HAVE_PCI_LEGACY\n+bool pci_legacy_has_sparse(struct pci_bus *bus, enum pci_mmap_state type);\n+#endif\n+\n #ifdef CONFIG_SYSFS\n extern const struct attribute_group *pci_dev_groups[];\n extern const struct attribute_group *pci_dev_attr_groups[];\n","prefixes":["v7","21/24"]}