{"id":2234808,"url":"http://patchwork.ozlabs.org/api/1.2/patches/2234808/?format=json","web_url":"http://patchwork.ozlabs.org/project/linuxppc-dev/patch/20260508043543.217179-10-kwilczynski@kernel.org/","project":{"id":2,"url":"http://patchwork.ozlabs.org/api/1.2/projects/2/?format=json","name":"Linux PPC development","link_name":"linuxppc-dev","list_id":"linuxppc-dev.lists.ozlabs.org","list_email":"linuxppc-dev@lists.ozlabs.org","web_url":"https://github.com/linuxppc/wiki/wiki","scm_url":"https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git","webscm_url":"https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/","list_archive_url":"https://lore.kernel.org/linuxppc-dev/","list_archive_url_format":"https://lore.kernel.org/linuxppc-dev/{}/","commit_url_format":"https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/commit/?id={}"},"msgid":"<20260508043543.217179-10-kwilczynski@kernel.org>","list_archive_url":"https://lore.kernel.org/linuxppc-dev/20260508043543.217179-10-kwilczynski@kernel.org/","date":"2026-05-08T04:35:28","name":"[v7,09/24] PCI/sysfs: Add stubs for pci_{create,remove}_sysfs_dev_files()","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"ecd807f5d0b463004540edcad5d31171345378e5","submitter":{"id":86709,"url":"http://patchwork.ozlabs.org/api/1.2/people/86709/?format=json","name":"Krzysztof Wilczyński","email":"kwilczynski@kernel.org"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linuxppc-dev/patch/20260508043543.217179-10-kwilczynski@kernel.org/mbox/","series":[{"id":503322,"url":"http://patchwork.ozlabs.org/api/1.2/series/503322/?format=json","web_url":"http://patchwork.ozlabs.org/project/linuxppc-dev/list/?series=503322","date":"2026-05-08T04:35:20","name":"PCI: Convert all dynamic sysfs attributes to static","version":7,"mbox":"http://patchwork.ozlabs.org/series/503322/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2234808/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2234808/checks/","tags":{},"related":[],"headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=sxOthkBj;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.ozlabs.org\n (client-ip=112.213.38.117; helo=lists.ozlabs.org;\n envelope-from=linuxppc-dev+bounces-20593-incoming=patchwork.ozlabs.org@lists.ozlabs.org;\n receiver=patchwork.ozlabs.org)","lists.ozlabs.org;\n arc=none smtp.remote-ip=\"2600:3c04:e001:324:0:1991:8:25\"","lists.ozlabs.org;\n dmarc=pass (p=quarantine dis=none) header.from=kernel.org","lists.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=sxOthkBj;\n\tdkim-atps=neutral","lists.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=kernel.org\n (client-ip=2600:3c04:e001:324:0:1991:8:25; helo=tor.source.kernel.org;\n envelope-from=kwilczynski@kernel.org; receiver=lists.ozlabs.org)"],"Received":["from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4gBbtm74Xxz1yJq\n\tfor ; Fri, 08 May 2026 14:37:04 +1000 (AEST)","from boromir.ozlabs.org (localhost [127.0.0.1])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 4gBbt069LHz30FR;\n\tFri, 08 May 2026 14:36:24 +1000 (AEST)","from tor.source.kernel.org (tor.source.kernel.org\n [IPv6:2600:3c04:e001:324:0:1991:8:25])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 4gBbsz6TvSz2xPb\n\tfor ; Fri, 08 May 2026 14:36:23 +1000 (AEST)","from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58])\n\tby tor.source.kernel.org (Postfix) with ESMTP id D2DA260252;\n\tFri, 8 May 2026 04:36:21 +0000 (UTC)","by smtp.kernel.org (Postfix) with ESMTPSA id 441EFC2BCB0;\n\tFri, 8 May 2026 04:36:18 +0000 (UTC)"],"ARC-Seal":"i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1778214984;\n\tcv=none;\n b=H3pHqpXv9HeP6UMrm/BJRw9Sib+qIcd9J0tsNzDMcX6Sy2kZAq5QVx3q9on5bnhXuYxJfUTvvhTck+nEClU7/iVkieYe/HlfE7b8l9yFQ8noQyLlYOU3bmfTvPvGc5S6uGyy+fzVMKi58cYf4FZC19CPq94jOGaSUBTuHLap+XoeBF4GZwpU33Xg4pQfrvlpZRCibxG3NS1pZq2MpeWOhsx0uIsqYnc+wRrGd/04I0oedl/eCBYr3Ewum3ws0uVLXWh5sNByd/0aUhKtL/FrM7Y1a2TdT7pM2qmXXKsLSQbI0EcUpdaIacz5iw+4L0vA1hj4MBPEzO0YZfbXEc+LdA==","ARC-Message-Signature":"i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707;\n\tt=1778214984; c=relaxed/relaxed;\n\tbh=G7vvuML/vlX61wzSso2iKZ900gHCcojNMcvFUY3HU+M=;\n\th=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References:\n\t MIME-Version:Content-Type;\n b=I3pyNSQIPX0zHNCUQNHrDvss30qINZrFKlkuDaW449qx58mFpd9dXDgJCJisdeoWERkWVUG3v3sT9o3W85WXVllyX8pm9RvLNKp3g+MneebRSium6rxLCzB0fTT2brqR8UzYGnyWo9JMvXHVoE88qwCgbZOuOPVw2pb1sUvVM15d9DCrCAafG/UYJycmkmwtLi8ayJs+yMVF0D4fbxMMspCJoNWOEd6MNAYlslZ6sLFX5LAFQPmP74MLaFjl6SEuepwvUcHZgRbV/64vpL7KRM8vkgu9QZyXkdTX1zhhcPmi87wWe26Q5Ynqx6pz6PeT6tdXf5wszQ7B3lUo2NCfuA==","ARC-Authentication-Results":"i=1; lists.ozlabs.org;\n dmarc=pass (p=quarantine dis=none) header.from=kernel.org;\n dkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=sxOthkBj; dkim-atps=neutral;\n spf=pass (client-ip=2600:3c04:e001:324:0:1991:8:25;\n helo=tor.source.kernel.org; envelope-from=kwilczynski@kernel.org;\n receiver=lists.ozlabs.org) smtp.mailfrom=kernel.org","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n\ts=k20201202; t=1778214981;\n\tbh=Ew4oMNbnD8ia1TjtEFnnPOCDhh0UnWgZ8/ajVBdz8Ew=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=sxOthkBj5rg2x+ly9mDbKmZWCrVE3aShmLOl8pnETDp8SD//7Grkaf54TXZHTcj+M\n\t kYEwLwGHsn4ug0iz6F4wz8CrZ7XncknGp9LYOGmwOtwa0mVc8aT/AAr2LC5bmEPeYs\n\t VNNs9xF5IHwywcJGE0LnRfuEO17POLNu2WMMxywada0TsF4QU75ANi/W1JlDpj2w3f\n\t jD1872owyDSdkEn73zJVaz5yD6qSVU38b2mE1ow5NZqgNaZynM16KqoK+71j/h2SJV\n\t lwglyPQoajiAIWBRIad2lGx2daz9q9j2bXxgpniWTGJa0xk2Dxhh3BqrO9Y9f0TBZG\n\t c0+rDFeYRqMLQ==","From":"=?utf-8?q?Krzysztof_Wilczy=C5=84ski?= ","To":"Bjorn Helgaas ","Cc":"Bjorn Helgaas ,\n Manivannan Sadhasivam ,\n Lorenzo Pieralisi ,\n Alex Williamson , Magnus Lindholm ,\n Matt Turner ,\n Richard Henderson ,\n Christophe Leroy ,\n Madhavan Srinivasan ,\n Michael Ellerman , Nicholas Piggin ,\n Dexuan Cui ,\n =?utf-8?q?Krzysztof_Ha=C5=82asa?= ,\n Lukas Wunner , \"Oliver O'Halloran\" ,\n Saurabh Singh Sengar ,\n Shuan He , Srivatsa Bhat ,\n\t=?utf-8?q?Ilpo_J=C3=A4rvinen?= ,\n linux-pci@vger.kernel.org, linux-alpha@vger.kernel.org,\n linuxppc-dev@lists.ozlabs.org","Subject":"[PATCH v7 09/24] PCI/sysfs: Add stubs for\n pci_{create,remove}_sysfs_dev_files()","Date":"Fri, 8 May 2026 04:35:28 +0000","Message-ID":"<20260508043543.217179-10-kwilczynski@kernel.org>","X-Mailer":"git-send-email 2.54.0","In-Reply-To":"<20260508043543.217179-1-kwilczynski@kernel.org>","References":"<20260508043543.217179-1-kwilczynski@kernel.org>","X-Mailing-List":"linuxppc-dev@lists.ozlabs.org","List-Id":"","List-Help":"","List-Owner":"","List-Post":"","List-Archive":",\n ","List-Subscribe":",\n ,\n ","List-Unsubscribe":"","Precedence":"list","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","X-Spam-Status":"No, score=-0.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,\n\tDKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS\n\tautolearn=disabled version=4.0.1 OzLabs 8","X-Spam-Checker-Version":"SpamAssassin 4.0.1 (2024-03-25) on lists.ozlabs.org"},"content":"On platforms with HAVE_PCI_MMAP or ARCH_GENERIC_PCI_MMAP_RESOURCE,\nresource files are now handled by static attribute groups registered\nvia pci_dev_groups[].\n\nThus, the pci_create_sysfs_dev_files() and pci_remove_sysfs_dev_files()\ncan now be stubbed out, as the dynamic resource file creation is no\nlonger needed.\n\nAlso, simplify pci_sysfs_init() on these platforms to only iterate\nbuses for legacy attributes creation, skipping the per-device loop.\n\nMove the __weak stubs for pci_create_resource_files() and\npci_remove_resource_files() into the #else branch since only platforms\nwithout HAVE_PCI_MMAP (such as Alpha architecture) still need them.\nGuard the res_attr[] and res_attr_wc[] fields in struct pci_dev the\nsame way.\n\nTested-by: Shivaprasad G Bhat \nSigned-off-by: Krzysztof Wilczyński \n---\n drivers/pci/pci-sysfs.c | 15 ++++++++++++---\n include/linux/pci.h | 4 ++++\n 2 files changed, 16 insertions(+), 3 deletions(-)","diff":"diff --git a/drivers/pci/pci-sysfs.c b/drivers/pci/pci-sysfs.c\nindex f34415a401ec..b2a2de622f39 100644\n--- a/drivers/pci/pci-sysfs.c\n+++ b/drivers/pci/pci-sysfs.c\n@@ -1370,10 +1370,9 @@ static const struct attribute_group *pci_dev_resource_attr_groups[] = {\n };\n #else\n #define pci_dev_resource_attr_groups NULL\n-#endif\n-\n int __weak pci_create_resource_files(struct pci_dev *dev) { return 0; }\n void __weak pci_remove_resource_files(struct pci_dev *dev) { }\n+#endif\n \n /**\n * pci_write_rom - used to enable access to the PCI ROM display\n@@ -1742,6 +1741,10 @@ static const struct attribute_group pci_dev_resource_resize_attr_group = {\n \t.is_visible = resource_resize_attr_is_visible,\n };\n \n+#if defined(HAVE_PCI_MMAP) || defined(ARCH_GENERIC_PCI_MMAP_RESOURCE)\n+int pci_create_sysfs_dev_files(struct pci_dev *pdev) { return 0; }\n+void pci_remove_sysfs_dev_files(struct pci_dev *pdev) { }\n+#else\n int __must_check pci_create_sysfs_dev_files(struct pci_dev *pdev)\n {\n \tif (!sysfs_initialized)\n@@ -1763,9 +1766,15 @@ void pci_remove_sysfs_dev_files(struct pci_dev *pdev)\n \n \tpci_remove_resource_files(pdev);\n }\n+#endif\n \n static int __init pci_sysfs_init(void)\n {\n+#if defined(HAVE_PCI_MMAP) || defined(ARCH_GENERIC_PCI_MMAP_RESOURCE)\n+\tstruct pci_bus *pbus = NULL;\n+\n+\tsysfs_initialized = 1;\n+#else\n \tstruct pci_dev *pdev = NULL;\n \tstruct pci_bus *pbus = NULL;\n \tint retval;\n@@ -1778,7 +1787,7 @@ static int __init pci_sysfs_init(void)\n \t\t\treturn retval;\n \t\t}\n \t}\n-\n+#endif\n \twhile ((pbus = pci_find_next_bus(pbus)))\n \t\tpci_create_legacy_files(pbus);\n \ndiff --git a/include/linux/pci.h b/include/linux/pci.h\nindex 974605c9fce2..b998a56f6010 100644\n--- a/include/linux/pci.h\n+++ b/include/linux/pci.h\n@@ -515,8 +515,10 @@ struct pci_dev {\n \tspinlock_t\tpcie_cap_lock;\t\t/* Protects RMW ops in capability accessors */\n \tu32\t\tsaved_config_space[16]; /* Config space saved at suspend time */\n \tstruct hlist_head saved_cap_space;\n+#if !defined(HAVE_PCI_MMAP) && !defined(ARCH_GENERIC_PCI_MMAP_RESOURCE)\n \tstruct bin_attribute *res_attr[DEVICE_COUNT_RESOURCE]; /* sysfs file for resources */\n \tstruct bin_attribute *res_attr_wc[DEVICE_COUNT_RESOURCE]; /* sysfs file for WC mapping of resources */\n+#endif\n \n #ifdef CONFIG_HOTPLUG_PCI_PCIE\n \tunsigned int\tbroken_cmd_compl:1;\t/* No compl for some cmds */\n@@ -2531,8 +2533,10 @@ int pcibios_alloc_irq(struct pci_dev *dev);\n void pcibios_free_irq(struct pci_dev *dev);\n resource_size_t pcibios_default_alignment(void);\n \n+#if !defined(HAVE_PCI_MMAP) && !defined(ARCH_GENERIC_PCI_MMAP_RESOURCE)\n extern int pci_create_resource_files(struct pci_dev *dev);\n extern void pci_remove_resource_files(struct pci_dev *dev);\n+#endif\n \n #if defined(CONFIG_PCI_MMCONFIG) || defined(CONFIG_ACPI_MCFG)\n void __init pci_mmcfg_early_init(void);\n","prefixes":["v7","09/24"]}