{"id":2234795,"url":"http://patchwork.ozlabs.org/api/1.2/patches/2234795/?format=json","web_url":"http://patchwork.ozlabs.org/project/linuxppc-dev/patch/20260508043543.217179-6-kwilczynski@kernel.org/","project":{"id":2,"url":"http://patchwork.ozlabs.org/api/1.2/projects/2/?format=json","name":"Linux PPC development","link_name":"linuxppc-dev","list_id":"linuxppc-dev.lists.ozlabs.org","list_email":"linuxppc-dev@lists.ozlabs.org","web_url":"https://github.com/linuxppc/wiki/wiki","scm_url":"https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git","webscm_url":"https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/","list_archive_url":"https://lore.kernel.org/linuxppc-dev/","list_archive_url_format":"https://lore.kernel.org/linuxppc-dev/{}/","commit_url_format":"https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/commit/?id={}"},"msgid":"<20260508043543.217179-6-kwilczynski@kernel.org>","list_archive_url":"https://lore.kernel.org/linuxppc-dev/20260508043543.217179-6-kwilczynski@kernel.org/","date":"2026-05-08T04:35:24","name":"[v7,05/24] PCI/sysfs: Add CAP_SYS_ADMIN check to __resource_resize_store()","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"c49e0a73cbc2101568fc3de0ec56b181777ddad3","submitter":{"id":86709,"url":"http://patchwork.ozlabs.org/api/1.2/people/86709/?format=json","name":"Krzysztof Wilczyński","email":"kwilczynski@kernel.org"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linuxppc-dev/patch/20260508043543.217179-6-kwilczynski@kernel.org/mbox/","series":[{"id":503322,"url":"http://patchwork.ozlabs.org/api/1.2/series/503322/?format=json","web_url":"http://patchwork.ozlabs.org/project/linuxppc-dev/list/?series=503322","date":"2026-05-08T04:35:20","name":"PCI: Convert all dynamic sysfs attributes to static","version":7,"mbox":"http://patchwork.ozlabs.org/series/503322/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2234795/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2234795/checks/","tags":{},"related":[],"headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linuxppc-dev@lists.ozlabs.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=c6YrOJEL;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.ozlabs.org\n (client-ip=112.213.38.117; helo=lists.ozlabs.org;\n envelope-from=linuxppc-dev+bounces-20589-incoming=patchwork.ozlabs.org@lists.ozlabs.org;\n receiver=patchwork.ozlabs.org)","lists.ozlabs.org;\n arc=none smtp.remote-ip=\"2600:3c0a:e001:78e:0:1991:8:25\"","lists.ozlabs.org;\n dmarc=pass (p=quarantine dis=none) header.from=kernel.org","lists.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=c6YrOJEL;\n\tdkim-atps=neutral","lists.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=kernel.org\n (client-ip=2600:3c0a:e001:78e:0:1991:8:25; helo=sea.source.kernel.org;\n envelope-from=kwilczynski@kernel.org; receiver=lists.ozlabs.org)"],"Received":["from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4gBbt95t3lz1yJq\n\tfor ; Fri, 08 May 2026 14:36:33 +1000 (AEST)","from boromir.ozlabs.org (localhost [127.0.0.1])\n\tby lists.ozlabs.org (Postfix) with ESMTP id 4gBbsj5KlRz2yjx;\n\tFri, 08 May 2026 14:36:09 +1000 (AEST)","from sea.source.kernel.org (sea.source.kernel.org\n [IPv6:2600:3c0a:e001:78e:0:1991:8:25])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby lists.ozlabs.org (Postfix) with ESMTPS id 4gBbsj0TC7z2xPb\n\tfor ; Fri, 08 May 2026 14:36:09 +1000 (AEST)","from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58])\n\tby sea.source.kernel.org (Postfix) with ESMTP id 1FAC643C68;\n\tFri, 8 May 2026 04:36:07 +0000 (UTC)","by smtp.kernel.org (Postfix) with ESMTPSA id B03F2C2BCB4;\n\tFri, 8 May 2026 04:36:03 +0000 (UTC)"],"ARC-Seal":"i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707; t=1778214969;\n\tcv=none;\n b=X7DAFUry5k/f9Lc4R7I2wYknxExfmVT6werD7qGbPD3bHzO6UjiaOmGACLji2EEUd4Lq4kUXCqUOYFreTCzd/9/Ik0zORk7FvqTp3M+Za6qYDs8ZFtJevVGsIMrQ6ckynwUvLCmrP7ce8OLsX7n7la9K9r3mEKY2U3D2utXsA0//M8qvjaZOZurMOiCchH4CcS/EqTzWXA2ktmEz6cQKl4D9bVopV5aGaCaB82/cbC/HbEt4bF1Cic+u7Fg3b/ChOMviPkOcf2xMbEUpEyJrDyjtwA+vV2R+oLwXqo1BfUXEvv6Cc4UlKEW7zkR4HciNooplQPA2AuLpreUf8b//rw==","ARC-Message-Signature":"i=1; a=rsa-sha256; d=lists.ozlabs.org; s=201707;\n\tt=1778214969; c=relaxed/relaxed;\n\tbh=5ptdizEpjuYqeg2f+U9wBoigKTE1I9tlh/xOEI1cGXU=;\n\th=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References:\n\t MIME-Version:Content-Type;\n b=mYDente/43QSjyW7iKmIWF6YKh8TzelFKI4KYW9HJze6TPhr3nR2NIsSW8FkUj8Q8jgH0oUBjB7NOGNV3+pwi0jktpuqOyDYMl3jLcwDoR1NhMQs1FMvTQ1Y7sycsU42R+n0ByK6iz8PmPS/AyvpbxWzxKcsuUOHArozk6PSi7Lx8svdcq/lzNAPIPQz+AqnffhdF+kbTVQ52jvM0F0UAkkVRoP3SgDte2WODzxVWG0j3Jcrc5+hIqcHXOS86QhR2gTWc7/0WzLVuQjiU7cejhYHuQw9l0hVBrw6Eedhf19UboXA8VgqFZhg3JEqxRuI77p3aXKPC3136hB6/euBNA==","ARC-Authentication-Results":"i=1; lists.ozlabs.org;\n dmarc=pass (p=quarantine dis=none) header.from=kernel.org;\n dkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=c6YrOJEL; dkim-atps=neutral;\n spf=pass (client-ip=2600:3c0a:e001:78e:0:1991:8:25;\n helo=sea.source.kernel.org; envelope-from=kwilczynski@kernel.org;\n receiver=lists.ozlabs.org) smtp.mailfrom=kernel.org","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n\ts=k20201202; t=1778214967;\n\tbh=9KXLrBNGT0ToNu4fHZqX/w3XLpky3ur23Tmkqe8TgNA=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=c6YrOJELe42YPhzYmdxA2+pDGLb/lIIe88nH1uFnMhkVo6O/4Hmt77NyiEHQiaOz/\n\t 3lW3I9GpoGve5tNp1zxXkM7MW2Kuxd1dHEpoDZ41L0vuQk1iqISSLe3A8us/fJtd7d\n\t o0Bx1t5t02a6uc6MTVhdP7hlvzstCojKjCNiMYJD2QuET9VC2eHdq7NswApXbkusrk\n\t Kr1zOzU+p7Y+pLwWxcrDqxahePyzuZJ59CaQPJXVyW3sDqGFLaCRDaEPUB3/qJ1svY\n\t rGbmmWFcH7osNf2BlaJa+N0ZAj3Rh7vG5kKKDreZfWwhWdE8mx5dlKTDGf2ScSJIN+\n\t Ur8pxP9rFDk4A==","From":"=?utf-8?q?Krzysztof_Wilczy=C5=84ski?= ","To":"Bjorn Helgaas ","Cc":"Bjorn Helgaas ,\n Manivannan Sadhasivam ,\n Lorenzo Pieralisi ,\n Alex Williamson , Magnus Lindholm ,\n Matt Turner ,\n Richard Henderson ,\n Christophe Leroy ,\n Madhavan Srinivasan ,\n Michael Ellerman , Nicholas Piggin ,\n Dexuan Cui ,\n =?utf-8?q?Krzysztof_Ha=C5=82asa?= ,\n Lukas Wunner , \"Oliver O'Halloran\" ,\n Saurabh Singh Sengar ,\n Shuan He , Srivatsa Bhat ,\n\t=?utf-8?q?Ilpo_J=C3=A4rvinen?= ,\n linux-pci@vger.kernel.org, linux-alpha@vger.kernel.org,\n linuxppc-dev@lists.ozlabs.org","Subject":"[PATCH v7 05/24] PCI/sysfs: Add CAP_SYS_ADMIN check to\n __resource_resize_store()","Date":"Fri, 8 May 2026 04:35:24 +0000","Message-ID":"<20260508043543.217179-6-kwilczynski@kernel.org>","X-Mailer":"git-send-email 2.54.0","In-Reply-To":"<20260508043543.217179-1-kwilczynski@kernel.org>","References":"<20260508043543.217179-1-kwilczynski@kernel.org>","X-Mailing-List":"linuxppc-dev@lists.ozlabs.org","List-Id":"","List-Help":"","List-Owner":"","List-Post":"","List-Archive":",\n ","List-Subscribe":",\n ,\n ","List-Unsubscribe":"","Precedence":"list","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","X-Spam-Status":"No, score=-0.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED,\n\tDKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS\n\tautolearn=disabled version=4.0.1 OzLabs 8","X-Spam-Checker-Version":"SpamAssassin 4.0.1 (2024-03-25) on lists.ozlabs.org"},"content":"Currently, the __resource_resize_store() allows writing to the\nresourceN_resize sysfs attribute to change a BAR's size without\nchecking for capabilities, currently relying only on the file\naccess check.\n\nResizing a BAR modifies PCI device configuration and can disrupt\nactive drivers. After the upcoming conversion to static attributes,\nit will also trigger resource file updates via sysfs_update_groups().\n\nThus, add a CAP_SYS_ADMIN check to prevent unprivileged users from\nperforming BAR resize operations.\n\nTested-by: Shivaprasad G Bhat \nReviewed-by: Ilpo Järvinen \nSigned-off-by: Krzysztof Wilczyński \n---\n drivers/pci/pci-sysfs.c | 3 +++\n 1 file changed, 3 insertions(+)","diff":"diff --git a/drivers/pci/pci-sysfs.c b/drivers/pci/pci-sysfs.c\nindex 2280b7edb41f..dac780597727 100644\n--- a/drivers/pci/pci-sysfs.c\n+++ b/drivers/pci/pci-sysfs.c\n@@ -1596,6 +1596,9 @@ static ssize_t __resource_resize_store(struct device *dev, int n,\n \tint ret;\n \tu16 cmd;\n \n+\tif (!capable(CAP_SYS_ADMIN))\n+\t\treturn -EPERM;\n+\n \tif (kstrtoul(buf, 0, &size) < 0)\n \t\treturn -EINVAL;\n \n","prefixes":["v7","05/24"]}