{"id":2234784,"url":"http://patchwork.ozlabs.org/api/1.2/patches/2234784/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-pci/patch/20260508043543.217179-4-kwilczynski@kernel.org/","project":{"id":28,"url":"http://patchwork.ozlabs.org/api/1.2/projects/28/?format=json","name":"Linux PCI development","link_name":"linux-pci","list_id":"linux-pci.vger.kernel.org","list_email":"linux-pci@vger.kernel.org","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260508043543.217179-4-kwilczynski@kernel.org>","list_archive_url":null,"date":"2026-05-08T04:35:22","name":"[v7,03/24] PCI/sysfs: Only allow supported resource types in I/O and MMIO helpers","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"b9370f49211b59d4f1f6be9c80372823ce7e1104","submitter":{"id":86709,"url":"http://patchwork.ozlabs.org/api/1.2/people/86709/?format=json","name":"Krzysztof Wilczyński","email":"kwilczynski@kernel.org"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/linux-pci/patch/20260508043543.217179-4-kwilczynski@kernel.org/mbox/","series":[{"id":503321,"url":"http://patchwork.ozlabs.org/api/1.2/series/503321/?format=json","web_url":"http://patchwork.ozlabs.org/project/linux-pci/list/?series=503321","date":"2026-05-08T04:35:19","name":"PCI: Convert all dynamic sysfs attributes to static","version":7,"mbox":"http://patchwork.ozlabs.org/series/503321/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2234784/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2234784/checks/","tags":{},"related":[],"headers":{"Return-Path":"\n ","X-Original-To":["incoming@patchwork.ozlabs.org","linux-pci@vger.kernel.org"],"Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256\n header.s=k20201202 header.b=QZhjKYSe;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=vger.kernel.org\n (client-ip=172.234.253.10; helo=sea.lore.kernel.org;\n envelope-from=linux-pci+bounces-54196-incoming=patchwork.ozlabs.org@vger.kernel.org;\n receiver=patchwork.ozlabs.org)","smtp.subspace.kernel.org;\n\tdkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=\"QZhjKYSe\"","smtp.subspace.kernel.org;\n arc=none smtp.client-ip=10.30.226.201"],"Received":["from sea.lore.kernel.org (sea.lore.kernel.org [172.234.253.10])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4gBbsb2qc0z1yJq\n\tfor ; Fri, 08 May 2026 14:36:03 +1000 (AEST)","from smtp.subspace.kernel.org (conduit.subspace.kernel.org\n [100.90.174.1])\n\tby sea.lore.kernel.org (Postfix) with ESMTP id CBC3D3021705\n\tfor ; Fri, 8 May 2026 04:36:00 +0000 (UTC)","from localhost.localdomain (localhost.localdomain [127.0.0.1])\n\tby smtp.subspace.kernel.org (Postfix) with ESMTP id F05CF21254B;\n\tFri, 8 May 2026 04:35:59 +0000 (UTC)","from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org\n [10.30.226.201])\n\t(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby smtp.subspace.kernel.org (Postfix) with ESMTPS id CD3591EE01A;\n\tFri, 8 May 2026 04:35:59 +0000 (UTC)","by smtp.kernel.org (Postfix) with ESMTPSA id 61832C2BCC9;\n\tFri, 8 May 2026 04:35:56 +0000 (UTC)"],"ARC-Seal":"i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;\n\tt=1778214959; cv=none;\n b=CyAS6p2pM2tDJuu/P7f27+FfSh9j3yFUt4ONh6sBZnbRxr2E2mYXFqCaO3mk+Fc63fUyWtrQCGrDVz3effJpZ7mKtRyz9xNLiXxO9Lc3VNtSfhGpOxgmPP44lFbCGo3uDOiA/6YzOMJrdd4lkZYuxIW0fmpaAtHdkwsq9XYXWQk=","ARC-Message-Signature":"i=1; a=rsa-sha256; d=subspace.kernel.org;\n\ts=arc-20240116; t=1778214959; c=relaxed/simple;\n\tbh=YDXDaTiZL/jU7S6ZlvEHwWX8F+uGcw5PflPiSNCW/f8=;\n\th=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References:\n\t MIME-Version:Content-Type;\n b=ji5yzuR7xomhofNr/fMOpmBsDgBECFNc89Ct8O3yqJ5N13/MyvacjJj9spO3NWljpT9sW7E1Rns23LSo9QSbgAiwS6NP5DOjV8uHb1o8hxUNPPiNpC+LGeJW1aV1uqXPPvGdc210SI4KBCVgZYYGa9dQMsYezMdb2PnIfKKLiXQ=","ARC-Authentication-Results":"i=1; smtp.subspace.kernel.org;\n dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org\n header.b=QZhjKYSe; arc=none smtp.client-ip=10.30.226.201","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;\n\ts=k20201202; t=1778214959;\n\tbh=YDXDaTiZL/jU7S6ZlvEHwWX8F+uGcw5PflPiSNCW/f8=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=QZhjKYSeueGY0YycWg9jXDotOLQQrRaBu+rKhOqUx1FIoOxL0nPgUCJjEVYHRi3iA\n\t GVa9vS/Bb77kvgo78GJrDxvY5kVlfcEutAhqhw3Jyfj8qvAaSFVD90QjjNq92XF/WR\n\t FNse+jmJk3xyH+u8Y5OjFV5acUnTgTUd/oo5KYFBJpFusS8Pkwvd8ob8cCEMP5uyBM\n\t TnueFwwFHVCqaMBlJvKrYWrOv4ZRyA2k5xaovTGmeWfdq3O8w4h5sVMYGBIBNmO47U\n\t qj03i6Uwa6psunVhFFVkONBP+1BMccmWwSBUk1yl1Hju/2ol7ZD3XKSHuctiCA8J3T\n\t QNgc45tnaNbvA==","From":"=?utf-8?q?Krzysztof_Wilczy=C5=84ski?= ","To":"Bjorn Helgaas ","Cc":"Bjorn Helgaas ,\n Manivannan Sadhasivam ,\n Lorenzo Pieralisi ,\n Alex Williamson , Magnus Lindholm ,\n Matt Turner ,\n Richard Henderson ,\n Christophe Leroy ,\n Madhavan Srinivasan ,\n Michael Ellerman , Nicholas Piggin ,\n Dexuan Cui ,\n =?utf-8?q?Krzysztof_Ha=C5=82asa?= ,\n Lukas Wunner , \"Oliver O'Halloran\" ,\n Saurabh Singh Sengar ,\n Shuan He , Srivatsa Bhat ,\n\t=?utf-8?q?Ilpo_J=C3=A4rvinen?= ,\n linux-pci@vger.kernel.org, linux-alpha@vger.kernel.org,\n linuxppc-dev@lists.ozlabs.org","Subject":"[PATCH v7 03/24] PCI/sysfs: Only allow supported resource types in\n I/O and MMIO helpers","Date":"Fri, 8 May 2026 04:35:22 +0000","Message-ID":"<20260508043543.217179-4-kwilczynski@kernel.org>","X-Mailer":"git-send-email 2.54.0","In-Reply-To":"<20260508043543.217179-1-kwilczynski@kernel.org>","References":"<20260508043543.217179-1-kwilczynski@kernel.org>","Precedence":"bulk","X-Mailing-List":"linux-pci@vger.kernel.org","List-Id":"","List-Subscribe":"","List-Unsubscribe":"","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit"},"content":"Currently, when the sysfs attributes for PCI resources are added\ndynamically, the resource access callbacks are only set when the\nunderlying BAR type matches, using .read and .write for IORESOURCE_IO,\nand .mmap for IORESOURCE_MEM or IORESOURCE_IO with arch_can_pci_mmap_io()\nsupport. As such, when the callback is not set, the operation inherently\nfails.\n\nAfter the conversion to static attributes, visibility callbacks will\ncontrol which resource files appear for each BAR, but the callbacks\nthemselves will always be set.\n\nThus, add a type check to pci_resource_io() and pci_mmap_resource()\nto return -EIO for an unsupported resource type.\n\nUse the new pci_resource_is_io() and pci_resource_is_mem() helpers\nfor the type checks, replacing the open-coded bitwise flag tests and\nalso drop the local struct resource pointer in pci_mmap_resource().\n\nTested-by: Shivaprasad G Bhat \nReviewed-by: Ilpo Järvinen \nSigned-off-by: Krzysztof Wilczyński \n---\n drivers/pci/pci-sysfs.c | 13 ++++++++++---\n 1 file changed, 10 insertions(+), 3 deletions(-)","diff":"diff --git a/drivers/pci/pci-sysfs.c b/drivers/pci/pci-sysfs.c\nindex 1fbc3daf87cc..2e4e226e78d4 100644\n--- a/drivers/pci/pci-sysfs.c\n+++ b/drivers/pci/pci-sysfs.c\n@@ -1082,20 +1082,24 @@ static int pci_mmap_resource(struct kobject *kobj, const struct bin_attribute *a\n \tstruct pci_dev *pdev = to_pci_dev(kobj_to_dev(kobj));\n \tint bar = (unsigned long)attr->private;\n \tenum pci_mmap_state mmap_type;\n-\tstruct resource *res = pci_resource_n(pdev, bar);\n \tint ret;\n \n \tret = security_locked_down(LOCKDOWN_PCI_ACCESS);\n \tif (ret)\n \t\treturn ret;\n \n-\tif (res->flags & IORESOURCE_MEM && iomem_is_exclusive(res->start))\n+\tif (!pci_resource_is_mem(pdev, bar) &&\n+\t !(pci_resource_is_io(pdev, bar) && arch_can_pci_mmap_io()))\n+\t\treturn -EIO;\n+\n+\tif (pci_resource_is_mem(pdev, bar) &&\n+\t iomem_is_exclusive(pci_resource_start(pdev, bar)))\n \t\treturn -EINVAL;\n \n \tif (!pci_mmap_fits(pdev, bar, vma, PCI_MMAP_SYSFS))\n \t\treturn -EINVAL;\n \n-\tmmap_type = res->flags & IORESOURCE_MEM ? pci_mmap_mem : pci_mmap_io;\n+\tmmap_type = pci_resource_is_mem(pdev, bar) ? pci_mmap_mem : pci_mmap_io;\n \n \treturn pci_mmap_resource_range(pdev, bar, vma, mmap_type, write_combine);\n }\n@@ -1123,6 +1127,9 @@ static ssize_t pci_resource_io(struct file *filp, struct kobject *kobj,\n \tint bar = (unsigned long)attr->private;\n \tunsigned long port = off;\n \n+\tif (!pci_resource_is_io(pdev, bar))\n+\t\treturn -EIO;\n+\n \tport += pci_resource_start(pdev, bar);\n \n \tif (port > pci_resource_end(pdev, bar))\n","prefixes":["v7","03/24"]}