{"id":2234761,"url":"http://patchwork.ozlabs.org/api/1.2/patches/2234761/?format=json","web_url":"http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20260507214706.309984-3-khai.wen.tan@linux.intel.com/","project":{"id":46,"url":"http://patchwork.ozlabs.org/api/1.2/projects/46/?format=json","name":"Intel Wired Ethernet development","link_name":"intel-wired-lan","list_id":"intel-wired-lan.osuosl.org","list_email":"intel-wired-lan@osuosl.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260507214706.309984-3-khai.wen.tan@linux.intel.com>","list_archive_url":null,"date":"2026-05-07T21:47:04","name":"[iwl-next,v5,2/4] igc: move autoneg-enabled settings into igc_handle_autoneg_enabled()","commit_ref":null,"pull_url":null,"state":"under-review","archived":false,"hash":"4365047b0efb4729adcf01274bbd73d87ed8bc32","submitter":{"id":93102,"url":"http://patchwork.ozlabs.org/api/1.2/people/93102/?format=json","name":"KhaiWenTan","email":"khai.wen.tan@linux.intel.com"},"delegate":{"id":109701,"url":"http://patchwork.ozlabs.org/api/1.2/users/109701/?format=json","username":"anguy11","first_name":"Anthony","last_name":"Nguyen","email":"anthony.l.nguyen@intel.com"},"mbox":"http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20260507214706.309984-3-khai.wen.tan@linux.intel.com/mbox/","series":[{"id":503316,"url":"http://patchwork.ozlabs.org/api/1.2/series/503316/?format=json","web_url":"http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=503316","date":"2026-05-07T21:47:02","name":"igc: add support for forcing link speed without autonegotiation","version":5,"mbox":"http://patchwork.ozlabs.org/series/503316/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2234761/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2234761/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=osuosl.org header.i=@osuosl.org header.a=rsa-sha256\n header.s=default header.b=jiHRKVBe;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org\n (client-ip=140.211.166.136; helo=smtp3.osuosl.org;\n envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4gBZqH5fWxz1yK7\n\tfor ; Fri, 08 May 2026 13:48:59 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby smtp3.osuosl.org (Postfix) with ESMTP id BBFF660DD4;\n\tFri, 8 May 2026 03:48:57 +0000 (UTC)","from smtp3.osuosl.org ([127.0.0.1])\n by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id u13JUyTKw2XO; Fri, 8 May 2026 03:48:57 +0000 (UTC)","from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142])\n\tby smtp3.osuosl.org (Postfix) with ESMTP id 0134260ABD;\n\tFri, 8 May 2026 03:48:57 +0000 (UTC)","from smtp3.osuosl.org (smtp3.osuosl.org [IPv6:2605:bc80:3010::136])\n by lists1.osuosl.org (Postfix) with ESMTP id 83C85272\n for ; Fri, 8 May 2026 03:48:55 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n by smtp3.osuosl.org (Postfix) with ESMTP id 6A02460AC0\n for ; Fri, 8 May 2026 03:48:55 +0000 (UTC)","from smtp3.osuosl.org ([127.0.0.1])\n by localhost (smtp3.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id ZQb5O8tE9dFh for ;\n Fri, 8 May 2026 03:48:54 +0000 (UTC)","from mgamail.intel.com (mgamail.intel.com [198.175.65.13])\n by smtp3.osuosl.org (Postfix) with ESMTPS id 5462F60ABD\n for ; Fri, 8 May 2026 03:48:54 +0000 (UTC)","from orviesa009.jf.intel.com ([10.64.159.149])\n by orvoesa105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 07 May 2026 20:48:54 -0700","from unknown (HELO localhost.png.intel.com) ([10.107.255.61])\n by orviesa009.jf.intel.com with ESMTP; 07 May 2026 20:48:49 -0700"],"X-Virus-Scanned":["amavis at osuosl.org","amavis at osuosl.org"],"X-Comment":"SPF check N/A for local connections - client-ip=140.211.166.142;\n helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver= ","DKIM-Filter":["OpenDKIM Filter v2.11.0 smtp3.osuosl.org 0134260ABD","OpenDKIM Filter v2.11.0 smtp3.osuosl.org 5462F60ABD"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org;\n\ts=default; t=1778212137;\n\tbh=KQsaFjlZc7xQucmXUqmh6eg0AqeLIJviziYAaDxtSt4=;\n\th=From:To:Cc:Date:In-Reply-To:References:Subject:List-Id:\n\t List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe:\n\t From;\n\tb=jiHRKVBeSEWhfcJg5wgAjqVFLhJYygurKSnNGUCCTCQq7pC0lUn/i51FkjlSYZVpW\n\t H5vLMqbEO9vEUJ86Hah544u5poYYus6mCD2DQVAZNCp/drCSL6e1iHv2oqrri2AVqZ\n\t rESH3WGtts/jzC1Tc/3czw2aFUN6CBRYIhZTo5HGAjnHpmNCj4/6pUl4jkpcR0jTFJ\n\t NPvy8rQLdGKnuML181KglmvHsdtWEXxCqUOJ5mSZAmPrvVKzZ6QnR5RIKW7Hrbfhfk\n\t JjlIu4k4qcpcYnc7uPjdRkHyn30cZ2Nb84zrNuFKqPKmDRKJOSXk5Iv3Rzju7Gn56R\n\t mPCnKfoFVbBVQ==","Received-SPF":"Pass (mailfrom) identity=mailfrom; client-ip=198.175.65.13;\n helo=mgamail.intel.com; envelope-from=khai.wen.tan@linux.intel.com;\n receiver=","DMARC-Filter":"OpenDMARC Filter v1.4.2 smtp3.osuosl.org 5462F60ABD","X-CSE-ConnectionGUID":["MjhI6qF5T+WzVAk+rYSv4Q==","X/QL0LFtS2Kapf7mTNXiKA=="],"X-CSE-MsgGUID":["wVTe4CVqS2GgPYCfEpi2vQ==","cxCc4oY6RE6NTtsN3b8B8w=="],"X-IronPort-AV":["E=McAfee;i=\"6800,10657,11779\"; a=\"90278878\"","E=Sophos;i=\"6.23,222,1770624000\"; d=\"scan'208\";a=\"90278878\"","E=Sophos;i=\"6.23,222,1770624000\"; d=\"scan'208\";a=\"236767311\""],"X-ExtLoop1":"1","From":"KhaiWenTan ","To":"anthony.l.nguyen@intel.com, przemyslaw.kitszel@intel.com,\n andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com,\n kuba@kernel.org, pabeni@redhat.com","Cc":"intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org,\n linux-kernel@vger.kernel.org, faizal.abdul.rahim@intel.com,\n hong.aun.looi@intel.com, hector.blanco.alcaine@intel.com,\n khai.wen.tan@intel.com, Faizal Rahim ,\n Aleksandr Loktionov ,\n Khai Wen Tan ","Date":"Fri, 8 May 2026 05:47:04 +0800","Message-ID":"<20260507214706.309984-3-khai.wen.tan@linux.intel.com>","X-Mailer":"git-send-email 2.43.0","In-Reply-To":"<20260507214706.309984-1-khai.wen.tan@linux.intel.com>","References":"<20260507214706.309984-1-khai.wen.tan@linux.intel.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-Mailman-Original-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1778212135; x=1809748135;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=OzVx/xeWQnGHVkDtrIL36NcQb5HsBgwSnA/5p4iz8DI=;\n b=KBrIzQThObjhhlNrQpL1e4iOHfN5YdDNFtsYWkNuO4lTUpMPSE1tA64T\n OcGkAb/REK849y7UOi4sXJG65iaAipzmTSABfTjHOVhJ/35tSscDNmybn\n QhnMWQd1QZUisuNCmy3qHlRK/mNOdRQG2Ia3MTOMX/HJ+zdg+bEmqZoxy\n FDY3kcyIn1H/4XOj7qq+aFnO58H1F1HykzAIjbS2/cZ3SqfZTM4niwfP4\n s1P3zV6liWVlRdhoqof3DGvU74qnCAoiEPo0Eao4EsxIAw0ksySc9ZJ3+\n r1cil0QhRndM0ACKw9asuPu5FXEuSESDOI1y/unnKlRi7phPaj8AnIFbB\n w==;","X-Mailman-Original-Authentication-Results":["smtp3.osuosl.org;\n dmarc=none (p=none dis=none)\n header.from=linux.intel.com","smtp3.osuosl.org;\n dkim=pass (2048-bit key,\n unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256\n header.s=Intel header.b=KBrIzQTh"],"Subject":"[Intel-wired-lan] [PATCH iwl-next v5 2/4] igc: move autoneg-enabled\n settings into igc_handle_autoneg_enabled()","X-BeenThere":"intel-wired-lan@osuosl.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"Intel Wired Ethernet Linux Kernel Driver Development\n ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"intel-wired-lan-bounces@osuosl.org","Sender":"\"Intel-wired-lan\" "},"content":"From: Faizal Rahim \n\nMove the advertised link modes and flow control configuration from\nigc_ethtool_set_link_ksettings() into igc_handle_autoneg_enabled().\n\nNo functional change.\n\nReviewed-by: Looi Hong Aun \nReviewed-by: Aleksandr Loktionov \nSigned-off-by: Faizal Rahim \nSigned-off-by: Khai Wen Tan \n---\n drivers/net/ethernet/intel/igc/igc_ethtool.c | 72 ++++++++++++--------\n 1 file changed, 44 insertions(+), 28 deletions(-)","diff":"diff --git a/drivers/net/ethernet/intel/igc/igc_ethtool.c b/drivers/net/ethernet/intel/igc/igc_ethtool.c\nindex 0122009bedd0..cfcbf2fdad6e 100644\n--- a/drivers/net/ethernet/intel/igc/igc_ethtool.c\n+++ b/drivers/net/ethernet/intel/igc/igc_ethtool.c\n@@ -2000,6 +2000,49 @@ static int igc_ethtool_get_link_ksettings(struct net_device *netdev,\n \treturn 0;\n }\n \n+/**\n+ * igc_handle_autoneg_enabled - Configure autonegotiation advertisement\n+ * @adapter: private driver structure\n+ * @cmd: ethtool link ksettings from user\n+ *\n+ * Records advertised speeds and flow control settings when autoneg\n+ * is enabled.\n+ */\n+static void igc_handle_autoneg_enabled(struct igc_adapter *adapter,\n+\t\t\t\t const struct ethtool_link_ksettings *cmd)\n+{\n+\tstruct igc_hw *hw = &adapter->hw;\n+\tu16 advertised = 0;\n+\n+\tif (ethtool_link_ksettings_test_link_mode(cmd, advertising,\n+\t\t\t\t\t\t 2500baseT_Full))\n+\t\tadvertised |= ADVERTISE_2500_FULL;\n+\n+\tif (ethtool_link_ksettings_test_link_mode(cmd, advertising,\n+\t\t\t\t\t\t 1000baseT_Full))\n+\t\tadvertised |= ADVERTISE_1000_FULL;\n+\n+\tif (ethtool_link_ksettings_test_link_mode(cmd, advertising,\n+\t\t\t\t\t\t 100baseT_Full))\n+\t\tadvertised |= ADVERTISE_100_FULL;\n+\n+\tif (ethtool_link_ksettings_test_link_mode(cmd, advertising,\n+\t\t\t\t\t\t 100baseT_Half))\n+\t\tadvertised |= ADVERTISE_100_HALF;\n+\n+\tif (ethtool_link_ksettings_test_link_mode(cmd, advertising,\n+\t\t\t\t\t\t 10baseT_Full))\n+\t\tadvertised |= ADVERTISE_10_FULL;\n+\n+\tif (ethtool_link_ksettings_test_link_mode(cmd, advertising,\n+\t\t\t\t\t\t 10baseT_Half))\n+\t\tadvertised |= ADVERTISE_10_HALF;\n+\n+\thw->phy.autoneg_advertised = advertised;\n+\tif (adapter->fc_autoneg)\n+\t\thw->fc.requested_mode = igc_fc_default;\n+}\n+\n static int\n igc_ethtool_set_link_ksettings(struct net_device *netdev,\n \t\t\t const struct ethtool_link_ksettings *cmd)\n@@ -2007,7 +2050,6 @@ igc_ethtool_set_link_ksettings(struct net_device *netdev,\n \tstruct igc_adapter *adapter = netdev_priv(netdev);\n \tstruct net_device *dev = adapter->netdev;\n \tstruct igc_hw *hw = &adapter->hw;\n-\tu16 advertised = 0;\n \n \t/* When adapter in resetting mode, autoneg/speed/duplex\n \t * cannot be changed\n@@ -2032,34 +2074,8 @@ igc_ethtool_set_link_ksettings(struct net_device *netdev,\n \twhile (test_and_set_bit(__IGC_RESETTING, &adapter->state))\n \t\tusleep_range(1000, 2000);\n \n-\tif (ethtool_link_ksettings_test_link_mode(cmd, advertising,\n-\t\t\t\t\t\t 2500baseT_Full))\n-\t\tadvertised |= ADVERTISE_2500_FULL;\n-\n-\tif (ethtool_link_ksettings_test_link_mode(cmd, advertising,\n-\t\t\t\t\t\t 1000baseT_Full))\n-\t\tadvertised |= ADVERTISE_1000_FULL;\n-\n-\tif (ethtool_link_ksettings_test_link_mode(cmd, advertising,\n-\t\t\t\t\t\t 100baseT_Full))\n-\t\tadvertised |= ADVERTISE_100_FULL;\n-\n-\tif (ethtool_link_ksettings_test_link_mode(cmd, advertising,\n-\t\t\t\t\t\t 100baseT_Half))\n-\t\tadvertised |= ADVERTISE_100_HALF;\n-\n-\tif (ethtool_link_ksettings_test_link_mode(cmd, advertising,\n-\t\t\t\t\t\t 10baseT_Full))\n-\t\tadvertised |= ADVERTISE_10_FULL;\n-\n-\tif (ethtool_link_ksettings_test_link_mode(cmd, advertising,\n-\t\t\t\t\t\t 10baseT_Half))\n-\t\tadvertised |= ADVERTISE_10_HALF;\n-\n \tif (cmd->base.autoneg == AUTONEG_ENABLE) {\n-\t\thw->phy.autoneg_advertised = advertised;\n-\t\tif (adapter->fc_autoneg)\n-\t\t\thw->fc.requested_mode = igc_fc_default;\n+\t\tigc_handle_autoneg_enabled(adapter, cmd);\n \t} else {\n \t\tnetdev_info(dev, \"Force mode currently not supported\\n\");\n \t}\n","prefixes":["iwl-next","v5","2/4"]}