{"id":2234760,"url":"http://patchwork.ozlabs.org/api/1.2/patches/2234760/?format=json","web_url":"http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20260507214706.309984-2-khai.wen.tan@linux.intel.com/","project":{"id":46,"url":"http://patchwork.ozlabs.org/api/1.2/projects/46/?format=json","name":"Intel Wired Ethernet development","link_name":"intel-wired-lan","list_id":"intel-wired-lan.osuosl.org","list_email":"intel-wired-lan@osuosl.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260507214706.309984-2-khai.wen.tan@linux.intel.com>","list_archive_url":null,"date":"2026-05-07T21:47:03","name":"[iwl-next,v5,1/4] igc: remove unused autoneg_failed field","commit_ref":null,"pull_url":null,"state":"under-review","archived":false,"hash":"6440bf710726f1b6ef703b4d9c29db47deb8684c","submitter":{"id":93102,"url":"http://patchwork.ozlabs.org/api/1.2/people/93102/?format=json","name":"KhaiWenTan","email":"khai.wen.tan@linux.intel.com"},"delegate":{"id":109701,"url":"http://patchwork.ozlabs.org/api/1.2/users/109701/?format=json","username":"anguy11","first_name":"Anthony","last_name":"Nguyen","email":"anthony.l.nguyen@intel.com"},"mbox":"http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20260507214706.309984-2-khai.wen.tan@linux.intel.com/mbox/","series":[{"id":503316,"url":"http://patchwork.ozlabs.org/api/1.2/series/503316/?format=json","web_url":"http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=503316","date":"2026-05-07T21:47:02","name":"igc: add support for forcing link speed without autonegotiation","version":5,"mbox":"http://patchwork.ozlabs.org/series/503316/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2234760/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2234760/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=osuosl.org header.i=@osuosl.org header.a=rsa-sha256\n header.s=default header.b=tRBimOi6;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org\n (client-ip=140.211.166.137; helo=smtp4.osuosl.org;\n envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4gBZqB1nplz1yK7\n\tfor ; Fri, 08 May 2026 13:48:54 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby smtp4.osuosl.org (Postfix) with ESMTP id 6E250414C9;\n\tFri, 8 May 2026 03:48:52 +0000 (UTC)","from smtp4.osuosl.org ([127.0.0.1])\n by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id dQ5MU-B10xXz; Fri, 8 May 2026 03:48:50 +0000 (UTC)","from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142])\n\tby smtp4.osuosl.org (Postfix) with ESMTP id 6C137414C8;\n\tFri, 8 May 2026 03:48:50 +0000 (UTC)","from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n by lists1.osuosl.org (Postfix) with ESMTP id D9CFB272\n for ; Fri, 8 May 2026 03:48:48 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n by smtp4.osuosl.org (Postfix) with ESMTP id CBFBF414C8\n for ; Fri, 8 May 2026 03:48:48 +0000 (UTC)","from smtp4.osuosl.org ([127.0.0.1])\n by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id nrKdc5zlyUyD for ;\n Fri, 8 May 2026 03:48:48 +0000 (UTC)","from mgamail.intel.com (mgamail.intel.com [198.175.65.13])\n by smtp4.osuosl.org (Postfix) with ESMTPS id 9FB12414C4\n for ; Fri, 8 May 2026 03:48:47 +0000 (UTC)","from orviesa009.jf.intel.com ([10.64.159.149])\n by orvoesa105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 07 May 2026 20:48:47 -0700","from unknown (HELO localhost.png.intel.com) ([10.107.255.61])\n by orviesa009.jf.intel.com with ESMTP; 07 May 2026 20:48:42 -0700"],"X-Virus-Scanned":["amavis at osuosl.org","amavis at osuosl.org"],"X-Comment":"SPF check N/A for local connections - client-ip=140.211.166.142;\n helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver= ","DKIM-Filter":["OpenDKIM Filter v2.11.0 smtp4.osuosl.org 6C137414C8","OpenDKIM Filter v2.11.0 smtp4.osuosl.org 9FB12414C4"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org;\n\ts=default; t=1778212130;\n\tbh=Na84m9kRzq+PH1GMI4hKGKYJ2RaKgHZOkMxXeleq4tI=;\n\th=From:To:Cc:Date:In-Reply-To:References:Subject:List-Id:\n\t List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe:\n\t From;\n\tb=tRBimOi6Ll47wfYe0rlESS2A3GVamTOUzqCOy2A/3yM4JUtOfb47GIgwH2ZpxI3Cd\n\t eAKy9pY9ydTLuYngQFacGnGqoXne2ouNyaZboeCp/daCxMNLuksAUP+UeeLwURowPq\n\t lIsD+9m81M6L6J7M/boG36REL6cx+/EOyzxAnwnENX6lkpoH6gyPOthld9rkVR01wx\n\t +J6zJYOeB9fGvDdhQrnSidpC3JJtk+3D3+0+0CJ9zx+n4mI3lbGadLuc0cunufrDZl\n\t lgV1CB7Dw6bCW5IYdtUoA6z2arHtR10q80XahIe05COTHo9w1UZmlvWuBUoscPR6wA\n\t uK3mHZZD3i0HQ==","Received-SPF":"Pass (mailfrom) identity=mailfrom; client-ip=198.175.65.13;\n helo=mgamail.intel.com; envelope-from=khai.wen.tan@linux.intel.com;\n receiver=","DMARC-Filter":"OpenDMARC Filter v1.4.2 smtp4.osuosl.org 9FB12414C4","X-CSE-ConnectionGUID":["ey3Opvb+TaCwjhJoyClOcw==","ZVbTtdOBSTy5opvJ/1Lc1w=="],"X-CSE-MsgGUID":["XcM7FjbkQwy8qr+RJxbCzw==","vUBzAKXPTDuBEzWjQE7hLQ=="],"X-IronPort-AV":["E=McAfee;i=\"6800,10657,11779\"; a=\"90278858\"","E=Sophos;i=\"6.23,222,1770624000\"; d=\"scan'208\";a=\"90278858\"","E=Sophos;i=\"6.23,222,1770624000\"; d=\"scan'208\";a=\"236767299\""],"X-ExtLoop1":"1","From":"KhaiWenTan ","To":"anthony.l.nguyen@intel.com, przemyslaw.kitszel@intel.com,\n andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com,\n kuba@kernel.org, pabeni@redhat.com","Cc":"intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org,\n linux-kernel@vger.kernel.org, faizal.abdul.rahim@intel.com,\n hong.aun.looi@intel.com, hector.blanco.alcaine@intel.com,\n khai.wen.tan@intel.com, Faizal Rahim ,\n Aleksandr Loktionov ,\n Khai Wen Tan ","Date":"Fri, 8 May 2026 05:47:03 +0800","Message-ID":"<20260507214706.309984-2-khai.wen.tan@linux.intel.com>","X-Mailer":"git-send-email 2.43.0","In-Reply-To":"<20260507214706.309984-1-khai.wen.tan@linux.intel.com>","References":"<20260507214706.309984-1-khai.wen.tan@linux.intel.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-Mailman-Original-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1778212128; x=1809748128;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=IysmtrfEnBl2FAT/X43D4kfZ0H/PNoYdWVnFXWlv2xE=;\n b=RXRry30oxlfyQ51PH0RZpsjl1iupkmD2W9/aIiQGAJXbP6h2/S4uDZ55\n LxaQA+gQjhFY/+XlTvc4ihQpND4yGbNiRqPTPzCQtzs1Pv52Hkk1v7VOg\n MEJryy678v6aYEluJmwygx4as87JMItebPe0F+QcMW7afZm01uXSdvYuB\n fb3DrvEguwyns/14+AqMC3eZ0jrwX2iMiMKY4/jvgRZPDXOCoa88K6HF+\n MSVDJZA7HQFjidlA9Byal5elEOERVuRB2pE3EMZFP0HBt9TP4vAv1NQFt\n J8hMWUmdr4E2TTtGVrXhSnHXI8II4eOfK2WTLNqxs8Eb2ND3WenxSFnlP\n g==;","X-Mailman-Original-Authentication-Results":["smtp4.osuosl.org;\n dmarc=none (p=none dis=none)\n header.from=linux.intel.com","smtp4.osuosl.org;\n dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com\n header.a=rsa-sha256 header.s=Intel header.b=RXRry30o"],"Subject":"[Intel-wired-lan] [PATCH iwl-next v5 1/4] igc: remove unused\n autoneg_failed field","X-BeenThere":"intel-wired-lan@osuosl.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"Intel Wired Ethernet Linux Kernel Driver Development\n ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"intel-wired-lan-bounces@osuosl.org","Sender":"\"Intel-wired-lan\" "},"content":"From: Faizal Rahim \n\nautoneg_failed in struct igc_mac_info is never set in the igc driver.\nRemove the field and the dead code checking it in\nigc_config_fc_after_link_up().\n\nThe field originates from the e1000/e1000e fiber/serdes forced-link\npath, where MAC-level autoneg timeout sets it to signal the flow-control\ncode to force pause. igc supports only copper, so it never needs to set\nthis field.\n\nReviewed-by: Looi Hong Aun \nReviewed-by: Aleksandr Loktionov \nSigned-off-by: Faizal Rahim \nSigned-off-by: Khai Wen Tan \n---\n drivers/net/ethernet/intel/igc/igc_hw.h | 1 -\n drivers/net/ethernet/intel/igc/igc_mac.c | 16 +---------------\n 2 files changed, 1 insertion(+), 16 deletions(-)","diff":"diff --git a/drivers/net/ethernet/intel/igc/igc_hw.h b/drivers/net/ethernet/intel/igc/igc_hw.h\nindex be8a49a86d09..86ab8f566f44 100644\n--- a/drivers/net/ethernet/intel/igc/igc_hw.h\n+++ b/drivers/net/ethernet/intel/igc/igc_hw.h\n@@ -92,7 +92,6 @@ struct igc_mac_info {\n \tbool asf_firmware_present;\n \tbool arc_subsystem_valid;\n \n-\tbool autoneg_failed;\n \tbool get_link_status;\n };\n \ndiff --git a/drivers/net/ethernet/intel/igc/igc_mac.c b/drivers/net/ethernet/intel/igc/igc_mac.c\nindex 7ac6637f8db7..142beb9ae557 100644\n--- a/drivers/net/ethernet/intel/igc/igc_mac.c\n+++ b/drivers/net/ethernet/intel/igc/igc_mac.c\n@@ -438,28 +438,14 @@ void igc_config_collision_dist(struct igc_hw *hw)\n * Checks the status of auto-negotiation after link up to ensure that the\n * speed and duplex were not forced. If the link needed to be forced, then\n * flow control needs to be forced also. If auto-negotiation is enabled\n- * and did not fail, then we configure flow control based on our link\n- * partner.\n+ * then we configure flow control based on our link partner.\n */\n s32 igc_config_fc_after_link_up(struct igc_hw *hw)\n {\n \tu16 mii_status_reg, mii_nway_adv_reg, mii_nway_lp_ability_reg;\n-\tstruct igc_mac_info *mac = &hw->mac;\n \tu16 speed, duplex;\n \ts32 ret_val = 0;\n \n-\t/* Check for the case where we have fiber media and auto-neg failed\n-\t * so we had to force link. In this case, we need to force the\n-\t * configuration of the MAC to match the \"fc\" parameter.\n-\t */\n-\tif (mac->autoneg_failed)\n-\t\tret_val = igc_force_mac_fc(hw);\n-\n-\tif (ret_val) {\n-\t\thw_dbg(\"Error forcing flow control settings\\n\");\n-\t\tgoto out;\n-\t}\n-\n \t/* In auto-neg, we need to check and see if Auto-Neg has completed,\n \t * and if so, how the PHY and link partner has flow control\n \t * configured.\n","prefixes":["iwl-next","v5","1/4"]}