{"id":2234728,"url":"http://patchwork.ozlabs.org/api/1.2/patches/2234728/?format=json","web_url":"http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20260508031226.3601800-2-aleksandr.loktionov@intel.com/","project":{"id":46,"url":"http://patchwork.ozlabs.org/api/1.2/projects/46/?format=json","name":"Intel Wired Ethernet development","link_name":"intel-wired-lan","list_id":"intel-wired-lan.osuosl.org","list_email":"intel-wired-lan@osuosl.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260508031226.3601800-2-aleksandr.loktionov@intel.com>","list_archive_url":null,"date":"2026-05-08T03:12:19","name":"[iwl-next,1/8] ixgbe: rename numa_node to node in struct ixgbe_q_vector","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"589b1bae33a66265e5e8993f8b61ef5be3fb6c2b","submitter":{"id":75597,"url":"http://patchwork.ozlabs.org/api/1.2/people/75597/?format=json","name":"Loktionov, Aleksandr","email":"aleksandr.loktionov@intel.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/intel-wired-lan/patch/20260508031226.3601800-2-aleksandr.loktionov@intel.com/mbox/","series":[{"id":503311,"url":"http://patchwork.ozlabs.org/api/1.2/series/503311/?format=json","web_url":"http://patchwork.ozlabs.org/project/intel-wired-lan/list/?series=503311","date":"2026-05-08T03:12:18","name":"ixgbe: small cleanups and improvements","version":1,"mbox":"http://patchwork.ozlabs.org/series/503311/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2234728/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2234728/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":["incoming@patchwork.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Delivered-To":["patchwork-incoming@legolas.ozlabs.org","intel-wired-lan@lists.osuosl.org"],"Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=osuosl.org header.i=@osuosl.org header.a=rsa-sha256\n header.s=default header.b=yRF7ieOt;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=osuosl.org\n (client-ip=140.211.166.137; helo=smtp4.osuosl.org;\n envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519 server-signature ECDSA (secp384r1) server-digest SHA384)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4gBZ1M6qKgz1yJq\n\tfor ; Fri, 08 May 2026 13:12:39 +1000 (AEST)","from localhost (localhost [127.0.0.1])\n\tby smtp4.osuosl.org (Postfix) with ESMTP id 6922C4144D;\n\tFri, 8 May 2026 03:12:35 +0000 (UTC)","from smtp4.osuosl.org ([127.0.0.1])\n by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id RJhqS6VkcTpY; Fri, 8 May 2026 03:12:34 +0000 (UTC)","from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142])\n\tby smtp4.osuosl.org (Postfix) with ESMTP id EB37441452;\n\tFri, 8 May 2026 03:12:33 +0000 (UTC)","from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133])\n by lists1.osuosl.org (Postfix) with ESMTP id CA3C8317\n for ; Fri, 8 May 2026 03:12:32 +0000 (UTC)","from localhost (localhost [127.0.0.1])\n by smtp2.osuosl.org (Postfix) with ESMTP id CAE7B4030E\n for ; Fri, 8 May 2026 03:12:31 +0000 (UTC)","from smtp2.osuosl.org ([127.0.0.1])\n by localhost (smtp2.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP\n id 2YXpTYytuFTs for ;\n Fri, 8 May 2026 03:12:31 +0000 (UTC)","from mgamail.intel.com (mgamail.intel.com [192.198.163.17])\n by smtp2.osuosl.org (Postfix) with ESMTPS id CF3E3409B3\n for ; Fri, 8 May 2026 03:12:30 +0000 (UTC)","from fmviesa005.fm.intel.com ([10.60.135.145])\n by fmvoesa111.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 07 May 2026 20:12:31 -0700","from amlin-019-225.igk.intel.com ([10.102.19.225])\n by fmviesa005.fm.intel.com with ESMTP; 07 May 2026 20:12:29 -0700"],"X-Virus-Scanned":["amavis at osuosl.org","amavis at osuosl.org"],"X-Comment":"SPF check N/A for local connections - client-ip=140.211.166.142;\n helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org;\n receiver= ","DKIM-Filter":["OpenDKIM Filter v2.11.0 smtp4.osuosl.org EB37441452","OpenDKIM Filter v2.11.0 smtp2.osuosl.org CF3E3409B3"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org;\n\ts=default; t=1778209954;\n\tbh=BM0lC/eM+KNhKyk/zHF1gP0RQ/e9DK15gxiJpEos/pA=;\n\th=From:To:Cc:Date:In-Reply-To:References:Subject:List-Id:\n\t List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe:\n\t From;\n\tb=yRF7ieOtIFMIsUK9gA2jEa7rk+YgBk229OYQoVSNMbHdj80MevB1TQ1ZkY4/N5a/W\n\t 4HufHq5vyIvGAUAK5ewPG009I9oW/aHI4uDIufFvENylqyPlZcKAIv2Z9S8kqjU5QA\n\t iQC7iyervdIJ3RuBmvAzfbcKd39lD6C+zNOQS562cD9UjZQzQSEBfT/C2a8zvNqvhy\n\t 5XWdhdkj9uDoZfnlblbaA3MP4s9iIQo9VCZvqewrh5wNKet7XxPWv3avfX5HMoigFu\n\t +26N8pHyd2QiqS+hFrPokYbQN8WMFlokdytYog/ulsaVadF1UAHiUYYDGPaXiZoo1O\n\t kYvFGneesVdrg==","Received-SPF":"Pass (mailfrom) identity=mailfrom; client-ip=192.198.163.17;\n helo=mgamail.intel.com; envelope-from=aleksandr.loktionov@intel.com;\n receiver=","DMARC-Filter":"OpenDMARC Filter v1.4.2 smtp2.osuosl.org CF3E3409B3","X-CSE-ConnectionGUID":["p76Nqu+XQXaC/t4iJo5VpQ==","w6ebjILARD2ObegaZgr2cg=="],"X-CSE-MsgGUID":["alQlXLbQTu2xrPAxpu55tQ==","y8qMGA66S7OEbHkF54q1mg=="],"X-IronPort-AV":["E=McAfee;i=\"6800,10657,11779\"; a=\"79027486\"","E=Sophos;i=\"6.23,222,1770624000\"; d=\"scan'208\";a=\"79027486\"","E=Sophos;i=\"6.23,222,1770624000\"; d=\"scan'208\";a=\"241623175\""],"X-ExtLoop1":"1","From":"Aleksandr Loktionov ","To":"intel-wired-lan@lists.osuosl.org, anthony.l.nguyen@intel.com,\n aleksandr.loktionov@intel.com","Cc":"netdev@vger.kernel.org,\n\tJacob Keller ","Date":"Fri, 8 May 2026 05:12:19 +0200","Message-ID":"<20260508031226.3601800-2-aleksandr.loktionov@intel.com>","X-Mailer":"git-send-email 2.52.0","In-Reply-To":"<20260508031226.3601800-1-aleksandr.loktionov@intel.com>","References":"<20260508031226.3601800-1-aleksandr.loktionov@intel.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-Mailman-Original-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1778209951; x=1809745951;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=1fz/pNUwDSH6iIhkeVb5RNFaw1xF4u6b6e7E26vW+kc=;\n b=ZXvwHq9Xn9530n6HqDX40dy29EuOWNRR5l3Cwe6A3cqXfwWqocma9UJl\n uZ4OOQELfc4N9MB6I8XP0DqkuMJtkb44LmYiM7Jf7wjuYkm3hvAjwNrWE\n XtdXL7ZCTzy4N49qRq/XD9jmuDDjQIAfbNQ1HdsHwojvQrGn3eonqg9d+\n 4sOwJhyscu35rm4mp7VClj7mJhMOgpSQBh4Ixlxaa9IIrqiAcZTmczL9J\n toDHBmhxBtt0ARZkxuFPv4ke1c8/YONtW11/MPlTWAImeLI3h41jRJhVs\n HgYLcqfaFcWYxi07+yiuiVoNMJe6bcV0JJPy3rnaUljfdP4Wxvkk5nvkA\n g==;","X-Mailman-Original-Authentication-Results":["smtp2.osuosl.org;\n dmarc=pass (p=none dis=none)\n header.from=intel.com","smtp2.osuosl.org;\n dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com\n header.a=rsa-sha256 header.s=Intel header.b=ZXvwHq9X"],"Subject":"[Intel-wired-lan] [PATCH iwl-next 1/8] ixgbe: rename numa_node to\n node in struct ixgbe_q_vector","X-BeenThere":"intel-wired-lan@osuosl.org","X-Mailman-Version":"2.1.30","Precedence":"list","List-Id":"Intel Wired Ethernet Linux Kernel Driver Development\n ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"intel-wired-lan-bounces@osuosl.org","Sender":"\"Intel-wired-lan\" "},"content":"From: Jacob Keller \n\nThe 'numa_node' field in struct ixgbe_q_vector shadows the 'numa_node'\naccessor for struct device, which triggers a sparse warning about\nshadowing a built-in object. The stored value here is a plain NUMA\nnode number, not a device attribute, so rename it to 'node' to avoid\nthe shadow and keep the naming consistent with other Intel drivers.\n\nUpdate all three usage sites in ixgbe_lib.c and ixgbe_main.c.\n\nSigned-off-by: Jacob Keller \nSigned-off-by: Aleksandr Loktionov \n---\n drivers/net/ethernet/intel/ixgbe/ixgbe.h | 2 +-\n drivers/net/ethernet/intel/ixgbe/ixgbe_lib.c | 2 +-\n drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 4 ++--\n 3 files changed, 4 insertions(+), 4 deletions(-)","diff":"diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe.h b/drivers/net/ethernet/intel/ixgbe/ixgbe.h\nindex 9b82175..cf2df18 100644\n--- a/drivers/net/ethernet/intel/ixgbe/ixgbe.h\n+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe.h\n@@ -515,7 +515,7 @@ struct ixgbe_q_vector {\n \tstruct rcu_head rcu;\t/* to avoid race with update stats on free */\n \n \tcpumask_t affinity_mask;\n-\tint numa_node;\n+\tint node;\n \tchar name[IFNAMSIZ + 9];\n \n \t/* for dynamic allocation of rings associated with this q_vector */\ndiff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_lib.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_lib.c\nindex 1db4bd5..5a4f05d 100644\n--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_lib.c\n+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_lib.c\n@@ -864,7 +864,7 @@ static int ixgbe_alloc_q_vector(struct ixgbe_adapter *adapter,\n \t/* setup affinity mask and node */\n \tif (cpu != -1)\n \t\tcpumask_set_cpu(cpu, &q_vector->affinity_mask);\n-\tq_vector->numa_node = node;\n+\tq_vector->node = node;\n \n #ifdef CONFIG_IXGBE_DCA\n \t/* initialize CPU for DCA */\ndiff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c\nindex 2646ee6..65426a1 100644\n--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c\n+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c\n@@ -7074,7 +7074,7 @@ int ixgbe_setup_tx_resources(struct ixgbe_ring *tx_ring)\n \tsize = sizeof(struct ixgbe_tx_buffer) * tx_ring->count;\n \n \tif (tx_ring->q_vector)\n-\t\tring_node = tx_ring->q_vector->numa_node;\n+\t\tring_node = tx_ring->q_vector->node;\n \n \ttx_ring->tx_buffer_info = vmalloc_node(size, ring_node);\n \tif (!tx_ring->tx_buffer_info)\n@@ -7175,7 +7175,7 @@ int ixgbe_setup_rx_resources(struct ixgbe_adapter *adapter,\n \tsize = sizeof(struct ixgbe_rx_buffer) * rx_ring->count;\n \n \tif (rx_ring->q_vector)\n-\t\tring_node = rx_ring->q_vector->numa_node;\n+\t\tring_node = rx_ring->q_vector->node;\n \n \trx_ring->rx_buffer_info = vmalloc_node(size, ring_node);\n \tif (!rx_ring->rx_buffer_info)\n","prefixes":["iwl-next","1/8"]}