{"id":2234284,"url":"http://patchwork.ozlabs.org/api/1.2/patches/2234284/?format=json","web_url":"http://patchwork.ozlabs.org/project/uboot/patch/20260507-doc-sysreset-qcom-v2-1-37fef7a9cf92@cherry.de/","project":{"id":18,"url":"http://patchwork.ozlabs.org/api/1.2/projects/18/?format=json","name":"U-Boot","link_name":"uboot","list_id":"u-boot.lists.denx.de","list_email":"u-boot@lists.denx.de","web_url":null,"scm_url":null,"webscm_url":null,"list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260507-doc-sysreset-qcom-v2-1-37fef7a9cf92@cherry.de>","list_archive_url":null,"date":"2026-05-07T15:04:05","name":"[v2,1/3] cmd: boot: fix edl being shown when not supported","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"cb7c615781a3a4b4cc9f2540e99581b64d85346f","submitter":{"id":84425,"url":"http://patchwork.ozlabs.org/api/1.2/people/84425/?format=json","name":"Quentin Schulz","email":"foss+uboot@0leil.net"},"delegate":{"id":68728,"url":"http://patchwork.ozlabs.org/api/1.2/users/68728/?format=json","username":"xypron","first_name":"Heinrich","last_name":"Schuchardt","email":"xypron.glpk@gmx.de"},"mbox":"http://patchwork.ozlabs.org/project/uboot/patch/20260507-doc-sysreset-qcom-v2-1-37fef7a9cf92@cherry.de/mbox/","series":[{"id":503198,"url":"http://patchwork.ozlabs.org/api/1.2/series/503198/?format=json","web_url":"http://patchwork.ozlabs.org/project/uboot/list/?series=503198","date":"2026-05-07T15:04:04","name":"cmd: reset: fixes related to Qualcomm's edl","version":2,"mbox":"http://patchwork.ozlabs.org/series/503198/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2234284/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2234284/checks/","tags":{},"related":[],"headers":{"Return-Path":"<u-boot-bounces@lists.denx.de>","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=0leil.net header.i=@0leil.net header.a=rsa-sha256\n header.s=20231125 header.b=BYjRzazN;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de\n (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de;\n envelope-from=u-boot-bounces@lists.denx.de; receiver=patchwork.ozlabs.org)","phobos.denx.de;\n dmarc=pass (p=reject dis=none) header.from=0leil.net","phobos.denx.de;\n spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de","phobos.denx.de;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=0leil.net header.i=@0leil.net header.b=\"BYjRzazN\";\n\tdkim-atps=neutral","phobos.denx.de;\n dmarc=pass (p=reject dis=none) header.from=0leil.net","phobos.denx.de;\n spf=pass smtp.mailfrom=foss+uboot@0leil.net"],"Received":["from phobos.denx.de (phobos.denx.de\n [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\t key-exchange x25519)\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4gBFsN2BRFz1yCg\n\tfor <incoming@patchwork.ozlabs.org>; Fri, 08 May 2026 01:04:40 +1000 (AEST)","from h2850616.stratoserver.net (localhost [IPv6:::1])\n\tby phobos.denx.de (Postfix) with ESMTP id ECC6384B2C;\n\tThu,  7 May 2026 17:04:28 +0200 (CEST)","by phobos.denx.de (Postfix, from userid 109)\n id 60BFD84A7B; Thu,  7 May 2026 17:04:27 +0200 (CEST)","from smtp-190a.mail.infomaniak.ch (smtp-190a.mail.infomaniak.ch\n [IPv6:2001:1600:19:38e0::190a])\n (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits))\n (No client certificate requested)\n by phobos.denx.de (Postfix) with ESMTPS id 84DCA84A93\n for <u-boot@lists.denx.de>; Thu,  7 May 2026 17:04:25 +0200 (CEST)","from smtp-3-0001.mail.infomaniak.ch (smtp-3-0001.mail.infomaniak.ch\n [10.4.36.108])\n by smtp-3-3000.mail.infomaniak.ch (Postfix) with ESMTPS id 4gBFs51sYpzW6g;\n Thu,  7 May 2026 17:04:25 +0200 (CEST)","from unknown by smtp-3-0001.mail.infomaniak.ch (Postfix) with ESMTPA\n id 4gBFs44KqnzVcv; Thu,  7 May 2026 17:04:24 +0200 (CEST)"],"X-Spam-Checker-Version":"SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de","X-Spam-Level":"","X-Spam-Status":"No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,\n DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED,\n SPF_HELO_PASS,SPF_PASS autolearn=ham autolearn_force=no version=3.4.2","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=0leil.net;\n s=20231125; t=1778166265;\n bh=Rt6rbponnh1mtHZvesAorRkx9wFNe3w/5JBfFFesuek=;\n h=From:Date:Subject:References:In-Reply-To:To:Cc:From;\n b=BYjRzazNjaRj8b4EqKfoDikCx7I3P+bgvAFooGDCGeiXE5mES+nOlX5mhkolx1XW5\n Sfo3c9fu+Dd3u7Rr84viwNF+JHovtlzI7igop18usZ4PzcZ3jyppdxIWA/iFwgzBdz\n yfePZx83DT7GTRg7zwhIrLhRg3XXRfq8DUQlLGKJ+GHniJITbLcsPD+4s6TooCKDfO\n y3/BQoIVHzLC+Mszu2SKRLYuXXEcHUfGbs8DUYToEPW8Zxe9I/9OMXSKMautSDDIHA\n O0m6FqieOyUIAv/Co/+r4Dfkbowk5xKpLCmCC6wVIXAz2Zly8pQn3zenhvIABvVnXI\n E7bFQEFHRt33w==","From":"Quentin Schulz <foss+uboot@0leil.net>","Date":"Thu, 07 May 2026 17:04:05 +0200","Subject":"[PATCH v2 1/3] cmd: boot: fix edl being shown when not supported","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"7bit","Message-Id":"<20260507-doc-sysreset-qcom-v2-1-37fef7a9cf92@cherry.de>","References":"<20260507-doc-sysreset-qcom-v2-0-37fef7a9cf92@cherry.de>","In-Reply-To":"<20260507-doc-sysreset-qcom-v2-0-37fef7a9cf92@cherry.de>","To":"Casey Connolly <casey.connolly@linaro.org>,\n Sumit Garg <sumit.garg@oss.qualcomm.com>,\n Varadarajan Narayanan <varadarajan.narayanan@oss.qualcomm.com>,\n u-boot@lists.denx.de, Heinrich Schuchardt <xypron.glpk@gmx.de>,\n Bin Meng <bmeng.cn@gmail.com>","Cc":"Tom Rini <trini@konsulko.com>, Quentin Schulz <quentin.schulz@cherry.de>","X-Mailer":"b4 0.15-dev-47773","X-Infomaniak-Routing":"alpha","X-BeenThere":"u-boot@lists.denx.de","X-Mailman-Version":"2.1.39","Precedence":"list","List-Id":"U-Boot discussion <u-boot.lists.denx.de>","List-Unsubscribe":"<https://lists.denx.de/options/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=unsubscribe>","List-Archive":"<https://lists.denx.de/pipermail/u-boot/>","List-Post":"<mailto:u-boot@lists.denx.de>","List-Help":"<mailto:u-boot-request@lists.denx.de?subject=help>","List-Subscribe":"<https://lists.denx.de/listinfo/u-boot>,\n <mailto:u-boot-request@lists.denx.de?subject=subscribe>","Errors-To":"u-boot-bounces@lists.denx.de","Sender":"\"U-Boot\" <u-boot-bounces@lists.denx.de>","X-Virus-Scanned":"clamav-milter 0.103.8 at phobos.denx.de","X-Virus-Status":"Clean"},"content":"From: Quentin Schulz <quentin.schulz@cherry.de>\n\nedl is implemented in the sysreset_ops.request_arg callback of the\nqcom-psci sysreset driver. That callback is only called from\nsysreset_request_arg() which is compiled only when\nCONFIG_SYSRESET_CMD_RESET_ARGS=y.\n\nTherefore, only show the edl option if that symbol is enabled.\n\nIt is in a separate if block because any option but -w will only be\nhandled when CONFIG_SYSRESET_CMD_RESET_ARGS=y as seen with the\nimplementation in do_reset() in drivers/sysreset/sysreset-uclass.c.\n\nFixes: ef06c5d76ff4 (\"cmd: boot: Add '-edl' option to reset command documentation\")\nSigned-off-by: Quentin Schulz <quentin.schulz@cherry.de>\n---\n cmd/boot.c | 3 +++\n 1 file changed, 3 insertions(+)","diff":"diff --git a/cmd/boot.c b/cmd/boot.c\nindex d80f9d8c05d..29cdf4a9a81 100644\n--- a/cmd/boot.c\n+++ b/cmd/boot.c\n@@ -60,8 +60,11 @@ U_BOOT_CMD(\n \treset, 2, 0,\tdo_reset,\n \t\"Perform RESET of the CPU\",\n \t\"- cold boot without level specifier\\n\"\n+#if IS_ENABLED(CONFIG_SYSRESET_CMD_RESET_ARGS)\n+// All options handled by sysreset drivers via their sysreset_ops.request_arg callback\n #ifdef CONFIG_SYSRESET_QCOM_PSCI\n \t\"reset -edl - Boot to Emergency DownLoad mode\\n\"\n+#endif\n #endif\n \t\"reset -w - warm reset if implemented\"\n );\n","prefixes":["v2","1/3"]}