{"id":2233311,"url":"http://patchwork.ozlabs.org/api/1.2/patches/2233311/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260506075813.120781-6-armenon@redhat.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.2/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260506075813.120781-6-armenon@redhat.com>","list_archive_url":null,"date":"2026-05-06T07:58:12","name":"[v7,5/6] test/qtest: Add test for tpm crb chunking","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"2b4df88e9187e5e3b49061f829c60cfb223d5380","submitter":{"id":91136,"url":"http://patchwork.ozlabs.org/api/1.2/people/91136/?format=json","name":"Arun Menon","email":"armenon@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260506075813.120781-6-armenon@redhat.com/mbox/","series":[{"id":502931,"url":"http://patchwork.ozlabs.org/api/1.2/series/502931/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=502931","date":"2026-05-06T07:58:09","name":"hw/tpm: CRB chunking capability to handle PQC","version":7,"mbox":"http://patchwork.ozlabs.org/series/502931/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2233311/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2233311/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=EkrsCAhN;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=google header.b=iYx3imMm;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g9ST74Q02z1yJq\n\tfor ; Wed, 06 May 2026 17:59:23 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wKX9k-0005I8-08; Wed, 06 May 2026 03:58:56 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wKX9i-0005Fq-EO\n for qemu-devel@nongnu.org; Wed, 06 May 2026 03:58:54 -0400","from us-smtp-delivery-124.mimecast.com ([170.10.133.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wKX9g-0000gy-Is\n for qemu-devel@nongnu.org; Wed, 06 May 2026 03:58:54 -0400","from mail-pj1-f70.google.com (mail-pj1-f70.google.com\n [209.85.216.70]) by relay.mimecast.com with ESMTP with STARTTLS\n (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n us-mta-582-nJe6ChdlPxGTcGIYFh6iFA-1; Wed, 06 May 2026 03:58:50 -0400","by mail-pj1-f70.google.com with SMTP id\n 98e67ed59e1d1-365d4d2fa04so16122a91.3\n for ; Wed, 06 May 2026 00:58:50 -0700 (PDT)","from fedora.armenon-thinkpadp16vgen1.bengluru.csb ([49.36.106.26])\n by smtp.gmail.com with ESMTPSA id\n d9443c01a7336-2ba7ca29f9dsm15439865ad.78.2026.05.06.00.58.43\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Wed, 06 May 2026 00:58:47 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1778054331;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=8VG1umfV8XbLQ9QjPcrnZsX2l74f6GjJZEm8Zg6nu/U=;\n b=EkrsCAhNmEi9wYTOfCZ78SXYQUTmWPbqRyzlrb6FhVkwzm14a0OAV5BxDd5NP0SD/HqtVe\n q0EBKc9of72i6r3U7IVO441IiV90Ekjh/cgMsavbEpVR2MYOn+CWobZJhMKWR9Op8qvNrT\n f0m+ZRishTg+tVLiOEjKxAysY+VYcN8=","v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=redhat.com; s=google; t=1778054329; x=1778659129; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=8VG1umfV8XbLQ9QjPcrnZsX2l74f6GjJZEm8Zg6nu/U=;\n b=iYx3imMmsWY5cIAD+SJ9B52icp4eHTUsNJktVxGiLJ4PGkaHv3eH70cHTe1wFVNgit\n N4pUwWLIylBKkFB5mz/W9vGOfyq/QR2myjz5/efOw7ga9HwIG/AAe6E2hAQ1srIBZ9vr\n tD/55ppsHoIXr/c68JP11XGih88ObPL2G+mgNHhrqIqLogFKQRFOQkkBSriUskS15ZGP\n oQ+yM5EDHbsz0+N1I+fqbQp0nEaOUY/M5MuWZZTVe6qzYXQ1JRi182mbewtpME4p7Tfw\n 4rm3TJm0zu/jD8hIVEeVhJur243bAC16HksyG3JUkAyIDwP0oL2d8SMy3Dh1lqtl3GnM\n 53ng=="],"X-MC-Unique":"nJe6ChdlPxGTcGIYFh6iFA-1","X-Mimecast-MFC-AGG-ID":"nJe6ChdlPxGTcGIYFh6iFA_1778054329","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1778054329; x=1778659129;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=8VG1umfV8XbLQ9QjPcrnZsX2l74f6GjJZEm8Zg6nu/U=;\n b=mChFS+dd8uePmtlqda8+CIP8kjg8A2AhMuUkcJ6aB90sTTnDxNYsWPoM+BuuopMm85\n 1uMqJ0A3w4a15AqA3DysH0p2NwnTN2t7Q6/ubJELq20Lt8fwfadU/OOw8D6UbTCs6vqi\n /5iujmpLF6h2gv3kvq7wizm7ZF1PrlFBY819wmOG9WVBCbTm674h0RjRyEtVNE3zNSX7\n lkYjzKVFVGa8Nsh4U/aKpEFkGW5jZrdthW6fQaTEaZ0BH08uQUFKa52JcM8pq20D6x59\n 5gBz54DGPSqf6p4xZl3A0xcK0peq90M8rnO1HiV5ji3ybKhg0KhggI+Ar9IeGS+DByAG\n SZeg==","X-Gm-Message-State":"AOJu0Ywa+uE95R3UIRACgO/b1eeSWlh1O2zFk2a9goB/GW724iNqwhuN\n Ln7Ca3VRpcbu77PDmRB9uQyohTg/iZzLS42abpYDX+v5ezEMU+fjxs4bNRCkaNhynBNje437H+i\n iwiH6UGh9TGW3ruu0xuQxVMVEU/v5CHQxIQBjpAw2JgJLVUi0yVqrV7zs2u7nwwxF0fUptJzwv+\n kwYypYbCntJcv7Tc4kdcxof5pWmU+3qySgEXFH7cI=","X-Gm-Gg":"AeBDiesUlZMuSKb8eD4Os4nW/6QvkvVavVK0Don0hvq22Mm2W70MDxkcb56mA7zLktZ\n nZncdHv7G7rAcz5SH/KNipVrYQvAjqM7PQ54Hyl2QejJEKGvc4GMF/GguUgPfpQHdQ5ViQZttoR\n 5iVIMdLrjTHzgNvUeurL1CCROW5t/kcXc6EFyPsDzx2lvRtyxdSlw0f/XdfkSFrIEN4MEbMBZ/q\n jCQOrzqbYbiFkfgnsjxYW1CHuOfCQk6vFObpgA1pMJNTZyI6XY4cRdMzdNVhY6cmEmyVj42sCVL\n YQarzts/+j4aAcxpKys8owdLyEXWZNoFx7DWbJ+EINS+FxV9iFUk/RuaLcMC6XZZM6vSzW9mu/u\n IfnCreLFPNnz3YEWNdUDpG05GCEzCsBbUImLNNi9xNEx2rlyBCymfXP5TGBNsWPkzlnTZPeJb","X-Received":["by 2002:a17:90b:5207:b0:364:919c:b52f with SMTP id\n 98e67ed59e1d1-365ac775c4cmr2178923a91.24.1778054328974;\n Wed, 06 May 2026 00:58:48 -0700 (PDT)","by 2002:a17:90b:5207:b0:364:919c:b52f with SMTP id\n 98e67ed59e1d1-365ac775c4cmr2178877a91.24.1778054328326;\n Wed, 06 May 2026 00:58:48 -0700 (PDT)"],"From":"Arun Menon ","To":"qemu-devel@nongnu.org","Cc":"Zhao Liu ,\n Marcel Apfelbaum ,\n Ani Sinha , Fabiano Rosas ,\n marcandre.lureau@redhat.com, Stefan Berger ,\n\t=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ,\n Yanan Wang , Paolo Bonzini ,\n Laurent Vivier , \"Michael S. Tsirkin\" ,\n Igor Mammedov , Arun Menon ,\n Stefan Berger ","Subject":"[PATCH v7 5/6] test/qtest: Add test for tpm crb chunking","Date":"Wed, 6 May 2026 13:28:12 +0530","Message-ID":"<20260506075813.120781-6-armenon@redhat.com>","X-Mailer":"git-send-email 2.54.0","In-Reply-To":"<20260506075813.120781-1-armenon@redhat.com>","References":"<20260506075813.120781-1-armenon@redhat.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=170.10.133.124; envelope-from=armenon@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com","X-Spam_score_int":"-24","X-Spam_score":"-2.5","X-Spam_bar":"--","X-Spam_report":"(-2.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.443,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"From: Arun Menon \n\n- New test case added to the swtpm test. Data is written and read from\n the buffer in chunks.\n- The chunk size is dynamically calculated by reading the\n CRB_CTRL_CMD_SIZE address. This can be changed manually to test.\n- Add a helper function tpm_wait_till_bit_clear()\n- Note that this commit does not yet exercise the chunked read/write\n logic, as current transfer sizes remain small. Testing for large\n transfers is introduced in a subsequent patch: 'tests: Use ML-DSA-87\n operations to cause large TPM transfers with CRB'\n\nSigned-off-by: Arun Menon \nReviewed-by: Marc-André Lureau \nReviewed-by: Stefan Berger \n---\n tests/qtest/tpm-crb-swtpm-test.c | 10 +++\n tests/qtest/tpm-util.c | 109 ++++++++++++++++++++++++++-----\n tests/qtest/tpm-util.h | 5 ++\n 3 files changed, 109 insertions(+), 15 deletions(-)","diff":"diff --git a/tests/qtest/tpm-crb-swtpm-test.c b/tests/qtest/tpm-crb-swtpm-test.c\nindex ffeb1c396b..050c7b0c1f 100644\n--- a/tests/qtest/tpm-crb-swtpm-test.c\n+++ b/tests/qtest/tpm-crb-swtpm-test.c\n@@ -33,6 +33,14 @@ static void tpm_crb_swtpm_test(const void *data)\n \"tpm-crb\", NULL);\n }\n \n+static void tpm_crb_chunk_swtpm_test(const void *data)\n+{\n+ const TestState *ts = data;\n+\n+ tpm_test_swtpm_test(ts->src_tpm_path, tpm_util_crb_chunk_transfer,\n+ \"tpm-crb\", NULL);\n+}\n+\n static void tpm_crb_swtpm_migration_test(const void *data)\n {\n const TestState *ts = data;\n@@ -54,6 +62,8 @@ int main(int argc, char **argv)\n g_test_init(&argc, &argv, NULL);\n \n qtest_add_data_func(\"/tpm/crb-swtpm/test\", &ts, tpm_crb_swtpm_test);\n+ qtest_add_data_func(\"/tpm/crb-chunk-swtpm/test\", &ts,\n+ tpm_crb_chunk_swtpm_test);\n qtest_add_data_func(\"/tpm/crb-swtpm-migration/test\", &ts,\n tpm_crb_swtpm_migration_test);\n ret = g_test_run();\ndiff --git a/tests/qtest/tpm-util.c b/tests/qtest/tpm-util.c\nindex 2cb2dd4796..b0763d86b3 100644\n--- a/tests/qtest/tpm-util.c\n+++ b/tests/qtest/tpm-util.c\n@@ -14,16 +14,44 @@\n \n #include \"qemu/osdep.h\"\n #include \n+#include \"qemu/bswap.h\"\n \n #include \"hw/acpi/tpm.h\"\n #include \"libqtest.h\"\n #include \"tpm-util.h\"\n #include \"qobject/qdict.h\"\n \n+#define CRB_ADDR_START (TPM_CRB_ADDR_BASE + A_CRB_CTRL_START)\n+#define CRB_ADDR_CTRL_STS (TPM_CRB_ADDR_BASE + A_CRB_CTRL_STS)\n+#define CRB_ADDR_CTRL_CMD_SIZE \\\n+ (TPM_CRB_ADDR_BASE + A_CRB_CTRL_CMD_SIZE)\n+\n+#define CRB_START_INVOKE (1 << 0)\n+#define CRB_START_RSP_RETRY (1 << 1)\n+#define CRB_START_NEXT_CHUNK (1 << 2)\n+\n+void tpm_wait_till_bit_clear(QTestState *s, uint64_t addr, uint32_t mask)\n+{\n+ uint32_t sts;\n+ uint64_t end_time = g_get_monotonic_time() + 5 * G_TIME_SPAN_SECOND;\n+\n+ while (true) {\n+ sts = qtest_readl(s, addr);\n+ if ((sts & mask) == 0) {\n+ break;\n+ }\n+ if (g_get_monotonic_time() >= end_time) {\n+ g_assert_cmphex(sts & mask, ==, 0);\n+ break;\n+ }\n+ }\n+}\n+\n void tpm_util_crb_transfer(QTestState *s,\n const unsigned char *req, size_t req_size,\n unsigned char *rsp, size_t rsp_size)\n {\n+ uint32_t tpm_sts;\n uint64_t caddr = qtest_readq(s, TPM_CRB_ADDR_BASE + A_CRB_CTRL_CMD_LADDR);\n uint64_t raddr = qtest_readq(s, TPM_CRB_ADDR_BASE + A_CRB_CTRL_RSP_ADDR);\n \n@@ -31,24 +59,75 @@ void tpm_util_crb_transfer(QTestState *s,\n \n qtest_memwrite(s, caddr, req, req_size);\n \n- uint32_t sts, start = 1;\n- uint64_t end_time = g_get_monotonic_time() + 5 * G_TIME_SPAN_SECOND;\n- qtest_writel(s, TPM_CRB_ADDR_BASE + A_CRB_CTRL_START, start);\n- while (true) {\n- start = qtest_readl(s, TPM_CRB_ADDR_BASE + A_CRB_CTRL_START);\n- if ((start & 1) == 0) {\n- break;\n+ qtest_writel(s, CRB_ADDR_START, CRB_START_INVOKE);\n+ tpm_wait_till_bit_clear(s, CRB_ADDR_START, CRB_START_INVOKE);\n+\n+ tpm_sts = qtest_readl(s, CRB_ADDR_CTRL_STS);\n+ g_assert_cmpint(tpm_sts & 1, ==, 0);\n+\n+ qtest_memread(s, raddr, rsp, rsp_size);\n+}\n+\n+void tpm_util_crb_chunk_transfer(QTestState *s,\n+ const unsigned char *req, size_t req_size,\n+ unsigned char *rsp, size_t rsp_size)\n+{\n+ uint32_t tpm_sts;\n+ size_t chunk_size;\n+ unsigned char header[10];\n+ uint32_t actual_response_size = 0;\n+\n+ uint64_t caddr = qtest_readq(s, TPM_CRB_ADDR_BASE + A_CRB_CTRL_CMD_LADDR);\n+ uint64_t raddr = qtest_readq(s, TPM_CRB_ADDR_BASE + A_CRB_CTRL_RSP_ADDR);\n+ uint32_t crb_ctrl_cmd_size = qtest_readl(s, CRB_ADDR_CTRL_CMD_SIZE);\n+\n+ chunk_size = crb_ctrl_cmd_size;\n+\n+ qtest_writeb(s, TPM_CRB_ADDR_BASE + A_CRB_LOC_CTRL, 1);\n+\n+ for (size_t i = 0; i < req_size; i += chunk_size) {\n+ bool last_chunk = false;\n+ size_t current_chunk_size = chunk_size;\n+\n+ if (i + chunk_size > req_size) {\n+ last_chunk = true;\n+ current_chunk_size = req_size - i;\n }\n- if (g_get_monotonic_time() >= end_time) {\n- break;\n+\n+ qtest_memwrite(s, caddr, req + i, current_chunk_size);\n+\n+ if (last_chunk) {\n+ qtest_writel(s, CRB_ADDR_START, CRB_START_INVOKE);\n+ tpm_wait_till_bit_clear(s, CRB_ADDR_START, CRB_START_INVOKE);\n+ } else {\n+ qtest_writel(s, CRB_ADDR_START, CRB_START_NEXT_CHUNK);\n+ tpm_wait_till_bit_clear(s, CRB_ADDR_START, CRB_START_NEXT_CHUNK);\n }\n- };\n- start = qtest_readl(s, TPM_CRB_ADDR_BASE + A_CRB_CTRL_START);\n- g_assert_cmpint(start & 1, ==, 0);\n- sts = qtest_readl(s, TPM_CRB_ADDR_BASE + A_CRB_CTRL_STS);\n- g_assert_cmpint(sts & 1, ==, 0);\n+ }\n+ tpm_sts = qtest_readl(s, CRB_ADDR_CTRL_STS);\n+ g_assert_cmpint(tpm_sts & 1, ==, 0);\n \n- qtest_memread(s, raddr, rsp, rsp_size);\n+ /*\n+ * Read response in chunks\n+ */\n+\n+ qtest_memread(s, raddr, header, sizeof(header));\n+ actual_response_size = ldl_be_p(&header[2]);\n+\n+ if (actual_response_size > rsp_size) {\n+ actual_response_size = rsp_size;\n+ }\n+\n+ for (size_t i = 0; i < actual_response_size; i += chunk_size) {\n+ size_t to_read = i + chunk_size > actual_response_size\n+ ? actual_response_size - i\n+ : chunk_size;\n+ if (i > 0) {\n+ qtest_writel(s, CRB_ADDR_START, CRB_START_NEXT_CHUNK);\n+ tpm_wait_till_bit_clear(s, CRB_ADDR_START, CRB_START_NEXT_CHUNK);\n+ }\n+ qtest_memread(s, raddr, rsp + i, to_read);\n+ }\n }\n \n void tpm_util_startup(QTestState *s, tx_func *tx)\ndiff --git a/tests/qtest/tpm-util.h b/tests/qtest/tpm-util.h\nindex 0cb28dd6e5..681544e7d8 100644\n--- a/tests/qtest/tpm-util.h\n+++ b/tests/qtest/tpm-util.h\n@@ -24,10 +24,15 @@ typedef void (tx_func)(QTestState *s,\n const unsigned char *req, size_t req_size,\n unsigned char *rsp, size_t rsp_size);\n \n+void tpm_wait_till_bit_clear(QTestState *s, uint64_t addr, uint32_t mask);\n void tpm_util_crb_transfer(QTestState *s,\n const unsigned char *req, size_t req_size,\n unsigned char *rsp, size_t rsp_size);\n \n+void tpm_util_crb_chunk_transfer(QTestState *s,\n+ const unsigned char *req, size_t req_size,\n+ unsigned char *rsp, size_t rsp_size);\n+\n void tpm_util_startup(QTestState *s, tx_func *tx);\n void tpm_util_pcrextend(QTestState *s, tx_func *tx);\n void tpm_util_pcrread(QTestState *s, tx_func *tx,\n","prefixes":["v7","5/6"]}