{"id":2233307,"url":"http://patchwork.ozlabs.org/api/1.2/patches/2233307/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260506075813.120781-4-armenon@redhat.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.2/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260506075813.120781-4-armenon@redhat.com>","list_archive_url":null,"date":"2026-05-06T07:58:10","name":"[v7,3/6] hw/tpm: Add internal buffer state for chunking","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"360e0c21320206795cdaf44452bd68d8adb5d90b","submitter":{"id":91136,"url":"http://patchwork.ozlabs.org/api/1.2/people/91136/?format=json","name":"Arun Menon","email":"armenon@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260506075813.120781-4-armenon@redhat.com/mbox/","series":[{"id":502931,"url":"http://patchwork.ozlabs.org/api/1.2/series/502931/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=502931","date":"2026-05-06T07:58:09","name":"hw/tpm: CRB chunking capability to handle PQC","version":7,"mbox":"http://patchwork.ozlabs.org/series/502931/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2233307/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2233307/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=eclsfoyt;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=google header.b=CP4xgpSg;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g9SSf6DN9z1yKd\n\tfor ; Wed, 06 May 2026 17:58:58 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wKX9Y-0004wW-IX; Wed, 06 May 2026 03:58:44 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wKX9X-0004wN-Fd\n for qemu-devel@nongnu.org; Wed, 06 May 2026 03:58:43 -0400","from us-smtp-delivery-124.mimecast.com ([170.10.129.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wKX9V-0000eh-Tm\n for qemu-devel@nongnu.org; Wed, 06 May 2026 03:58:43 -0400","from mail-pl1-f199.google.com (mail-pl1-f199.google.com\n [209.85.214.199]) by relay.mimecast.com with ESMTP with STARTTLS\n (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n us-mta-633-QF_NSvnBMyyjkh7MgOWMhQ-1; Wed, 06 May 2026 03:58:39 -0400","by mail-pl1-f199.google.com with SMTP id\n d9443c01a7336-2b4654f9bb6so63616545ad.2\n for ; Wed, 06 May 2026 00:58:39 -0700 (PDT)","from fedora.armenon-thinkpadp16vgen1.bengluru.csb ([49.36.106.26])\n by smtp.gmail.com with ESMTPSA id\n d9443c01a7336-2ba7ca29f9dsm15439865ad.78.2026.05.06.00.58.32\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Wed, 06 May 2026 00:58:37 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1778054321;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=mqQQa0sIdgZK6GVtiZnksrInbkePHvX9cE0LybQFiho=;\n b=eclsfoytS0bgmsF8ZTxh1Qv+y40I0jICbDw3SNfcrFJaIvsh4Ggzzngaf3zdFyw+X0Ewa4\n pVU9fjkCOEPa+9r1cnDDXVH6dCEefankcizus1mVSLdhmIY8llqbiYO+heZSJNWh9XVnnB\n ttePAyzharUizE04sN3FmXUEkd/sihA=","v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=redhat.com; s=google; t=1778054318; x=1778659118; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=mqQQa0sIdgZK6GVtiZnksrInbkePHvX9cE0LybQFiho=;\n b=CP4xgpSgtHv0d6CJ137je5MkmzTKyKjQS3mPnlid5yPCZ1n8fVOkF10WHd/jajkRFs\n BkBJP7PHcpkObY7JBoFXkFa2l3FKTVnMI/h4U07uBI/4hGB6TXZ8HU2srb4tTT1WzrSY\n xzbD2K7WBhG0teLJeZ8hb5bkNE21o1S1UFymZzjJi/qnZ3R0eL8DiDRHWU3oZhgOJTA6\n vFqs7t6lcIaae3tPdcXQxtA30NtqADB3fkFurrpmpHrJ2Idg1ACxz/djce4dArlgoUVD\n HK9YIS/TnsFbqHXnPwXQFkpyF2YPr/4J+x5CQhROvxrY47qYb4n49+AjUhpRHjQn56BW\n 0tjQ=="],"X-MC-Unique":"QF_NSvnBMyyjkh7MgOWMhQ-1","X-Mimecast-MFC-AGG-ID":"QF_NSvnBMyyjkh7MgOWMhQ_1778054319","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1778054318; x=1778659118;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=mqQQa0sIdgZK6GVtiZnksrInbkePHvX9cE0LybQFiho=;\n b=PknxQijkhnQ0l8hOI3nj8v9isJb0esD0pQwS/eo1kh5yl2DyWxQfgGJnZlCh+3mnnr\n 7Z3a7W9jujYko773M22NNNpiBLWwj26QfARc56yS5Cjqq8QQKncydLybk+/AOKoUTnMd\n cMefdGrcpztq/pzszLXK9Fe2lvelvI+0TALzsB3bvUxmR78LNQnZ9+XK2UZNVfsyco+d\n 27NSrmywS0d0p0WnkcTUeXALjcG6zwEJ4aI4EZHYGpX/UWvEeFJ9HqyBQsCSpyML2AFI\n 04hCLfUU2PuGuFk98pP6GYlq9NSAEPP72JTG9qeXDBSUeoq7pVqAiJNT+NjE1ZZwfsYl\n ymDw==","X-Gm-Message-State":"AOJu0Yx4FFTTlUjN98v6txdDRE1ueSyhT95FZtbYUiv9Yq3upHyFFOLM\n OYOsc34HSdLhRiS7ED+W3Z+aU71KDUI9qbhG6W3bJz/LZ7JIE50Ax//EPNfLDFQd3u6A1Prps+0\n Btuk4EIwawCuXdake8AwOg8tgD4c7rUeON2PKglphGVdsejWkmjc365e2Nopibb6JqtSNB7Shot\n DsLZsTKYV5UHLuH6F8eXwsEB8wjBqOmNFg7CW9d0U=","X-Gm-Gg":"AeBDietgD2RDdk11bhxBuzZbH0XIsAVUfpNClVWsouPmUU7YEW4eqGTRGnZtHmxlffA\n JIpLzS3FTgdNTzViXfJey2eSwTblCWAb1dLM0ynkwpp2di0icPl+iz6GhtEEkyn5m5cv5Nn+d08\n F54GZ7pEjz4w+MYiiky1tWx99I2j9G1av7umj+VMf7BzOY/Uf3TnOIuF06fYSC5j3OiZl5Jt/GD\n qphfmxAS+uSGV51Tx0Go6J/dbKl0tKEVmgX0xd0AIa7EEaYJhZENAv51hw6Vc3cnwpF+GzSxHF9\n 1YGrIGROpUoiMvAnrXZGIyQqZd/VUQLjx52lEU80N/TEY3OHRpGk/5AXgYCWyyAonniyQ0kudVL\n d0ydQjb5DRR9/pA185Gf6W9+uJjF17oBlO/qPhOGXPI/cFQcNVN4+eKftaj+vnK0Khu3WsN94","X-Received":["by 2002:a17:903:90e:b0:2b2:4d36:7ba with SMTP id\n d9443c01a7336-2ba78831407mr24044745ad.0.1778054318407;\n Wed, 06 May 2026 00:58:38 -0700 (PDT)","by 2002:a17:903:90e:b0:2b2:4d36:7ba with SMTP id\n d9443c01a7336-2ba78831407mr24044425ad.0.1778054317739;\n Wed, 06 May 2026 00:58:37 -0700 (PDT)"],"From":"Arun Menon ","To":"qemu-devel@nongnu.org","Cc":"Zhao Liu ,\n Marcel Apfelbaum ,\n Ani Sinha , Fabiano Rosas ,\n marcandre.lureau@redhat.com, Stefan Berger ,\n\t=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ,\n Yanan Wang , Paolo Bonzini ,\n Laurent Vivier , \"Michael S. Tsirkin\" ,\n Igor Mammedov , Arun Menon ,\n Stefan Berger ","Subject":"[PATCH v7 3/6] hw/tpm: Add internal buffer state for chunking","Date":"Wed, 6 May 2026 13:28:10 +0530","Message-ID":"<20260506075813.120781-4-armenon@redhat.com>","X-Mailer":"git-send-email 2.54.0","In-Reply-To":"<20260506075813.120781-1-armenon@redhat.com>","References":"<20260506075813.120781-1-armenon@redhat.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=170.10.129.124; envelope-from=armenon@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com","X-Spam_score_int":"-24","X-Spam_score":"-2.5","X-Spam_bar":"--","X-Spam_report":"(-2.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.443,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"From: Arun Menon \n\n- Introduce GByteArray buffers to hold the command request and response\n data during chunked TPM CRB transactions.\n- Add helper function to clean them.\n\nSigned-off-by: Arun Menon \nReviewed-by: Marc-André Lureau \nReviewed-by: Stefan Berger \n---\n hw/tpm/tpm_crb.c | 33 +++++++++++++++++++++++++++++----\n 1 file changed, 29 insertions(+), 4 deletions(-)","diff":"diff --git a/hw/tpm/tpm_crb.c b/hw/tpm/tpm_crb.c\nindex a0f472652e..1c944d7ef2 100644\n--- a/hw/tpm/tpm_crb.c\n+++ b/hw/tpm/tpm_crb.c\n@@ -38,10 +38,13 @@ struct CRBState {\n TPMBackend *tpmbe;\n TPMBackendCmd cmd;\n uint32_t regs[TPM_CRB_R_MAX];\n+ size_t be_buffer_size;\n MemoryRegion mmio;\n MemoryRegion cmdmem;\n \n- size_t be_buffer_size;\n+ GByteArray *command_buffer;\n+ GByteArray *response_buffer;\n+ uint32_t response_offset;\n \n TPMPPI ppi;\n \n@@ -86,6 +89,13 @@ enum crb_cancel {\n \n #define TPM_CRB_NO_LOCALITY 0xff\n \n+static void tpm_crb_clear_internal_buffers(CRBState *s)\n+{\n+ g_byte_array_set_size(s->response_buffer, 0);\n+ g_byte_array_set_size(s->command_buffer, 0);\n+ s->response_offset = 0;\n+}\n+\n static uint64_t tpm_crb_mmio_read(void *opaque, hwaddr addr,\n unsigned size)\n {\n@@ -135,9 +145,11 @@ static void tpm_crb_mmio_write(void *opaque, hwaddr addr,\n }\n break;\n case A_CRB_CTRL_CANCEL:\n- if (val == CRB_CANCEL_INVOKE &&\n- s->regs[R_CRB_CTRL_START] & CRB_START_INVOKE) {\n- tpm_backend_cancel_cmd(s->tpmbe);\n+ if (val == CRB_CANCEL_INVOKE) {\n+ if (s->regs[R_CRB_CTRL_START] & CRB_START_INVOKE) {\n+ tpm_backend_cancel_cmd(s->tpmbe);\n+ }\n+ tpm_crb_clear_internal_buffers(s);\n }\n break;\n case A_CRB_CTRL_START:\n@@ -239,6 +251,7 @@ static void tpm_crb_reset(void *dev)\n \n tpm_ppi_reset(&s->ppi);\n tpm_backend_reset(s->tpmbe);\n+ tpm_crb_clear_internal_buffers(s);\n \n memset(s->regs, 0, sizeof(s->regs));\n \n@@ -305,6 +318,9 @@ static void tpm_crb_realize(DeviceState *dev, Error **errp)\n memory_region_add_subregion(get_system_memory(),\n TPM_CRB_ADDR_BASE + sizeof(s->regs), &s->cmdmem);\n \n+ s->command_buffer = g_byte_array_new();\n+ s->response_buffer = g_byte_array_new();\n+\n tpm_ppi_init(&s->ppi, get_system_memory(),\n TPM_PPI_ADDR_BASE, OBJECT(s));\n \n@@ -315,12 +331,21 @@ static void tpm_crb_realize(DeviceState *dev, Error **errp)\n }\n }\n \n+static void tpm_crb_unrealize(DeviceState *dev)\n+{\n+ CRBState *s = CRB(dev);\n+\n+ g_clear_pointer(&s->command_buffer, g_byte_array_unref);\n+ g_clear_pointer(&s->response_buffer, g_byte_array_unref);\n+}\n+\n static void tpm_crb_class_init(ObjectClass *klass, const void *data)\n {\n DeviceClass *dc = DEVICE_CLASS(klass);\n TPMIfClass *tc = TPM_IF_CLASS(klass);\n \n dc->realize = tpm_crb_realize;\n+ dc->unrealize = tpm_crb_unrealize;\n device_class_set_props(dc, tpm_crb_properties);\n dc->vmsd = &vmstate_tpm_crb;\n dc->user_creatable = true;\n","prefixes":["v7","3/6"]}