{"id":2233305,"url":"http://patchwork.ozlabs.org/api/1.2/patches/2233305/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260506075813.120781-3-armenon@redhat.com/","project":{"id":14,"url":"http://patchwork.ozlabs.org/api/1.2/projects/14/?format=json","name":"QEMU Development","link_name":"qemu-devel","list_id":"qemu-devel.nongnu.org","list_email":"qemu-devel@nongnu.org","web_url":"","scm_url":"","webscm_url":"","list_archive_url":"","list_archive_url_format":"","commit_url_format":""},"msgid":"<20260506075813.120781-3-armenon@redhat.com>","list_archive_url":null,"date":"2026-05-06T07:58:09","name":"[v7,2/6] hw/tpm: Refactor CRB_CTRL_START register access","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"853bb2b85a8cad5ecfa4f10e62e79a4248ef72ce","submitter":{"id":91136,"url":"http://patchwork.ozlabs.org/api/1.2/people/91136/?format=json","name":"Arun Menon","email":"armenon@redhat.com"},"delegate":null,"mbox":"http://patchwork.ozlabs.org/project/qemu-devel/patch/20260506075813.120781-3-armenon@redhat.com/mbox/","series":[{"id":502931,"url":"http://patchwork.ozlabs.org/api/1.2/series/502931/?format=json","web_url":"http://patchwork.ozlabs.org/project/qemu-devel/list/?series=502931","date":"2026-05-06T07:58:09","name":"hw/tpm: CRB chunking capability to handle PQC","version":7,"mbox":"http://patchwork.ozlabs.org/series/502931/mbox/"}],"comments":"http://patchwork.ozlabs.org/api/patches/2233305/comments/","check":"pending","checks":"http://patchwork.ozlabs.org/api/patches/2233305/checks/","tags":{},"related":[],"headers":{"Return-Path":"","X-Original-To":"incoming@patchwork.ozlabs.org","Delivered-To":"patchwork-incoming@legolas.ozlabs.org","Authentication-Results":["legolas.ozlabs.org;\n\tdkim=pass (1024-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=mimecast20190719 header.b=Bzccnmz0;\n\tdkim=pass (2048-bit key;\n unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256\n header.s=google header.b=lWzGVpiA;\n\tdkim-atps=neutral","legolas.ozlabs.org;\n spf=pass (sender SPF authorized) smtp.mailfrom=nongnu.org\n (client-ip=209.51.188.17; helo=lists1p.gnu.org;\n envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org;\n receiver=patchwork.ozlabs.org)"],"Received":["from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17])\n\t(using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits))\n\t(No client certificate requested)\n\tby legolas.ozlabs.org (Postfix) with ESMTPS id 4g9SSR0XSlz1yJq\n\tfor ; Wed, 06 May 2026 17:58:47 +1000 (AEST)","from localhost ([::1] helo=lists1p.gnu.org)\n\tby lists1p.gnu.org with esmtp (Exim 4.90_1)\n\t(envelope-from )\n\tid 1wKX9S-0004vQ-WA; Wed, 06 May 2026 03:58:39 -0400","from eggs.gnu.org ([2001:470:142:3::10])\n by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wKX9R-0004ud-M3\n for qemu-devel@nongnu.org; Wed, 06 May 2026 03:58:37 -0400","from us-smtp-delivery-124.mimecast.com ([170.10.129.124])\n by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)\n (Exim 4.90_1) (envelope-from )\n id 1wKX9Q-0000cc-86\n for qemu-devel@nongnu.org; Wed, 06 May 2026 03:58:37 -0400","from mail-pl1-f200.google.com (mail-pl1-f200.google.com\n [209.85.214.200]) by relay.mimecast.com with ESMTP with STARTTLS\n (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n us-mta-335-Ty5X4LtMMJuhiS8eEyEw8A-1; Wed, 06 May 2026 03:58:34 -0400","by mail-pl1-f200.google.com with SMTP id\n d9443c01a7336-2b9b8137828so55822375ad.0\n for ; Wed, 06 May 2026 00:58:34 -0700 (PDT)","from fedora.armenon-thinkpadp16vgen1.bengluru.csb ([49.36.106.26])\n by smtp.gmail.com with ESMTPSA id\n d9443c01a7336-2ba7ca29f9dsm15439865ad.78.2026.05.06.00.58.27\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Wed, 06 May 2026 00:58:31 -0700 (PDT)"],"DKIM-Signature":["v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1778054315;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=rrFde0CzVFJL6FQDSYJhldHvMPOSgrKBQeMX0L6Tpo4=;\n b=Bzccnmz0kdT+xxEsAlAjYrsHs29fkyFJ60PLy4DGiX9nvRXbG20ziNIsV3F9HZmjNQE9eW\n YjPj/UiHmnsIpCtfAdgS1oOWSmSEdx7DyH36mn64YgvEOcp+SX+SIKd5tYw3oRT4VhiFOD\n RADktV1PqWAWgHMQ1/I2aJCzp8eKRZo=","v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=redhat.com; s=google; t=1778054313; x=1778659113; darn=nongnu.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=rrFde0CzVFJL6FQDSYJhldHvMPOSgrKBQeMX0L6Tpo4=;\n b=lWzGVpiAHLxeNV3g5l2n2Cy/lIEg7pXRpRX4Xx2X9dkRCp236B6i1Czyw+jNARXShr\n WKbhlWdAzijVlCoProshoocEdaytj1tMWImlP2fO5oGCdbVkoX5wfcCBXEv3rXe3ljcm\n FfMiBdGBo5AEvlh4OpTGmAFEykQVceUAHChxNNURByZXFyO3mYFHM9nmFItoCfJq9y8I\n A5Jj2YGE+NCbu0+CYYrBKmxDSgPKauCIdAVGvT1Nhw+fAQSWbEdkA56Dk2MjejO4Saip\n rl5BovyvkNPoTQKVyPx5cqB/VE0JJFcPkEEjIg/LwIprbEpYt5etAjK61cVLZkwjTuwv\n x9Cw=="],"X-MC-Unique":"Ty5X4LtMMJuhiS8eEyEw8A-1","X-Mimecast-MFC-AGG-ID":"Ty5X4LtMMJuhiS8eEyEw8A_1778054313","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20251104; t=1778054313; x=1778659113;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n :to:cc:subject:date:message-id:reply-to;\n bh=rrFde0CzVFJL6FQDSYJhldHvMPOSgrKBQeMX0L6Tpo4=;\n b=aS+OZVDWhOomKXOrlJWl61zfReo/uXsggJERaqQNVheY49/tqWrnig63cWB2rUIITS\n lR91fn+wOobVdFE3pZD99h9kW6D7V896X9Vj/cyLzxxEO2BLgeQTJxWjs2wJo67TwUEG\n no0yIkA7bYp6uS7DHP5VBD0GX5Qtwm564OA8veJJCpHUjP6mvXhbQ/U0Alt55joZ1hRN\n +RtsQOQNJIBb5gzMsY8sWRC3QOWFEMBykeOTk/bC905qcjnxqx853RGpNF9veAyXI4dN\n /sE2FHdx7thXpRpPW1rruruk8VucnJlrixTbl+rghwqfXJsn6UyUoX5Pvz3ORy8Q+GHV\n omyQ==","X-Gm-Message-State":"AOJu0YxkqsMsn6MP9Hw4FPAV2rQAkYb/6hm+Kuy0G5Y2rp+EAQjRHV9s\n RuAX46MyadjfDiSn6KRoRKQokqp66AsbhLEn58ZRTQL7R5xYvg57aQu2Dm9Fv+1TS5HBDCKeW9H\n Fj1fQAxzQd2jbFHGR1vRLauTln6akFOepQo98FWX9kAg8py3Sru+3Igio10HOqVdvT7OznDKaU9\n XEohL/E88MdXs0iQOvhL72Pux8PKSQTJ8o+W2fJME=","X-Gm-Gg":"AeBDiev0STUinJULuEbYvRzL4oomUF3IFdxWbQYhW3DpboXBpF7At5eZ4kgmf+iEUJ3\n ddhFPYsHQVMFsGS6rdQYbLwM2XVFuOxfg1OH6C8E4jg3LvDH5+73S/luGeHmBSatuyUJx+W7olv\n HE/FBb2NiAH1X+efJg944oM4/D75nFS3i7G6a2adjRU1UgoPJ29IhHMM3nEe+V3my559+yqL1r9\n z6YcZdy3I/knwgVKUhEEJmenJOg5m8kVMpw4QIx5SsOqongr+IStFbvbHMFX8B1A0uieKTlzLSn\n joopq8ed8mYdM199ZLVAa61Xwp8GIggPXsTm7SzyNvUEnSB95/G7A4mfPO/ViBzjBQ15wM+EoMy\n sB8RFNjJT3DyHu0MaJHX4E2paR01NNNy7SzioRs6Sqh4zgY4b8Q8KLY7dHPHFigPwD19u6b8d","X-Received":["by 2002:a17:902:c40a:b0:2ba:13d8:d503 with SMTP id\n d9443c01a7336-2ba78b3fcfdmr23743755ad.8.1778054313172;\n Wed, 06 May 2026 00:58:33 -0700 (PDT)","by 2002:a17:902:c40a:b0:2ba:13d8:d503 with SMTP id\n d9443c01a7336-2ba78b3fcfdmr23743365ad.8.1778054312559;\n Wed, 06 May 2026 00:58:32 -0700 (PDT)"],"From":"Arun Menon ","To":"qemu-devel@nongnu.org","Cc":"Zhao Liu ,\n Marcel Apfelbaum ,\n Ani Sinha , Fabiano Rosas ,\n marcandre.lureau@redhat.com, Stefan Berger ,\n\t=?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= ,\n Yanan Wang , Paolo Bonzini ,\n Laurent Vivier , \"Michael S. Tsirkin\" ,\n Igor Mammedov , Arun Menon ,\n Stefan Berger ","Subject":"[PATCH v7 2/6] hw/tpm: Refactor CRB_CTRL_START register access","Date":"Wed, 6 May 2026 13:28:09 +0530","Message-ID":"<20260506075813.120781-3-armenon@redhat.com>","X-Mailer":"git-send-email 2.54.0","In-Reply-To":"<20260506075813.120781-1-armenon@redhat.com>","References":"<20260506075813.120781-1-armenon@redhat.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","Received-SPF":"pass client-ip=170.10.129.124; envelope-from=armenon@redhat.com;\n helo=us-smtp-delivery-124.mimecast.com","X-Spam_score_int":"-24","X-Spam_score":"-2.5","X-Spam_bar":"--","X-Spam_report":"(-2.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.443,\n DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,\n RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001,\n SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no","X-Spam_action":"no action","X-BeenThere":"qemu-devel@nongnu.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"qemu development ","List-Unsubscribe":",\n ","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n ","Errors-To":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org","Sender":"qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org"},"content":"From: Arun Menon \n\nReplace manual bitwise operations with ARRAY_FIELD_DP32 macros\nNo functional changes.\n\nSigned-off-by: Arun Menon \nReviewed-by: Stefan Berger \nReviewed-by: Marc-André Lureau \n---\n hw/tpm/tpm_crb.c | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)","diff":"diff --git a/hw/tpm/tpm_crb.c b/hw/tpm/tpm_crb.c\nindex bfa09c04cf..a0f472652e 100644\n--- a/hw/tpm/tpm_crb.c\n+++ b/hw/tpm/tpm_crb.c\n@@ -146,7 +146,7 @@ static void tpm_crb_mmio_write(void *opaque, hwaddr addr,\n tpm_crb_get_active_locty(s) == locty) {\n void *mem = memory_region_get_ram_ptr(&s->cmdmem);\n \n- s->regs[R_CRB_CTRL_START] |= CRB_START_INVOKE;\n+ ARRAY_FIELD_DP32(s->regs, CRB_CTRL_START, Start, 1);\n s->cmd = (TPMBackendCmd) {\n .in = mem,\n .in_len = MIN(tpm_cmd_get_size(mem), s->be_buffer_size),\n@@ -195,7 +195,7 @@ static void tpm_crb_request_completed(TPMIf *ti, int ret)\n {\n CRBState *s = CRB(ti);\n \n- s->regs[R_CRB_CTRL_START] &= ~CRB_START_INVOKE;\n+ ARRAY_FIELD_DP32(s->regs, CRB_CTRL_START, Start, 0);\n if (ret != 0) {\n ARRAY_FIELD_DP32(s->regs, CRB_CTRL_STS,\n tpmSts, 1); /* fatal error */\n","prefixes":["v7","2/6"]}